Attention is currently required from: Nicholas Chin.
Paul Menzel has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/84097?usp=email )
Change subject: mb/dell/snb_ivb_latitude: Move early_init.c out of variants
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/84097?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic43915888f5893652991b7402ebab3bd3a2cf278
Gerrit-Change-Number: 84097
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Tue, 10 Sep 2024 12:52:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Alicja Michalska, David Milosevic, Felix Held, Felix Singer, Lean Sheng Tan.
Angel Pons has posted comments on this change by David Milosevic. ( https://review.coreboot.org/c/coreboot/+/83979?usp=email )
Change subject: mb/hardkernel/odroid-h4: Add initial ODROID-H4 series support
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS2:
> h4 is the base configuration with only 1 ethernet controller, no sata, and a n97 cpu. […]
One could consider dynamically choosing the right SMBIOS strings and a few other whatnots for the specific board configuration being used, but it doesn't seem worth the effort. One can always change the SMBIOS strings in Kconfig anyway
--
To view, visit https://review.coreboot.org/c/coreboot/+/83979?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7e0d395ba3d15dfcf6d47a222b90499ca371e4eb
Gerrit-Change-Number: 83979
Gerrit-PatchSet: 7
Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Comment-Date: Tue, 10 Sep 2024 12:22:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Alicja Michalska, David Milosevic, Felix Singer, Lean Sheng Tan.
Angel Pons has posted comments on this change by David Milosevic. ( https://review.coreboot.org/c/coreboot/+/83979?usp=email )
Change subject: mb/hardkernel/odroid-h4: Add initial ODROID-H4 series support
......................................................................
Patch Set 7:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83979/comment/916190d0_b6ac55b2?us… :
PS7, Line 9: Adds
Add
https://review.coreboot.org/c/coreboot/+/83979/comment/210e7bd5_b3519a64?us… :
PS7, Line 10: 2
The board has 4 USB ports on the back, and there's more USB ports on one of the headers
File src/mainboard/hardkernel/odroid-h4/Kconfig:
https://review.coreboot.org/c/coreboot/+/83979/comment/a0be2f42_c780f957?us… :
PS7, Line 28: string
Type not needed
File src/mainboard/hardkernel/odroid-h4/bootblock.c:
https://review.coreboot.org/c/coreboot/+/83979/comment/68b09ab5_6face11d?us… :
PS7, Line 13: ite_reg_write(GPIO_DEV, 0x29, 0x01); // The value matches vendor firmware
: ite_reg_write(GPIO_DEV, 0x2c, 0x41); // Internal Voltage Divider for ACC3
: ite_reg_write(GPIO_DEV, 0xbc, 0xc0); // GP56, GP57 Internal pullup
: ite_reg_write(GPIO_DEV, 0xbd, 0x03); // GP60, GP61 Internal pullup
: ite_reg_write(GPIO_DEV, 0xc3, 0x41); // GP40, GP46 Simple I/O function
Are the comments accurate? I don't have a datasheet for this Super I/O
File src/mainboard/hardkernel/odroid-h4/romstage_fsp_params.c:
https://review.coreboot.org/c/coreboot/+/83979/comment/b98654cb_963c62d0?us… :
PS7, Line 19: 0x52
This is weird, but if it works (memory is detected and all capacity is found) then it's correct. Can you check if the total memory size reported by firmware or OS matches the DDR5 module's size? I am pretty sure your board has 8 GiB of DDR5.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83979?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7e0d395ba3d15dfcf6d47a222b90499ca371e4eb
Gerrit-Change-Number: 83979
Gerrit-PatchSet: 7
Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Comment-Date: Tue, 10 Sep 2024 12:20:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Alicja Michalska, Angel Pons, David Milosevic, Felix Singer, Lean Sheng Tan.
Felix Held has posted comments on this change by David Milosevic. ( https://review.coreboot.org/c/coreboot/+/83979?usp=email )
Change subject: mb/hardkernel/odroid-h4: Add initial ODROID-H4 series support
......................................................................
Patch Set 7:
(4 comments)
Patchset:
PS2:
> Acknowledged
h4 is the base configuration with only 1 ethernet controller, no sata, and a n97 cpu. h4+ adds the second ethernet controller and sata chip and the other one replaces the n97 cpu with one that has double the core count
File src/mainboard/hardkernel/odroid-h4/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/83979/comment/a6ef1daa_5f6f9d91?us… :
PS7, Line 5: register "pmc_gpe0_dw0" = "GPP_B"
: register "pmc_gpe0_dw1" = "GPP_D"
: register "pmc_gpe0_dw2" = "GPP_E"
do those match what the vendor firmware does? CB:84213 has other values for that and at least the devicetree in that patch seems to be in a better shape than this devicetree
https://review.coreboot.org/c/coreboot/+/83979/comment/400428a8_aff55f31?us… :
PS7, Line 36: device ref tcss_xhci on
tcss xhci is unused; the pch xhci controller which is the one used is missing in the devicetree. the usb2 and usb3 port configs are missing in here too
File src/mainboard/hardkernel/odroid-h4/gpio.h:
PS7:
i wonder if this is missing the vgpios; at least the other patch for adding the mainboard support has those
--
To view, visit https://review.coreboot.org/c/coreboot/+/83979?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7e0d395ba3d15dfcf6d47a222b90499ca371e4eb
Gerrit-Change-Number: 83979
Gerrit-PatchSet: 7
Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Comment-Date: Tue, 10 Sep 2024 12:11:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com>
Attention is currently required from: Alicja Michalska, Angel Pons, David Milosevic, Felix Singer.
Lean Sheng Tan has uploaded a new patch set (#7) to the change originally created by David Milosevic. ( https://review.coreboot.org/c/coreboot/+/83979?usp=email )
Change subject: mb/hardkernel/odroid-h4: Add initial ODROID-H4 series support
......................................................................
mb/hardkernel/odroid-h4: Add initial ODROID-H4 series support
Adds initial support for the ODRIOD-H4 & H4+ boards. Able to boot
to EDKII shell & Linux on NVME & eMMC. 2 USB ports working. However
graphic display is still not working yet.
Change-Id: I7e0d395ba3d15dfcf6d47a222b90499ca371e4eb
Signed-off-by: David Milosevic <David.Milosevic(a)9elements.com>
---
A src/mainboard/hardkernel/Kconfig
A src/mainboard/hardkernel/Kconfig.name
A src/mainboard/hardkernel/odroid-h4/Kconfig
A src/mainboard/hardkernel/odroid-h4/Kconfig.name
A src/mainboard/hardkernel/odroid-h4/Makefile.mk
A src/mainboard/hardkernel/odroid-h4/board_info.txt
A src/mainboard/hardkernel/odroid-h4/bootblock.c
A src/mainboard/hardkernel/odroid-h4/data.vbt
A src/mainboard/hardkernel/odroid-h4/devicetree.cb
A src/mainboard/hardkernel/odroid-h4/dsdt.asl
A src/mainboard/hardkernel/odroid-h4/gpio.h
A src/mainboard/hardkernel/odroid-h4/mainboard.c
A src/mainboard/hardkernel/odroid-h4/romstage_fsp_params.c
13 files changed, 521 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/83979/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/83979?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7e0d395ba3d15dfcf6d47a222b90499ca371e4eb
Gerrit-Change-Number: 83979
Gerrit-PatchSet: 7
Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com>
Attention is currently required from: Alicja Michalska, David Milosevic, Michał Żygowski.
Felix Held has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/84213?usp=email )
Change subject: mainboard/hardkernel: Add ODROID H4+ initial support
......................................................................
Patch Set 2:
(7 comments)
File src/mainboard/hardkernel/odroid_h4/Kconfig:
https://review.coreboot.org/c/coreboot/+/84213/comment/891c6be7_52f12daa?us… :
PS2, Line 17:
in order to have aspm enabled, the following kconfig selects are probably needed:
select PCIEXP_ASPM
select PCIEXP_CLK_PM
select PCIEXP_COMMON_CLOCK
select PCIEXP_L1_SUB_STATE
https://review.coreboot.org/c/coreboot/+/84213/comment/47d1d56e_f756cffe?us… :
PS2, Line 24: config MAINBOARD_VENDOR
: default "HARDKERNEL"
already specified in the mainboard vendor kconfig, so this can be dropped here
https://review.coreboot.org/c/coreboot/+/84213/comment/6c0fa9e4_8493e1e5?us… :
PS2, Line 27: config MAINBOARD_FAMILY
: default "Default String"
is this needed?
File src/mainboard/hardkernel/odroid_h4/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/84213/comment/2f2160d8_d559f7bf?us… :
PS2, Line 26: device cpu_cluster 0 on end
this line isn't needed, since the chipset devicetree already has that one
https://review.coreboot.org/c/coreboot/+/84213/comment/254e92e7_2f326ce0?us… :
PS2, Line 67: register "usb3_ports[9]" = "USB3_PORT_EMPTY"
there are more usb2_ports and usb3_ports entries in here than the soc has usb 2/3 ports; i'd drop the entries for the ones that aren't available on the hardware; iirc adl-n has 8 usb2 ports and up to 4 usb3 ports on the pch
https://review.coreboot.org/c/coreboot/+/84213/comment/46c978d3_9b653a53?us… :
PS2, Line 163: .clk_req = 3,
this soc input is connected to ground, so i wonder if this should be replaced by .flags = PCIE_RP_CLK_REQ_UNUSED
File src/mainboard/hardkernel/odroid_h4/gpio.c:
https://review.coreboot.org/c/coreboot/+/84213/comment/686698d4_01c65e30?us… :
PS2, Line 8: #define PAD_CFG_GPIO_BIDIRECT(pad, val, pull, rst, trig, own) \
shouldn't this go into one of the soc's gpio header files?
--
To view, visit https://review.coreboot.org/c/coreboot/+/84213?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iee066cb0da27e3bf7ce52fc199396185912893aa
Gerrit-Change-Number: 84213
Gerrit-PatchSet: 2
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Reviewer: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Comment-Date: Tue, 10 Sep 2024 11:46:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Alicja Michalska, Angel Pons, David Milosevic, Felix Singer.
Lean Sheng Tan has posted comments on this change by David Milosevic. ( https://review.coreboot.org/c/coreboot/+/83979?usp=email )
Change subject: mb/hardkernel/odroid-h4: Add initial ODROID-H4 series support
......................................................................
Patch Set 6:
(10 comments)
Patchset:
PS2:
> What are the differences? If possible I'd try to avoid creating variants (different firmware builds) […]
Acknowledged
File src/mainboard/hardkernel/odroid-h4/Kconfig:
https://review.coreboot.org/c/coreboot/+/83979/comment/d9f02cc7_694b6b6d?us… :
PS4, Line 37: config NO_POST
: default y
:
> There's a FFC (Flat Flexible Cable) connector on the bottom of the board named "ESPI_DEBUG1", so I w […]
Done
File src/mainboard/hardkernel/odroid-h4/bootblock.c:
https://review.coreboot.org/c/coreboot/+/83979/comment/e152768a_252578b1?us… :
PS4, Line 13: ite_reg_write(GPIO_DEV, 0x25, 0x01); // Enable Pin GP10
> What is GP10 used for? Seems unused on both schematics and in vendor firmware default settings (0x00 […]
Done
https://review.coreboot.org/c/coreboot/+/83979/comment/bc91c274_055f924f?us… :
PS4, Line 14: ite_reg_write(GPIO_DEV, 0x27, 0x02); // Enable Pin GP31
> GP31 is used as CTS# so this should be removed too
Done
https://review.coreboot.org/c/coreboot/+/83979/comment/23b3a7b1_190d2cf8?us… :
PS4, Line 15: ite_reg_write(GPIO_DEV, 0x28, 0x01); // Enable Pin GP40
> This seems to be used as PWRGD3, going to SYS_PWROK. I think this should be removed.
Done
https://review.coreboot.org/c/coreboot/+/83979/comment/bb8f32a4_564abdf9?us… :
PS4, Line 16: Enable Pin GP50
> This is not GP50 (doesn't appear in the schematics), but the value matches vendor firmware.
Done
File src/mainboard/hardkernel/odroid-h4/gpio.h:
https://review.coreboot.org/c/coreboot/+/83979/comment/b8f1f16e_285a0a15?us… :
PS4, Line 96: PAD_CFG_NF(GPP_H11, NONE, DEEP, NF2), /* UART0_TXD */
> This is not used
Done
File src/mainboard/hardkernel/odroid-h4/ramstage_fsp_params.c:
PS4:
> No license header
Done
https://review.coreboot.org/c/coreboot/+/83979/comment/cda0354b_b6700b3f?us… :
PS4, Line 4:
: fsp_s_config->PchLegacyIoLowLatency = 1;
: fsp_s_config->PchDmiAspmCtrl = 0;
> Why?
Done
File src/mainboard/hardkernel/odroid-h4/romstage_fsp_params.c:
https://review.coreboot.org/c/coreboot/+/83979/comment/ce9d7efc_685cdee5?us… :
PS4, Line 29: TODO: Implement __weak variant_is_half_populated(void) function.
> Copy-pasta? This board has no variants, so this doesn't make much sense
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/83979?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7e0d395ba3d15dfcf6d47a222b90499ca371e4eb
Gerrit-Change-Number: 83979
Gerrit-PatchSet: 6
Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Comment-Date: Tue, 10 Sep 2024 11:43:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com>
Attention is currently required from: Alicja Michalska, Angel Pons, David Milosevic, Felix Singer, Lean Sheng Tan.
Lean Sheng Tan has uploaded a new patch set (#6) to the change originally created by David Milosevic. ( https://review.coreboot.org/c/coreboot/+/83979?usp=email )
The following approvals got outdated and were removed:
Code-Review+1 by Angel Pons, Verified-1 by build bot (Jenkins)
Change subject: mb/hardkernel/odroid-h4: Add initial ODROID-H4 series support
......................................................................
mb/hardkernel/odroid-h4: Add initial ODROID-H4 series support
Adds initial support for the ODRIOD-H4 & H4+ boards. Able to boot
to EDKII shell & Linux on NVME & eMMC. 2 USB ports working. However
graphic display is still not working yet.
Change-Id: I7e0d395ba3d15dfcf6d47a222b90499ca371e4eb
Signed-off-by: David Milosevic <David.Milosevic(a)9elements.com>
---
A src/mainboard/hardkernel/Kconfig
A src/mainboard/hardkernel/Kconfig.name
A src/mainboard/hardkernel/odroid-h4/Kconfig
A src/mainboard/hardkernel/odroid-h4/Kconfig.name
A src/mainboard/hardkernel/odroid-h4/Makefile.mk
A src/mainboard/hardkernel/odroid-h4/board_info.txt
A src/mainboard/hardkernel/odroid-h4/bootblock.c
A src/mainboard/hardkernel/odroid-h4/data.vbt
A src/mainboard/hardkernel/odroid-h4/devicetree.cb
A src/mainboard/hardkernel/odroid-h4/dsdt.asl
A src/mainboard/hardkernel/odroid-h4/gpio.h
A src/mainboard/hardkernel/odroid-h4/mainboard.c
A src/mainboard/hardkernel/odroid-h4/romstage_fsp_params.c
13 files changed, 525 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/83979/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/83979?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7e0d395ba3d15dfcf6d47a222b90499ca371e4eb
Gerrit-Change-Number: 83979
Gerrit-PatchSet: 6
Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com>
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84280?usp=email )
Change subject: Documentation/mb/starlabs/byte_adl: Correct title
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/84280?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia35c656a66c623e88579cf4b9e894c77a404c375
Gerrit-Change-Number: 84280
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 10 Sep 2024 11:17:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No