Attention is currently required from: Alicja Michalska, David Milosevic, Felix Held, Felix Singer, Lean Sheng Tan.
Angel Pons has uploaded a new patch set (#8) to the change originally created by David Milosevic. ( https://review.coreboot.org/c/coreboot/+/83979?usp=email )
Change subject: [WIP] mb/hardkernel/odroid-h4: Add support for ODROID-H4 series
......................................................................
[WIP] mb/hardkernel/odroid-h4: Add support for ODROID-H4 series
Add support for the ODROID-H4 family of boards. Tested on an ODROID-H4+
board, but all of them use the same PCB (with different components).
Currently working on getting things set up properly. Expect some chaos.
Working:
- DDR5 SO-DIMM slot
- At least one SATA port on ASMedia ASM1064B PCIe-to-SATA controller
- UART to emit spam
- All video outputs (FSP GOP only lights up one output at a time)
- Booting to Linux on SATA SSD with SeaBIOS <current version>
Not working:
- USB ports: need to tell the Super I/O to enable power to the ports
on the built-in connectors (below the Ethernet ports)
- Dual BIOS: flash chip switching mechanism is very sus
Untested:
- The other SATA ports
- Fan control: seems wonky
- Rest of Super I/O config: needs exorcism
- HDA codec: SPDIF is untestable
- Ethernet NICs
- M.2 slot (PCIe only, no SATA lanes)
- S3 suspend/resume
- edk2 payload
- Windows (with edk2 payload)
- PCIe ASPM and friends
Change-Id: I7e0d395ba3d15dfcf6d47a222b90499ca371e4eb
Signed-off-by: David Milosevic <David.Milosevic(a)9elements.com>
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
---
A src/mainboard/hardkernel/Kconfig
A src/mainboard/hardkernel/Kconfig.name
A src/mainboard/hardkernel/odroid-h4/Kconfig
A src/mainboard/hardkernel/odroid-h4/Kconfig.name
A src/mainboard/hardkernel/odroid-h4/Makefile.mk
A src/mainboard/hardkernel/odroid-h4/board_info.txt
A src/mainboard/hardkernel/odroid-h4/bootblock.c
A src/mainboard/hardkernel/odroid-h4/data.vbt
A src/mainboard/hardkernel/odroid-h4/devicetree.cb
A src/mainboard/hardkernel/odroid-h4/dsdt.asl
A src/mainboard/hardkernel/odroid-h4/hda_verb.c
A src/mainboard/hardkernel/odroid-h4/mainboard.c
A src/mainboard/hardkernel/odroid-h4/romstage_fsp_params.c
13 files changed, 558 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/83979/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/83979?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7e0d395ba3d15dfcf6d47a222b90499ca371e4eb
Gerrit-Change-Number: 83979
Gerrit-PatchSet: 8
Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com>
Attention is currently required from: Alicja Michalska, David Milosevic, Michał Żygowski.
Felix Held has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/84213?usp=email )
Change subject: mainboard/hardkernel: Add ODROID H4+ initial support
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/hardkernel/odroid_h4/Kconfig:
https://review.coreboot.org/c/coreboot/+/84213/comment/68f4bcde_297397dc?us… :
PS2, Line 17:
> in order to have aspm enabled, the following kconfig selects are probably needed: […]
if you prefer to look into enabling aspm in a separate follow-up patch, just ack this one
--
To view, visit https://review.coreboot.org/c/coreboot/+/84213?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iee066cb0da27e3bf7ce52fc199396185912893aa
Gerrit-Change-Number: 84213
Gerrit-PatchSet: 2
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Reviewer: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Comment-Date: Tue, 10 Sep 2024 17:02:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Benjamin Doron, Lean Sheng Tan, Martin L Roth, Sean Rhodes, Sergii Dmytruk.
Hello Benjamin Doron, Lean Sheng Tan, Martin L Roth, Matt DeVillier, Sean Rhodes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84292?usp=email
to look at the new patch set (#2).
Change subject: payloads/edk2/Makefile: detect invalid commit hash on checkout
......................................................................
payloads/edk2/Makefile: detect invalid commit hash on checkout
There is already a check for invalid reference, however `git rev-parse
reference` doesn't fail on unknown commit hash unless `^{object}`
peeling operator is used (`^{commit}` can be used as well).
Change-Id: I7ef39aeee2e902ac2fad6ac41b546c47418e1dec
Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
---
M payloads/external/edk2/Makefile
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/84292/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84292?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7ef39aeee2e902ac2fad6ac41b546c47418e1dec
Gerrit-Change-Number: 84292
Gerrit-PatchSet: 2
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84293?usp=email )
Change subject: payloads/edk2: Update default branch for MrChromebox repo to 2024-08
......................................................................
payloads/edk2: Update default branch for MrChromebox repo to 2024-08
Update the default branch used for MrChromebox's edk2 fork from 2023-09
to 2024-08. This updated branch has been rebased on the latest upstream
stable tag (edk2-stable202408), and updates the EFI filesystem drivers
which had been causing some issues with bootable USBs created using
Rufus as it tried to unload the filesystem drivers and load its own.
TEST=build/boot google boards link, panther, lulu, reef, ampton, akemi,
banshee, zork, dewatt, frostflow with edk2 payload selected.
Change-Id: I459b668345ed2a34e198e6a3d3a2da94b2940e69
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M payloads/external/edk2/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/84293/1
diff --git a/payloads/external/edk2/Kconfig b/payloads/external/edk2/Kconfig
index 0f88d36..9b32403 100644
--- a/payloads/external/edk2/Kconfig
+++ b/payloads/external/edk2/Kconfig
@@ -86,7 +86,7 @@
config EDK2_TAG_OR_REV
string "Insert a commit's SHA-1 or a branch name"
- default "origin/uefipayload_202309" if EDK2_REPO_MRCHROMEBOX
+ default "origin/uefipayload_202408" if EDK2_REPO_MRCHROMEBOX
default "origin/universalpayload" if EDK2_UNIVERSAL_PAYLOAD
default "origin/master" if EDK2_REPO_OFFICIAL
default "" if EDK2_REPO_CUSTOM
--
To view, visit https://review.coreboot.org/c/coreboot/+/84293?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I459b668345ed2a34e198e6a3d3a2da94b2940e69
Gerrit-Change-Number: 84293
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Attention is currently required from: Benjamin Doron, Lean Sheng Tan, Martin L Roth, Sean Rhodes, Sergii Dmytruk.
Matt DeVillier has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/coreboot/+/84292?usp=email )
Change subject: payloads/edk2/Makefile: detect invalid commit hash on checkout
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84292?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7ef39aeee2e902ac2fad6ac41b546c47418e1dec
Gerrit-Change-Number: 84292
Gerrit-PatchSet: 1
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Comment-Date: Tue, 10 Sep 2024 16:04:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes