Attention is currently required from: Maxim.
Martin L Roth has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/83862?usp=email )
Change subject: soc/intel/cml, pci_ids: Remove IDs of non-existent graphics devices
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83862?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8ff7b062f930cb63ffd9caf240874742bd53fc23
Gerrit-Change-Number: 83862
Gerrit-PatchSet: 5
Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Comment-Date: Tue, 10 Sep 2024 02:20:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Maxim.
Martin L Roth has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/83861?usp=email )
Change subject: soc/intel/cml, pci_ids: Fix IDs for Intel Comet Lake-S/H GT1
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83861?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I776f434f3627d6fbd046a92eb736b1ffcac8274a
Gerrit-Change-Number: 83861
Gerrit-PatchSet: 5
Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Comment-Date: Tue, 10 Sep 2024 02:19:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Felix Singer, Jérémy Compostella, Maxim, Subrata Banik.
Martin L Roth has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/83708?usp=email )
Change subject: soc/intel/cml, pci_ids: Fix ID for Comet Lake-H GT2
......................................................................
Patch Set 12: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83708?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iacab0a03388af3f6fd5d78a597580037889e8ef2
Gerrit-Change-Number: 83708
Gerrit-PatchSet: 12
Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Comment-Date: Tue, 10 Sep 2024 02:18:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Maximilian Brune.
Martin L Roth has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83872?usp=email )
Change subject: util/lint/lint-final-newlines: Supply dirs in row
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83872?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I802aece355bba4900e71824d802c4b2438726e84
Gerrit-Change-Number: 83872
Gerrit-PatchSet: 1
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Comment-Date: Tue, 10 Sep 2024 02:16:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Jeremy Compostella, Kapil Porwal, Nick Vaccaro, Nico Huber, Rishika Raj, Ronak Kanabar.
Martin L Roth has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/83826?usp=email )
Change subject: intel/alderlake: Drop redundant Client/AlderLake* FSP paths
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
I'm going to give this a +2 and allow it to be merged. If there does turn out to be an issue, we can always revert the patch or update it again at that point.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83826?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia9b256ce1940894e2cf31acaa4a83ea39f6723b6
Gerrit-Change-Number: 83826
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Jeremy Compostella <jeremy.compostella(a)gmail.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Attention: Jeremy Compostella <jeremy.compostella(a)gmail.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Comment-Date: Tue, 10 Sep 2024 02:15:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Bao Zheng, Zheng Bao.
Martin L Roth has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/84130?usp=email )
Change subject: amdfwtool: Set the field when the header is created
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Patchset:
PS2:
Please just update the commit message before merging.
Commit Message:
https://review.coreboot.org/c/coreboot/+/84130/comment/86a958c2_edd62951?us… :
PS2, Line 7: the field
Which field?
--
To view, visit https://review.coreboot.org/c/coreboot/+/84130?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I55c400e45536a57841b01d7c90d3fef9afa53e78
Gerrit-Change-Number: 84130
Gerrit-PatchSet: 2
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Tue, 10 Sep 2024 02:10:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Martin L Roth.
Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83185?usp=email )
Change subject: util/autoport: Add CC-PDDC SPDX header to empty files
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83185/comment/2231ea14_f4e8e9f8?us… :
PS3, Line 9: As per commit cf4722d317ea (src/mb: Update unlicensable files with the
> > `Possible repeated word: 'the'` […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/83185?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5fdf0c80443a79c082b3d0418d16cd858782b2c9
Gerrit-Change-Number: 83185
Gerrit-PatchSet: 4
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Tue, 10 Sep 2024 02:03:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>
Attention is currently required from: Martin L Roth.
Hello Martin L Roth, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83185?usp=email
to look at the new patch set (#4).
Change subject: util/autoport: Add CC-PDDC SPDX header to empty files
......................................................................
util/autoport: Add CC-PDDC SPDX header to empty files
As per commit cf4722d317ea (src/mb: Update unlicensable files with the
CC-PDDC SPDX ID) effectively empty files should use the Creative Commons
Public Domain Dedication and Certification (CC-PDDC) license header.
The only empty files that autoport currently generates are ec.asl and
superio.asl on non-laptop systems, where NoEC() is used.
Change-Id: I5fdf0c80443a79c082b3d0418d16cd858782b2c9
Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com>
---
M util/autoport/ec_none.go
M util/autoport/main.go
2 files changed, 10 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/83185/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/83185?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5fdf0c80443a79c082b3d0418d16cd858782b2c9
Gerrit-Change-Number: 83185
Gerrit-PatchSet: 4
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Attention is currently required from: Martin L Roth.
Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83185?usp=email )
Change subject: util/autoport: Add CC-PDDC SPDX header to empty files
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83185/comment/82afaf4d_7b9d825d?us… :
PS3, Line 9: As per commit cf4722d317ea (src/mb: Update unlicensable files with the
> `Possible repeated word: 'the'`
Please fix.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83185?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5fdf0c80443a79c082b3d0418d16cd858782b2c9
Gerrit-Change-Number: 83185
Gerrit-PatchSet: 3
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Tue, 10 Sep 2024 02:02:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No