Attention is currently required from: Hung-Te Lin, Xi Chen, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/84222?usp=email )
Change subject: soc/mediatek: Remove redundant struct pad_func and PAD_* definitions
......................................................................
Patch Set 2:
(2 comments)
File src/soc/mediatek/common/include/soc/gpio_common.h:
https://review.coreboot.org/c/coreboot/+/84222/comment/f8cf2911_25135eaa?us… :
PS2, Line 59: PAD_##name##_FUNC_##func
> These are defined in the `PIN()` macro in gpio_defs. […]
`PIN()` macro of `mt8173` and `mt8183` are different from others SoCs. That's why I exclude `mt8173` and `mt8183` from CB:84221. If you agree, I will move those to `gpio_def.h` and exclude `mt8173` and `mt8183` from refactoring.
https://review.coreboot.org/c/coreboot/+/84222/comment/a396a6f2_73a880d0?us… :
PS2, Line 59: }
> Is it reasonable to have `GPIO_PULL_DOWN` as the default? I wonder if we could replace `PAD_FUNC` an […]
The driver that uses `PAD_FUNC` either `OMITS` pull_select setting (because it may have external pull up/down resistor depending on the design.) or sets pull_select as they need[1].
`pull_select` is an invalid setting for driver that uses `PAD_FUNC_GPIO`. GPIO pin will disable pull up/down setting eventually. (see `gpio_input` and `gpio_output`)
I prefer keeping existed settings since those settings already passed the SI measurement.
[1]: https://review.coreboot.org/c/coreboot/+/84222/2/src/soc/mediatek/mt8183/i2…
--
To view, visit https://review.coreboot.org/c/coreboot/+/84222?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I12b8f6749015bff52988208a7c3aa01e952612c6
Gerrit-Change-Number: 84222
Gerrit-PatchSet: 2
Gerrit-Owner: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Tue, 10 Sep 2024 14:56:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83633?usp=email )
Change subject: ec/starlabs/merlin: Don't report the battery serial number to ACPI
......................................................................
ec/starlabs/merlin: Don't report the battery serial number to ACPI
Reporting the battery serial number to ACPI causes Windows to say
there isn't a battery present. As the serial number is as useful as
waterproof towel, don't do it.
Change-Id: I97a28b1d8d7bb45ea4790c8125cd3c1bc52ee5f9
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83633
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/ec/starlabs/merlin/acpi/battery.asl
1 file changed, 0 insertions(+), 6 deletions(-)
Approvals:
build bot (Jenkins): Verified
Matt DeVillier: Looks good to me, approved
diff --git a/src/ec/starlabs/merlin/acpi/battery.asl b/src/ec/starlabs/merlin/acpi/battery.asl
index e6b0964..ee800ed 100644
--- a/src/ec/starlabs/merlin/acpi/battery.asl
+++ b/src/ec/starlabs/merlin/acpi/battery.asl
@@ -48,9 +48,6 @@
SBIF [6] = B1DC / 20 // 5%
SBIF [7] = B1DC / 500 // 0.2%
SBIF [8] = B1DC / 500 // 0.2%
- If (B1SN != 0xffff) {
- SBIF [10] = B1SN
- }
}
Return (SBIF)
}
@@ -101,9 +98,6 @@
}
XBIF [14] = B1DC / 500 // 0.2%
XBIF [15] = B1DC / 500 // 0.2%
- If (B1SN != 0xffff) {
- XBIF [17] = B1SN
- }
}
Return (XBIF)
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/83633?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I97a28b1d8d7bb45ea4790c8125cd3c1bc52ee5f9
Gerrit-Change-Number: 83633
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: Cliff Huang, Felix Held, Lance Zhao, Tim Wawrzynczak.
Matt DeVillier has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/84192?usp=email )
Change subject: acpi/acpigen: Increase max package length for acpigen_pop_len()
......................................................................
Patch Set 3:
(1 comment)
File src/acpi/acpigen.c:
https://review.coreboot.org/c/coreboot/+/84192/comment/e49a61ec_3b53ef98?us… :
PS2, Line 105: /* The case of PkgLength up to 0xfffffff isn't supported at the moment */
> that comment isn't true any more after this patch
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/84192?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8f72fa84cfdae480fec42b0968bd7cefcdb96bdc
Gerrit-Change-Number: 84192
Gerrit-PatchSet: 3
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 10 Sep 2024 13:20:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Nicholas Chin.
Nico Huber has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/84097?usp=email )
Change subject: mb/dell/snb_ivb_latitude: Move early_init.c out of variants
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84097?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic43915888f5893652991b7402ebab3bd3a2cf278
Gerrit-Change-Number: 84097
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Tue, 10 Sep 2024 13:00:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Nicholas Chin.
Paul Menzel has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/84097?usp=email )
Change subject: mb/dell/snb_ivb_latitude: Move early_init.c out of variants
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/84097?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic43915888f5893652991b7402ebab3bd3a2cf278
Gerrit-Change-Number: 84097
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Tue, 10 Sep 2024 12:52:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes