Attention is currently required from: Felix Held, Marshall Dawson, Nikolai Vyssotski.
Bao Zheng has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/75682?usp=email )
Change subject: amdfwtool: Add PSP backup directory for A/B recovery
......................................................................
Patch Set 6:
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/75682/comment/de894207_fe608551?us… :
PS6, Line 925: TABLE_ALIGNMENT
> TODO: […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/75682?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia5a745c86595554c83cd13a35c312c17987b716b
Gerrit-Change-Number: 75682
Gerrit-PatchSet: 6
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 12 Sep 2024 03:35:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bao Zheng <fishbaozi(a)gmail.com>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Felix Held, Marshall Dawson, Nikolai Vyssotski.
Bao Zheng has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/75682?usp=email )
Change subject: amdfwtool: Add PSP backup directory for A/B recovery
......................................................................
Patch Set 6:
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/75682/comment/32623c92_dea91e62?us… :
PS6, Line 925: TABLE_ALIGNMENT
> should this be TABLE_ALIGNMENT or TABLE_ERASE_ALIGNMENT? recovery_ab implies multi_level and in that […]
TODO:
use the count inside the header as copy size.
--
To view, visit https://review.coreboot.org/c/coreboot/+/75682?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia5a745c86595554c83cd13a35c312c17987b716b
Gerrit-Change-Number: 75682
Gerrit-PatchSet: 6
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 12 Sep 2024 03:18:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Nicholas Chin has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/84329?usp=email )
Change subject: util/autoport: Add function to create empty files
......................................................................
util/autoport: Add function to create empty files
As per commit cf4722d317ea (src/mb: Update unlicensable files with the
CC-PDDC SPDX ID) effectively empty files should use the Creative Commons
Public Domain Dedication and Certification (CC-PDDC) license header. Add
a function to create an empty file and add the CC-PDDC SPDX header and a
comment to change the license if content is added.
The only empty files that autoport currently generates are ec.asl and
superio.asl on non-laptop systems, where NoEC() is used.
Change-Id: I409a6d90d671258e318c26e34a35c238d6fd28c1
Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com>
---
M util/autoport/ec_none.go
M util/autoport/main.go
2 files changed, 12 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/84329/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84329?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I409a6d90d671258e318c26e34a35c238d6fd28c1
Gerrit-Change-Number: 84329
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Attention is currently required from: Angel Pons, Martin L Roth, Nico Huber.
Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83185?usp=email )
Change subject: util/autoport: Add CC-PDDC SPDX header to empty files
......................................................................
Patch Set 5:
(2 comments)
File util/autoport/main.go:
https://review.coreboot.org/c/coreboot/+/83185/comment/fe0d6c3b_e417506c?us… :
PS4, Line 244: fmt.Fprintln(f)
> This adds an extra newline
Fixed
https://review.coreboot.org/c/coreboot/+/83185/comment/d5eda26d_e46ee9c3?us… :
PS4, Line 245: }
> Suggestion: You could turn it around and have a new function that […]
Created an alternative to this patch implementing that idea here: https://review.coreboot.org/c/coreboot/+/84329
--
To view, visit https://review.coreboot.org/c/coreboot/+/83185?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5fdf0c80443a79c082b3d0418d16cd858782b2c9
Gerrit-Change-Number: 83185
Gerrit-PatchSet: 5
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Thu, 12 Sep 2024 02:53:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>
Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/84329?usp=email )
Change subject: util/autoport: Add function to create empty files
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Alternate implementation of https://review.coreboot.org/c/coreboot/+/83185, only submit one or the other.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84329?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I409a6d90d671258e318c26e34a35c238d6fd28c1
Gerrit-Change-Number: 84329
Gerrit-PatchSet: 1
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Thu, 12 Sep 2024 02:53:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Jian Tong has posted comments on this change by Jian Tong. ( https://review.coreboot.org/c/coreboot/+/84184?usp=email )
Change subject: mb/google/brox/var/lotso: Update verb table
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84184/comment/23507e6f_60991817?us… :
PS3, Line 9: Correct the number of NID entries.
> Done
4 verb table is a NID entry, so it need be corrected.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84184?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5f5553a5d8014f957d6b89ac4c1039594817bf32
Gerrit-Change-Number: 84184
Gerrit-PatchSet: 3
Gerrit-Owner: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Thu, 12 Sep 2024 02:52:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Jian Tong has posted comments on this change by Jian Tong. ( https://review.coreboot.org/c/coreboot/+/84184?usp=email )
Change subject: mb/google/brox/var/lotso: Update verb table
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84184/comment/9a0e961a_cc57e76b?us… :
PS3, Line 9: Correct the number of NID entries.
> Why is the new value the correct one?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/84184?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5f5553a5d8014f957d6b89ac4c1039594817bf32
Gerrit-Change-Number: 84184
Gerrit-PatchSet: 3
Gerrit-Owner: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Thu, 12 Sep 2024 02:51:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Jian Tong has posted comments on this change by Jian Tong. ( https://review.coreboot.org/c/coreboot/+/84184?usp=email )
Change subject: mb/google/brox/var/lotso: Update verb table
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84184/comment/8fea2fd3_6f55ebca?us… :
PS3, Line 7: Update verb table
:
> Please be more specific next time. For example: […]
Thanks for your review
--
To view, visit https://review.coreboot.org/c/coreboot/+/84184?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5f5553a5d8014f957d6b89ac4c1039594817bf32
Gerrit-Change-Number: 84184
Gerrit-PatchSet: 3
Gerrit-Owner: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Thu, 12 Sep 2024 02:50:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Attention is currently required from: Angel Pons, Martin L Roth, Nico Huber.
Hello Angel Pons, Martin L Roth, Nico Huber, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83185?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Code-Review+2 by Angel Pons, Code-Review+2 by Nico Huber, Verified+1 by build bot (Jenkins)
Change subject: util/autoport: Add CC-PDDC SPDX header to empty files
......................................................................
util/autoport: Add CC-PDDC SPDX header to empty files
As per commit cf4722d317ea (src/mb: Update unlicensable files with the
CC-PDDC SPDX ID) effectively empty files should use the Creative Commons
Public Domain Dedication and Certification (CC-PDDC) license header.
The only empty files that autoport currently generates are ec.asl and
superio.asl on non-laptop systems, where NoEC() is used.
Change-Id: I5fdf0c80443a79c082b3d0418d16cd858782b2c9
Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com>
---
M util/autoport/ec_none.go
M util/autoport/main.go
2 files changed, 9 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/83185/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/83185?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5fdf0c80443a79c082b3d0418d16cd858782b2c9
Gerrit-Change-Number: 83185
Gerrit-PatchSet: 5
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>