Attention is currently required from: Hung-Te Lin, Jianjun Wang, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/84116?usp=email )
Change subject: soc/mediatek: Add EARLY_INIT_PCIE_RESET to early_init_type
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84116?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7ab85694e85a4c3f77fefc22efe16734c347a716
Gerrit-Change-Number: 84116
Gerrit-PatchSet: 2
Gerrit-Owner: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Jianjun Wang <jianjun.wang(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Jianjun Wang <jianjun.wang(a)mediatek.com>
Gerrit-Comment-Date: Thu, 29 Aug 2024 09:02:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Eran Mitrani, Felix Singer, Jakub Czapiga, Kapil Porwal, Nico Huber, Tarun.
Subrata Banik has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/84125?usp=email )
Change subject: soc/intel/meteorlake: Hook up microcode from repository
......................................................................
Patch Set 4:
(1 comment)
File src/soc/intel/meteorlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/84125/comment/b5e7dfb6_0feade3a?us… :
PS4, Line 40: MICROCODE_BLOB_UNDISCLOSED
> Are you sure it makes a difference? It only changes the default.
i meant for below code change. https://review.coreboot.org/c/coreboot/+/84125/4/src/soc/intel/meteorlake/M…
this 3rdparty path is not applicable for us while we are building the code inside chromium repo.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84125?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I46021accacbb911d7a7ecfdbb52973a7da78f36e
Gerrit-Change-Number: 84125
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-Comment-Date: Thu, 29 Aug 2024 09:01:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Attention is currently required from: Hung-Te Lin, Jianjun Wang, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/84115?usp=email )
Change subject: soc/mediatek/common: Move mtk_pcie_reset to common/pcie.c
......................................................................
Patch Set 2:
(1 comment)
File src/soc/mediatek/common/pcie.c:
https://review.coreboot.org/c/coreboot/+/84115/comment/ecf8838f_2f7d59cb?us… :
PS2, Line 250: base
`reg` or `base_reg` or `reg_base`.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84115?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib540cf9cc568206a1e78306624f4df7c5631c128
Gerrit-Change-Number: 84115
Gerrit-PatchSet: 2
Gerrit-Owner: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Jianjun Wang <jianjun.wang(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Jianjun Wang <jianjun.wang(a)mediatek.com>
Gerrit-Comment-Date: Thu, 29 Aug 2024 09:00:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Hung-Te Lin, Jianjun Wang, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/84114?usp=email )
Change subject: soc/mediatek/common/pcie: Use clr/setbits32p
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
Thanks. I should have noticed this when reviewing the code.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84114?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id99d5aafdf4d687dbe3a0bef29b148537cf58dd8
Gerrit-Change-Number: 84114
Gerrit-PatchSet: 2
Gerrit-Owner: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Jianjun Wang <jianjun.wang(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Jianjun Wang <jianjun.wang(a)mediatek.com>
Gerrit-Comment-Date: Thu, 29 Aug 2024 08:56:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has uploaded a new patch set (#13) to the change originally created by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84026?usp=email )
Change subject: soc/mediatek/mt8196: Add EINT support
......................................................................
soc/mediatek/mt8196: Add EINT support
BUG=b:334723688
TEST=EINT works in Rauru
Change-Id: Ibeb2dafcd9909b4afbfa81728700718f01d3818f
Signed-off-by: Yidi Lin <yidilin(a)chromium.org>
---
M src/soc/mediatek/mt8196/Makefile.mk
A src/soc/mediatek/mt8196/gpio_eint.c
2 files changed, 303 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/84026/13
--
To view, visit https://review.coreboot.org/c/coreboot/+/84026?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibeb2dafcd9909b4afbfa81728700718f01d3818f
Gerrit-Change-Number: 84026
Gerrit-PatchSet: 13
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Attention is currently required from: Hung-Te Lin, Jianjun Wang, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/84113?usp=email )
Change subject: soc/mediatek/common/pcie: Add DEVTREE_CONST qualifier
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84113?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia7c95424019ec0dca50bbc6be7f81b6180d06d6e
Gerrit-Change-Number: 84113
Gerrit-PatchSet: 2
Gerrit-Owner: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Jianjun Wang <jianjun.wang(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Jianjun Wang <jianjun.wang(a)mediatek.com>
Gerrit-Comment-Date: Thu, 29 Aug 2024 08:53:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Hung-Te Lin, Jianjun Wang, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/84113?usp=email )
Change subject: soc/mediatek/common/pcie: Add DEVTREE_CONST qualifier
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84113/comment/ac3a5fe7_0fe68222?us… :
PS2, Line 12: src/soc/mediatek/common/pcie.c:104:26: error: assignment discards
When will this error show up? I mean, why didn't Jenkins build fail without this patch?
--
To view, visit https://review.coreboot.org/c/coreboot/+/84113?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia7c95424019ec0dca50bbc6be7f81b6180d06d6e
Gerrit-Change-Number: 84113
Gerrit-PatchSet: 2
Gerrit-Owner: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Jianjun Wang <jianjun.wang(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Jianjun Wang <jianjun.wang(a)mediatek.com>
Gerrit-Comment-Date: Thu, 29 Aug 2024 08:53:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84026?usp=email )
Change subject: soc/mediatek/mt8196: Add EINT support
......................................................................
Patch Set 12:
(4 comments)
File src/soc/mediatek/mt8196/eint.c:
PS7:
> rename to gpio_eint.c for consistency.
Done
File src/soc/mediatek/mt8196/eint.c:
https://review.coreboot.org/c/coreboot/+/84026/comment/e8d9d038_7ce1dbd9?us… :
PS8, Line 11: [4]
> If we're using `uint8_t` for `instance`, please define enum for its values (e.g. […]
Use `define` instead of `enum` since `enum` data size is 4 bytes.
https://review.coreboot.org/c/coreboot/+/84026/comment/fe20a0d4_272afe9a?us… :
PS8, Line 11: uint32_t
> We only use EINT to setup the IRQ pin from GSC. […]
Done
https://review.coreboot.org/c/coreboot/+/84026/comment/3834e651_4c5aaad8?us… :
PS8, Line 13: {0, 2, 0, 1},
> Can we put one entry `{a, b, c, d}` per line?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/84026?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibeb2dafcd9909b4afbfa81728700718f01d3818f
Gerrit-Change-Number: 84026
Gerrit-PatchSet: 12
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Comment-Date: Thu, 29 Aug 2024 08:53:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org>
Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>