coreboot-gerrit August 2024

coreboot-gerrit@coreboot.org

1 participants
3913 discussions

[L] Change in coreboot[main]: mb/hp: Add Compaq Elite 8300 CMT port
by Riku Viitanen (Code Review) 01 Aug '24

01 Aug '24

Attention is currently required from: Nicholas Chin, Paul Menzel. Riku Viitanen has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/79745?usp=email ) Change subject: mb/hp: Add Compaq Elite 8300 CMT port ...................................................................... Patch Set 15: (1 comment) File src/mainboard/hp/compaq_elite_8300_cmt/early_init.c: https://review.coreboot.org/c/coreboot/+/79745/comment/a62564c1_2d691f73?us… : PS14, Line 11: { 1, 0, 0 }, : { 1, 0, 0 }, : { 1, 0, 1 }, : { 1, 0, 1 }, : { 1, 0, 2 }, : { 1, 0, 2 }, : { 1, 0, 3 }, : { 1, 0, 3 }, : { 1, 0, 4 }, : { 1, 0, 4 }, : { 1, 0, 6 }, : { 1, 0, 5 }, : { 1, 0, 5 }, : { 1, 0, 6 }, > Move to devicetree, refer to commit c36b5ea18983 (mb/*: Copy bd82x6x boards' USB port config into de […] After doing that, it no longer builds: coreboot main $ make Updating git submodules. HOSTCC util/sconfig/lex.yy.o HOSTCC util/sconfig/sconfig.tab.o HOSTCC util/sconfig/main.o HOSTCC util/sconfig/sconfig (link) SCONFIG mainboard/hp/compaq_elite_8300_cmt/devicetree.cb ERROR: Duplicate device! (null) make: *** [Makefile.mk:763: build/mainboard/hp/compaq_elite_8300_cmt/static.c] Error 1 -- To view, visit https://review.coreboot.org/c/coreboot/+/79745?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie6ec60d2f4ee50d5e3fa2847c19fa4cf0ab73363 Gerrit-Change-Number: 79745 Gerrit-PatchSet: 15 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Thu, 01 Aug 2024 19:10:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[L] Change in coreboot[main]: mb/hp: Add Compaq Elite 8300 CMT port
by Riku Viitanen (Code Review) 01 Aug '24

01 Aug '24

Attention is currently required from: Paul Menzel, Riku Viitanen. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79745?usp=email to look at the new patch set (#15). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/hp: Add Compaq Elite 8300 CMT port ...................................................................... mb/hp: Add Compaq Elite 8300 CMT port Based on autoport and Z220 SuperIO code. With SeaBIOS and Nouveau on Debian, only nomodeset works with GTX 780 (must use proprietary driver instead). Tested by xilynx / spot_ on #libreboot: - i3-3220, native raminit 2x2GB, M378B5773DH0-CH9 + MT8JTF25664AZ-1G6M1 - Celeron G1620, native raminit 1x4GB, MT8JTF51264AZ-1G6E1 - Booting Debian with Linux 6.1.0-16-amd64 via SeaBIOS - All SATA ports - Audio: internal speaker, headphone and microphone plugs - Rebooting - S3 suspend and wake - libgfxinit: VGA, DisplayPort - Ethernet - Super I/O: fan speeds stay in control - GPU in PEG slot Untested: - EHCI debugging - Other PCI/PCIe slots - PS/2 - Serial, parallel ports Change-Id: Ie6ec60d2f4ee50d5e3fa2847c19fa4cf0ab73363 Signed-off-by: Riku Viitanen <riku.viitanen(a)protonmail.com> --- A src/mainboard/hp/compaq_elite_8300_cmt/Kconfig A src/mainboard/hp/compaq_elite_8300_cmt/Kconfig.name A src/mainboard/hp/compaq_elite_8300_cmt/Makefile.inc A src/mainboard/hp/compaq_elite_8300_cmt/acpi/ec.asl A src/mainboard/hp/compaq_elite_8300_cmt/acpi/platform.asl A src/mainboard/hp/compaq_elite_8300_cmt/acpi/superio.asl A src/mainboard/hp/compaq_elite_8300_cmt/acpi_tables.c A src/mainboard/hp/compaq_elite_8300_cmt/board_info.txt A src/mainboard/hp/compaq_elite_8300_cmt/cmos.default A src/mainboard/hp/compaq_elite_8300_cmt/cmos.layout A src/mainboard/hp/compaq_elite_8300_cmt/data.vbt A src/mainboard/hp/compaq_elite_8300_cmt/devicetree.cb A src/mainboard/hp/compaq_elite_8300_cmt/dsdt.asl A src/mainboard/hp/compaq_elite_8300_cmt/early_init.c A src/mainboard/hp/compaq_elite_8300_cmt/gma-mainboard.ads A src/mainboard/hp/compaq_elite_8300_cmt/gpio.c A src/mainboard/hp/compaq_elite_8300_cmt/hda_verb.c A src/mainboard/hp/compaq_elite_8300_cmt/mainboard.c 18 files changed, 660 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/79745/15 -- To view, visit https://review.coreboot.org/c/coreboot/+/79745?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie6ec60d2f4ee50d5e3fa2847c19fa4cf0ab73363 Gerrit-Change-Number: 79745 Gerrit-PatchSet: 15 Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[M] Change in coreboot[main]: mb/google/brox: Boot to kernel without battery
by Caveh Jalali (Code Review) 01 Aug '24

01 Aug '24

Attention is currently required from: Dinesh Gehlot, Eric Herrmann, Forest Mittelberg, Kapil Porwal, Karthik Ramasubramanian, Keith Short, Nick Vaccaro, Rishika Raj, Shelly Chang, Sowmya Aralguppe, Subrata Banik. Caveh Jalali has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/83735?usp=email ) Change subject: mb/google/brox: Boot to kernel without battery ...................................................................... Patch Set 4: (1 comment) File src/ec/google/chromeec/ec.h: https://review.coreboot.org/c/coreboot/+/83735/comment/682c556e_c02782e5?us… : PS4, Line 433: google_chromeec_is_battery_present please split the addition of a new chromeec API into a separate patch. also, do you really need a new API here? i would expect that the existing `google_chromeec_is_battery_present_and_above_critical_threshold` be a better choice here. it was introduced in https://review.coreboot.org/c/coreboot/+/78321 to address no-battery booting issues with MTL. -- To view, visit https://review.coreboot.org/c/coreboot/+/83735?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie49ed8f6d8b0fa59ec0e7b06efea9cac4d253957 Gerrit-Change-Number: 83735 Gerrit-PatchSet: 4 Gerrit-Owner: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Herrmann <eherrmann(a)google.com> Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Keith Short <keithshort(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com> Gerrit-Reviewer: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-CC: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-CC: Vinay Kumar <vinay.kumar(a)intel.com> Gerrit-Attention: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Eric Herrmann <eherrmann(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Keith Short <keithshort(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-Attention: Forest Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Thu, 01 Aug 2024 19:01:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: mb/google/brox: Boot to kernel without battery
by Sowmya Aralguppe (Code Review) 01 Aug '24

01 Aug '24

Attention is currently required from: Caveh Jalali, Dinesh Gehlot, Eric Herrmann, Forest Mittelberg, Kapil Porwal, Karthik Ramasubramanian, Keith Short, Nick Vaccaro, Rishika Raj, Shelly Chang, Subrata Banik. Hello Caveh Jalali, Dinesh Gehlot, Eric Herrmann, Forest Mittelberg, Kapil Porwal, Karthik Ramasubramanian, Keith Short, Nick Vaccaro, Rishika Raj, Shelly Chang, Subrata Banik, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83735?usp=email to look at the new patch set (#4). Change subject: mb/google/brox: Boot to kernel without battery ...................................................................... mb/google/brox: Boot to kernel without battery Set Boot frequency UPD to 1 to avoid higher PL2 power draw when only adaptor is connected with battery removed or disconnected. Reduce PL4 value to overcome power spikes from SoC during boot. Remove Psys implementation since it impacts active state platform performance. BUG=b:335046538,b:329722827 BRANCH=None TEST=Able to successfully boot on 3 different Brox proto2 SKU1 and SKU2 boards with 65W,45W and 30W adaptors for 3 iterations of cold boot. Change-Id: Ie49ed8f6d8b0fa59ec0e7b06efea9cac4d253957 Signed-off-by: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> --- M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec.h M src/mainboard/google/brox/variants/baseboard/brox/ramstage.c M src/mainboard/google/brox/variants/brox/ramstage.c M src/soc/intel/alderlake/romstage/fsp_params.c 5 files changed, 82 insertions(+), 104 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/83735/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/83735?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie49ed8f6d8b0fa59ec0e7b06efea9cac4d253957 Gerrit-Change-Number: 83735 Gerrit-PatchSet: 4 Gerrit-Owner: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Herrmann <eherrmann(a)google.com> Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Keith Short <keithshort(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com> Gerrit-Reviewer: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-CC: Vinay Kumar <vinay.kumar(a)intel.com> Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Eric Herrmann <eherrmann(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Keith Short <keithshort(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-Attention: Forest Mittelberg <bmbm(a)google.com>

1 0

[S] Change in coreboot[main]: mb/starlabs/starbook/rpl: Merge and alphabetise FSP UPDs
by Felix Held (Code Review) 01 Aug '24

01 Aug '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83622?usp=email ) Change subject: mb/starlabs/starbook/rpl: Merge and alphabetise FSP UPDs ...................................................................... mb/starlabs/starbook/rpl: Merge and alphabetise FSP UPDs Change-Id: I3c4a963b233f549c7a76c76333af87c887550ac3 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/83622 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb 1 file changed, 15 insertions(+), 18 deletions(-) Approvals: Matt DeVillier: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb index ac3ebdc..c393019 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb @@ -1,33 +1,30 @@ chip soc/intel/alderlake - # FSP Memory - register "enable_c6dram" = "1" - register "sagv" = "SaGv_Enabled" - - # FSP Silicon - register "eist_enable" = "1" - register "enable_c1e" = "1" - - register "disable_dynamic_tccold_handshake" = "1" + # FSP UPDs + register "disable_dynamic_tccold_handshake" = "true" + register "eist_enable" = "true" + register "enable_c1e" = "true" + register "enable_c6dram" = "true" + register "sagv" = "SaGv_Enabled" # Serial I/O register "serial_io_i2c_mode" = "{ - [PchSerialIoIndexI2C0] = PchSerialIoPci, + [PchSerialIoIndexI2C0] = PchSerialIoPci, }" register "serial_io_uart_mode" = "{ - [PchSerialIoIndexUART0] = PchSerialIoSkipInit, + [PchSerialIoIndexUART0] = PchSerialIoSkipInit, }" # Power - register "pch_slp_s3_min_assertion_width" = "2" # 50ms - register "pch_slp_s4_min_assertion_width" = "3" # 1s - register "pch_slp_sus_min_assertion_width" = "3" # 500ms - register "pch_slp_a_min_assertion_width" = "3" # 2s + register "pch_slp_s3_min_assertion_width" = "2" # 50ms + register "pch_slp_s4_min_assertion_width" = "3" # 1s + register "pch_slp_sus_min_assertion_width" = "3" # 500ms + register "pch_slp_a_min_assertion_width" = "3" # 2s # PM Util - register "pmc_gpe0_dw0" = "GPP_B" - register "pmc_gpe0_dw1" = "GPP_C" - register "pmc_gpe0_dw2" = "GPP_E" + register "pmc_gpe0_dw0" = "GPP_B" + register "pmc_gpe0_dw1" = "GPP_C" + register "pmc_gpe0_dw2" = "GPP_E" # Device Tree device domain 0 on -- To view, visit https://review.coreboot.org/c/coreboot/+/83622?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3c4a963b233f549c7a76c76333af87c887550ac3 Gerrit-Change-Number: 83622 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/starlabs/*: Add the subsystem ids for HDA
by Felix Held (Code Review) 01 Aug '24

01 Aug '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83621?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/starlabs/*: Add the subsystem ids for HDA ...................................................................... mb/starlabs/*: Add the subsystem ids for HDA The Windows drivers require the subsystem ID to match on the PCI device, so set these to allow the driver to install. Change-Id: I01b36554d5322018efc72734a8e749cc06263577 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/83621 Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/starlabs/lite/variants/glk/devicetree.cb M src/mainboard/starlabs/lite/variants/glkr/devicetree.cb M src/mainboard/starlabs/starbook/variants/adl/devicetree.cb M src/mainboard/starlabs/starbook/variants/cml/devicetree.cb M src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb M src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb M src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb 7 files changed, 13 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/lite/variants/glk/devicetree.cb b/src/mainboard/starlabs/lite/variants/glk/devicetree.cb index 2f58a7b..6c0269b 100644 --- a/src/mainboard/starlabs/lite/variants/glk/devicetree.cb +++ b/src/mainboard/starlabs/lite/variants/glk/devicetree.cb @@ -66,7 +66,9 @@ device ref p2sb on end device ref fast_spi on end device ref sram on end - device ref hda on end + device ref hda on + subsystemid 0x10ec 0x111e + end device ref heci1 on end device ref heci2 on end device ref heci3 on end diff --git a/src/mainboard/starlabs/lite/variants/glkr/devicetree.cb b/src/mainboard/starlabs/lite/variants/glkr/devicetree.cb index fe32143c5d..bfe9d51 100644 --- a/src/mainboard/starlabs/lite/variants/glkr/devicetree.cb +++ b/src/mainboard/starlabs/lite/variants/glkr/devicetree.cb @@ -66,7 +66,9 @@ device ref p2sb on end device ref fast_spi on end device ref sram on end - device ref hda on end + device ref hda on + subsystemid 0x10ec 0x111e + end device ref heci1 on end device ref heci2 on end device ref heci3 on end diff --git a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb index bbc428e..b9e449f 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb @@ -173,6 +173,7 @@ end end device ref hda on + subsystemid 0x1e50 0x7007 register "pch_hda_sdi_enable[0]" = "1" register "pch_hda_audio_link_hda_enable" = "1" register "pch_hda_idisp_codec_enable" = "1" diff --git a/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb b/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb index 448fc29..81d593f 100644 --- a/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb @@ -141,6 +141,7 @@ end end device ref hda on + subsystemid 0x10ec 0x1200 register "PchHdaAudioLinkHda" = "1" end device ref smbus on end diff --git a/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb index 42047b2..08f5006 100644 --- a/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb @@ -139,7 +139,9 @@ device pnp 4e.19 off end # Power Management Channel 5 end end - device ref hda on end + device ref hda on + subsystemid 0x10ec 0x10d0 + end device ref smbus on end device ref fast_spi on end end diff --git a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb index c7b8738..ac3ebdc 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb @@ -168,6 +168,7 @@ end end device ref hda on + subsystemid 0x1e50 0x7007 register "pch_hda_sdi_enable[0]" = "1" register "pch_hda_audio_link_hda_enable" = "1" register "pch_hda_idisp_codec_enable" = "1" diff --git a/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb index c29d7c9..26197a2 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb @@ -189,6 +189,7 @@ end end device ref hda on + subsystemid 0x10ec 0x1200 register "PchHdaAudioLinkHdaEnable" = "1" end device ref smbus on end -- To view, visit https://review.coreboot.org/c/coreboot/+/83621?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I01b36554d5322018efc72734a8e749cc06263577 Gerrit-Change-Number: 83621 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: mb/dell/optiplex_9020: Fix UB challenged package power calculation
by Máté Kukri (Code Review) 01 Aug '24

01 Aug '24

Attention is currently required from: Nico Huber. Máté Kukri has posted comments on this change by Máté Kukri. ( https://review.coreboot.org/c/coreboot/+/83736?usp=email ) Change subject: mb/dell/optiplex_9020: Fix UB challenged package power calculation ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: See Nico Huber's comment on CB:81529 -- To view, visit https://review.coreboot.org/c/coreboot/+/83736?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I48ef59c4fbeb0a55675ac24da31e6e0b194cb58d Gerrit-Change-Number: 83736 Gerrit-PatchSet: 1 Gerrit-Owner: Máté Kukri <km(a)mkukri.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Thu, 01 Aug 2024 18:43:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in coreboot[main]: mb/dell/optiplex_9020: Implement late HWM initialization
by Máté Kukri (Code Review) 01 Aug '24

01 Aug '24

Máté Kukri has posted comments on this change by Máté Kukri. ( https://review.coreboot.org/c/coreboot/+/81529?usp=email ) Change subject: mb/dell/optiplex_9020: Implement late HWM initialization ...................................................................... Patch Set 11: (1 comment) File src/mainboard/dell/optiplex_9020/mainboard.c: https://review.coreboot.org/c/coreboot/+/81529/comment/f40e80df_996c461c?us… : PS11, Line 310: / rapl_power_unit > I had a bit of a brain fart there, i dont know why i read `1 << (rapl_power_unit - 1)`.... […] See CB:83736 -- To view, visit https://review.coreboot.org/c/coreboot/+/81529?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibdccd3fc7364e03e84ca606592928410624eed43 Gerrit-Change-Number: 81529 Gerrit-PatchSet: 11 Gerrit-Owner: Máté Kukri <km(a)mkukri.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Comment-Date: Thu, 01 Aug 2024 18:43:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Máté Kukri <km(a)mkukri.xyz> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>

1 0

[XS] Change in coreboot[main]: mb/dell/optiplex_9020: Fix UB challenged package power calculation
by Máté Kukri (Code Review) 01 Aug '24

01 Aug '24

Máté Kukri has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83736?usp=email ) Change subject: mb/dell/optiplex_9020: Fix UB challenged package power calculation ...................................................................... mb/dell/optiplex_9020: Fix UB challenged package power calculation Signed-off-by: Mate Kukri <km(a)mkukri.xyz> Change-Id: I48ef59c4fbeb0a55675ac24da31e6e0b194cb58d --- M src/mainboard/dell/optiplex_9020/mainboard.c 1 file changed, 4 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/83736/1 diff --git a/src/mainboard/dell/optiplex_9020/mainboard.c b/src/mainboard/dell/optiplex_9020/mainboard.c index 6630a12..c1acbe2 100644 --- a/src/mainboard/dell/optiplex_9020/mainboard.c +++ b/src/mainboard/dell/optiplex_9020/mainboard.c @@ -303,11 +303,10 @@ static uint16_t get_pkg_power(void) { - uint8_t rapl_power_unit = rdmsr(0x606).lo & 0xf; - if (rapl_power_unit) - rapl_power_unit = 2 << (rapl_power_unit - 1); - uint16_t pkg_power_info = rdmsr(0x614).lo & 0x7fff; - if (pkg_power_info / rapl_power_unit > 0x41) + unsigned int pkg_power, power_unit; + pkg_power = rdmsr(0x614).lo & 0x7fff; + power_unit = 1 << (rdmsr(0x606).lo & 0xf); + if (pkg_power / power_unit > 0x41) return 32; else return 16; -- To view, visit https://review.coreboot.org/c/coreboot/+/83736?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I48ef59c4fbeb0a55675ac24da31e6e0b194cb58d Gerrit-Change-Number: 83736 Gerrit-PatchSet: 1 Gerrit-Owner: Máté Kukri <km(a)mkukri.xyz>

1 0

[M] Change in coreboot[main]: mb/google/brox: Boot to kernel without battery
by Sowmya Aralguppe (Code Review) 01 Aug '24

01 Aug '24

Attention is currently required from: Caveh Jalali, Dinesh Gehlot, Forest Mittelberg, Kapil Porwal, Nick Vaccaro, Rishika Raj, Subrata Banik. Hello Caveh Jalali, Dinesh Gehlot, Forest Mittelberg, Kapil Porwal, Nick Vaccaro, Rishika Raj, Subrata Banik, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83735?usp=email to look at the new patch set (#3). Change subject: mb/google/brox: Boot to kernel without battery ...................................................................... mb/google/brox: Boot to kernel without battery Set Boot frequency UPD to 1 to avoid higher PL2 power draw when only adaptor is connected with battery removed or disconnected. Reduce PL4 value to overcome power spikes from SoC during boot. BUG=b:335046538,b:329722827 BRANCH=None TEST=Able to successfully boot on 3 different Brox proto2 SKU1 and SKU2 boards with 65W,45W and 30W adaptors for 3 iterations of cold boot. Change-Id: Ie49ed8f6d8b0fa59ec0e7b06efea9cac4d253957 Signed-off-by: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> --- M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec.h M src/mainboard/google/brox/variants/baseboard/brox/ramstage.c M src/mainboard/google/brox/variants/brox/ramstage.c M src/soc/intel/alderlake/romstage/fsp_params.c 5 files changed, 82 insertions(+), 104 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/83735/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/83735?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie49ed8f6d8b0fa59ec0e7b06efea9cac4d253957 Gerrit-Change-Number: 83735 Gerrit-PatchSet: 3 Gerrit-Owner: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Forest Mittelberg <bmbm(a)google.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2024