coreboot-gerrit August 2024

coreboot-gerrit@coreboot.org

1 participants
3913 discussions

[S] Change in coreboot[main]: soc/intel/cnvi: Add power related methods
by Sean Rhodes (Code Review) 01 Aug '24

01 Aug '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83711?usp=email ) Change subject: soc/intel/cnvi: Add power related methods ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/83711?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib4a1a8a76ce74b991a3e8686e9594c2c2b145a39 Gerrit-Change-Number: 83711 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 01 Aug 2024 19:57:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: soc/intel/cnvw: Add GPEH Method
by Sean Rhodes (Code Review) 01 Aug '24

01 Aug '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83710?usp=email ) Change subject: soc/intel/cnvw: Add GPEH Method ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/83710?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I36c98c525c99fb2b7b5ebd8b0e392e6626e97290 Gerrit-Change-Number: 83710 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 01 Aug 2024 19:57:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: soc/intel/cnvi: Add PRR method for CNVi Reset
by Sean Rhodes (Code Review) 01 Aug '24

01 Aug '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83557?usp=email ) Change subject: soc/intel/cnvi: Add PRR method for CNVi Reset ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/83557?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I25e8462780badcad88b13052a6eb282c83af5def Gerrit-Change-Number: 83557 Gerrit-PatchSet: 12 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 01 Aug 2024 19:57:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: soc/intel/cnvi: Add SOW to ensure CNVi isn't put into D3 Cold
by Sean Rhodes (Code Review) 01 Aug '24

01 Aug '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83558?usp=email ) Change subject: soc/intel/cnvi: Add SOW to ensure CNVi isn't put into D3 Cold ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/83558?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1541cebc022adc927a9cd883500320e9ef82359f Gerrit-Change-Number: 83558 Gerrit-PatchSet: 8 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 01 Aug 2024 19:57:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: soc/intel/cnvi: Add CWAR Fields
by Sean Rhodes (Code Review) 01 Aug '24

01 Aug '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83709?usp=email ) Change subject: soc/intel/cnvi: Add CWAR Fields ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/83709?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3c1efc039e929ad1eeb8a0dd7c176e370e502e0c Gerrit-Change-Number: 83709 Gerrit-PatchSet: 6 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 01 Aug 2024 19:57:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: soc/intel/cnvi: Add CNVW OpRegion
by Sean Rhodes (Code Review) 01 Aug '24

01 Aug '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83556?usp=email ) Change subject: soc/intel/cnvi: Add CNVW OpRegion ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/83556?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idd2ff93fb65c40f656804d96966e1881202ccb56 Gerrit-Change-Number: 83556 Gerrit-PatchSet: 11 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Thu, 01 Aug 2024 19:57:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/dell/optiplex_9020: Fix 0-division and unintended truncation in pa...
by Angel Pons (Code Review) 01 Aug '24

01 Aug '24

Attention is currently required from: Máté Kukri, Nico Huber. Angel Pons has posted comments on this change by Máté Kukri. ( https://review.coreboot.org/c/coreboot/+/83736?usp=email ) Change subject: mb/dell/optiplex_9020: Fix 0-division and unintended truncation in package power calculation ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/83736/comment/4c0136e5_1858af60?us… : PS2, Line 7: mb/dell/optiplex_9020: Fix 0-division and unintended truncation in package power calculation Hmmm, now the summary line is too long. How about: > mb/dell/optiplex_9020: Fix UB in package power calculation > > Fix potential undefined behaviour in the `get_pkg_power()` function: Followed by the list in the current commit message's body -- To view, visit https://review.coreboot.org/c/coreboot/+/83736?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I48ef59c4fbeb0a55675ac24da31e6e0b194cb58d Gerrit-Change-Number: 83736 Gerrit-PatchSet: 2 Gerrit-Owner: Máté Kukri <km(a)mkukri.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Máté Kukri <km(a)mkukri.xyz> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Thu, 01 Aug 2024 19:53:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/dell/optiplex_9020: Fix 0-division and unintended truncation in pa...
by Máté Kukri (Code Review) 01 Aug '24

01 Aug '24

Attention is currently required from: Angel Pons, Nico Huber. Máté Kukri has posted comments on this change by Máté Kukri. ( https://review.coreboot.org/c/coreboot/+/83736?usp=email ) Change subject: mb/dell/optiplex_9020: Fix 0-division and unintended truncation in package power calculation ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/83736/comment/9460423b_130ac5c8?us… : PS1, Line 7: UB challenged > What does "UB challenged" mean? Poor choice of words, fixed now. File src/mainboard/dell/optiplex_9020/mainboard.c: https://review.coreboot.org/c/coreboot/+/83736/comment/455d27dc_e9987bcf?us… : PS1, Line 306: unsigned int pkg_power, power_unit; : pkg_power = rdmsr(0x614).lo & 0x7fff; : power_unit = 1 << (rdmsr(0x606).lo & 0xf); > ```suggestion […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/83736?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I48ef59c4fbeb0a55675ac24da31e6e0b194cb58d Gerrit-Change-Number: 83736 Gerrit-PatchSet: 2 Gerrit-Owner: Máté Kukri <km(a)mkukri.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 01 Aug 2024 19:22:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[XS] Change in coreboot[main]: mb/dell/optiplex_9020: Fix 0-division and unintended truncation in pa...
by Máté Kukri (Code Review) 01 Aug '24

01 Aug '24

Attention is currently required from: Angel Pons, Máté Kukri, Nico Huber. Hello Angel Pons, Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83736?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by Angel Pons Change subject: mb/dell/optiplex_9020: Fix 0-division and unintended truncation in package power calculation ...................................................................... mb/dell/optiplex_9020: Fix 0-division and unintended truncation in package power calculation - If `rapl_power_unit == 0`, `pkg_power_info / rapl_power_unit` is invalid - If `rapl_power_unit > 7`, the result of the shift doesn't fit into a `uint8_t` Signed-off-by: Mate Kukri <km(a)mkukri.xyz> Change-Id: I48ef59c4fbeb0a55675ac24da31e6e0b194cb58d --- M src/mainboard/dell/optiplex_9020/mainboard.c 1 file changed, 3 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/83736/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83736?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I48ef59c4fbeb0a55675ac24da31e6e0b194cb58d Gerrit-Change-Number: 83736 Gerrit-PatchSet: 2 Gerrit-Owner: Máté Kukri <km(a)mkukri.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Máté Kukri <km(a)mkukri.xyz> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>

1 0

[XS] Change in coreboot[main]: mb/dell/optiplex_9020: Fix UB challenged package power calculation
by Angel Pons (Code Review) 01 Aug '24

01 Aug '24

Attention is currently required from: Máté Kukri, Nico Huber. Angel Pons has posted comments on this change by Máté Kukri. ( https://review.coreboot.org/c/coreboot/+/83736?usp=email ) Change subject: mb/dell/optiplex_9020: Fix UB challenged package power calculation ...................................................................... Patch Set 1: Code-Review+1 (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/83736/comment/25655f20_09127fa4?us… : PS1, Line 7: UB challenged What does "UB challenged" mean? File src/mainboard/dell/optiplex_9020/mainboard.c: https://review.coreboot.org/c/coreboot/+/83736/comment/ef057a87_d3b0d514?us… : PS1, Line 306: unsigned int pkg_power, power_unit; : pkg_power = rdmsr(0x614).lo & 0x7fff; : power_unit = 1 << (rdmsr(0x606).lo & 0xf); ```suggestion const unsigned int pkg_power = rdmsr(0x614).lo & 0x7fff; const unsigned int power_unit = 1 << (rdmsr(0x606).lo & 0xf); ``` https://review.coreboot.org/c/coreboot/+/83736/comment/03e46514_15af6ec7?us… : PS1, Line 309: 0x41 nit: `65` is a more meaningful value -- To view, visit https://review.coreboot.org/c/coreboot/+/83736?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I48ef59c4fbeb0a55675ac24da31e6e0b194cb58d Gerrit-Change-Number: 83736 Gerrit-PatchSet: 1 Gerrit-Owner: Máté Kukri <km(a)mkukri.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Máté Kukri <km(a)mkukri.xyz> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Thu, 01 Aug 2024 19:17:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2024