coreboot-gerrit August 2024

coreboot-gerrit@coreboot.org

1 participants
3913 discussions

[S] Change in coreboot[main]: soc/intel/cnvi: Add SBTE Method
by Matt DeVillier (Code Review) 02 Aug '24

02 Aug '24

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83714?usp=email ) Change subject: soc/intel/cnvi: Add SBTE Method ...................................................................... Patch Set 5: (1 comment) File src/soc/intel/common/block/cnvi/cnvi.c: https://review.coreboot.org/c/coreboot/+/83714/comment/847168e4_6a993cf9?us… : PS5, Line 284: // TODO: ADL PCH S is 0x08030000, should be able to use an `if CONFIG()` check for the PCH -- To view, visit https://review.coreboot.org/c/coreboot/+/83714?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I11cdf654223daa7b417d6aa18855b48b50a8faa4 Gerrit-Change-Number: 83714 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Fri, 02 Aug 2024 13:57:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: soc/intel/cnvi: Add CNIP Method
by Matt DeVillier (Code Review) 02 Aug '24

02 Aug '24

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83713?usp=email ) Change subject: soc/intel/cnvi: Add CNIP Method ...................................................................... Patch Set 5: (1 comment) File src/soc/intel/common/block/cnvi/cnvi.c: https://review.coreboot.org/c/coreboot/+/83713/comment/699c314a_bca98f18?us… : PS5, Line 249: Method (CNIP, 0, NotSerialized) asl and acpigen here don't match -- To view, visit https://review.coreboot.org/c/coreboot/+/83713?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id8a36a09c7beaf3ba8b29d3276bd9dc59420dab5 Gerrit-Change-Number: 83713 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Fri, 02 Aug 2024 13:56:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: soc/intel/cnvi: Add CFLR Method
by Matt DeVillier (Code Review) 02 Aug '24

02 Aug '24

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83712?usp=email ) Change subject: soc/intel/cnvi: Add CFLR Method ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83712?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idc4c35e71076fd31786212995472bb8d58c961de Gerrit-Change-Number: 83712 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Fri, 02 Aug 2024 13:55:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: soc/intel/cnvi: Add power related methods
by Matt DeVillier (Code Review) 02 Aug '24

02 Aug '24

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83711?usp=email ) Change subject: soc/intel/cnvi: Add power related methods ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83711?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib4a1a8a76ce74b991a3e8686e9594c2c2b145a39 Gerrit-Change-Number: 83711 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Fri, 02 Aug 2024 13:54:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: soc/intel/cnvw: Add GPEH Method
by Matt DeVillier (Code Review) 02 Aug '24

02 Aug '24

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83710?usp=email ) Change subject: soc/intel/cnvw: Add GPEH Method ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83710?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I36c98c525c99fb2b7b5ebd8b0e392e6626e97290 Gerrit-Change-Number: 83710 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Fri, 02 Aug 2024 13:54:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: soc/intel/cnvi: Add PRR method for CNVi Reset
by Matt DeVillier (Code Review) 02 Aug '24

02 Aug '24

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83557?usp=email ) Change subject: soc/intel/cnvi: Add PRR method for CNVi Reset ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83557?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I25e8462780badcad88b13052a6eb282c83af5def Gerrit-Change-Number: 83557 Gerrit-PatchSet: 12 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Fri, 02 Aug 2024 13:52:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: soc/intel/cnvi: Add SOW to ensure CNVi isn't put into D3 Cold
by Matt DeVillier (Code Review) 02 Aug '24

02 Aug '24

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83558?usp=email ) Change subject: soc/intel/cnvi: Add SOW to ensure CNVi isn't put into D3 Cold ...................................................................... Patch Set 8: Code-Review+1 (1 comment) File src/soc/intel/common/block/cnvi/cnvi.c: https://review.coreboot.org/c/coreboot/+/83558/comment/adab2463_d18f051d?us… : PS8, Line 97: /* maybe add a comment here that the '3' is limiting it to D3 Hot? -- To view, visit https://review.coreboot.org/c/coreboot/+/83558?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1541cebc022adc927a9cd883500320e9ef82359f Gerrit-Change-Number: 83558 Gerrit-PatchSet: 8 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Fri, 02 Aug 2024 13:52:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: soc/intel/cnvi: Add CWAR Fields
by Matt DeVillier (Code Review) 02 Aug '24

02 Aug '24

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83709?usp=email ) Change subject: soc/intel/cnvi: Add CWAR Fields ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83709?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3c1efc039e929ad1eeb8a0dd7c176e370e502e0c Gerrit-Change-Number: 83709 Gerrit-PatchSet: 6 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Fri, 02 Aug 2024 13:51:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: soc/intel/cnvi: Add CNVW OpRegion
by Matt DeVillier (Code Review) 02 Aug '24

02 Aug '24

Attention is currently required from: Nico Huber, Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83556?usp=email ) Change subject: soc/intel/cnvi: Add CNVW OpRegion ...................................................................... Patch Set 11: Code-Review+1 (1 comment) File src/soc/intel/common/block/cnvi/cnvi.c: https://review.coreboot.org/c/coreboot/+/83556/comment/93cd804c_47f03c8a?us… : PS6, Line 40: dev->path.pnp.port, 2 > Oh, this is PCI config space? that's confusing, there should be an ACPI […] `GPCB() + <offset>` is used in coreboot's tcss.asl for TGL/ADL/MTL, though it would be nice to know where this offset is coming from -- To view, visit https://review.coreboot.org/c/coreboot/+/83556?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idd2ff93fb65c40f656804d96966e1881202ccb56 Gerrit-Change-Number: 83556 Gerrit-PatchSet: 11 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Fri, 02 Aug 2024 13:49:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>

1 0

[M] Change in coreboot[main]: util/autoport: Put devicetree devices above chips
by Angel Pons (Code Review) 02 Aug '24

02 Aug '24

Attention is currently required from: Nicholas Chin. Angel Pons has posted comments on this change by Angel Pons. ( https://review.coreboot.org/c/coreboot/+/82406?usp=email ) Change subject: util/autoport: Put devicetree devices above chips ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > Leaving the other comment open. When tested, it can be submitted as is, I guess. Maybe we should have a set of files checked in, to use for testing. Hmmm, I can get some logs out of the SNB laptop I have somewhere... -- To view, visit https://review.coreboot.org/c/coreboot/+/82406?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9dc2ff13182ff9d92141b1736796749cea49d23a Gerrit-Change-Number: 82406 Gerrit-PatchSet: 5 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Fri, 02 Aug 2024 13:47:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2024