Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84168?usp=email )
Change subject: bsd/metadata_hash.h: Fix Wunterminated-string-initialization error on metadata_hash_anchor
......................................................................
bsd/metadata_hash.h: Fix Wunterminated-string-initialization error on metadata_hash_anchor
while on it, fix "metadata_hash.c" file name in comment.
Change-Id: Ife62d9f7e1e403df130bb4aacacb4897af920460
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M src/commonlib/bsd/include/commonlib/bsd/metadata_hash.h
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/84168/1
diff --git a/src/commonlib/bsd/include/commonlib/bsd/metadata_hash.h b/src/commonlib/bsd/include/commonlib/bsd/metadata_hash.h
index d5e54b5..4f9fa8f 100644
--- a/src/commonlib/bsd/include/commonlib/bsd/metadata_hash.h
+++ b/src/commonlib/bsd/include/commonlib/bsd/metadata_hash.h
@@ -8,7 +8,7 @@
/* This structure is embedded somewhere in the (uncompressed) bootblock. */
struct metadata_hash_anchor {
- uint8_t magic[8];
+ uint8_t magic[9];
struct vb2_hash cbfs_hash;
/* NOTE: This is just reserving space. sizeof(struct vb2_hash) may change between
configurations/versions and cannot be relied upon, so the FMAP hash must be placed
@@ -26,7 +26,7 @@
/*
* Do not use this constant anywhere else in coreboot code to ensure the bit pattern really only
* appears once in the CBFS image. The only coreboot file allowed to use this is
- * src/lib/metadata_anchor.c to define the actual anchor data structure. It is defined here so
+ * src/lib/metadata_hash.c to define the actual anchor data structure. It is defined here so
* that it can be shared with cbfstool (which may use it freely).
*/
#define DO_NOT_USE_METADATA_HASH_ANCHOR_MAGIC_DO_NOT_USE "\xadMdtHsh\x15"
--
To view, visit https://review.coreboot.org/c/coreboot/+/84168?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ife62d9f7e1e403df130bb4aacacb4897af920460
Gerrit-Change-Number: 84168
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Attention is currently required from: Martin L Roth, Nico Huber.
Hello Martin L Roth, Nico Huber, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83909?usp=email
to look at the new patch set (#5).
Change subject: include/stdbool: Fix useless type name in empty declaration error
......................................................................
include/stdbool: Fix useless type name in empty declaration error
This fixes the following error:
src/include/stdbool.h:6:17: error: two or more data types in declaration specifiers
6 | typedef _Bool bool;
| ^~~~
src/include/stdbool.h:6:1: error: useless type name in empty declaration [-Werror]
6 | typedef _Bool bool;
| ^~~~~~~
Change-Id: Iec9b4e3f308008ece773ce3460daff97370161ea
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M src/include/stdbool.h
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/83909/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/83909?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iec9b4e3f308008ece773ce3460daff97370161ea
Gerrit-Change-Number: 83909
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Attention is currently required from: Arthur Heymans.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84033?usp=email
to look at the new patch set (#29).
Change subject: [NOT_FOR_MERGE]Kconfig: Build all targets with LTO
......................................................................
[NOT_FOR_MERGE]Kconfig: Build all targets with LTO
ARM with GCC LTO fails hard.
Change-Id: I3be6a71fdf9c2d1e14226550daa734b7cdc7e350
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/84033/29
--
To view, visit https://review.coreboot.org/c/coreboot/+/84033?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3be6a71fdf9c2d1e14226550daa734b7cdc7e350
Gerrit-Change-Number: 84033
Gerrit-PatchSet: 29
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Attention is currently required from: Martin L Roth, Paul Menzel, Ronak Kanabar.
Sergii Dmytruk has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/coreboot/+/83738?usp=email )
Change subject: vendorcode/intel: allow selecting EDK headers manually
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83738/comment/31d6b7c9_6b20444e?us… :
PS3, Line 7: vendorcode/intel
> Why is this Intel specific?
I think that's because it was initially added for Intel FSP in CB:4015.
https://review.coreboot.org/c/coreboot/+/83738/comment/60a462a0_a6d46101?us… :
PS3, Line 10: This prevents enabling those options
: for boards which don't require EDK bindings.
> Please elaborate and give examples.
See the latest version.
File src/vendorcode/intel/Kconfig:
https://review.coreboot.org/c/coreboot/+/83738/comment/c64605d5_d2b9e5cf?us… :
PS3, Line 37: Set of UEFI headers to use
> Maybe: […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/83738?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I964142ef64967b4c9b329025ebcad701e34a5035
Gerrit-Change-Number: 83738
Gerrit-PatchSet: 4
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Comment-Date: Sat, 31 Aug 2024 13:03:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Attention is currently required from: Martin L Roth, Ronak Kanabar, Sergii Dmytruk.
Hello Ronak Kanabar, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83738?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: vendorcode/intel: allow selecting EDK headers manually
......................................................................
vendorcode/intel: allow selecting EDK headers manually
EFI-specific options depend on CONFIG_UDK_BASE which gets set only when
CONFIG_*_BINDING is selected by SOCs (e.g., when necessary for Intel
FSP). This prevents enabling DRIVERS_EFI_VARIABLE_STORE and
DRIVERS_EFI_FW_INFO options for boards which don't require EDK bindings
for anything else.
Make version of the bindings freely selectable when SOC doesn't request
a specific version and EDK2 payload is used.
The implementation looks somewhat ugly and duplicated because otherwise
kconfig detects a loop in configuration options and refuses to do
anything.
Change-Id: I964142ef64967b4c9b329025ebcad701e34a5035
Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
---
M src/vendorcode/intel/Kconfig
M src/vendorcode/intel/Makefile.mk
2 files changed, 44 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/83738/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/83738?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I964142ef64967b4c9b329025ebcad701e34a5035
Gerrit-Change-Number: 83738
Gerrit-PatchSet: 4
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Attention is currently required from: Arthur Heymans, Krystian Hebel, Martin L Roth, Patrick Rudolph, Paul Menzel.
Sergii Dmytruk has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/coreboot/+/83426?usp=email )
Change subject: Documentation/drivers/smmstorev2.md: describe capsule update API
......................................................................
Patch Set 6:
(1 comment)
File Documentation/drivers/smmstorev2.md:
https://review.coreboot.org/c/coreboot/+/83426/comment/1f37eeb9_966192bd?us… :
PS6, Line 227: but because coreboot has no way of enforcing it being used might
: as well leave it to a reboot
> I do not fully parse “enforcing it being used might as well”.
It was meant to be read as "but, because coreboot has no way of enforcing it being used, might as well leave it to a reboot". I tried to reword the sentence to make it more readable.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83426?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I94761d18be567e5302d1a836f09f0a7eecb4fb00
Gerrit-Change-Number: 83426
Gerrit-PatchSet: 6
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Comment-Date: Sat, 31 Aug 2024 12:57:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>