August 2024 - coreboot-gerrit - mail.coreboot.org

[L] Change in coreboot[main]: [RFC] Add UPL FDT handoff
by Maximilian Brune (Code Review) Aug. 31, 2024

Aug. 31, 2024

Attention is currently required from: Arthur Heymans, Jakub Czapiga, Julius Werner, Jérémy Compostella, Lean Sheng Tan, Matt DeVillier, Philipp Hug, Simon Glass, ron minnich. Hello Jakub Czapiga, Julius Werner, Jérémy Compostella, Lean Sheng Tan, Matt DeVillier, Philipp Hug, Simon Glass, build bot (Jenkins), ron minnich, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76591?usp=email to look at the new patch set (#22). Change subject: [RFC] Add UPL FDT handoff ...................................................................... [RFC] Add UPL FDT handoff This adds another handoff that is basically the same as coreboot tables. The only real difference is that it uses the devicetree format to transfer the information to payload. This handoff is inspired by the UPL (universal payload) specification. Tested: start q35 qemu with coreinfo as payload and see that console still works and the devicetree is printed by coreboot. Change-Id: I36148e9de6ee992a67ec853ef5cbf1b5f83b44ae Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> --- M payloads/Kconfig M payloads/libpayload/Kconfig M payloads/libpayload/arch/arm/coreboot.c M payloads/libpayload/arch/arm64/coreboot.c M payloads/libpayload/arch/x86/coreboot.c M payloads/libpayload/include/sysinfo.h M payloads/libpayload/libc/Makefile.mk A payloads/libpayload/libc/upl_fdt.c M src/arch/arm/include/arch/cbconfig.h M src/arch/arm64/include/arch/cbconfig.h M src/arch/ppc64/include/arch/cbconfig.h M src/arch/riscv/include/arch/cbconfig.h M src/arch/x86/include/arch/cbconfig.h M src/arch/x86/tables.c M src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h M src/drivers/uart/pl011.c M src/drivers/uart/uart8250io.c M src/drivers/uart/uart8250mem.c M src/include/boot/coreboot_tables.h M src/include/boot/tables.h A src/include/boot/upl_fdt_table.h M src/lib/Makefile.mk M src/lib/bootmem.c M src/lib/coreboot_table.c A src/lib/tables.c A src/lib/upl_fdt_table.c M tests/lib/Makefile.mk 27 files changed, 662 insertions(+), 62 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/76591/22 -- To view, visit https://review.coreboot.org/c/coreboot/+/76591?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I36148e9de6ee992a67ec853ef5cbf1b5f83b44ae Gerrit-Change-Number: 76591 Gerrit-PatchSet: 22 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Shuo Liu <shuo.liu(a)intel.com> Gerrit-CC: coreboot org <coreboot.org(a)gmail.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Simon Glass <sjg(a)chromium.org> Gerrit-Attention: ron minnich <rminnich(a)gmail.com>

1 0

[S] Change in coreboot[main]: [for test] test upgrade crossgcc
by Elyes Haouas (Code Review) Aug. 31, 2024

Aug. 31, 2024

Attention is currently required from: Cliff Huang, Lance Zhao, Martin L Roth, Tim Wawrzynczak. Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/81419?usp=email ) Change subject: [for test] test upgrade crossgcc ...................................................................... Patch Set 26: -Code-Review -- To view, visit https://review.coreboot.org/c/coreboot/+/81419?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I463c303694c304bb3bf664bc1d914462e7af5dbb Gerrit-Change-Number: 81419 Gerrit-PatchSet: 26 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Comment-Date: Sat, 31 Aug 2024 16:48:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: [for test] test upgrade crossgcc
by Elyes Haouas (Code Review) Aug. 31, 2024

Aug. 31, 2024

Attention is currently required from: Cliff Huang, Lance Zhao, Martin L Roth, Tim Wawrzynczak. Hello Cliff Huang, Lance Zhao, Martin L Roth, Tim Wawrzynczak, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81419?usp=email to look at the new patch set (#26). Change subject: [for test] test upgrade crossgcc ...................................................................... [for test] test upgrade crossgcc Change-Id: I463c303694c304bb3bf664bc1d914462e7af5dbb Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/crossgcc/buildgcc R util/crossgcc/patches/gcc-15-20240825_asan_shadow_offset_callback.patch R util/crossgcc/patches/gcc-15-20240825_gnat.patch R util/crossgcc/patches/gcc-15-20240825_libcpp.patch R util/crossgcc/patches/gcc-15-20240825_libgcc.patch R util/crossgcc/patches/gcc-15-20240825_musl_poisoned_calloc.patch R util/crossgcc/patches/gcc-15-20240825_rv32iafc.patch D util/crossgcc/sum/clang-18.1.8.src.tar.xz.cksum A util/crossgcc/sum/clang-19.1.0-rc3.src.tar.xz.cksum D util/crossgcc/sum/clang-tools-extra-18.1.8.src.tar.xz.cksum A util/crossgcc/sum/clang-tools-extra-19.1.0-rc3.src.tar.xz.cksum D util/crossgcc/sum/cmake-18.1.8.src.tar.xz.cksum A util/crossgcc/sum/cmake-19.1.0-rc3.src.tar.xz.cksum D util/crossgcc/sum/cmake-3.30.2.tar.gz.cksum A util/crossgcc/sum/cmake-3.30.3.tar.gz.cksum D util/crossgcc/sum/compiler-rt-18.1.8.src.tar.xz.cksum A util/crossgcc/sum/compiler-rt-19.1.0-rc3.src.tar.xz.cksum D util/crossgcc/sum/gcc-14.2.0.tar.xz.cksum A util/crossgcc/sum/gcc-15-20240825.tar.xz.cksum D util/crossgcc/sum/libunwind-18.1.8.src.tar.xz.cksum A util/crossgcc/sum/libunwind-19.1.0-rc3.src.tar.xz.cksum D util/crossgcc/sum/lld-18.1.8.src.tar.xz.cksum A util/crossgcc/sum/lld-19.1.0-rc3.src.tar.xz.cksum D util/crossgcc/sum/llvm-18.1.8.src.tar.xz.cksum A util/crossgcc/sum/llvm-19.1.0-rc3.src.tar.xz.cksum 25 files changed, 14 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/81419/26 -- To view, visit https://review.coreboot.org/c/coreboot/+/81419?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I463c303694c304bb3bf664bc1d914462e7af5dbb Gerrit-Change-Number: 81419 Gerrit-PatchSet: 26 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>

1 0

[XS] Change in coreboot[main]: mb/google/brox/jubilant: Modify FP IRQ pin
by Bob Moragues (Code Review) Aug. 31, 2024

Aug. 31, 2024

Attention is currently required from: Marx Wang, Marx Wang, Nick Vaccaro, Ren Kuo, Subrata Banik. Bob Moragues has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/84124?usp=email ) Change subject: mb/google/brox/jubilant: Modify FP IRQ pin ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: Will this affect any devices that have shipped to labs or otherwise? If this change deprecates any hardware, please advise. -- To view, visit https://review.coreboot.org/c/coreboot/+/84124?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic4a7ca07eab0dab234ab025cf77bbb8093b6b9d1 Gerrit-Change-Number: 84124 Gerrit-PatchSet: 8 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Bob Moragues <moragues(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Marx Wang <marx.wang(a)intel.com> Gerrit-Reviewer: Marx Wang <marx.wang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Marx Wang <marx.wang(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Marx Wang <marx.wang(a)intel.corp-partner.google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Sat, 31 Aug 2024 16:22:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: soc/qclib_common.h: Fix Wunterminated-string-initialization error on ...
by Elyes Haouas (Code Review) Aug. 31, 2024

Aug. 31, 2024

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84169?usp=email ) Change subject: soc/qclib_common.h: Fix Wunterminated-string-initialization error on qclib_cb_if_table ...................................................................... soc/qclib_common.h: Fix Wunterminated-string-initialization error on qclib_cb_if_table Change-Id: I50a70f1161ea5f9926dcce51be1156ec86b4b709 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/soc/qualcomm/common/include/soc/qclib_common.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/84169/1 diff --git a/src/soc/qualcomm/common/include/soc/qclib_common.h b/src/soc/qualcomm/common/include/soc/qclib_common.h index 792b743..00e9f77 100644 --- a/src/soc/qualcomm/common/include/soc/qclib_common.h +++ b/src/soc/qualcomm/common/include/soc/qclib_common.h @@ -53,7 +53,7 @@ #define QCLIB_MAGIC_NUMBER "QCLIB_CB" struct qclib_cb_if_table { - char magic[8]; /* 0x00 */ + char magic[9]; /* 0x00 */ uint32_t version; /* 0x08 */ uint32_t num_entries; /* 0x0C */ uint32_t max_entries; /* 0x10 */ -- To view, visit https://review.coreboot.org/c/coreboot/+/84169?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I50a70f1161ea5f9926dcce51be1156ec86b4b709 Gerrit-Change-Number: 84169 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: bsd/metadata_hash.h: Fix Wunterminated-string-initialization error on...
by Elyes Haouas (Code Review) Aug. 31, 2024

Aug. 31, 2024

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84168?usp=email ) Change subject: bsd/metadata_hash.h: Fix Wunterminated-string-initialization error on metadata_hash_anchor ...................................................................... bsd/metadata_hash.h: Fix Wunterminated-string-initialization error on metadata_hash_anchor while on it, fix "metadata_hash.c" file name in comment. Change-Id: Ife62d9f7e1e403df130bb4aacacb4897af920460 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/commonlib/bsd/include/commonlib/bsd/metadata_hash.h 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/84168/1 diff --git a/src/commonlib/bsd/include/commonlib/bsd/metadata_hash.h b/src/commonlib/bsd/include/commonlib/bsd/metadata_hash.h index d5e54b5..4f9fa8f 100644 --- a/src/commonlib/bsd/include/commonlib/bsd/metadata_hash.h +++ b/src/commonlib/bsd/include/commonlib/bsd/metadata_hash.h @@ -8,7 +8,7 @@ /* This structure is embedded somewhere in the (uncompressed) bootblock. */ struct metadata_hash_anchor { - uint8_t magic[8]; + uint8_t magic[9]; struct vb2_hash cbfs_hash; /* NOTE: This is just reserving space. sizeof(struct vb2_hash) may change between configurations/versions and cannot be relied upon, so the FMAP hash must be placed @@ -26,7 +26,7 @@ /* * Do not use this constant anywhere else in coreboot code to ensure the bit pattern really only * appears once in the CBFS image. The only coreboot file allowed to use this is - * src/lib/metadata_anchor.c to define the actual anchor data structure. It is defined here so + * src/lib/metadata_hash.c to define the actual anchor data structure. It is defined here so * that it can be shared with cbfstool (which may use it freely). */ #define DO_NOT_USE_METADATA_HASH_ANCHOR_MAGIC_DO_NOT_USE "\xadMdtHsh\x15" -- To view, visit https://review.coreboot.org/c/coreboot/+/84168?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ife62d9f7e1e403df130bb4aacacb4897af920460 Gerrit-Change-Number: 84168 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: acpi/sata.c: Fix Wunterminated-string-initialization error on port_name
by Tim Wawrzynczak (Code Review) Aug. 31, 2024

Aug. 31, 2024

Attention is currently required from: Cliff Huang, Elyes Haouas, Lance Zhao. Tim Wawrzynczak has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84166?usp=email ) Change subject: acpi/sata.c: Fix Wunterminated-string-initialization error on port_name ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84166?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie80c2329c4a2698bd9e72ba1b36c1c05e37b214b Gerrit-Change-Number: 84166 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Sumeet Pawnikar <sumeet4linux(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sat, 31 Aug 2024 15:51:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: [only build test] tree: add -fsanitize=undefined
by Elyes Haouas (Code Review) Aug. 31, 2024

Aug. 31, 2024

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84167?usp=email ) Change subject: [only build test] tree: add -fsanitize=undefined ...................................................................... [only build test] tree: add -fsanitize=undefined Change-Id: I4002ba18ebddb87f177b27048d8ade2df8016362 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Makefile.mk 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/84167/1 diff --git a/Makefile.mk b/Makefile.mk index e7a9ab1..a00e249 100644 --- a/Makefile.mk +++ b/Makefile.mk @@ -534,7 +534,7 @@ CFLAGS_common += -fno-pie CFLAGS_common += -Wstring-compare ifeq ($(CONFIG_COMPILER_GCC),y) -CFLAGS_common += -Wold-style-declaration +CFLAGS_common += -Wold-style-declaration -fsanitize=undefined CFLAGS_common += -Wcast-function-type # Don't add these GCC specific flags when running scan-build ifeq ($(CCC_ANALYZER_OUTPUT_FORMAT),) -- To view, visit https://review.coreboot.org/c/coreboot/+/84167?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4002ba18ebddb87f177b27048d8ade2df8016362 Gerrit-Change-Number: 84167 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: include/stdbool: Fix useless type name in empty declaration error
by Elyes Haouas (Code Review) Aug. 31, 2024

Aug. 31, 2024

Attention is currently required from: Martin L Roth, Nico Huber. Hello Martin L Roth, Nico Huber, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83909?usp=email to look at the new patch set (#5). Change subject: include/stdbool: Fix useless type name in empty declaration error ...................................................................... include/stdbool: Fix useless type name in empty declaration error This fixes the following error: src/include/stdbool.h:6:17: error: two or more data types in declaration specifiers 6 | typedef _Bool bool; | ^~~~ src/include/stdbool.h:6:1: error: useless type name in empty declaration [-Werror] 6 | typedef _Bool bool; | ^~~~~~~ Change-Id: Iec9b4e3f308008ece773ce3460daff97370161ea Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/include/stdbool.h 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/83909/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/83909?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iec9b4e3f308008ece773ce3460daff97370161ea Gerrit-Change-Number: 83909 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>

1 0

[XS] Change in coreboot[main]: acpi/sata.c: Fix Wunterminated-string-initialization error on port_name
by Sumeet Pawnikar (Code Review) Aug. 31, 2024

Aug. 31, 2024

Attention is currently required from: Cliff Huang, Elyes Haouas, Lance Zhao, Tim Wawrzynczak. Sumeet Pawnikar has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84166?usp=email ) Change subject: acpi/sata.c: Fix Wunterminated-string-initialization error on port_name ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/84166?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie80c2329c4a2698bd9e72ba1b36c1c05e37b214b Gerrit-Change-Number: 84166 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Sumeet Pawnikar <sumeet4linux(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sat, 31 Aug 2024 13:38:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0