coreboot-gerrit August 2024

coreboot-gerrit@coreboot.org

1 participants
3913 discussions

[XS] Change in coreboot[main]: mb/google/brox/jubilant: Modify FP IRQ pin
by Bob Moragues (Code Review) 31 Aug '24

31 Aug '24

Attention is currently required from: Marx Wang, Marx Wang, Nick Vaccaro, Ren Kuo, Subrata Banik. Bob Moragues has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/84124?usp=email ) Change subject: mb/google/brox/jubilant: Modify FP IRQ pin ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: Will this affect any devices that have shipped to labs or otherwise? If this change deprecates any hardware, please advise. -- To view, visit https://review.coreboot.org/c/coreboot/+/84124?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic4a7ca07eab0dab234ab025cf77bbb8093b6b9d1 Gerrit-Change-Number: 84124 Gerrit-PatchSet: 8 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Bob Moragues <moragues(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Marx Wang <marx.wang(a)intel.com> Gerrit-Reviewer: Marx Wang <marx.wang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Marx Wang <marx.wang(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Marx Wang <marx.wang(a)intel.corp-partner.google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Sat, 31 Aug 2024 16:22:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: soc/qclib_common.h: Fix Wunterminated-string-initialization error on ...
by Elyes Haouas (Code Review) 31 Aug '24

31 Aug '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84169?usp=email ) Change subject: soc/qclib_common.h: Fix Wunterminated-string-initialization error on qclib_cb_if_table ...................................................................... soc/qclib_common.h: Fix Wunterminated-string-initialization error on qclib_cb_if_table Change-Id: I50a70f1161ea5f9926dcce51be1156ec86b4b709 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/soc/qualcomm/common/include/soc/qclib_common.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/84169/1 diff --git a/src/soc/qualcomm/common/include/soc/qclib_common.h b/src/soc/qualcomm/common/include/soc/qclib_common.h index 792b743..00e9f77 100644 --- a/src/soc/qualcomm/common/include/soc/qclib_common.h +++ b/src/soc/qualcomm/common/include/soc/qclib_common.h @@ -53,7 +53,7 @@ #define QCLIB_MAGIC_NUMBER "QCLIB_CB" struct qclib_cb_if_table { - char magic[8]; /* 0x00 */ + char magic[9]; /* 0x00 */ uint32_t version; /* 0x08 */ uint32_t num_entries; /* 0x0C */ uint32_t max_entries; /* 0x10 */ -- To view, visit https://review.coreboot.org/c/coreboot/+/84169?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I50a70f1161ea5f9926dcce51be1156ec86b4b709 Gerrit-Change-Number: 84169 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: bsd/metadata_hash.h: Fix Wunterminated-string-initialization error on...
by Elyes Haouas (Code Review) 31 Aug '24

31 Aug '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84168?usp=email ) Change subject: bsd/metadata_hash.h: Fix Wunterminated-string-initialization error on metadata_hash_anchor ...................................................................... bsd/metadata_hash.h: Fix Wunterminated-string-initialization error on metadata_hash_anchor while on it, fix "metadata_hash.c" file name in comment. Change-Id: Ife62d9f7e1e403df130bb4aacacb4897af920460 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/commonlib/bsd/include/commonlib/bsd/metadata_hash.h 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/84168/1 diff --git a/src/commonlib/bsd/include/commonlib/bsd/metadata_hash.h b/src/commonlib/bsd/include/commonlib/bsd/metadata_hash.h index d5e54b5..4f9fa8f 100644 --- a/src/commonlib/bsd/include/commonlib/bsd/metadata_hash.h +++ b/src/commonlib/bsd/include/commonlib/bsd/metadata_hash.h @@ -8,7 +8,7 @@ /* This structure is embedded somewhere in the (uncompressed) bootblock. */ struct metadata_hash_anchor { - uint8_t magic[8]; + uint8_t magic[9]; struct vb2_hash cbfs_hash; /* NOTE: This is just reserving space. sizeof(struct vb2_hash) may change between configurations/versions and cannot be relied upon, so the FMAP hash must be placed @@ -26,7 +26,7 @@ /* * Do not use this constant anywhere else in coreboot code to ensure the bit pattern really only * appears once in the CBFS image. The only coreboot file allowed to use this is - * src/lib/metadata_anchor.c to define the actual anchor data structure. It is defined here so + * src/lib/metadata_hash.c to define the actual anchor data structure. It is defined here so * that it can be shared with cbfstool (which may use it freely). */ #define DO_NOT_USE_METADATA_HASH_ANCHOR_MAGIC_DO_NOT_USE "\xadMdtHsh\x15" -- To view, visit https://review.coreboot.org/c/coreboot/+/84168?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ife62d9f7e1e403df130bb4aacacb4897af920460 Gerrit-Change-Number: 84168 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: acpi/sata.c: Fix Wunterminated-string-initialization error on port_name
by Tim Wawrzynczak (Code Review) 31 Aug '24

31 Aug '24

Attention is currently required from: Cliff Huang, Elyes Haouas, Lance Zhao. Tim Wawrzynczak has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84166?usp=email ) Change subject: acpi/sata.c: Fix Wunterminated-string-initialization error on port_name ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84166?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie80c2329c4a2698bd9e72ba1b36c1c05e37b214b Gerrit-Change-Number: 84166 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Sumeet Pawnikar <sumeet4linux(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sat, 31 Aug 2024 15:51:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: [only build test] tree: add -fsanitize=undefined
by Elyes Haouas (Code Review) 31 Aug '24

31 Aug '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84167?usp=email ) Change subject: [only build test] tree: add -fsanitize=undefined ...................................................................... [only build test] tree: add -fsanitize=undefined Change-Id: I4002ba18ebddb87f177b27048d8ade2df8016362 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Makefile.mk 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/84167/1 diff --git a/Makefile.mk b/Makefile.mk index e7a9ab1..a00e249 100644 --- a/Makefile.mk +++ b/Makefile.mk @@ -534,7 +534,7 @@ CFLAGS_common += -fno-pie CFLAGS_common += -Wstring-compare ifeq ($(CONFIG_COMPILER_GCC),y) -CFLAGS_common += -Wold-style-declaration +CFLAGS_common += -Wold-style-declaration -fsanitize=undefined CFLAGS_common += -Wcast-function-type # Don't add these GCC specific flags when running scan-build ifeq ($(CCC_ANALYZER_OUTPUT_FORMAT),) -- To view, visit https://review.coreboot.org/c/coreboot/+/84167?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4002ba18ebddb87f177b27048d8ade2df8016362 Gerrit-Change-Number: 84167 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: include/stdbool: Fix useless type name in empty declaration error
by Elyes Haouas (Code Review) 31 Aug '24

31 Aug '24

Attention is currently required from: Martin L Roth, Nico Huber. Hello Martin L Roth, Nico Huber, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83909?usp=email to look at the new patch set (#5). Change subject: include/stdbool: Fix useless type name in empty declaration error ...................................................................... include/stdbool: Fix useless type name in empty declaration error This fixes the following error: src/include/stdbool.h:6:17: error: two or more data types in declaration specifiers 6 | typedef _Bool bool; | ^~~~ src/include/stdbool.h:6:1: error: useless type name in empty declaration [-Werror] 6 | typedef _Bool bool; | ^~~~~~~ Change-Id: Iec9b4e3f308008ece773ce3460daff97370161ea Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/include/stdbool.h 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/83909/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/83909?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iec9b4e3f308008ece773ce3460daff97370161ea Gerrit-Change-Number: 83909 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>

1 0

[XS] Change in coreboot[main]: acpi/sata.c: Fix Wunterminated-string-initialization error on port_name
by Sumeet Pawnikar (Code Review) 31 Aug '24

31 Aug '24

Attention is currently required from: Cliff Huang, Elyes Haouas, Lance Zhao, Tim Wawrzynczak. Sumeet Pawnikar has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84166?usp=email ) Change subject: acpi/sata.c: Fix Wunterminated-string-initialization error on port_name ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/84166?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie80c2329c4a2698bd9e72ba1b36c1c05e37b214b Gerrit-Change-Number: 84166 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Sumeet Pawnikar <sumeet4linux(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sat, 31 Aug 2024 13:38:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: [NOT_FOR_MERGE]Kconfig: Build all targets with LTO
by Arthur Heymans (Code Review) 31 Aug '24

31 Aug '24

Attention is currently required from: Arthur Heymans. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84033?usp=email to look at the new patch set (#29). Change subject: [NOT_FOR_MERGE]Kconfig: Build all targets with LTO ...................................................................... [NOT_FOR_MERGE]Kconfig: Build all targets with LTO ARM with GCC LTO fails hard. Change-Id: I3be6a71fdf9c2d1e14226550daa734b7cdc7e350 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/84033/29 -- To view, visit https://review.coreboot.org/c/coreboot/+/84033?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3be6a71fdf9c2d1e14226550daa734b7cdc7e350 Gerrit-Change-Number: 84033 Gerrit-PatchSet: 29 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

[M] Change in coreboot[main]: vendorcode/intel: allow selecting EDK headers manually
by Sergii Dmytruk (Code Review) 31 Aug '24

31 Aug '24

Attention is currently required from: Martin L Roth, Paul Menzel, Ronak Kanabar. Sergii Dmytruk has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/coreboot/+/83738?usp=email ) Change subject: vendorcode/intel: allow selecting EDK headers manually ...................................................................... Patch Set 4: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/83738/comment/31d6b7c9_6b20444e?us… : PS3, Line 7: vendorcode/intel > Why is this Intel specific? I think that's because it was initially added for Intel FSP in CB:4015. https://review.coreboot.org/c/coreboot/+/83738/comment/60a462a0_a6d46101?us… : PS3, Line 10: This prevents enabling those options : for boards which don't require EDK bindings. > Please elaborate and give examples. See the latest version. File src/vendorcode/intel/Kconfig: https://review.coreboot.org/c/coreboot/+/83738/comment/c64605d5_d2b9e5cf?us… : PS3, Line 37: Set of UEFI headers to use > Maybe: […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/83738?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I964142ef64967b4c9b329025ebcad701e34a5035 Gerrit-Change-Number: 83738 Gerrit-PatchSet: 4 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Comment-Date: Sat, 31 Aug 2024 13:03:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[M] Change in coreboot[main]: vendorcode/intel: allow selecting EDK headers manually
by Sergii Dmytruk (Code Review) 31 Aug '24

31 Aug '24

Attention is currently required from: Martin L Roth, Ronak Kanabar, Sergii Dmytruk. Hello Ronak Kanabar, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83738?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: vendorcode/intel: allow selecting EDK headers manually ...................................................................... vendorcode/intel: allow selecting EDK headers manually EFI-specific options depend on CONFIG_UDK_BASE which gets set only when CONFIG_*_BINDING is selected by SOCs (e.g., when necessary for Intel FSP). This prevents enabling DRIVERS_EFI_VARIABLE_STORE and DRIVERS_EFI_FW_INFO options for boards which don't require EDK bindings for anything else. Make version of the bindings freely selectable when SOC doesn't request a specific version and EDK2 payload is used. The implementation looks somewhat ugly and duplicated because otherwise kconfig detects a loop in configuration options and refuses to do anything. Change-Id: I964142ef64967b4c9b329025ebcad701e34a5035 Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> --- M src/vendorcode/intel/Kconfig M src/vendorcode/intel/Makefile.mk 2 files changed, 44 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/83738/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/83738?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I964142ef64967b4c9b329025ebcad701e34a5035 Gerrit-Change-Number: 83738 Gerrit-PatchSet: 4 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2024