coreboot-gerrit August 2024

coreboot-gerrit@coreboot.org

1 participants
3913 discussions

[XS] Change in coreboot[main]: device/dram/spd: Add missing <smbios.h>
by Martin L Roth (Code Review) 09 Aug '24

09 Aug '24

Attention is currently required from: Elyes Haouas, Felix Singer. Martin L Roth has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82245?usp=email ) Change subject: device/dram/spd: Add missing <smbios.h> ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82245?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iacab6171c61abd047c09ff7e20313a455bd8414f Gerrit-Change-Number: 82245 Gerrit-PatchSet: 7 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Fri, 09 Aug 2024 21:14:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: tree: Remove unused <smbios.h>
by Martin L Roth (Code Review) 09 Aug '24

09 Aug '24

Attention is currently required from: Elyes Haouas, Jason Nien, Martin Roth. Martin L Roth has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82250?usp=email ) Change subject: tree: Remove unused <smbios.h> ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82250?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iab7e9f3d17c87576761333c4b62c40eea5e424a5 Gerrit-Change-Number: 82250 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Fri, 09 Aug 2024 21:14:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: Documentation: getting-started: faq: Remove line break in URL breakin...
by Martin L Roth (Code Review) 09 Aug '24

09 Aug '24

Attention is currently required from: Nicholas Chin, Pablo, Paul Menzel. Martin L Roth has posted comments on this change by Pablo. ( https://review.coreboot.org/c/coreboot/+/83817?usp=email ) Change subject: Documentation: getting-started: faq: Remove line break in URL breaking link ...................................................................... Patch Set 6: (1 comment) File Documentation/getting_started/faq.md: https://review.coreboot.org/c/coreboot/+/83817/comment/ebdbcb4e_b441f0b0?us… : PS6, Line 87: ) Remove trailing whitespace please? Thanks much! -- To view, visit https://review.coreboot.org/c/coreboot/+/83817?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3f950af4201486cd90e5fa61a4657ab7ae643825 Gerrit-Change-Number: 83817 Gerrit-PatchSet: 6 Gerrit-Owner: Pablo <Pablo(a)Iranzo.io> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Pablo <Pablo(a)Iranzo.io> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Fri, 09 Aug 2024 21:13:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: soc/intel/meteorlake/chip.h: Use boolean type where applicable
by Martin L Roth (Code Review) 09 Aug '24

09 Aug '24

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Felix Singer, Jakub Czapiga, Kapil Porwal, Marvin Evers, Michael Strosche, Subrata Banik, Tarun, Tarun Tuli. Martin L Roth has posted comments on this change by Michael Strosche. ( https://review.coreboot.org/c/coreboot/+/77374?usp=email ) Change subject: soc/intel/meteorlake/chip.h: Use boolean type where applicable ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: Michael, If you want to update the comments as requested, please go ahead, otherwise we'll look at getting someone to make the changes for you. Thanks. Martin -- To view, visit https://review.coreboot.org/c/coreboot/+/77374?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I15dfd5ed0541352930c3b70252b3e536ad1e6efd Gerrit-Change-Number: 77374 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Strosche <michael.strosche(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Marvin Evers <marvin.n.evers(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Marvin Evers <marvin.n.evers(a)gmail.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Michael Strosche <michael.strosche(a)gmail.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Fri, 09 Aug 2024 21:10:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: coreboot-sdk/Dockerfile: Add 'gettext' and 'xfonts-unifont'
by Martin L Roth (Code Review) 09 Aug '24

09 Aug '24

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83676?usp=email ) Change subject: coreboot-sdk/Dockerfile: Add 'gettext' and 'xfonts-unifont' ...................................................................... coreboot-sdk/Dockerfile: Add 'gettext' and 'xfonts-unifont' Required for building grub2. BUG=N/A TEST=Build successfully for 'QEMU x86 i440fx/piix4' with GRUB2 payload. Change-Id: I97860f33dd3fde2f6db2f005d65b53cd669403e9 Signed-off-by: Harrie Paijmans <hpaijmans(a)eltan.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/83676 Reviewed-by: Frans Hendriks <fhendriks(a)eltan.com> Reviewed-by: Martin L Roth <gaumless(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M util/docker/coreboot-sdk/Dockerfile 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Martin L Roth: Looks good to me, approved build bot (Jenkins): Verified Frans Hendriks: Looks good to me, but someone else must approve diff --git a/util/docker/coreboot-sdk/Dockerfile b/util/docker/coreboot-sdk/Dockerfile index 5c4f9c4..6c3a06b 100644 --- a/util/docker/coreboot-sdk/Dockerfile +++ b/util/docker/coreboot-sdk/Dockerfile @@ -33,6 +33,7 @@ g++ \ gawk \ gcc \ + gettext \ git \ gnat \ golang \ @@ -86,6 +87,7 @@ uuid-dev \ vim-common \ wget \ + xfonts-unifont \ xz-utils \ zlib1g-dev \ && apt-get clean -- To view, visit https://review.coreboot.org/c/coreboot/+/83676?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I97860f33dd3fde2f6db2f005d65b53cd669403e9 Gerrit-Change-Number: 83676 Gerrit-PatchSet: 2 Gerrit-Owner: Harrie Paijmans <hpaijmans(a)eltan.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: coreboot-sdk/Dockerfile: Add 'gettext' and 'xfonts-unifont'
by Martin L Roth (Code Review) 09 Aug '24

09 Aug '24

Attention is currently required from: Felix Singer, Harrie Paijmans. Martin L Roth has posted comments on this change by Harrie Paijmans. ( https://review.coreboot.org/c/coreboot/+/83676?usp=email ) Change subject: coreboot-sdk/Dockerfile: Add 'gettext' and 'xfonts-unifont' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83676?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I97860f33dd3fde2f6db2f005d65b53cd669403e9 Gerrit-Change-Number: 83676 Gerrit-PatchSet: 1 Gerrit-Owner: Harrie Paijmans <hpaijmans(a)eltan.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Harrie Paijmans <hpaijmans(a)eltan.com> Gerrit-Comment-Date: Fri, 09 Aug 2024 21:07:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/emulation/qemu-q35: Move QEMU specific macros to "q35.h"
by Martin L Roth (Code Review) 09 Aug '24

09 Aug '24

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83407?usp=email ) Change subject: mb/emulation/qemu-q35: Move QEMU specific macros to "q35.h" ...................................................................... mb/emulation/qemu-q35: Move QEMU specific macros to "q35.h" As `qemu-q35/memmap.c` includes `qemu-q35/q35.h`, move macros into q35.h file. Change-Id: I0bf13def8bc4510053f6bb44e043bbcb0b958b01 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/83407 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/emulation/qemu-q35/memmap.c M src/mainboard/emulation/qemu-q35/q35.h 2 files changed, 3 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/emulation/qemu-q35/memmap.c b/src/mainboard/emulation/qemu-q35/memmap.c index 9b391d6..d57b25c 100644 --- a/src/mainboard/emulation/qemu-q35/memmap.c +++ b/src/mainboard/emulation/qemu-q35/memmap.c @@ -34,10 +34,6 @@ die("You must run qemu for machine Q35 (-M q35)"); } -/* QEMU-specific register */ -#define EXT_TSEG_MBYTES 0x50 -#define C_BASE_SEG ((0 << 2) | (1 << 1) | (0 << 0)) - /* Decodes TSEG region size to bytes. */ static size_t decode_tseg_size(u8 esmramc) { diff --git a/src/mainboard/emulation/qemu-q35/q35.h b/src/mainboard/emulation/qemu-q35/q35.h index ae0fa38..6dee5f1 100644 --- a/src/mainboard/emulation/qemu-q35/q35.h +++ b/src/mainboard/emulation/qemu-q35/q35.h @@ -8,6 +8,9 @@ #define HOST_BRIDGE PCI_DEV(0, 0, 0) +#define EXT_TSEG_MBYTES 0x50 +#define C_BASE_SEG ((0 << 2) | (1 << 1) | (0 << 0)) + #define D0F0_PCIEXBAR_LO 0x60 #define D0F0_PCIEXBAR_HI 0x64 -- To view, visit https://review.coreboot.org/c/coreboot/+/83407?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0bf13def8bc4510053f6bb44e043bbcb0b958b01 Gerrit-Change-Number: 83407 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

[XS] Change in coreboot[main]: mb/emulation/qemu-q35: Move QEMU specific macros to "q35.h"
by Martin L Roth (Code Review) 09 Aug '24

09 Aug '24

Attention is currently required from: Arthur Heymans, Elyes Haouas. Martin L Roth has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83407?usp=email ) Change subject: mb/emulation/qemu-q35: Move QEMU specific macros to "q35.h" ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Those macros […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/83407?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0bf13def8bc4510053f6bb44e043bbcb0b958b01 Gerrit-Change-Number: 83407 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Fri, 09 Aug 2024 20:45:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[L] Change in coreboot[main]: profiler: Add basic profiler with cbmem support
by Martin L Roth (Code Review) 09 Aug '24

09 Aug '24

Attention is currently required from: Jakub Czapiga, Reka Norman, Tarun Tuli, Tim Wawrzynczak. Martin L Roth has posted comments on this change by Jakub Czapiga. ( https://review.coreboot.org/c/coreboot/+/65606?usp=email ) Change subject: profiler: Add basic profiler with cbmem support ...................................................................... Patch Set 10: (1 comment) Patchset: PS10: Ping? -- To view, visit https://review.coreboot.org/c/coreboot/+/65606?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5665922b1109ee9305274294c93de577f1bf9ae2 Gerrit-Change-Number: 65606 Gerrit-PatchSet: 10 Gerrit-Owner: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alex Levin <levinale(a)google.com> Gerrit-CC: Jan Dabros <jsd(a)semihalf.com> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Comment-Date: Fri, 09 Aug 2024 20:42:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: util/marvell/doimage_mv: Update CFLAGS to CFLAGS_doimage
by Martin L Roth (Code Review) 09 Aug '24

09 Aug '24

Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83857?usp=email ) Change subject: util/marvell/doimage_mv: Update CFLAGS to CFLAGS_doimage ...................................................................... util/marvell/doimage_mv: Update CFLAGS to CFLAGS_doimage Because we import the doimage_mv/Makefile.mk directly into the main coreboot makefile, this was setting a global CFLAGS variable. That's not a huge issue since coreboot doesn't use the global CFLAGS variable, but it should be updated anyway. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Iebe281ca891745c1f993df274ef75b1440059c85 --- M util/marvell/doimage_mv/Makefile.mk 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/83857/1 diff --git a/util/marvell/doimage_mv/Makefile.mk b/util/marvell/doimage_mv/Makefile.mk index 3f4f528..6f3a401 100644 --- a/util/marvell/doimage_mv/Makefile.mk +++ b/util/marvell/doimage_mv/Makefile.mk @@ -3,13 +3,13 @@ DOIMAGE_FOLDER = marvell/doimage_mv DOIMAGE_BINARY = doimage -CFLAGS = -g -O1 -I./../inc -DMV_CPU_LE -I $(TOP)/src/commonlib/bsd/include +CFLAGS_doimage = -g -O1 -I./../inc -DMV_CPU_LE -I $(TOP)/src/commonlib/bsd/include $(objutil)/$(DOIMAGE_FOLDER): mkdir -p $@ $(objutil)/$(DOIMAGE_FOLDER)/doimage.o: $(top)/util/marvell/doimage_mv/doimage.c $(objutil)/$(DOIMAGE_FOLDER) - $(HOSTCC) $(CFLAGS) -c $< -o $@ + $(HOSTCC) $(CFLAGS_doimage) -c $< -o $@ $(objutil)/$(DOIMAGE_FOLDER)/$(DOIMAGE_BINARY): $(objutil)/$(DOIMAGE_FOLDER)/doimage.o - $(HOSTCC) $(CFLAGS) -o $@ $^ + $(HOSTCC) $(CFLAGS_doimage) -o $@ $^ -- To view, visit https://review.coreboot.org/c/coreboot/+/83857?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iebe281ca891745c1f993df274ef75b1440059c85 Gerrit-Change-Number: 83857 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2024