Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83865?usp=email )
Change subject: soc/intel/alderlake/romstage/fsp_params: fix clock request warning
......................................................................
soc/intel/alderlake/romstage/fsp_params: fix clock request warning
If a root port doesn't use a clock request pin, we shouldn't check if
this pin is already used. This fixes the following spurious warning that
was previously printed for each external PCIe port which has the
'PCIE_RP_CLK_REQ_UNUSED' flag set and didn't set 'clk_req' to some
unused clock request pin number:
Found overlapped clkreq assignment on clk req 0
Change-Id: I3ee66ca5ed5a2d06dfb68c45a50e11eb2b93daa0
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
---
M src/soc/intel/alderlake/romstage/fsp_params.c
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/83865/1
diff --git a/src/soc/intel/alderlake/romstage/fsp_params.c b/src/soc/intel/alderlake/romstage/fsp_params.c
index d917e6c..a63b64c 100644
--- a/src/soc/intel/alderlake/romstage/fsp_params.c
+++ b/src/soc/intel/alderlake/romstage/fsp_params.c
@@ -71,10 +71,12 @@
printk(BIOS_WARNING, "Missing root port clock structure definition\n");
continue;
}
- if (clk_req_mapping & (1 << cfg[i].clk_req))
- printk(BIOS_WARNING, "Found overlapped clkreq assignment on clk req %d\n"
- , cfg[i].clk_req);
+
if (!(cfg[i].flags & PCIE_RP_CLK_REQ_UNUSED)) {
+ if (clk_req_mapping & (1 << cfg[i].clk_req))
+ printk(BIOS_WARNING,
+ "Found overlapped clkreq assignment on clk req %d\n",
+ cfg[i].clk_req);
m_cfg->PcieClkSrcClkReq[cfg[i].clk_src] = cfg[i].clk_req;
clk_req_mapping |= 1 << cfg[i].clk_req;
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/83865?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3ee66ca5ed5a2d06dfb68c45a50e11eb2b93daa0
Gerrit-Change-Number: 83865
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Felix Held, Michał Żygowski.
Angel Pons has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/80318?usp=email )
Change subject: util/superiotool/ite: Add extra dumps for IT8613E EC
......................................................................
Patch Set 6: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80318/comment/ab3cb55e_c9d5c383?us… :
PS6, Line 7: util/superiotool/ite: Add extra dumps for IT8613E EC
Where did you get the register information from? Datasheet? Would be nice to specify in the commit message.
https://review.coreboot.org/c/coreboot/+/80318/comment/8428d1c8_e85a3d49?us… :
PS6, Line 14: briodge
typo: bridge
--
To view, visit https://review.coreboot.org/c/coreboot/+/80318?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic8fdc56d1b0fbe811e13bc6b800512af654c1cb6
Gerrit-Change-Number: 80318
Gerrit-PatchSet: 6
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sat, 10 Aug 2024 16:24:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Elyes Haouas, Jeremy Soller, Sean Rhodes, Tim Crawford.
Dinesh Gehlot has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83863?usp=email )
Change subject: tree: Use boolean for pch_hda_sdi_enable[]
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83863?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I27568d1205216f697b48ffb09ce5208505718978
Gerrit-Change-Number: 83863
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sat, 10 Aug 2024 15:33:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes