Attention is currently required from: Jérémy Compostella, Maxim, Subrata Banik.
Hello Felix Singer, Jérémy Compostella, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83708?usp=email
to look at the new patch set (#9).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: soc/intel/cml, pci_ids: Fix ID for Comet Lake-H GT2
......................................................................
soc/intel/cml, pci_ids: Fix ID for Comet Lake-H GT2
According to the Intel GPU list[1], 0x3E9B is DID of "Intel UHD Graphics
630" for the Coffee Lake processor family and has already been added to
the pci_ids.h as PCI_IDE_INTEL_CFL_H_GT2.
At the same time, the real PCI DID for Comet Lake-H GT2 is 0x9BC2 [1],
which is missing in the file.
[1] https://web.archive.org/web/20240731152818/https://dgpu-docs.intel.com/devices/hardware-table.html
Change-Id: Iacab0a03388af3f6fd5d78a597580037889e8ef2
Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com>
---
M src/include/device/pci_ids.h
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/83708/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/83708?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iacab0a03388af3f6fd5d78a597580037889e8ef2
Gerrit-Change-Number: 83708
Gerrit-PatchSet: 9
Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Attention is currently required from: Jakub Czapiga, Martin L Roth, Nico Huber.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83459?usp=email )
Change subject: tree: Add kconfig option for testing C23 dialect
......................................................................
Patch Set 15:
(2 comments)
File Makefile.mk:
https://review.coreboot.org/c/coreboot/+/83459/comment/ca484a75_351bada6?us… :
PS6, Line 511: gnu2x
> `gnu23`as `gnu2x` is deprecated.
Done
File src/include/stddef.h:
https://review.coreboot.org/c/coreboot/+/83459/comment/1063bbe4_2ea60832?us… :
PS6, Line 22: >
> it should be `>=`. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/83459?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I07db866bebfd25f1a60d18a3228ada2957500234
Gerrit-Change-Number: 83459
Gerrit-PatchSet: 15
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Comment-Date: Sat, 10 Aug 2024 07:58:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Attention is currently required from: Jakub Czapiga, Martin L Roth, Nico Huber.
Hello Jakub Czapiga, Martin L Roth, Nico Huber, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83459?usp=email
to look at the new patch set (#15).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: tree: Add kconfig option for testing C23 dialect
......................................................................
tree: Add kconfig option for testing C23 dialect
This adds C23 dialect for testing and prepare for C23 dialect support.
Change-Id: I07db866bebfd25f1a60d18a3228ada2957500234
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M Makefile.mk
M src/Kconfig
M src/include/stdbool.h
M src/include/stddef.h
4 files changed, 24 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/83459/15
--
To view, visit https://review.coreboot.org/c/coreboot/+/83459?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I07db866bebfd25f1a60d18a3228ada2957500234
Gerrit-Change-Number: 83459
Gerrit-PatchSet: 15
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Elyes Haouas has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/83858?usp=email )
Change subject: bn/intel/i945: Correct intel_gma_init_lvds returned value
......................................................................
bn/intel/i945: Correct intel_gma_init_lvds returned value
Since Change-Id: I61b6946, on error returned value was changed from 1 to -1.
Change-Id: Iad9657a4ad44d8b3ad17812397429f04b75d4fa9
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M src/northbridge/intel/i945/gma.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/83858/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83858?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iad9657a4ad44d8b3ad17812397429f04b75d4fa9
Gerrit-Change-Number: 83858
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>