Attention is currently required from: Arthur Heymans, Elyes Haouas, Nico Huber.
Hello Angel Pons, Elyes Haouas, Nico Huber, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84059?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by Nico Huber, Code-Review+2 by Elyes Haouas, Verified+1 by build bot (Jenkins)
Change subject: drivers/spi: Stop using a variable-length array
......................................................................
drivers/spi: Stop using a variable-length array
Only the call in `spi_flash_cmd_write_page_program` uses non-constant
values for the array length. However, the value for `data_len` has an
upper bound: `flash->page_size` is set to `1U << vi->page_size_shift`
which depends on the flash chip vendor info, and the largest value it
can currently have is 8. Thus, the maximum page size is currently 256.
Define the `MAX_FLASH_CMD_DATA_SIZE` macro to place an upper bound on
the amount of data that can be written in one command. Then, use this
value to allocate a fixed-size buffer in `spi_flash_cmd_write`. Also,
add a check to prevent buffer overflow problems. Finally, ensure that
the `spi_flash_cmd_write_page_program` function always writes no more
than 256 bytes of data when using the `spi_flash_cmd_write` function.
The buffer is placed in .bss so that it does not increase stack usage in
some use cases.
Tested on Asrock B85M Pro4 (Winbond W25Q64FV), MRC cache still works.
Repost of https://review.coreboot.org/c/coreboot/+/50480 with 'static'
so that the buffer is in bss.
Change-Id: I157ecec69c049ead06467b0328efd7d1a09bd268
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/drivers/spi/spi_flash.c
M src/drivers/spi/spi_flash_internal.h
2 files changed, 9 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/84059/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84059?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I157ecec69c049ead06467b0328efd7d1a09bd268
Gerrit-Change-Number: 84059
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Attention is currently required from: Yidi Lin.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/blobs/+/84029?usp=email )
Change subject: soc/mediatek/mt8196: Add MCUPM firmware v1.0
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/blobs/+/84029/comment/734485c4_d2bd2134?usp=e… :
PS4, Line 9: Add mcupm.bin initial version
> nit: Missing `.` at the end.
Done
--
To view, visit https://review.coreboot.org/c/blobs/+/84029?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: I639eb495e3499e0ed886368e6581031baaec0b9d
Gerrit-Change-Number: 84029
Gerrit-PatchSet: 5
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Comment-Date: Fri, 30 Aug 2024 07:38:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Attention is currently required from: Jarried Lin, Yidi Lin.
Hello Yidi Lin, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/blobs/+/84029?usp=email
to look at the new patch set (#5).
Change subject: soc/mediatek/mt8196: Add MCUPM firmware v1.0
......................................................................
soc/mediatek/mt8196: Add MCUPM firmware v1.0
Add mcupm.bin initial version.
TEST=NA
BUG=b:317009620
Change-Id: I639eb495e3499e0ed886368e6581031baaec0b9d
Signed-off-by: Jarried Lin <jarried.lin(a)mediatek.corp-partner.google.com>
---
M soc/mediatek/mt8196/README.md
A soc/mediatek/mt8196/mcupm.bin
A soc/mediatek/mt8196/mcupm.bin.md5
A soc/mediatek/mt8196/mcupm_release_notes.txt
4 files changed, 23 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/blobs refs/changes/29/84029/5
--
To view, visit https://review.coreboot.org/c/blobs/+/84029?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: I639eb495e3499e0ed886368e6581031baaec0b9d
Gerrit-Change-Number: 84029
Gerrit-PatchSet: 5
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Attention is currently required from: Jarried Lin.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/blobs/+/84028?usp=email )
Change subject: soc/mediatek/mt8196: Add dpm.pm and dpm.dm version 1.0
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://review.coreboot.org/c/blobs/+/84028?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: I91c34f105992f38aa42521f7e11f42a4ccb81856
Gerrit-Change-Number: 84028
Gerrit-PatchSet: 4
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Comment-Date: Fri, 30 Aug 2024 07:37:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Arthur Heymans has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84047?usp=email )
Change subject: soc/intel/apl: Fix building with clang & LTO
......................................................................
soc/intel/apl: Fix building with clang & LTO
LTO does not like that assert on a constant, so use the more appropriate
static assertion.
Change-Id: I52094ec825fcec56a9b9fb6b9abc58644c2bf9cb
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84047
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Sean Rhodes <sean(a)starlabs.systems>
Reviewed-by: Nico Huber <nico.h(a)gmx.de>
---
M src/soc/intel/apollolake/romstage.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
build bot (Jenkins): Verified
Sean Rhodes: Looks good to me, approved
Nico Huber: Looks good to me, approved
diff --git a/src/soc/intel/apollolake/romstage.c b/src/soc/intel/apollolake/romstage.c
index f710883..d8d11a0 100644
--- a/src/soc/intel/apollolake/romstage.c
+++ b/src/soc/intel/apollolake/romstage.c
@@ -319,7 +319,7 @@
mrc_cache_current_mmap_leak(MRC_VARIABLE_DATA, version,
NULL);
- assert(CONFIG(BOOT_DEVICE_MEMORY_MAPPED));
+ _Static_assert(CONFIG(BOOT_DEVICE_MEMORY_MAPPED), "Boot device not memory mapped");
fsp_version = version;
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/84047?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I52094ec825fcec56a9b9fb6b9abc58644c2bf9cb
Gerrit-Change-Number: 84047
Gerrit-PatchSet: 15
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>