Attention is currently required from: Elyes Haouas, Felix Singer, Jérémy Compostella, Vasiliy Khoruzhick, yuchi.chen(a)intel.com.
Shuo Liu has posted comments on this change by yuchi.chen(a)intel.com. ( https://review.coreboot.org/c/coreboot/+/83321?usp=email )
Change subject: soc/intel/snowridge: Add support for Intel Atom Snow Ridge SoC
......................................................................
Patch Set 17:
(7 comments)
File src/soc/intel/snowridge/Kconfig:
https://review.coreboot.org/c/coreboot/+/83321/comment/70467ac5_0d6f6afc?us… :
PS15, Line 42: select FSP_T_XIP
> Should FSP_S_XIP be selected as well?
Close this, in this SoC, FSP_S is put at fixed location in flash but still relocatable.
File src/soc/intel/snowridge/chip.c:
https://review.coreboot.org/c/coreboot/+/83321/comment/b168d107_dfa82a4b?us… :
PS15, Line 418: }
will the common pci codes do this again?
File src/soc/intel/snowridge/sriov.c:
https://review.coreboot.org/c/coreboot/+/83321/comment/0fde3d77_e8cfcf8d?us… :
PS15, Line 13: void pciexp_vf_read_resources(struct device *dev)
if coreboot only enables PF, can the OS still work?
https://review.coreboot.org/c/coreboot/+/83321/comment/02c19b57_df091187?us… :
PS15, Line 76: resource->flags |= IORESOURCE_ABOVE_4G;
is this VF req or RCiEP req?
File src/soc/intel/snowridge/systemagent.c:
https://review.coreboot.org/c/coreboot/+/83321/comment/0ee754a8_75ee264e?us… :
PS15, Line 17: *size = CONFIG_ECAM_MMCONF_LENGTH;
> Shouldn't be probed by BAR access?
CONFIG_ECAM_MMCONF_LENGTH => should be aligned with the probed value
https://review.coreboot.org/c/coreboot/+/83321/comment/e15ee06b_b0f80e9d?us… :
PS15, Line 32: void soc_add_fixed_mmio_resources(struct device *dev, int *resource_cnt)
resource_cnt -> resource_index?
https://review.coreboot.org/c/coreboot/+/83321/comment/538fb3df_1f550413?us… :
PS15, Line 56: I
PCIe MMCFG BAR?
--
To view, visit https://review.coreboot.org/c/coreboot/+/83321?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I32ad836dfaaff0d1816eac41e5a7d19ece11080f
Gerrit-Change-Number: 83321
Gerrit-PatchSet: 17
Gerrit-Owner: yuchi.chen(a)intel.com
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Vasiliy Khoruzhick <vasilykh(a)arista.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: yuchi.chen(a)intel.com
Gerrit-Attention: Vasiliy Khoruzhick <vasilykh(a)arista.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Fri, 30 Aug 2024 07:45:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shuo Liu <shuo.liu(a)intel.com>
Attention is currently required from: Arthur Heymans, Elyes Haouas, Nico Huber.
Hello Angel Pons, Elyes Haouas, Nico Huber, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84059?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by Nico Huber, Code-Review+2 by Elyes Haouas, Verified+1 by build bot (Jenkins)
Change subject: drivers/spi: Stop using a variable-length array
......................................................................
drivers/spi: Stop using a variable-length array
Only the call in `spi_flash_cmd_write_page_program` uses non-constant
values for the array length. However, the value for `data_len` has an
upper bound: `flash->page_size` is set to `1U << vi->page_size_shift`
which depends on the flash chip vendor info, and the largest value it
can currently have is 8. Thus, the maximum page size is currently 256.
Define the `MAX_FLASH_CMD_DATA_SIZE` macro to place an upper bound on
the amount of data that can be written in one command. Then, use this
value to allocate a fixed-size buffer in `spi_flash_cmd_write`. Also,
add a check to prevent buffer overflow problems. Finally, ensure that
the `spi_flash_cmd_write_page_program` function always writes no more
than 256 bytes of data when using the `spi_flash_cmd_write` function.
The buffer is placed in .bss so that it does not increase stack usage in
some use cases.
Tested on Asrock B85M Pro4 (Winbond W25Q64FV), MRC cache still works.
Repost of https://review.coreboot.org/c/coreboot/+/50480 with 'static'
so that the buffer is in bss.
Change-Id: I157ecec69c049ead06467b0328efd7d1a09bd268
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/drivers/spi/spi_flash.c
M src/drivers/spi/spi_flash_internal.h
2 files changed, 9 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/84059/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84059?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I157ecec69c049ead06467b0328efd7d1a09bd268
Gerrit-Change-Number: 84059
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Attention is currently required from: Yidi Lin.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/blobs/+/84029?usp=email )
Change subject: soc/mediatek/mt8196: Add MCUPM firmware v1.0
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/blobs/+/84029/comment/734485c4_d2bd2134?usp=e… :
PS4, Line 9: Add mcupm.bin initial version
> nit: Missing `.` at the end.
Done
--
To view, visit https://review.coreboot.org/c/blobs/+/84029?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: I639eb495e3499e0ed886368e6581031baaec0b9d
Gerrit-Change-Number: 84029
Gerrit-PatchSet: 5
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Comment-Date: Fri, 30 Aug 2024 07:38:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Attention is currently required from: Jarried Lin, Yidi Lin.
Hello Yidi Lin, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/blobs/+/84029?usp=email
to look at the new patch set (#5).
Change subject: soc/mediatek/mt8196: Add MCUPM firmware v1.0
......................................................................
soc/mediatek/mt8196: Add MCUPM firmware v1.0
Add mcupm.bin initial version.
TEST=NA
BUG=b:317009620
Change-Id: I639eb495e3499e0ed886368e6581031baaec0b9d
Signed-off-by: Jarried Lin <jarried.lin(a)mediatek.corp-partner.google.com>
---
M soc/mediatek/mt8196/README.md
A soc/mediatek/mt8196/mcupm.bin
A soc/mediatek/mt8196/mcupm.bin.md5
A soc/mediatek/mt8196/mcupm_release_notes.txt
4 files changed, 23 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/blobs refs/changes/29/84029/5
--
To view, visit https://review.coreboot.org/c/blobs/+/84029?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: I639eb495e3499e0ed886368e6581031baaec0b9d
Gerrit-Change-Number: 84029
Gerrit-PatchSet: 5
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Attention is currently required from: Jarried Lin.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/blobs/+/84028?usp=email )
Change subject: soc/mediatek/mt8196: Add dpm.pm and dpm.dm version 1.0
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://review.coreboot.org/c/blobs/+/84028?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: I91c34f105992f38aa42521f7e11f42a4ccb81856
Gerrit-Change-Number: 84028
Gerrit-PatchSet: 4
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Comment-Date: Fri, 30 Aug 2024 07:37:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes