Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Nick Vaccaro, Rishika Raj.
Subrata Banik has posted comments on this change by Nick Vaccaro. ( https://review.coreboot.org/c/coreboot/+/83932?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/goog/brya: Don't lock GPP_F15 (FPMCU_INT_L)
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Patchset:
PS3:
With commit CB:64089, we now program the GPE Enable bit for all SCI pins during boot. This means that if there is any GPE status active for any pin, we won't be able to clear it. Because these bits are sticky bits and are cleared by writing a 1 back to this bit position, being unable to clear pending GPE status would result in a fake wake when GPE EN for the PAD is enabled and the last GPE hasn't been cleared. By removing the lock, coreboot can now clear the GPE status during boot to avoid a fake wake.
To prove this point, let's dump the GPE status without this CL during boot and before issuing the poweroff operation from depthcharge. This will prove that the last GPE status was causing this fake wake.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83932?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1c73035b02021b0d1268cd46dcd0841621556ad5
Gerrit-Change-Number: 83932
Gerrit-PatchSet: 3
Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Thu, 15 Aug 2024 17:53:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Keith Hui has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/83913?usp=email )
Change subject: util/autoport: Assign SPD addresses in devicetree for Haswell
......................................................................
Abandoned
Rolled into CB:79025
--
To view, visit https://review.coreboot.org/c/coreboot/+/83913?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie32f6b1e79fd367e7ed2cf46e496b9c1ee813604
Gerrit-Change-Number: 83913
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Hui <buurin(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: Alexander Couzens, Keith Hui, Martin L Roth, Nicholas Chin.
Hello Alexander Couzens, Angel Pons, Martin L Roth, Nicholas Chin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79025?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: nb/intel/haswell: Move SPD addresses to devicetree
......................................................................
nb/intel/haswell: Move SPD addresses to devicetree
Introduce a sandybridge-style devicetree setting for SPD addresses,
and use it instead of runtime code in mb_get_spd_map() for all
haswell boards without CONFIG(HAVE_SPD_IN_CBFS) - effectively all
boards except google/slippy.
Patch also covers recently added Z97 boards using Broadwell MRC.
Also update util/autoport to match.
abuild passes for all affected boards.
autoport builds, but otherwise untested.
Change-Id: I574aec9cb6a47c8aaf275ae06c7e1fb695534b34
Signed-off-by: Keith Hui <buurin(a)gmail.com>
---
M src/mainboard/asrock/b85m_pro4/devicetree.cb
M src/mainboard/asrock/b85m_pro4/romstage.c
M src/mainboard/asrock/fatal1ty_z87_professional/devicetree.cb
M src/mainboard/asrock/fatal1ty_z87_professional/romstage.c
M src/mainboard/asrock/h81m-hds/devicetree.cb
M src/mainboard/asrock/h81m-hds/romstage.c
M src/mainboard/asrock/z87e-itx/devicetree.cb
M src/mainboard/asrock/z87e-itx/romstage.c
M src/mainboard/asrock/z87m_oc_formula/devicetree.cb
M src/mainboard/asrock/z87m_oc_formula/romstage.c
M src/mainboard/asrock/z97_extreme6/devicetree.cb
M src/mainboard/asrock/z97_extreme6/romstage.c
M src/mainboard/asrock/z97e-itx_ac/devicetree.cb
M src/mainboard/asrock/z97e-itx_ac/romstage.c
M src/mainboard/dell/e7240/devicetree.cb
M src/mainboard/dell/e7240/romstage.c
M src/mainboard/dell/optiplex_9020/devicetree.cb
M src/mainboard/dell/optiplex_9020/romstage.c
M src/mainboard/google/beltino/devicetree.cb
M src/mainboard/google/beltino/romstage.c
M src/mainboard/hp/folio_9480m/devicetree.cb
M src/mainboard/hp/folio_9480m/romstage.c
M src/mainboard/intel/baskingridge/devicetree.cb
M src/mainboard/intel/baskingridge/romstage.c
M src/mainboard/lenovo/haswell/romstage.c
M src/mainboard/lenovo/haswell/variants/t440p/devicetree.cb
M src/mainboard/lenovo/haswell/variants/t440p/romstage.c
M src/mainboard/lenovo/haswell/variants/w541/devicetree.cb
M src/mainboard/lenovo/haswell/variants/w541/romstage.c
M src/mainboard/msi/h81m-p33/devicetree.cb
M src/mainboard/msi/h81m-p33/romstage.c
M src/mainboard/supermicro/x10slm-f/devicetree.cb
M src/mainboard/supermicro/x10slm-f/romstage.c
M src/northbridge/intel/haswell/Makefile.mk
M src/northbridge/intel/haswell/broadwell_mrc/raminit.c
M src/northbridge/intel/haswell/chip.h
M src/northbridge/intel/haswell/haswell_mrc/raminit.c
M src/northbridge/intel/haswell/native_raminit/spd_bitmunching.c
M src/northbridge/intel/haswell/raminit.h
A src/northbridge/intel/haswell/raminit_shared.c
M util/autoport/haswell.go
M util/autoport/lynxpoint.go
42 files changed, 43 insertions(+), 145 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/79025/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/79025?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I574aec9cb6a47c8aaf275ae06c7e1fb695534b34
Gerrit-Change-Number: 79025
Gerrit-PatchSet: 5
Gerrit-Owner: Keith Hui <buurin(a)gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: coreboot org <coreboot.org(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Keith Hui <buurin(a)gmail.com>
Attention is currently required from: Felix Singer, Keith Hui, Riku Viitanen.
Matt DeVillier has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/79583?usp=email )
Change subject: mb/hp/snb_ivb_desktops: Add 8200 USDT variant
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79583?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1cba7a5e664758eba7ea2ab8a55658b307d1d173
Gerrit-Change-Number: 79583
Gerrit-PatchSet: 4
Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Keith Hui <buurin(a)gmail.com>
Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Keith Hui <buurin(a)gmail.com>
Gerrit-Comment-Date: Thu, 15 Aug 2024 17:42:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Keith Hui, Riku Viitanen.
Felix Singer has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/79545?usp=email )
Change subject: mb/hp: Move compaq_8200_elite_sff_pc into snb_ivb_desktops variants
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/79545?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I03d57c7e76ccdfccd58b2a6deab4dee87b02503a
Gerrit-Change-Number: 79545
Gerrit-PatchSet: 2
Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Keith Hui <buurin(a)gmail.com>
Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com>
Gerrit-Attention: Keith Hui <buurin(a)gmail.com>
Gerrit-Comment-Date: Thu, 15 Aug 2024 17:41:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Dinesh Gehlot, Elyes Haouas, Eran Mitrani, Felix Singer, Jakub Czapiga, Kapil Porwal, Marvin Evers, Michael Strosche, Subrata Banik, Tarun, Tarun Tuli.
Matt DeVillier has posted comments on this change by Michael Strosche. ( https://review.coreboot.org/c/coreboot/+/77374?usp=email )
Change subject: soc/intel/meteorlake/chip.h: Use boolean type where applicable
......................................................................
Patch Set 11: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/77374?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I15dfd5ed0541352930c3b70252b3e536ad1e6efd
Gerrit-Change-Number: 77374
Gerrit-PatchSet: 11
Gerrit-Owner: Michael Strosche <michael.strosche(a)gmail.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Marvin Evers <marvin.n.evers(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Marvin Evers <marvin.n.evers(a)gmail.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Michael Strosche <michael.strosche(a)gmail.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Thu, 15 Aug 2024 17:41:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Felix Singer, Keith Hui, Riku Viitanen.
Felix Singer has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/79544?usp=email )
Change subject: mb/hp: Move compaq_elite_8300_usdt into snb_ivb_desktops variants
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/79544?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idc61e5d17f4c71fc50cf87c60a5063fc893c1d8c
Gerrit-Change-Number: 79544
Gerrit-PatchSet: 5
Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Keith Hui <buurin(a)gmail.com>
Gerrit-Comment-Date: Thu, 15 Aug 2024 17:40:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Felix Singer, Keith Hui, Riku Viitanen.
Matt DeVillier has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/79544?usp=email )
Change subject: mb/hp: Move compaq_elite_8300_usdt into snb_ivb_desktops variants
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79544?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idc61e5d17f4c71fc50cf87c60a5063fc893c1d8c
Gerrit-Change-Number: 79544
Gerrit-PatchSet: 5
Gerrit-Owner: Riku Viitanen <riku.viitanen(a)protonmail.com>
Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Keith Hui <buurin(a)gmail.com>
Gerrit-Comment-Date: Thu, 15 Aug 2024 17:40:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Nick Vaccaro, Rishika Raj.
Hello Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rishika Raj, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83932?usp=email
to look at the new patch set (#3).
Change subject: mb/goog/brya: Don't lock GPP_F15 (FPMCU_INT_L)
......................................................................
mb/goog/brya: Don't lock GPP_F15 (FPMCU_INT_L)
Locking GPP_F15 causes DUTs with fingerprint sensor to not be able to
correctly power down and stay powered down. This pin does not need to
be locked.
BUG=b:359692570, b:356750516, b:356178796
BRANCH=firmware-brya-14505.B
TEST=`FW_NAME=gimble emerge-brya coreboot chromeos-bootimage`, flash and
boot gimble into developer mode, then reboot into dev screen and select
the "Power off" button and verify gimble powers off and does not power
itself back up.
Change-Id: I1c73035b02021b0d1268cd46dcd0841621556ad5
Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com>
---
M src/mainboard/google/brya/variants/baseboard/brya/gpio.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/83932/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/83932?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1c73035b02021b0d1268cd46dcd0841621556ad5
Gerrit-Change-Number: 83932
Gerrit-PatchSet: 3
Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Attention is currently required from: Kapil Porwal, KunYi Chen, RONAK KANABAR, Subrata Banik.
Felix Singer has posted comments on this change by KunYi Chen. ( https://review.coreboot.org/c/coreboot/+/83718?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: update FSP headers of ADL-N to latest version
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83718/comment/62a346b9_be754514?us… :
PS2, Line 7: update FSP headers of ADL-N to latest version
We usually add a "topic" to the headline in order to give the reader a better what the patch is about and which areas it affects. Please have a look on the commit history.
Example:
```
vc/intel/fsp: Update Alderlake N headers to version <number>
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/83718?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I96fccbb92866fbc18c57187628612fda655cd7a7
Gerrit-Change-Number: 83718
Gerrit-PatchSet: 2
Gerrit-Owner: KunYi Chen
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: RONAK KANABAR <ronak199323(a)gmail.com>
Gerrit-Reviewer: Subrata Banik <subi.banik(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Subrata Banik <subi.banik(a)gmail.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: KunYi Chen
Gerrit-Attention: RONAK KANABAR <ronak199323(a)gmail.com>
Gerrit-Comment-Date: Thu, 15 Aug 2024 17:36:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No