Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Nick Vaccaro, Rishika Raj.
Subrata Banik has posted comments on this change by Nick Vaccaro. ( https://review.coreboot.org/c/coreboot/+/83932?usp=email )
Change subject: mb/goog/brya: Don't lock GPP_F15 (FPMCU_INT_L)
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83932?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1c73035b02021b0d1268cd46dcd0841621556ad5
Gerrit-Change-Number: 83932
Gerrit-PatchSet: 2
Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Thu, 15 Aug 2024 17:36:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Felix Singer, Jakub Czapiga, Julius Werner, Karthik Ramasubramanian, Yu-Ping Wu.
Jon Murphy has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/83931?usp=email )
Change subject: Revert "commonlib/bsd: Add strcat() and strncat() functions"
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83931/comment/ee273b94_a9832b67?us… :
PS1, Line 11: b/359951393
> Please don't use these numbers for upstream patches. […]
See https://review.coreboot.org/c/coreboot/+/83930/3..6//COMMIT_MSG#b11 and lets discuss there
--
To view, visit https://review.coreboot.org/c/coreboot/+/83931?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I32d79fceca462e363c7d7b17a08d6c60c2bb8aff
Gerrit-Change-Number: 83931
Gerrit-PatchSet: 3
Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Thu, 15 Aug 2024 17:29:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Attention is currently required from: Jakub Czapiga, Jon Murphy, Julius Werner, Karthik Ramasubramanian, Yu-Ping Wu.
Hello Jakub Czapiga, Julius Werner, Karthik Ramasubramanian, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83931?usp=email
to look at the new patch set (#3).
Change subject: Revert "commonlib/bsd: Add strcat() and strncat() functions"
......................................................................
Revert "commonlib/bsd: Add strcat() and strncat() functions"
This reverts commit aff734bc42b4e132abb5de0e44b0464dd4688590.
Reason for revert: b/359951393 breaking builds for ChromeOS and likely others
Devices are unable to boot and log the following:
[DEBUG] ACPI: * FACS
[DEBUG] SCI is IRQ 9, GSI 9
[DEBUG] ACPI: * FACP
[DEBUG] ACPI: added table 1/32, length now 44
[DEBUG] Found 1 CPU(s) with 10/12 physical/logical core(s) each.
[DEBUG] PCI space above 4GB MMIO is at 0x47fc00000, len = 0x7b80400000
[EMERG] ASSERTION ERROR: file '', line 1214
Change-Id: I32d79fceca462e363c7d7b17a08d6c60c2bb8aff
Signed-off-by: Jon Murphy <jpmurphy(a)google.com>
---
M payloads/libpayload/include/string.h
M payloads/libpayload/libc/string.c
M src/commonlib/bsd/include/commonlib/bsd/string.h
M src/commonlib/bsd/string.c
M tests/commonlib/bsd/string-test.c
5 files changed, 42 insertions(+), 99 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/83931/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/83931?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I32d79fceca462e363c7d7b17a08d6c60c2bb8aff
Gerrit-Change-Number: 83931
Gerrit-PatchSet: 3
Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Attention is currently required from: Felix Singer, Jakub Czapiga, Julius Werner, Karthik Ramasubramanian, Maximilian Brune, Yu-Ping Wu.
Hello Jakub Czapiga, Julius Werner, Karthik Ramasubramanian, Maximilian Brune, Subrata Banik, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83930?usp=email
to look at the new patch set (#6).
Change subject: Revert "commonlib/bsd: Add strlen() and strnlen() functions"
......................................................................
Revert "commonlib/bsd: Add strlen() and strnlen() functions"
This reverts commit 0dcdc0347c8d0405c1c6b444d23483dd9bf31d34.
Reason for revert: b/359951393 breaking builds affecting many devices
Devices are unable to boot and log the following:
[DEBUG] ACPI: * FACS
[DEBUG] SCI is IRQ 9, GSI 9
[DEBUG] ACPI: * FACP
[DEBUG] ACPI: added table 1/32, length now 44
[DEBUG] Found 1 CPU(s) with 10/12 physical/logical core(s) each.
[DEBUG] PCI space above 4GB MMIO is at 0x47fc00000, len = 0x7b80400000
[EMERG] ASSERTION ERROR: file '', line 1214
Change-Id: Ic145ed88c683ecbb9f7cefa1a40cdf20c4518d03
Signed-off-by: Jon Murphy <jpmurphy(a)google.com>
---
M payloads/libpayload/include/string.h
M payloads/libpayload/libc/string.c
M src/commonlib/bsd/include/commonlib/bsd/string.h
M src/commonlib/bsd/string.c
M src/include/string.h
M src/lib/string.c
M tests/commonlib/bsd/string-test.c
M tests/lib/string-test.c
8 files changed, 103 insertions(+), 70 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/83930/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/83930?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic145ed88c683ecbb9f7cefa1a40cdf20c4518d03
Gerrit-Change-Number: 83930
Gerrit-PatchSet: 6
Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rishika Raj, Subrata Banik.
Hello Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rishika Raj, Subrata Banik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83932?usp=email
to look at the new patch set (#2).
Change subject: mb/goog/brya: Don't lock GPP_F15 (FPMCU_INT_L)
......................................................................
mb/goog/brya: Don't lock GPP_F15 (FPMCU_INT_L)
Locking GPP_F15 causes DUTs with fingerprint sensor to not be able to
correctly power down and stay powered down. This pin does not need to
be locked.
BUG=b:359692570, b:356750516
BRANCH=None
TEST=`FW_NAME=gimble emerge-brya coreboot chromeos-bootimage`, flash and
boot gimble into developer mode, then reboot into dev screen and select
the "Power off" button and verify gimble powers off and does not power
itself back up.
Change-Id: I1c73035b02021b0d1268cd46dcd0841621556ad5
Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com>
---
M src/mainboard/google/brya/variants/baseboard/brya/gpio.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/83932/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83932?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1c73035b02021b0d1268cd46dcd0841621556ad5
Gerrit-Change-Number: 83932
Gerrit-PatchSet: 2
Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Attention is currently required from: Jakub Czapiga, Jon Murphy, Julius Werner, Karthik Ramasubramanian, Yu-Ping Wu.
Hello Jakub Czapiga, Julius Werner, Karthik Ramasubramanian, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83931?usp=email
to look at the new patch set (#2).
Change subject: Revert "commonlib/bsd: Add strcat() and strncat() functions"
......................................................................
Revert "commonlib/bsd: Add strcat() and strncat() functions"
This reverts commit aff734bc42b4e132abb5de0e44b0464dd4688590.
Reason for revert: b/359951393 breaking builds for ChromeOS and likely others
[DEBUG] ACPI: * FACS
[DEBUG] SCI is IRQ 9, GSI 9
[DEBUG] ACPI: * FACP
[DEBUG] ACPI: added table 1/32, length now 44
[DEBUG] Found 1 CPU(s) with 10/12 physical/logical core(s) each.
[DEBUG] PCI space above 4GB MMIO is at 0x47fc00000, len = 0x7b80400000
[EMERG] ASSERTION ERROR: file '', line 1214
Change-Id: I32d79fceca462e363c7d7b17a08d6c60c2bb8aff
Signed-off-by: Jon Murphy <jpmurphy(a)google.com>
---
M payloads/libpayload/include/string.h
M payloads/libpayload/libc/string.c
M src/commonlib/bsd/include/commonlib/bsd/string.h
M src/commonlib/bsd/string.c
M tests/commonlib/bsd/string-test.c
5 files changed, 42 insertions(+), 99 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/83931/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83931?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I32d79fceca462e363c7d7b17a08d6c60c2bb8aff
Gerrit-Change-Number: 83931
Gerrit-PatchSet: 2
Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Attention is currently required from: Felix Singer, Jakub Czapiga, Julius Werner, Karthik Ramasubramanian, Maximilian Brune, Yu-Ping Wu.
Jon Murphy has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/83930?usp=email )
Change subject: Revert "commonlib/bsd: Add strlen() and strnlen() functions"
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83930/comment/2ee6fe03_f5201850?us… :
PS3, Line 11: Reason for revert: b/359951393 breaking builds affecting many devices
> Please don't use these numbers for upstream patches. […]
Tried to add more context. I'd prefer to keep the bug number in, and we often add them to headers as long as the bug is also described. When downstreamed, it automatically links to the bug in our tooling. Not trying to hide anything, just increase traceability.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83930?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic145ed88c683ecbb9f7cefa1a40cdf20c4518d03
Gerrit-Change-Number: 83930
Gerrit-PatchSet: 5
Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Thu, 15 Aug 2024 17:25:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Attention is currently required from: Jakub Czapiga, Jon Murphy, Julius Werner, Karthik Ramasubramanian, Maximilian Brune, Yu-Ping Wu.
Subrata Banik has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/83930?usp=email )
Change subject: Revert "commonlib/bsd: Add strlen() and strnlen() functions"
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83930?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic145ed88c683ecbb9f7cefa1a40cdf20c4518d03
Gerrit-Change-Number: 83930
Gerrit-PatchSet: 5
Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Thu, 15 Aug 2024 17:25:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83932?usp=email )
Change subject: mb/goog/brya: Don't lock GPP_F15 (FPMCU_INT_L)
......................................................................
mb/goog/brya: Don't lock GPP_F15 (FPMCU_INT_L)
Locking GPP_F15 causes DUTs with fingerprint sensor to not be able to
correctly power down and stay powered down. This pin does not need to
be locked.
BUG=b:359692570, b:356750516
BRANCH=None
TEST=`FW_NAME=gimble emerge-brya coreboot chromeos-bootimage`, flash and
boot gimble into developer mode, then reboot into dev screen and select
the "Power off" button and verify gimble powers off and does not power
itself back up.
Change-Id: I1c73035b02021b0d1268cd46dcd0841621556ad5
Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com>
---
M src/mainboard/google/brya/variants/baseboard/brya/gpio.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/83932/1
diff --git a/src/mainboard/google/brya/variants/baseboard/brya/gpio.c b/src/mainboard/google/brya/variants/baseboard/brya/gpio.c
index 07f8dbd..984d13b 100644
--- a/src/mainboard/google/brya/variants/baseboard/brya/gpio.c
+++ b/src/mainboard/google/brya/variants/baseboard/brya/gpio.c
@@ -242,7 +242,7 @@
/* F14 : GSXDIN ==> TCHPAD_INT_ODL */
PAD_CFG_GPI_IRQ_WAKE(GPP_F14, NONE, PWROK, LEVEL, INVERT),
/* F15 : GSXSRESET# ==> FPMCU_INT_L */
- PAD_CFG_GPI_IRQ_WAKE_LOCK(GPP_F15, NONE, LEVEL, INVERT, LOCK_CONFIG),
+ PAD_CFG_GPI_IRQ_WAKE(GPP_F15, NONE, PLTRST, LEVEL, INVERT),
/* F16 : GSXCLK ==> GSPI_PCH_CS_FPMCU_R_L */
PAD_CFG_NF_LOCK(GPP_F16, NONE, NF4, LOCK_CONFIG),
/* F17 : THC1_SPI2_RST# ==> EC_PCH_INT_ODL */
--
To view, visit https://review.coreboot.org/c/coreboot/+/83932?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1c73035b02021b0d1268cd46dcd0841621556ad5
Gerrit-Change-Number: 83932
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com>
Attention is currently required from: Jakub Czapiga, Jon Murphy, Julius Werner, Karthik Ramasubramanian, Maximilian Brune, Yu-Ping Wu.
Hello Jakub Czapiga, Julius Werner, Karthik Ramasubramanian, Maximilian Brune, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83930?usp=email
to look at the new patch set (#5).
Change subject: Revert "commonlib/bsd: Add strlen() and strnlen() functions"
......................................................................
Revert "commonlib/bsd: Add strlen() and strnlen() functions"
This reverts commit 0dcdc0347c8d0405c1c6b444d23483dd9bf31d34.
Reason for revert: b/359951393 breaking builds affecting many devices
[DEBUG] ACPI: * FACS
[DEBUG] SCI is IRQ 9, GSI 9
[DEBUG] ACPI: * FACP
[DEBUG] ACPI: added table 1/32, length now 44
[DEBUG] Found 1 CPU(s) with 10/12 physical/logical core(s) each.
[DEBUG] PCI space above 4GB MMIO is at 0x47fc00000, len = 0x7b80400000
[EMERG] ASSERTION ERROR: file '', line 1214
Change-Id: Ic145ed88c683ecbb9f7cefa1a40cdf20c4518d03
Signed-off-by: Jon Murphy <jpmurphy(a)google.com>
---
M payloads/libpayload/include/string.h
M payloads/libpayload/libc/string.c
M src/commonlib/bsd/include/commonlib/bsd/string.h
M src/commonlib/bsd/string.c
M src/include/string.h
M src/lib/string.c
M tests/commonlib/bsd/string-test.c
M tests/lib/string-test.c
8 files changed, 103 insertions(+), 70 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/83930/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/83930?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic145ed88c683ecbb9f7cefa1a40cdf20c4518d03
Gerrit-Change-Number: 83930
Gerrit-PatchSet: 5
Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>