Attention is currently required from: Jakub Czapiga, Jon Murphy, Julius Werner, Karthik Ramasubramanian, Maximilian Brune, Yu-Ping Wu.
Hello Jakub Czapiga, Julius Werner, Karthik Ramasubramanian, Maximilian Brune, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83930?usp=email
to look at the new patch set (#4).
Change subject: Revert "commonlib/bsd: Add strlen() and strnlen() functions"
......................................................................
Revert "commonlib/bsd: Add strlen() and strnlen() functions"
This reverts commit 0dcdc0347c8d0405c1c6b444d23483dd9bf31d34.
Reason for revert: b/359951393 breaking builds affecting many devices
```
[DEBUG] ACPI: * FACS
[DEBUG] SCI is IRQ 9, GSI 9
[DEBUG] ACPI: * FACP
[DEBUG] ACPI: added table 1/32, length now 44
[DEBUG] Found 1 CPU(s) with 10/12 physical/logical core(s) each.
[DEBUG] PCI space above 4GB MMIO is at 0x47fc00000, len = 0x7b80400000
[EMERG] ASSERTION ERROR: file '', line 1214
```
Change-Id: Ic145ed88c683ecbb9f7cefa1a40cdf20c4518d03
Signed-off-by: Jon Murphy <jpmurphy(a)google.com>
---
M payloads/libpayload/include/string.h
M payloads/libpayload/libc/string.c
M src/commonlib/bsd/include/commonlib/bsd/string.h
M src/commonlib/bsd/string.c
M src/include/string.h
M src/lib/string.c
M tests/commonlib/bsd/string-test.c
M tests/lib/string-test.c
8 files changed, 103 insertions(+), 70 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/83930/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/83930?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic145ed88c683ecbb9f7cefa1a40cdf20c4518d03
Gerrit-Change-Number: 83930
Gerrit-PatchSet: 4
Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Attention is currently required from: Jakub Czapiga, Jon Murphy, Julius Werner, Karthik Ramasubramanian, Maximilian Brune, Yu-Ping Wu.
Felix Singer has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/83930?usp=email )
Change subject: Revert "commonlib/bsd: Add strlen() and strnlen() functions"
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83930/comment/401a996a_2f5edb1d?us… :
PS3, Line 11: Reason for revert: b/359951393 breaking builds affecting many devices
Please don't use these numbers for upstream patches. I have no idea what that is or what it is saying.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83930?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic145ed88c683ecbb9f7cefa1a40cdf20c4518d03
Gerrit-Change-Number: 83930
Gerrit-PatchSet: 3
Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Thu, 15 Aug 2024 17:20:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Jakub Czapiga, Jon Murphy, Julius Werner, Karthik Ramasubramanian, Yu-Ping Wu.
Felix Singer has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/83931?usp=email )
Change subject: Revert "commonlib/bsd: Add strcat() and strncat() functions"
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83931/comment/f67b4cba_67c0963a?us… :
PS1, Line 11: b/359951393
Please don't use these numbers for upstream patches. I have no idea what that is or what it is saying.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83931?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I32d79fceca462e363c7d7b17a08d6c60c2bb8aff
Gerrit-Change-Number: 83931
Gerrit-PatchSet: 1
Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Thu, 15 Aug 2024 17:20:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Julius Werner, Maximilian Brune, Yu-Ping Wu.
Karthik Ramasubramanian has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/83914?usp=email )
Change subject: commonlib/bsd/string: Fix pointer overflow for strnlen()
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83914?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic9d983b11391f5e05c2bceb262682aced5206f94
Gerrit-Change-Number: 83914
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Thu, 15 Aug 2024 16:31:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Jon Murphy has created a revert of this change. ( https://review.coreboot.org/c/coreboot/+/83765?usp=email )
Change subject: commonlib/bsd: Add strcat() and strncat() functions
......................................................................
--
To view, visit https://review.coreboot.org/c/coreboot/+/83765?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: revert
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If02fce0eafb4f6fa01d8bab17d87a32360f4ac83
Gerrit-Change-Number: 83765
Gerrit-PatchSet: 7
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: Jakub Czapiga, Jon Murphy, Julius Werner, Karthik Ramasubramanian, Maximilian Brune, Yu-Ping Wu.
Hello Jakub Czapiga, Julius Werner, Karthik Ramasubramanian, Maximilian Brune, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83930?usp=email
to look at the new patch set (#2).
Change subject: Revert "commonlib/bsd: Add strlen() and strnlen() functions"
......................................................................
Revert "commonlib/bsd: Add strlen() and strnlen() functions"
This reverts commit 0dcdc0347c8d0405c1c6b444d23483dd9bf31d34.
Reason for revert: b/359951393 breaking builds affecting many devices
Change-Id: Ic145ed88c683ecbb9f7cefa1a40cdf20c4518d03
Signed-off-by: Jon Murphy <jpmurphy(a)google.com>
---
M payloads/libpayload/include/string.h
M payloads/libpayload/libc/string.c
M src/commonlib/bsd/include/commonlib/bsd/string.h
M src/commonlib/bsd/string.c
M src/include/string.h
M src/lib/string.c
M tests/commonlib/bsd/string-test.c
M tests/lib/string-test.c
8 files changed, 103 insertions(+), 70 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/83930/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83930?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic145ed88c683ecbb9f7cefa1a40cdf20c4518d03
Gerrit-Change-Number: 83930
Gerrit-PatchSet: 2
Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Jon Murphy has created a revert of this change. ( https://review.coreboot.org/c/coreboot/+/83830?usp=email )
Change subject: commonlib/bsd: Add strlen() and strnlen() functions
......................................................................
--
To view, visit https://review.coreboot.org/c/coreboot/+/83830?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: revert
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1203ec9affabe493bd14b46662d212b08240cced
Gerrit-Change-Number: 83830
Gerrit-PatchSet: 3
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Attention is currently required from: Hung-Te Lin, Jarried Lin, Xi Chen, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83925?usp=email )
Change subject: soc/mediatek/mt8196: Enable mmu operation for L2C SRAM and DMA
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Can we split this patch into two patches ?
One is code refactoring for `common/mmu_cmops.c`.
Another is this one.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83925?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6a3cb63d3418f085f5d8d08b282dd59ea431c294
Gerrit-Change-Number: 83925
Gerrit-PatchSet: 2
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Thu, 15 Aug 2024 14:39:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No