Attention is currently required from: Michael Büchler.
Julia has posted comments on this change by Michael Büchler. ( https://review.coreboot.org/c/coreboot/+/57764?usp=email )
Change subject: [NEEDS_TEST]: mb/acer/g43t-am3: Add Acer Q45T-AM as a variant
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/57764?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I425852f4bdacf7cb6688a5fb845ac3001373262e
Gerrit-Change-Number: 57764
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Büchler <michael.buechler(a)posteo.net>
Gerrit-Reviewer: Julia <launchpad.vineyard395(a)passinbox.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Michael Büchler <michael.buechler(a)posteo.net>
Gerrit-Comment-Date: Sat, 17 Aug 2024 16:05:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Dinesh Gehlot, Subrata Banik.
Paul Menzel has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/83759?usp=email )
Change subject: src: Log boot info at early romstage
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83759/comment/e6e9293a_db1281df?us… :
PS3, Line 14: TEST=Verified elog boot info at early romstage
What does it contain now? Maybe just paste it here too?
--
To view, visit https://review.coreboot.org/c/coreboot/+/83759?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5223d387e207e1042d832c36bd076c3966687bdf
Gerrit-Change-Number: 83759
Gerrit-PatchSet: 3
Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Comment-Date: Sat, 17 Aug 2024 13:54:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Dinesh Gehlot, Subrata Banik.
Paul Menzel has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/83759?usp=email )
Change subject: src: Log boot info at early romstage
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83759/comment/37e96cda_87194ee8?us… :
PS3, Line 12:
The diff only contains `elog_add_vboot_info()`. Can you please clarify.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83759?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5223d387e207e1042d832c36bd076c3966687bdf
Gerrit-Change-Number: 83759
Gerrit-PatchSet: 3
Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Comment-Date: Sat, 17 Aug 2024 13:54:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Felix Singer has restored this change. ( https://review.coreboot.org/c/coreboot/+/57764?usp=email )
Change subject: [NEEDS_TEST]: mb/acer/g43t-am3: Add Acer Q45T-AM as a variant
......................................................................
Restored
--
To view, visit https://review.coreboot.org/c/coreboot/+/57764?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: restore
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I425852f4bdacf7cb6688a5fb845ac3001373262e
Gerrit-Change-Number: 57764
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Büchler <michael.buechler(a)posteo.net>
Gerrit-Reviewer: Attila Nemčkov <hunne(a)protonmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Attention is currently required from: Dinesh Gehlot, Subrata Banik.
Hello Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83759?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: src: Log boot info at early romstage
......................................................................
src: Log boot info at early romstage
This patch logs the current boot information at early romstage. As
certain events can trigger a system restart, there is a possibility
that the system may reboot before the boot information is logged.
BUG=b:360082747
TEST=Verified elog boot info at early romstage
Change-Id: I5223d387e207e1042d832c36bd076c3966687bdf
Signed-off-by: Dinesh Gehlot <digehlot(a)google.com>
---
M src/cpu/intel/car/romstage.c
M src/include/elog.h
M src/vendorcode/google/chromeos/Makefile.mk
M src/vendorcode/google/chromeos/elog.c
4 files changed, 8 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/83759/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/83759?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5223d387e207e1042d832c36bd076c3966687bdf
Gerrit-Change-Number: 83759
Gerrit-PatchSet: 3
Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83759?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: src: Log boot info at early romstage
......................................................................
src: Log boot info at early romstage
This patch logs the current boot information at early romstage. As
certain events can trigger a system restart, there is a possibility
that the system may reboot before the boot information is logged.
BUG=b:360082747
TEST=Verified elog boot info at early romstage
Change-Id: I5223d387e207e1042d832c36bd076c3966687bdf
Signed-off-by: Dinesh Gehlot <digehlot(a)google.com>
---
M src/cpu/intel/car/romstage.c
M src/include/elog.h
M src/vendorcode/google/chromeos/Makefile.mk
M src/vendorcode/google/chromeos/elog.c
4 files changed, 8 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/83759/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83759?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5223d387e207e1042d832c36bd076c3966687bdf
Gerrit-Change-Number: 83759
Gerrit-PatchSet: 2
Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: Patrick Rudolph.
Elyes Haouas has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/30118?usp=email )
Change subject: arch/x86/boot: Jump to payload in protected mode
......................................................................
Patch Set 34:
(1 comment)
File src/include/assert.h:
https://review.coreboot.org/c/coreboot/+/30118/comment/462bdae7_924ced77?us… :
PS34, Line 87: (uint32_t)(uintptr_t)(x); \
this line is unreachable, or I'm wrong?
--
To view, visit https://review.coreboot.org/c/coreboot/+/30118?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6552ac30f1b6205e08e16d251328e01ce3fbfd14
Gerrit-Change-Number: 30118
Gerrit-PatchSet: 34
Gerrit-Owner: Patrick Rudolph <rudolphpatrick05(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <rudolphpatrick05(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Patrick Rudolph <rudolphpatrick05(a)gmail.com>
Gerrit-Comment-Date: Sat, 17 Aug 2024 06:24:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No