Attention is currently required from: Arthur Heymans, Jérémy Compostella, Nico Huber.
Hello Elyes Haouas, Jérémy Compostella, Nico Huber, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83999?usp=email
to look at the new patch set (#3).
Change subject: arch/x86: Move oformat definition into the linker file
......................................................................
arch/x86: Move oformat definition into the linker file
This removes the boilerplate --oformat out of the makefile.mk
Change-Id: Ib78934fff4a31c4375da2038efca5027b813b07b
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/arch/x86/Makefile.mk
M src/arch/x86/include/arch/header.ld
2 files changed, 14 insertions(+), 27 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/83999/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/83999?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib78934fff4a31c4375da2038efca5027b813b07b
Gerrit-Change-Number: 83999
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Attention is currently required from: Ashish Kumar Mishra, Balaji Manigandan, Saurabh Mishra.
Nico Huber has posted comments on this change by Balaji Manigandan. ( https://review.coreboot.org/c/coreboot/+/83887?usp=email )
Change subject: Fix no-op for empty arg in Makefile conditional
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
> Hmmm, I think now I understand where we misunderstood each other. What […]
I ran it through `strace` now and realized that GNU make optimizes the `:` away.
So the original workaround shouldn't be an issue. Please return to patch set 4.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83887?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I276e89792779832edf325d4f781aa8df101e9091
Gerrit-Change-Number: 83887
Gerrit-PatchSet: 5
Gerrit-Owner: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Saurabh Mishra <mishra.saurabh(a)intel.corp-partner.google.com>
Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Comment-Date: Wed, 21 Aug 2024 08:09:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Saurabh Mishra <mishra.saurabh(a)intel.com>
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Attention is currently required from: Ashish Kumar Mishra, Balaji Manigandan, Saurabh Mishra.
Nico Huber has posted comments on this change by Balaji Manigandan. ( https://review.coreboot.org/c/coreboot/+/83887?usp=email )
Change subject: Fix no-op for empty arg in Makefile conditional
......................................................................
Patch Set 5:
(3 comments)
Patchset:
PS4:
>> Although I hit this issue due to different change, it can be replicated like:
>
> What change?
Ping.
> Test case1: Uisng $(if ,-$(CBFSTOOL) $@.tmp remove -n $(call extract_nth,2,$(file)) 2>/dev/null)
> Result: Failure
> UPDATE-FIT Microcode
> E: Couldn't find microcode blob.
That's a different error. And also, we should try to reproduce the issue
with the upstream coreboot main branch, without changes.
Patchset:
PS5:
I'm still struggling to understand why Ubuntu behaves differently for you
and me. Is there anything special about your installation maybe? Any extra
package repositories? Any virtualization, a special container, WSL or anything
like that?
If we can't figure this out, we can't report the bug upstream.
PS5:
> Hi, Updated the patch to invoke another shell process.
Hmmm, I think now I understand where we misunderstood each other. What
I meant is that with `:` make already invokes another shell, only to
execute the `:`. Already one shell too many for my taste.
Now with `(:)` make will invoke a shell that executes this which will
result in a second shell that eventually executes `:`.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83887?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I276e89792779832edf325d4f781aa8df101e9091
Gerrit-Change-Number: 83887
Gerrit-PatchSet: 5
Gerrit-Owner: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Saurabh Mishra <mishra.saurabh(a)intel.corp-partner.google.com>
Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Comment-Date: Wed, 21 Aug 2024 07:46:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Saurabh Mishra <mishra.saurabh(a)intel.com>
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Balaji Manigandan <balaji.manigandan(a)intel.com>
Attention is currently required from: Weimin Wu.
Qinghong Zeng has posted comments on this change by Qinghong Zeng. ( https://review.coreboot.org/c/coreboot/+/84001?usp=email )
Change subject: mb/google/nissa/var/teliks: Adjust usb2 pin of wlan
......................................................................
Patch Set 2:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84001?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icd1ec3b561ee5b3f55e5f97a56fd9cb7df893508
Gerrit-Change-Number: 84001
Gerrit-PatchSet: 2
Gerrit-Owner: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 21 Aug 2024 07:32:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: Alexander Couzens, Nicholas Sudsgaard.
Angel Pons has posted comments on this change by Nicholas Sudsgaard. ( https://review.coreboot.org/c/coreboot/+/83994?usp=email )
Change subject: mb/lenovo/thinkcentre_m710s: Disable DRIVER_LENOVO_SERIALS
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> How so? I would be happy to do some cleaning. […]
I haven't looked into it, but I would try to have mainboards explicitly select the driver instead of having to disable it. Not sure if all other existing mainboards are correct, though.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83994?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If6f948bc4c63c7afdc8b31e1945d3c3beb99883f
Gerrit-Change-Number: 83994
Gerrit-PatchSet: 1
Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 21 Aug 2024 07:21:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Attention is currently required from: Ashish Kumar Mishra, Balaji Manigandan, Nico Huber, Saurabh Mishra.
Saurabh Mishra has uploaded a new patch set (#5) to the change originally created by Balaji Manigandan. ( https://review.coreboot.org/c/coreboot/+/83887?usp=email )
The following approvals got outdated and were removed:
Code-Review+1 by Nico Huber, Code-Review+1 by Saurabh Mishra, Verified+1 by build bot (Jenkins)
Change subject: Fix no-op for empty arg in Makefile conditional
......................................................................
Fix no-op for empty arg in Makefile conditional
This change addresses an issue where the Makefile failed with the error:
/bin/bash: -c: option requires an argument
make: *** [Makefile.mk:1261: build/coreboot.pre] Error 2
The error was due to an empty third argument `$(3)` in a conditional
`$(if ...)` statement. The original line did not have an explicit no-op
for the case when `$(3)` is empty, leading to an incomplete command.
By adding a colon `:` as a no-op command in the else-part of the `$(if ...)`,
we ensure execution of a harmless command when `$(3)` is empty, preventing
the Makefile from failing due to a missing argument.
This fix ensures compatibility with newer shell environments and prevents
the Makefile from breaking under the specified conditions.
Change-Id: I276e89792779832edf325d4f781aa8df101e9091
Signed-off-by: Manigandan, Balaji <balaji.manigandan(a)intel.com>
---
M Makefile.mk
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/83887/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/83887?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I276e89792779832edf325d4f781aa8df101e9091
Gerrit-Change-Number: 83887
Gerrit-PatchSet: 5
Gerrit-Owner: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Saurabh Mishra <mishra.saurabh(a)intel.corp-partner.google.com>
Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com>
Attention is currently required from: Matt DeVillier, Nick Vaccaro.
Felix Singer has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/83995?usp=email )
Change subject: mb/google/volteer/var/drobit: Set UART GPIOs in bootblock
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83995?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If94eb8caca3469143433fef06b972050f886be6a
Gerrit-Change-Number: 83995
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Wed, 21 Aug 2024 06:54:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Ren Kuo has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84000?usp=email )
Change subject: mb/google/brox/var/jubilant: Enable storage config on unprovisioned fw_config
......................................................................
mb/google/brox/var/jubilant: Enable storage config on unprovisioned fw_config
Add the condition of unprovisioned fw_config to enable the all storages config.
BUG=None
TEST=Build jubilant firmware and boot to OS when fw_config is unprovisioned.
Change-Id: I19582f72e4ab4062b89f794d6d905f47747f85ff
Signed-off-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brox/variants/jubilant/variant.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/84000/1
diff --git a/src/mainboard/google/brox/variants/jubilant/variant.c b/src/mainboard/google/brox/variants/jubilant/variant.c
index c6b2626..0f4b63c 100644
--- a/src/mainboard/google/brox/variants/jubilant/variant.c
+++ b/src/mainboard/google/brox/variants/jubilant/variant.c
@@ -31,8 +31,8 @@
struct device *ish = DEV_PTR(ish);
struct device *nvme_rp = DEV_PTR(pcie4_0);
- if (fw_config_probe(FW_CONFIG(STORAGE, STORAGE_UNKNOWN))) {
- printk(BIOS_INFO, "fw_config storage is unknown so enable all storage devices.\n");
+ if ((!fw_config_is_provisioned()) || fw_config_probe(FW_CONFIG(STORAGE, STORAGE_UNKNOWN))) {
+ printk(BIOS_INFO, "fw_config is unprovisioned or storage is unknow so enable all storages config.\n");
return;
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/84000?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I19582f72e4ab4062b89f794d6d905f47747f85ff
Gerrit-Change-Number: 84000
Gerrit-PatchSet: 1
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>