Attention is currently required from: Arthur Heymans, Martin L Roth.
Hello Julius Werner, Martin L Roth, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81658?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: arch/arm64: Use -mno-implicit-float with clang
......................................................................
arch/arm64: Use -mno-implicit-float with clang
This fixes building inline assembly that uses SIMD registers. This is
for instance the case in the vboot library.
Change-Id: I24fa9d9f81430ea3ecd40de4304a10c6e235fece
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M toolchain.mk
M util/xcompile/xcompile
2 files changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/81658/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/81658?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I24fa9d9f81430ea3ecd40de4304a10c6e235fece
Gerrit-Change-Number: 81658
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Attention is currently required from: Julius Werner.
Hello Julius Werner, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80639?usp=email
to look at the new patch set (#8).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: soc/qualcomm/sc7{1,2}80: Increase early stages size for clang
......................................................................
soc/qualcomm/sc7{1,2}80: Increase early stages size for clang
Clang builds slightly larger binaries so increase the section.
The qcsdi is used for an external blob that is currently not in use so
reducing the size is fine for now.
Change-Id: Ide01233f209613678c5408f1afab19415c1071be
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/soc/qualcomm/sc7180/memlayout.ld
M src/soc/qualcomm/sc7280/memlayout.ld
2 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/80639/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/80639?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ide01233f209613678c5408f1afab19415c1071be
Gerrit-Change-Number: 80639
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Attention is currently required from: Arthur Heymans, Jon Murphy.
Hello Julius Werner, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74501?usp=email
to look at the new patch set (#30).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: arch/arm64: Add Clang as supported target
......................................................................
arch/arm64: Add Clang as supported target
QEMU aarch64 boots to payload when compiled with clang.
Change-Id: I940a1ccf5cc4ec7bed5b6c8be92fc47922e1e747
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/arch/arm64/Kconfig
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/74501/30
--
To view, visit https://review.coreboot.org/c/coreboot/+/74501?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I940a1ccf5cc4ec7bed5b6c8be92fc47922e1e747
Gerrit-Change-Number: 74501
Gerrit-PatchSet: 30
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Attention is currently required from: Julius Werner.
Arthur Heymans has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/80639?usp=email )
Change subject: soc/qualcomm/sc7{1,2}80: Increase early stages size for clang
......................................................................
Patch Set 7:
(1 comment)
File src/soc/qualcomm/sc7180/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/80639/comment/d38b254c_6fe038eb?us… :
PS7, Line 36: 46K
> I think you're dropping 10K on the floor here?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/80639?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ide01233f209613678c5408f1afab19415c1071be
Gerrit-Change-Number: 80639
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Wed, 21 Aug 2024 09:22:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Attention is currently required from: Arthur Heymans.
Nico Huber has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84003?usp=email )
Change subject: Add initial experimental LTO support
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
File Makefile.mk:
https://review.coreboot.org/c/coreboot/+/84003/comment/78219dcb_e752ec20?us… :
PS2, Line 551: CFLAGS_common += -flto
Have you tried this with ADAFLAGS_common?
https://review.coreboot.org/c/coreboot/+/84003/comment/b1aedc91_7f8bc56f?us… :
PS2, Line 1329: @printf " LINK $$(subst $$(obj)/,,$$(@))\n"
Technically, you could move the first two lines out of the `ifeq`.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84003?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieb9204777fd349542744a8946e2207731c37969c
Gerrit-Change-Number: 84003
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Wed, 21 Aug 2024 09:22:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Julius Werner.
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84005?usp=email )
Change subject: arch/arm: Fix building with LTO
......................................................................
arch/arm: Fix building with LTO
With LTO clang cannot find the aliased symbols.
Change-Id: I3d89c093cee2636e648987a06afb0d325b1d96ff
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/arch/arm/Makefile.mk
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/84005/1
diff --git a/src/arch/arm/Makefile.mk b/src/arch/arm/Makefile.mk
index 3f8232f..3374e9a 100644
--- a/src/arch/arm/Makefile.mk
+++ b/src/arch/arm/Makefile.mk
@@ -97,6 +97,8 @@
ramstage-y += stages.c
ramstage-y += div0.c
+# Clang LTO does not like the aliasing in here.
+$(call src-to-obj,ramstage,$(dir)/eabi_compat.c): CFLAGS_ramstage += -fno-lto
ramstage-y += eabi_compat.c
ramstage-y += boot.c
ramstage-y += tables.c
--
To view, visit https://review.coreboot.org/c/coreboot/+/84005?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3d89c093cee2636e648987a06afb0d325b1d96ff
Gerrit-Change-Number: 84005
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Attention is currently required from: Arthur Heymans.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84003?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: Add initial experimental LTO support
......................................................................
Add initial experimental LTO support
This will not succeed in compiling on all target and compiler
combinations but at least gets the ball rolling. The change is not
invasive.
Some notes:
- GCC has issues with LTO on ARM
- Clang uses LLD automatically on some arch
- Clang with LTO fails on x86 as it forwards the linking to GCC for some
reason
- SMM building succeeds but the binary is empty
Change-Id: Ieb9204777fd349542744a8946e2207731c37969c
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M Makefile.mk
M src/Kconfig
2 files changed, 18 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/84003/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/84003?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieb9204777fd349542744a8946e2207731c37969c
Gerrit-Change-Number: 84003
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Attention is currently required from: Arthur Heymans, Julius Werner, Jérémy Compostella, Maximilian Brune, Philipp Hug, ron minnich.
Nico Huber has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/83574?usp=email )
Change subject: Makefile.mk: Add a common link_stage function and use it
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
Patchset:
PS6:
Compared various timeless builds, nothing changed.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83574?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I64f7686894c99732d06972e7ba327061db6d7c44
Gerrit-Change-Number: 83574
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Wed, 21 Aug 2024 09:15:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Julius Werner, Paul Menzel.
Arthur Heymans has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/69747?usp=email )
Change subject: arch/arm: Add a few ARM targets as supported by CLANG
......................................................................
Patch Set 25:
(2 comments)
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/69747/comment/4fdf6230_3532ea11?us… :
PS20, Line 1544: default n
> Should this be set for x86 somewhere as well? I thought that was already supporting clang?
Done
File src/soc/nvidia/tegra124/Kconfig:
https://review.coreboot.org/c/coreboot/+/69747/comment/0d123e0a_5c9b7e2b?us… :
PS20, Line 20: default n if SOC_NVIDIA_TEGRA124 && CHROMEOS
> > Why not move these into the `if SOC_...` blocks below? […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/69747?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I88cf8ce16fb6c61c19d615e396f5871179b06fc8
Gerrit-Change-Number: 69747
Gerrit-PatchSet: 25
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Wed, 21 Aug 2024 09:14:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>