Attention is currently required from: Angel Pons, David Milosevic.
Lean Sheng Tan has posted comments on this change by David Milosevic. ( https://review.coreboot.org/c/coreboot/+/83979?usp=email )
Change subject: [WIP] mb/hardkernel/odroid-h4: add initial odroid-h4 support
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
i think we also support odroid-h4 plus too, should you add this as another variant?
--
To view, visit https://review.coreboot.org/c/coreboot/+/83979?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7e0d395ba3d15dfcf6d47a222b90499ca371e4eb
Gerrit-Change-Number: 83979
Gerrit-PatchSet: 2
Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Comment-Date: Wed, 21 Aug 2024 12:15:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Nico Huber.
Hello Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84014?usp=email
to look at the new patch set (#2).
Change subject: libpayload: Set reasonable arch defaults
......................................................................
libpayload: Set reasonable arch defaults
This makes it easy to switch between x86_32 and x86_64 in payloads.
Change-Id: I3ac5f24d83dc80db924e92b53403c477e6256c44
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M payloads/coreinfo/Makefile
M payloads/libpayload/Makefile.payload
M payloads/nvramcui/Makefile
3 files changed, 19 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/84014/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84014?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3ac5f24d83dc80db924e92b53403c477e6256c44
Gerrit-Change-Number: 84014
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Attention is currently required from: Arthur Heymans, Julius Werner.
Paul Menzel has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/69747?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: arch/arm: Add a few ARM targets as supported by CLANG
......................................................................
Patch Set 25:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69747/comment/a51e07e2_fccf2e0f?us… :
PS25, Line 7: arch/arm: Add a few ARM targets as supported by CLANG
Mention that it’s for non ChromeOS case?
https://review.coreboot.org/c/coreboot/+/69747/comment/0aa0a38c_97888ca1?us… :
PS25, Line 11:
Some numbers would be nice.
--
To view, visit https://review.coreboot.org/c/coreboot/+/69747?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I88cf8ce16fb6c61c19d615e396f5871179b06fc8
Gerrit-Change-Number: 69747
Gerrit-PatchSet: 25
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Wed, 21 Aug 2024 11:52:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84013?usp=email )
Change subject: libpayload: Fix x86 output arch
......................................................................
libpayload: Fix x86 output arch
The value used is not acceptable to gcc.
Change-Id: I0f134a96c596d69e10dd441b96184b119e9f1908
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M payloads/libpayload/arch/x86/libpayload.ldscript
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/84013/1
diff --git a/payloads/libpayload/arch/x86/libpayload.ldscript b/payloads/libpayload/arch/x86/libpayload.ldscript
index 49c7e37..338840c 100644
--- a/payloads/libpayload/arch/x86/libpayload.ldscript
+++ b/payloads/libpayload/arch/x86/libpayload.ldscript
@@ -28,7 +28,7 @@
#if CONFIG(LP_ARCH_X86_64)
OUTPUT_FORMAT(elf64-x86-64)
-OUTPUT_ARCH(x86_64)
+OUTPUT_ARCH(i386:x86-64)
#else
OUTPUT_FORMAT(elf32-i386)
OUTPUT_ARCH(i386)
--
To view, visit https://review.coreboot.org/c/coreboot/+/84013?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0f134a96c596d69e10dd441b96184b119e9f1908
Gerrit-Change-Number: 84013
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84012?usp=email )
Change subject: libpayload: Allow LTO with clang
......................................................................
libpayload: Allow LTO with clang
Change-Id: I41bb613de5d16ca180dd684a0bec4840d9119e6f
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M payloads/libpayload/Kconfig
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/84012/1
diff --git a/payloads/libpayload/Kconfig b/payloads/libpayload/Kconfig
index 0c07ecd..b5da2d9 100644
--- a/payloads/libpayload/Kconfig
+++ b/payloads/libpayload/Kconfig
@@ -84,7 +84,6 @@
config LTO
bool "Use link time optimization (LTO)"
default n
- depends on COMPILER_GCC
help
Compile with link time optimization. This can often decrease the
final binary size, but may increase compilation time.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84012?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I41bb613de5d16ca180dd684a0bec4840d9119e6f
Gerrit-Change-Number: 84012
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84011?usp=email )
Change subject: nvramcui: Fix main function signature
......................................................................
nvramcui: Fix main function signature
LTO is not happy about signature mismatch.
Change-Id: Ia0c50224bd70503e884573fedf3bf33c134bba00
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M payloads/nvramcui/nvramcui.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/84011/1
diff --git a/payloads/nvramcui/nvramcui.c b/payloads/nvramcui/nvramcui.c
index b3a8306..97a8a23 100644
--- a/payloads/nvramcui/nvramcui.c
+++ b/payloads/nvramcui/nvramcui.c
@@ -159,7 +159,7 @@
fields[2 * numopts] = NULL;
}
-int main(void)
+int main(int argc, char **argv)
{
int ch, done;
int i;
--
To view, visit https://review.coreboot.org/c/coreboot/+/84011?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia0c50224bd70503e884573fedf3bf33c134bba00
Gerrit-Change-Number: 84011
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84010?usp=email )
Change subject: libpayload: Don't force GCC in Makefile.payload
......................................................................
libpayload: Don't force GCC in Makefile.payload
This allows nvramcui to be build with clang.
Change-Id: I5e56ead81fc92b7ba4fb63a2c098b0e10b01ca53
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M payloads/libpayload/Makefile.payload
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/84010/1
diff --git a/payloads/libpayload/Makefile.payload b/payloads/libpayload/Makefile.payload
index fa98d8a4..9366987 100644
--- a/payloads/libpayload/Makefile.payload
+++ b/payloads/libpayload/Makefile.payload
@@ -79,7 +79,7 @@
endif
# `lpgcc` in in-tree mode:
-LPGCC = CC="$(CCACHE) $(GCC_CC_$(ARCH))"
+LPGCC = CC="$(CCACHE) $(CC_$(ARCH))"
LPGCC += _OBJ="$(LIBPAYLOAD_OBJ)"
LPGCC += $(LIBPAYLOAD_SRC)/bin/lpgcc
--
To view, visit https://review.coreboot.org/c/coreboot/+/84010?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5e56ead81fc92b7ba4fb63a2c098b0e10b01ca53
Gerrit-Change-Number: 84010
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>