Attention is currently required from: Arthur Heymans, Jérémy Compostella.
Nico Huber has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/83999?usp=email )
Change subject: arch/x86: Move oformat definition into the linker file
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83999?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib78934fff4a31c4375da2038efca5027b813b07b
Gerrit-Change-Number: 83999
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Wed, 21 Aug 2024 08:53:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: David Wu, Karthik Ramasubramanian, Morris Hsu, Ren Kuo.
Tyler Wang has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/84002?usp=email )
Change subject: mb/google/brox/var/jubilant: Enable devices on unprovisioned fw_config
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brox/variants/jubilant/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/84002/comment/f04e4764_d652ba21?us… :
PS2, Line 235: unprovisioned
> Have you define "UNPROVISIONED"? I didn't saw it in overridetree.cb.
Sorry, please ignore this comment. I just saw it defined in CB:83983.
Thanks.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84002?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia14632744c34548e2c201dfc58d82515cdd02df0
Gerrit-Change-Number: 84002
Gerrit-PatchSet: 2
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Wed, 21 Aug 2024 08:52:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Attention is currently required from: David Wu, Karthik Ramasubramanian, Morris Hsu, Ren Kuo.
Hello David Wu, Karthik Ramasubramanian, Morris Hsu, Tyler Wang, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84002?usp=email
to look at the new patch set (#3).
Change subject: mb/google/brox/var/jubilant: Enable devices on unprovisioned fw_config
......................................................................
mb/google/brox/var/jubilant: Enable devices on unprovisioned fw_config
Add the condition of unprovisioned fw_config to enable all storages
and devices. It's for first boot on all storags and preliminary test
in factory when fw_config is unprovisioned.
BUG=None
TEST=Build jubilant firmware and boot to OS on storages when fw_config
is unprovisioned and ensure all devices are enable.
Change-Id: Ia14632744c34548e2c201dfc58d82515cdd02df0
Signed-off-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brox/variants/jubilant/fw_config.c
M src/mainboard/google/brox/variants/jubilant/overridetree.cb
M src/mainboard/google/brox/variants/jubilant/variant.c
3 files changed, 11 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/84002/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/84002?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia14632744c34548e2c201dfc58d82515cdd02df0
Gerrit-Change-Number: 84002
Gerrit-PatchSet: 3
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Attention is currently required from: Julius Werner.
Hello Julius Werner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84004?usp=email
to look at the new patch set (#2).
Change subject: NOT_FOR_MERGE: Check garbage collection using LTO
......................................................................
NOT_FOR_MERGE: Check garbage collection using LTO
Result: Clang throws away the romstage. GCC not...
Change-Id: I6fed7671739bfec49fbfc78c1416b5ea7dc9f236
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/arch/arm64/Makefile.mk
A src/arch/arm64/return_early.c
M src/arch/arm64/romstage.c
M src/include/romstage_common.h
4 files changed, 11 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/84004/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84004?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6fed7671739bfec49fbfc78c1416b5ea7dc9f236
Gerrit-Change-Number: 84004
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Attention is currently required from: Arthur Heymans.
Patrick Rudolph has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84003?usp=email )
Change subject: Add initial experimental LTO support
......................................................................
Patch Set 2:
(1 comment)
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/84003/comment/422589e9_7d9d70c0?us… :
PS2, Line 120: experimantal
experimental
--
To view, visit https://review.coreboot.org/c/coreboot/+/84003?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieb9204777fd349542744a8946e2207731c37969c
Gerrit-Change-Number: 84003
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Wed, 21 Aug 2024 08:42:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: David Wu, Karthik Ramasubramanian, Morris Hsu, Ren Kuo.
Tyler Wang has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/84002?usp=email )
Change subject: mb/google/brox/var/jubilant: Enable devices on unprovisioned fw_config
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84002/comment/ae451a09_5a87e6d3?us… :
PS2, Line 11: fw-config
fw_config?
File src/mainboard/google/brox/variants/jubilant/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/84002/comment/7521680b_d982ef77?us… :
PS2, Line 235: unprovisioned
Have you define "UNPROVISIONED"? I didn't saw it in overridetree.cb.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84002?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia14632744c34548e2c201dfc58d82515cdd02df0
Gerrit-Change-Number: 84002
Gerrit-PatchSet: 2
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Wed, 21 Aug 2024 08:39:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Arthur Heymans has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/84003?usp=email )
Change subject: Add initial experimental LTO support
......................................................................
Add initial experimental LTO support
This will not succeed in compiling on all target and compiler
combinations but at least gets the ball rolling. The change is not
invasive.
Some notes:
- GCC has issues with LTO on ARM
- Clang uses LLD automatically on some arch
- Clang with LTO fails on x86 as it forwards the linking to GCC for some
reason
- SMM building succeeds but the binary is empty
Change-Id: Ieb9204777fd349542744a8946e2207731c37969c
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M Makefile.mk
M src/Kconfig
2 files changed, 18 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/84003/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84003?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieb9204777fd349542744a8946e2207731c37969c
Gerrit-Change-Number: 84003
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>