Attention is currently required from: Angel Pons, Elyes Haouas, Jason Glenesk, Martin L Roth.
Felix Singer has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84075?usp=email )
Change subject: Doc/releases: List toolchain updates in coreboot-24.11-relnotes
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84075?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3690882a742cfe1800f20fdf23a836cb297bbe35
Gerrit-Change-Number: 84075
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sat, 24 Aug 2024 21:51:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84081?usp=email )
Change subject: mainboard/google/rex: Remove HAVE_ACPI_RESUME for Intel Meteor Lake
......................................................................
mainboard/google/rex: Remove HAVE_ACPI_RESUME for Intel Meteor Lake
This patch removes the HAVE_ACPI_RESUME config option from the Google
Rex mainboard configuration. The Intel Meteor Lake SoC does not support
S3 (ACPI sleep state) entry/exit, and attempting S3 validation could
lead to abnormal platform behavior. This change ensures that `_S3` is
not listed as a valid wake source in the DSDT (Differentiated System
Description Table) after booting to the OS.
BUG=b:351025543
TEST=Booted google/rex successfully and verified that the `_S3` name
variable is not present in the DSDT.
Change-Id: I730ade628eea84c60ba003a0c871e729b0ee0a9f
Signed-off-by: Subrata Banik <subratabanik(a)google.com>
---
M src/mainboard/google/rex/Kconfig
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/84081/1
diff --git a/src/mainboard/google/rex/Kconfig b/src/mainboard/google/rex/Kconfig
index 2ebcf32..c277725 100644
--- a/src/mainboard/google/rex/Kconfig
+++ b/src/mainboard/google/rex/Kconfig
@@ -19,7 +19,6 @@
select FW_CONFIG
select FW_CONFIG_SOURCE_CHROMEEC_CBI
select GOOGLE_SMBIOS_MAINBOARD_VERSION
- select HAVE_ACPI_RESUME
select HAVE_ACPI_TABLES
select I2C_TPM
select INTEL_LPSS_UART_FOR_CONSOLE
--
To view, visit https://review.coreboot.org/c/coreboot/+/84081?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I730ade628eea84c60ba003a0c871e729b0ee0a9f
Gerrit-Change-Number: 84081
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84080?usp=email )
Change subject: soc/intel/adl: Prevent unconditional legacy COM ports initialization
......................................................................
soc/intel/adl: Prevent unconditional legacy COM ports initialization
This patch eliminates the LPC_IOE_COMA_EN and LPC_IOE_COMB_EN IO enables
from the io_enables variable in the pch_early_iorange_init() function
because lpc_io_setup_comm_a_b() is intended to activate legacy COM
ports like COM-A (0x3F8 - 0x3FF) and COM_B (0x2F8 - 0x2FF).
These COM ports are being activated unconditionally, which is
undesirable for the Intel Alder Lake platform and causes traffic over
the IO bus.
As a result, this code is being removed and platforms that select
DRIVERS_UART_8250IO can activate legacy COM ports.
BUG=b:354066052
TEST=Able to boot google/redrix to OS.
Change-Id: I7a6e38bd151f823d37c07ee89a800489122cc209
Signed-off-by: Subrata Banik <subratabanik(a)google.com>
---
M src/soc/intel/alderlake/bootblock/pch.c
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/84080/1
diff --git a/src/soc/intel/alderlake/bootblock/pch.c b/src/soc/intel/alderlake/bootblock/pch.c
index 9041052..0115348 100644
--- a/src/soc/intel/alderlake/bootblock/pch.c
+++ b/src/soc/intel/alderlake/bootblock/pch.c
@@ -98,8 +98,7 @@
void pch_early_iorange_init(void)
{
- uint16_t io_enables = LPC_IOE_COMA_EN | LPC_IOE_COMB_EN |
- LPC_IOE_LPT_EN | LPC_IOE_FDD_EN |
+ uint16_t io_enables = LPC_IOE_LPT_EN | LPC_IOE_FDD_EN |
LPC_IOE_LGE_200 | LPC_IOE_HGE_208 |
LPC_IOE_KBC_60_64 | LPC_IOE_EC_62_66 |
LPC_IOE_SUPERIO_2E_2F | LPC_IOE_EC_4E_4F;
--
To view, visit https://review.coreboot.org/c/coreboot/+/84080?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7a6e38bd151f823d37c07ee89a800489122cc209
Gerrit-Change-Number: 84080
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Attention is currently required from: Felix Held, Felix Singer, Kapil Porwal, RONAK KANABAR, Subrata Banik.
KunYi Chen has posted comments on this change by KunYi Chen. ( https://review.coreboot.org/c/coreboot/+/83718?usp=email )
Change subject: vc/intel/fsp: Update ADL N FSP headers from v5021.00 to v5132.00
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> Regarding potential side effects on other mainboards, I understand that in principle, there should b […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/83718?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I96fccbb92866fbc18c57187628612fda655cd7a7
Gerrit-Change-Number: 83718
Gerrit-PatchSet: 3
Gerrit-Owner: KunYi Chen
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: RONAK KANABAR <ronak199323(a)gmail.com>
Gerrit-Reviewer: Subrata Banik <subi.banik(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Subrata Banik <subi.banik(a)gmail.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: RONAK KANABAR <ronak199323(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sat, 24 Aug 2024 14:36:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: KunYi Chen
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Felix Held, Felix Singer, Kapil Porwal, RONAK KANABAR, Subrata Banik.
KunYi Chen has posted comments on this change by KunYi Chen. ( https://review.coreboot.org/c/coreboot/+/83718?usp=email )
Change subject: vc/intel/fsp: Update ADL N FSP headers from v5021.00 to v5132.00
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
please review again
--
To view, visit https://review.coreboot.org/c/coreboot/+/83718?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I96fccbb92866fbc18c57187628612fda655cd7a7
Gerrit-Change-Number: 83718
Gerrit-PatchSet: 3
Gerrit-Owner: KunYi Chen
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: RONAK KANABAR <ronak199323(a)gmail.com>
Gerrit-Reviewer: Subrata Banik <subi.banik(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Subrata Banik <subi.banik(a)gmail.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: RONAK KANABAR <ronak199323(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sat, 24 Aug 2024 14:34:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/84072?usp=email )
Change subject: Update cmocka submodule to upstream master
......................................................................
Abandoned
some 3rdparty are a pain !
--
To view, visit https://review.coreboot.org/c/coreboot/+/84072?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9c41ee6c6a5fdd0105e39ea2e3927c4ec2d29ee1
Gerrit-Change-Number: 84072
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/84070?usp=email )
Change subject: Update intel-sec-tools submodule to upstream main
......................................................................
Abandoned
some 3rdparty are a pain !
--
To view, visit https://review.coreboot.org/c/coreboot/+/84070?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifc05f0d0be297b0206b590573244fb8048041c2a
Gerrit-Change-Number: 84070
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/84073?usp=email )
Change subject: [build test] move Wextra to Makefile.mk
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/84073?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I13d0e51919375711d6a6675ee80f546be357a6d1
Gerrit-Change-Number: 84073
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>