Felix Held has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83927?usp=email )
Change subject: soc/mediatek/mt8196: Add I2C driver support
......................................................................
Patch Set 20:
(1 comment)
File src/soc/mediatek/mt8196/i2c.c:
https://review.coreboot.org/c/coreboot/+/83927/comment/6071fd25_266645a9?us… :
PS20, Line 101: #define PAD_FUNC(name, func) {GPIO(name), PAD_##name##_FUNC_##func}
i'd suggest moving this define and also the PAD_FUNC_SEL define from the spi flash code to either the soc's gpio.h or the common mediatek gpio_common.h, since that seems to be gpio-related and only indirectly related to the spi or i2c
--
To view, visit https://review.coreboot.org/c/coreboot/+/83927?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I617ad8a43ce8b492b1a0e5dc06c1f0ffe7d92b5e
Gerrit-Change-Number: 83927
Gerrit-PatchSet: 20
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ot_hao.han(a)mediatek.com <ot_hao.han(a)mediatek.corp-partner.google.com>
Gerrit-Comment-Date: Sat, 24 Aug 2024 13:05:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83993?usp=email )
Change subject: mb/lenovo/thinkcentre_m710s: Drop PCH UPDs from PEG device
......................................................................
mb/lenovo/thinkcentre_m710s: Drop PCH UPDs from PEG device
Change-Id: Ic0e0864b99c5078e5b84b9183262b3c47ffcb329
Signed-off-by: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83993
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Angel Pons <th3fanbus(a)gmail.com>
Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
---
M src/mainboard/lenovo/thinkcentre_m710s/devicetree.cb
1 file changed, 0 insertions(+), 7 deletions(-)
Approvals:
Felix Singer: Looks good to me, approved
build bot (Jenkins): Verified
Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/lenovo/thinkcentre_m710s/devicetree.cb b/src/mainboard/lenovo/thinkcentre_m710s/devicetree.cb
index bce93ae..4d1828c 100644
--- a/src/mainboard/lenovo/thinkcentre_m710s/devicetree.cb
+++ b/src/mainboard/lenovo/thinkcentre_m710s/devicetree.cb
@@ -9,13 +9,6 @@
"SlotLengthLong"
"PCIE16X"
"SlotDataBusWidth16X"
-
- # These configurations are technically for PCIe root
- # ports. However, they are used as there is no
- # equivalent for PEG devices.
- register "PcieRpClkReqSupport[0]" = "true"
- register "PcieRpClkReqNumber[0]" = "2"
- register "PcieRpClkSrcNumber[0]" = "0"
end
device ref igpu on end
device ref south_xhci on
--
To view, visit https://review.coreboot.org/c/coreboot/+/83993?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic0e0864b99c5078e5b84b9183262b3c47ffcb329
Gerrit-Change-Number: 83993
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>