Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84089?usp=email )
Change subject: mb/qemu-i440fx/rom_media: Use MEM_REGION_DEV_INIT() for boot_dev
......................................................................
mb/qemu-i440fx/rom_media: Use MEM_REGION_DEV_INIT() for boot_dev
`boot_dev` can be const, and we can use MEM_REGION_DEV_INIT() as all
the values are known at compile time.
Change-Id: Icd3757ba4b5e8bfbee9e9c9d18bf0ee71520a8ac
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
M src/mainboard/emulation/qemu-i440fx/rom_media.c
1 file changed, 2 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/84089/1
diff --git a/src/mainboard/emulation/qemu-i440fx/rom_media.c b/src/mainboard/emulation/qemu-i440fx/rom_media.c
index d2469ba..f4fd3c3 100644
--- a/src/mainboard/emulation/qemu-i440fx/rom_media.c
+++ b/src/mainboard/emulation/qemu-i440fx/rom_media.c
@@ -97,7 +97,8 @@
}
static struct region_device_ops flash_ops;
-static struct mem_region_device boot_dev;
+static const struct mem_region_device boot_dev =
+ MEM_REGION_DEV_INIT(0x100000000ULL - CONFIG_ROM_SIZE, CONFIG_ROM_SIZE, &flash_ops);
/*
* Depending on how firmware image was passed to QEMU, it may behave as:
@@ -133,10 +134,6 @@
*/
flash_ops = mem_rdev_rw_ops;
- boot_dev.base = (void *)(uintptr_t)(0x100000000ULL - CONFIG_ROM_SIZE);
- boot_dev.rdev.ops = &flash_ops;
- boot_dev.rdev.region.size = CONFIG_ROM_SIZE;
-
/*
* Find first byte different than any of the commands, simplified.
*
--
To view, visit https://review.coreboot.org/c/coreboot/+/84089?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icd3757ba4b5e8bfbee9e9c9d18bf0ee71520a8ac
Gerrit-Change-Number: 84089
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84086?usp=email )
Change subject: payloads/Kconfig: Fix dependencies of PAYLOAD_FIT_SUPPORT
......................................................................
payloads/Kconfig: Fix dependencies of PAYLOAD_FIT_SUPPORT
Move config PAYLOAD_FIT_SUPPORT out of the `if !PAYLOAD_NONE'. It's
independent of the choice to add a payload right away.
Change-Id: I4b9cd13bf017d4afc30d1599ecc2faaf87bf0213
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
M payloads/Kconfig
1 file changed, 11 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/84086/1
diff --git a/payloads/Kconfig b/payloads/Kconfig
index ec1d40c..4948624 100644
--- a/payloads/Kconfig
+++ b/payloads/Kconfig
@@ -103,17 +103,6 @@
bool
default n
-config PAYLOAD_FIT_SUPPORT
- bool "FIT support"
- default n
- default y if PAYLOAD_LINUX && (ARCH_ARM || ARCH_ARM64 || ARCH_RISCV)
- depends on ARCH_ARM64 || ARCH_RISCV || ARCH_ARM
- select FLATTENED_DEVICE_TREE
- help
- Select this option if your payload is of type FIT.
- Enables FIT parser and devicetree patching. The FIT is non
- self-extracting and needs to have a compatible compression format.
-
config COMPRESS_SECONDARY_PAYLOAD
bool "Use LZMA compression for secondary payloads"
default y
@@ -191,4 +180,15 @@
endif # !PAYLOAD_NONE
+config PAYLOAD_FIT_SUPPORT
+ bool "FIT support"
+ default n
+ default y if PAYLOAD_LINUX && (ARCH_ARM || ARCH_ARM64 || ARCH_RISCV)
+ depends on ARCH_ARM64 || ARCH_RISCV || ARCH_ARM
+ select FLATTENED_DEVICE_TREE
+ help
+ Select this option if your payload is of type FIT.
+ Enables FIT parser and devicetree patching. The FIT is non
+ self-extracting and needs to have a compatible compression format.
+
endmenu
--
To view, visit https://review.coreboot.org/c/coreboot/+/84086?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4b9cd13bf017d4afc30d1599ecc2faaf87bf0213
Gerrit-Change-Number: 84086
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Attention is currently required from: Jakub Czapiga, Julius Werner, Maximilian Brune, Nico Huber, Philipp Hug, ron minnich.
Hello Jakub Czapiga, Julius Werner, Maximilian Brune, Philipp Hug, build bot (Jenkins), ron minnich,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79907?usp=email
to look at the new patch set (#9).
The following approvals got outdated and were removed:
Code-Review+1 by Julius Werner, Verified+1 by build bot (Jenkins)
Change subject: region: Hide struct region members
......................................................................
region: Hide struct region members
We cannot make `struct region` opaque for several reasons (size needs
to be known for local objects, a lot of inline API functions, ...).
However, we still want to encourage using the high-level region API
instead of directly accessing and manipulating the struct members.
This patch tries to achieve this by renaming the struct members. Only
if REGION_INTERNAL_STRUCTURES is defined before including <region.h>,
the usual member names are used.
Change-Id: I713be9cf0bab4c2e21113b55e7229ab50f06c6cf
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
M src/commonlib/include/commonlib/region.h
M src/commonlib/region.c
M tests/commonlib/Makefile.mk
M tests/commonlib/region-test.c
M tests/lib/cbfs-lookup-test.c
M tests/lib/fmap-test.c
6 files changed, 35 insertions(+), 25 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/79907/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/79907?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I713be9cf0bab4c2e21113b55e7229ab50f06c6cf
Gerrit-Change-Number: 79907
Gerrit-PatchSet: 9
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: coreboot org <coreboot.org(a)gmail.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Attention is currently required from: Jérémy Compostella.
Hello Jérémy Compostella,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84045?usp=email
to look at the new patch set (#17).
Change subject: [WIP]arch/x86: Make bootblock.ld LLD compatible
......................................................................
[WIP]arch/x86: Make bootblock.ld LLD compatible
Change-Id: I278c7199a25b7af77247c0e4fe52fe1c81c17a2a
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/arch/x86/bootblock.ld
M src/cpu/x86/reset16.S
2 files changed, 22 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/84045/17
--
To view, visit https://review.coreboot.org/c/coreboot/+/84045?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I278c7199a25b7af77247c0e4fe52fe1c81c17a2a
Gerrit-Change-Number: 84045
Gerrit-PatchSet: 17
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84069?usp=email )
Change subject: Docs/conf.py: Explicitly define external URL schemes
......................................................................
Docs/conf.py: Explicitly define external URL schemes
By default, any URL with a scheme of "http", "https", "ftp", or "mailto"
is treated as an external link. Since the "ircs" scheme is not included,
the IRC link in community/forums.md does not get resolved as an external
link, and instead tries to link to a header in the docs themselves. Fix
this by explicitly defining which schemes should resolve to external
links using the myst_url_schemes configuration option [1], which is now
set to the default schemes along with "ircs".
This fixes the "cross-reference target not found" warning for
'ircs://irc.libera.chat/#coreboot'
[1] https://myst-parser.readthedocs.io/en/latest/syntax/cross-referencing.html#…
Change-Id: I9e1c76b2bacbacaa06340f940c76b50de38e43e8
Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84069
Reviewed-by: Nico Huber <nico.h(a)gmx.de>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M Documentation/conf.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
build bot (Jenkins): Verified
Nico Huber: Looks good to me, approved
diff --git a/Documentation/conf.py b/Documentation/conf.py
index b0f2975..6284fca 100644
--- a/Documentation/conf.py
+++ b/Documentation/conf.py
@@ -23,6 +23,7 @@
extensions = ["myst_parser"]
myst_heading_anchors = 5
+myst_url_schemes = ["http", "https", "mailto", "ftp", "ircs"]
templates_path = ['_templates']
exclude_patterns = ['_build', 'Thumbs.db', '.DS_Store']
--
To view, visit https://review.coreboot.org/c/coreboot/+/84069?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9e1c76b2bacbacaa06340f940c76b50de38e43e8
Gerrit-Change-Number: 84069
Gerrit-PatchSet: 3
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: Arthur Heymans.
Nicholas Sudsgaard has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84041?usp=email )
Change subject: drivers/intel/opregion.c: Also set vbt_size if size is 0
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84041?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4fcc6c02f898640e9b40d769e1165a4a0fb0fdf2
Gerrit-Change-Number: 84041
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Sun, 25 Aug 2024 13:18:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Jérémy Compostella.
Hello Jérémy Compostella,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84045?usp=email
to look at the new patch set (#16).
Change subject: [WIP]arch/x86: Make bootblock.ld LLD compatible
......................................................................
[WIP]arch/x86: Make bootblock.ld LLD compatible
Change-Id: I278c7199a25b7af77247c0e4fe52fe1c81c17a2a
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/arch/x86/bootblock.ld
M src/cpu/x86/reset16.S
2 files changed, 15 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/84045/16
--
To view, visit https://review.coreboot.org/c/coreboot/+/84045?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I278c7199a25b7af77247c0e4fe52fe1c81c17a2a
Gerrit-Change-Number: 84045
Gerrit-PatchSet: 16
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>