Attention is currently required from: Jarried Lin, Mingjin Ge.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84024?usp=email )
Change subject: mb/google/rauru: reset usb hub in bootblock
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/google/rauru/bootblock.c:
https://review.coreboot.org/c/coreboot/+/84024/comment/7b22b8be_fe2f7a21?us… :
PS7, Line 4: #include "gpio.h"
Put it in a separate section. See geralt/bootblock.c as an example.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84024?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iea793b4b04bd009d0354e2331604bccf30466a23
Gerrit-Change-Number: 84024
Gerrit-PatchSet: 7
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Mingjin Ge <mingjin.ge(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Mingjin Ge <mingjin.ge(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Comment-Date: Mon, 26 Aug 2024 06:06:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Hung-Te Lin, Jarried Lin, Mingjin Ge, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84023?usp=email )
Change subject: soc/mediatek/mt8196: add usb host support
......................................................................
Patch Set 7:
(3 comments)
File src/soc/mediatek/mt8196/usb.c:
https://review.coreboot.org/c/coreboot/+/84023/comment/688ec97c_3517b3d2?us… :
PS7, Line 10: #include <gpio.h>
: #include <soc/pll_common.h>
Do we need these?
https://review.coreboot.org/c/coreboot/+/84023/comment/398d76c3_4801352b?us… :
PS7, Line 18: force
change
https://review.coreboot.org/c/coreboot/+/84023/comment/c419c3fe_4ec3ee10?us… :
PS7, Line 18: set
sets
--
To view, visit https://review.coreboot.org/c/coreboot/+/84023?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia4efcddac9bf5e04e688648a5c22384075a0b026
Gerrit-Change-Number: 84023
Gerrit-PatchSet: 7
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Mingjin Ge <mingjin.ge(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Mingjin Ge <mingjin.ge(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Comment-Date: Mon, 26 Aug 2024 06:05:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Jarried Lin, Mingjin Ge.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84022?usp=email )
Change subject: mb/google/rauru: add usb host support
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/google/rauru/mainboard.c:
https://review.coreboot.org/c/coreboot/+/84022/comment/801607ec_bab9c81f?us… :
PS7, Line 8: add mainboard init
Now this function isn't a no-op anymore. Please either remove the comment (which I prefer) or change it to something to be done (such as audio).
--
To view, visit https://review.coreboot.org/c/coreboot/+/84022?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5d081ff3e7367b87fab5ebdcb148c9005ab583f5
Gerrit-Change-Number: 84022
Gerrit-PatchSet: 7
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Mingjin Ge <mingjin.ge(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Mingjin Ge <mingjin.ge(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Comment-Date: Mon, 26 Aug 2024 06:01:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, Zhanzhan Ge.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83928?usp=email )
Change subject: soc/mediatek/mt8196: Fix timer reset in BL31
......................................................................
Patch Set 20:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83928/comment/5da44a55_49679356?us… :
PS8, Line 9: 1. Set systimer compensation to version 2.0.
: 2. The system does not need to serve pending IRQ from systimer
: after rebooting. Therefore we clear systimer IRQ pending bit
: at early booting.
> 1 and 2 are related, 1 fixes to you, 2 fixes potential issues, but 2 depends on 1, so there is no ne […]
Okay, then they can be in the same patch. However, please explain the dependency in the commit message. It doesn't seem clear to me.
File src/soc/mediatek/mt8196/timer_prepare.c:
https://review.coreboot.org/c/coreboot/+/83928/comment/3696e970_2c949ca0?us… :
PS8, Line 18: &mtk_systimer->cnttval[id].con
> Hi, mtk_systimer is already a local variable, thank you
I mean another variable, so that we don't need to perform duplicate `->cnttval[id].con` lookup.
https://review.coreboot.org/c/coreboot/+/83928/comment/2062b667_58107d71?us… :
PS8, Line 28: clrbits32
> The difference between clrbits32 and clrbits32p is whether the first parameter is a pointer
Exactly, so there's no need to cast `SYSTIMER_BASE` to `void *`. Otherwise, why do you think coreboot has `clrbits32p` to begin with?
--
To view, visit https://review.coreboot.org/c/coreboot/+/83928?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I520986b81ca153ec3ce56558a80619448cfc0c59
Gerrit-Change-Number: 83928
Gerrit-PatchSet: 20
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Zhanzhan Ge <zhanzhan.ge(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Zhanzhan Ge <zhanzhan.ge(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Comment-Date: Mon, 26 Aug 2024 05:59:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Zhanzhan Ge <zhanzhan.ge(a)mediatek.corp-partner.google.com>
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Nick Vaccaro, Subrata Banik, Tarun.
Eric Lai has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/84081?usp=email )
Change subject: mainboard/google/rex: Remove HAVE_ACPI_RESUME for Intel Meteor Lake
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84081?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I730ade628eea84c60ba003a0c871e729b0ee0a9f
Gerrit-Change-Number: 84081
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-Comment-Date: Mon, 26 Aug 2024 03:34:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes