coreboot-gerrit July 2024

coreboot-gerrit@coreboot.org

1 participants
3025 discussions

[XS] Change in coreboot[main]: 3rdparty/fsp: Update submodule to upstream master
by Werner Zeh (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Felix Singer, Lean Sheng Tan. Werner Zeh has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83294?usp=email ) Change subject: 3rdparty/fsp: Update submodule to upstream master ...................................................................... Patch Set 3: (1 comment) File src/soc/intel/elkhartlake/Kconfig: https://review.coreboot.org/c/coreboot/+/83294/comment/525c8c58_70ad466d?us… : PS3, Line 195: FSPRel.bin" We just recently changed it in CB:81344. Are you sure we nedd to change it back? I do not see newer patches on Elkhart Lake FSP that requires the change. -- To view, visit https://review.coreboot.org/c/coreboot/+/83294?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I47013bce65054f2c496c9aa7c16e55b51d65e5fe Gerrit-Change-Number: 83294 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Mon, 01 Jul 2024 14:46:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/google/geralt: change config to FW_config for support TAS2563 audi...
by Yidi Lin (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Hung-Te Lin, Paul Menzel, Rui Zhou, cong yang. Yidi Lin has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/83287?usp=email ) Change subject: mb/google/geralt: change config to FW_config for support TAS2563 audio amp ...................................................................... Patch Set 9: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/83287/comment/9682bf56_13097a73?us… : PS9, Line 9: In order to support the judgment of FW_CONFIG, we change the config : GERALT_USE_MAX98390 to FW_CONFIG and add the relevant configuration : of devicetree. In addition, we delete the unused GERALT_USE_MAX98390. Use FW_CONFIG to differentiate MAX98390 and TAS2563. Since config GERALT_USE_MAX98390 is no longer needed after using FW_CONFIG, we remove GERALT_USE_MAX98390 from Kconfig. -- To view, visit https://review.coreboot.org/c/coreboot/+/83287?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie9f0cbc30dd950b85581fc1924fa351efe1e0aab Gerrit-Change-Number: 83287 Gerrit-PatchSet: 9 Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Mon, 01 Jul 2024 14:39:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: Revert "util/crossgcc: Update ACPICA from 20230628 to 20240321"
by Felix Singer (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Elyes Haouas, Martin L Roth, Maximilian Brune. Felix Singer has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83296?usp=email ) Change subject: Revert "util/crossgcc: Update ACPICA from 20230628 to 20240321" ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > Though, I've build-tested QEMU Q35 and that worked. Not sure why that didn't work for you. […] I looked into the tarball and it seems they actually packaged the sources from 20230628. -- To view, visit https://review.coreboot.org/c/coreboot/+/83296?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3ce0c5798f14162eaa063a9a64e16e6dbbb9e468 Gerrit-Change-Number: 83296 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 01 Jul 2024 14:27:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com>

1 0

[XS] Change in coreboot[main]: Revert "util/crossgcc: Update ACPICA from 20230628 to 20240321"
by Felix Singer (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Elyes Haouas, Martin L Roth, Maximilian Brune. Felix Singer has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83296?usp=email ) Change subject: Revert "util/crossgcc: Update ACPICA from 20230628 to 20240321" ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > Confirmed. iasl --version says […] Though, I've build-tested QEMU Q35 and that worked. Not sure why that didn't work for you. The coreboot build system only looks for the coreboot version string in the compilers, which is available here. ``` coreboot toolchain v2024-05-20_b4949d3de5 ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/83296?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3ce0c5798f14162eaa063a9a64e16e6dbbb9e468 Gerrit-Change-Number: 83296 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 01 Jul 2024 14:22:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com>

1 0

[S] Change in coreboot[main]: mb/google/geralt: change config to FW_config for support TAS2563 audi...
by Yu-Ping Wu (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Hung-Te Lin, Paul Menzel, Rui Zhou, Yidi Lin, cong yang. Yu-Ping Wu has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/83287?usp=email ) Change subject: mb/google/geralt: change config to FW_config for support TAS2563 audio amp ...................................................................... Patch Set 9: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/83287/comment/4f0e3aee_5b640d4a?us… : PS9, Line 7: change config to FW_config for support TAS2563 audio amp Replace GERALT_USE_MAX98390 with FW_CONFIG for TAS2563 -- To view, visit https://review.coreboot.org/c/coreboot/+/83287?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie9f0cbc30dd950b85581fc1924fa351efe1e0aab Gerrit-Change-Number: 83287 Gerrit-PatchSet: 9 Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Mon, 01 Jul 2024 14:16:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: Revert "util/crossgcc: Update ACPICA from 20230628 to 20240321"
by Felix Singer (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Elyes Haouas, Martin L Roth, Maximilian Brune. Felix Singer has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83296?usp=email ) Change subject: Revert "util/crossgcc: Update ACPICA from 20230628 to 20240321" ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > > The github release has got the correct version. The issue seems to come from the intel mirror. […] Confirmed. iasl --version says ``` ASL+ Optimizing Compiler/Disassembler version 20230628 ``` *table flip* -- To view, visit https://review.coreboot.org/c/coreboot/+/83296?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3ce0c5798f14162eaa063a9a64e16e6dbbb9e468 Gerrit-Change-Number: 83296 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 01 Jul 2024 14:14:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com>

1 0

[XS] Change in coreboot[main]: Revert "util/crossgcc: Update ACPICA from 20230628 to 20240321"
by Felix Singer (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Elyes Haouas, Martin L Roth, Maximilian Brune. Felix Singer has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83296?usp=email ) Change subject: Revert "util/crossgcc: Update ACPICA from 20230628 to 20240321" ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > The github release has got the correct version. The issue seems to come from the intel mirror. So we could just switch to github for ACPICA. > Oh I see we have only just recently switched to the intel mirror: CB:80721 (so I guess that is not an option then?) We switched to the Intel mirror because the GitHub tarballs are not stable and hashes change with time. -- To view, visit https://review.coreboot.org/c/coreboot/+/83296?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3ce0c5798f14162eaa063a9a64e16e6dbbb9e468 Gerrit-Change-Number: 83296 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 01 Jul 2024 14:06:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com>

1 0

[XL] Change in coreboot[main]: mb/system76/mtl: Add Lemur Pro 13
by Tim Crawford (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Jeremy Soller, Paul Menzel. Hello Jeremy Soller, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82788?usp=email to look at the new patch set (#3). Change subject: mb/system76/mtl: Add Lemur Pro 13 ...................................................................... mb/system76/mtl: Add Lemur Pro 13 The Lemur Pro 13 (lemp13) is an Intel Meteor Lake-U based board. There are 2 variants to differentiate which keyboard design the unit uses, as they require different EC firmware. Change-Id: Icac8c7dafd6371881622d797f399f8ddbe13cbce Signed-off-by: Jeremy Soller <jeremy(a)system76.com> Signed-off-by: Tim Crawford <tcrawford(a)system76.com> --- M src/mainboard/system76/mtl/Kconfig M src/mainboard/system76/mtl/Kconfig.name M src/mainboard/system76/mtl/Makefile.mk A src/mainboard/system76/mtl/spd/samsung-M425R1GB4BB0-CQKOD.spd.hex A src/mainboard/system76/mtl/spd/samsung-M425R1GB4PB0-CWMOD.spd.hex A src/mainboard/system76/mtl/variants/lemp13/board.fmd A src/mainboard/system76/mtl/variants/lemp13/board_info.txt A src/mainboard/system76/mtl/variants/lemp13/data.vbt A src/mainboard/system76/mtl/variants/lemp13/gpio.c A src/mainboard/system76/mtl/variants/lemp13/gpio_early.c A src/mainboard/system76/mtl/variants/lemp13/hda_verb.c A src/mainboard/system76/mtl/variants/lemp13/overridetree.cb A src/mainboard/system76/mtl/variants/lemp13/ramstage.c A src/mainboard/system76/mtl/variants/lemp13/romstage.c A src/mainboard/system76/mtl/variants/lemp13/tas5825m.c 15 files changed, 1,672 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/82788/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/82788?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icac8c7dafd6371881622d797f399f8ddbe13cbce Gerrit-Change-Number: 82788 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[M] Change in coreboot[main]: arch/riscv: Factor out common romstage code
by Felix Held (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Arthur Heymans, Maximilian Brune, Philipp Hug, Ron Minnich. Felix Held has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83098?usp=email ) Change subject: arch/riscv: Factor out common romstage code ...................................................................... Patch Set 5: (1 comment) File src/mainboard/sifive/hifive-unmatched/romstage.c: https://review.coreboot.org/c/coreboot/+/83098/comment/18db9cc6_c967ad1a?us… : PS5, Line 19: console_init(); console_init is already called in the common code before calling this function. does the console_init have some dependency on clock_init or should uart_init be called after clock_init like it's done in hifive-unleashed? -- To view, visit https://review.coreboot.org/c/coreboot/+/83098?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ieb11d2644bf42dacf89ef15b2ec51286fe729d64 Gerrit-Change-Number: 83098 Gerrit-PatchSet: 5 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Mon, 01 Jul 2024 14:03:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: Revert "util/crossgcc: Update ACPICA from 20230628 to 20240321"
by Felix Singer (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Elyes Haouas, Martin L Roth, Maximilian Brune. Felix Singer has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83296?usp=email ) Change subject: Revert "util/crossgcc: Update ACPICA from 20230628 to 20240321" ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > The github release has got the correct version. The issue seems to come from the intel mirror. […] ACPICA is so much depressing. Why can't they get their stuff right? Anyway, thanks. I'm just trying to reproduce the issue in a clean environment. -- To view, visit https://review.coreboot.org/c/coreboot/+/83296?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3ce0c5798f14162eaa063a9a64e16e6dbbb9e468 Gerrit-Change-Number: 83296 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 01 Jul 2024 14:03:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2024