coreboot-gerrit July 2024

coreboot-gerrit@coreboot.org

1 participants
3025 discussions

[XS] Change in coreboot[main]: util/crossgcc: Update ACPICA from 20230628 to 20240321
by Maximilian Brune (Code Review) 01 Jul '24

01 Jul '24

Maximilian Brune has created a revert of this change. ( https://review.coreboot.org/c/coreboot/+/81671?usp=email ) Change subject: util/crossgcc: Update ACPICA from 20230628 to 20240321 ...................................................................... -- To view, visit https://review.coreboot.org/c/coreboot/+/81671?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: revert Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I41f56ba58af51b1ec1d7554fb35a49ccf9e778f6 Gerrit-Change-Number: 81671 Gerrit-PatchSet: 7 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>

1 0

[XS] Change in coreboot[main]: Revert "util/crossgcc: Update ACPICA from 20230628 to 20240321"
by Maximilian Brune (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Elyes Haouas, Felix Singer, Martin L Roth. Hello Felix Singer, build bot (Jenkins), Martin L Roth, Elyes Haouas, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/83296?usp=email to review the following change. Change subject: Revert "util/crossgcc: Update ACPICA from 20230628 to 20240321" ...................................................................... Revert "util/crossgcc: Update ACPICA from 20230628 to 20240321" This reverts commit 41fdb882f1f0c3cda41651c2e9c920580415a0dc. Reason for revert: The version downloaded does not match the version that is printed out when executing `iasl --version`. Coreboot notices that and refuses to compile QEMU-Q35 mainboard. I tested it on 2 different PCs. Change-Id: I3ce0c5798f14162eaa063a9a64e16e6dbbb9e468 TODO: Someone please confirm --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix-20230628_iasl.patch A util/crossgcc/sum/acpica-unix-20230628.tar.gz.cksum D util/crossgcc/sum/acpica-unix-20240321.tar.gz.cksum 4 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/83296/1 diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index c35fc78..0691a5f2 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -40,7 +40,7 @@ MPC_VERSION=1.3.1 GCC_VERSION=13.2.0 BINUTILS_VERSION=2.42 -IASL_VERSION=20240321 +IASL_VERSION="20230628" # CLANG version number CLANG_VERSION=17.0.6 CMAKE_VERSION=3.29.3 @@ -74,7 +74,7 @@ MPC_BASE_URL="https://ftpmirror.gnu.org/mpc" GCC_BASE_URL="https://ftpmirror.gnu.org/gcc/gcc-${GCC_VERSION}" BINUTILS_BASE_URL="https://ftpmirror.gnu.org/binutils" -IASL_BASE_URL="https://downloadmirror.intel.com/819451" +IASL_BASE_URL="https://downloadmirror.intel.com/783534" # CLANG toolchain archive locations LLVM_BASE_URL="https://github.com/llvm/llvm-project/releases/download/llvmorg-${CLANG_VERS…" CLANG_BASE_URL="https://github.com/llvm/llvm-project/releases/download/llvmorg-${CLANG_VERS…" diff --git a/util/crossgcc/patches/acpica-unix-20240321_iasl.patch b/util/crossgcc/patches/acpica-unix-20230628_iasl.patch similarity index 100% rename from util/crossgcc/patches/acpica-unix-20240321_iasl.patch rename to util/crossgcc/patches/acpica-unix-20230628_iasl.patch diff --git a/util/crossgcc/sum/acpica-unix-20230628.tar.gz.cksum b/util/crossgcc/sum/acpica-unix-20230628.tar.gz.cksum new file mode 100644 index 0000000..9b676bb --- /dev/null +++ b/util/crossgcc/sum/acpica-unix-20230628.tar.gz.cksum @@ -0,0 +1 @@ +3b893fb771cf3fbd3531de3036e1a5bfc624c9d2 tarballs/acpica-unix-20230628.tar.gz diff --git a/util/crossgcc/sum/acpica-unix-20240321.tar.gz.cksum b/util/crossgcc/sum/acpica-unix-20240321.tar.gz.cksum deleted file mode 100644 index e7b7afe..0000000 --- a/util/crossgcc/sum/acpica-unix-20240321.tar.gz.cksum +++ /dev/null @@ -1 +0,0 @@ -19f5b03de6de059a95432d17ed24095262a97aba tarballs/acpica-unix-20240321.tar.gz -- To view, visit https://review.coreboot.org/c/coreboot/+/83296?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3ce0c5798f14162eaa063a9a64e16e6dbbb9e468 Gerrit-Change-Number: 83296 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[L] Change in coreboot[main]: treewide: Add generation of CFR Tables
by Angel Pons (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Arthur Heymans, Martin L Roth, Maximilian Brune. Angel Pons has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/82494?usp=email ) Change subject: treewide: Add generation of CFR Tables ...................................................................... Patch Set 7: (1 comment) File src/lib/coreboot_table.c: https://review.coreboot.org/c/coreboot/+/82494/comment/cf212da8_af4ee30f?us… : PS7, Line 568: __weak > Then you have another weak function. […] Well, this function would stop being weak. And weak no-op functions are "OK". Alternatively, don't provide an empty weak definition and introduce a Kconfig symbol to guard the `mainboard_update_sot_table()` function call. -- To view, visit https://review.coreboot.org/c/coreboot/+/82494?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3408e9166139a95b7dcf4b151472a01951597133 Gerrit-Change-Number: 82494 Gerrit-PatchSet: 7 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 01 Jul 2024 13:34:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

[L] Change in coreboot[main]: treewide: Add generation of CFR Tables
by Maximilian Brune (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Angel Pons, Arthur Heymans, Martin L Roth. Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/82494?usp=email ) Change subject: treewide: Add generation of CFR Tables ...................................................................... Patch Set 7: (2 comments) File src/lib/coreboot_table.c: https://review.coreboot.org/c/coreboot/+/82494/comment/fce927eb_008f8fec?us… : PS7, Line 568: __weak > What does Atlas need to do? If possible, I'd suggest having something like `void __weak mainboard_up […] Then you have another weak function. But I see that having an extra specific `mainboard_*` weak function might be beneficial. https://review.coreboot.org/c/coreboot/+/82494/comment/5ef55a40_079e00bc?us… : PS7, Line 575: size_t size = cbfs_load("fallback/sot", sot_buf, MAX_SOT_SIZE); > Is there a way to get the uncompressed size of a CBFS file at runtime? If so, it would be nice to us […] I guess I could just use `cbfs_cbmem_alloc()`. Will try that. -- To view, visit https://review.coreboot.org/c/coreboot/+/82494?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3408e9166139a95b7dcf4b151472a01951597133 Gerrit-Change-Number: 82494 Gerrit-PatchSet: 7 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 01 Jul 2024 13:26:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

[S] Change in coreboot[main]: cpu/intel/model_206ax: Allow PL1/PL2 configuration
by Anastasios Koutian (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Angel Pons, Patrick Rudolph, Paul Menzel. Anastasios Koutian has posted comments on this change by Anastasios Koutian. ( https://review.coreboot.org/c/coreboot/+/83269?usp=email ) Change subject: cpu/intel/model_206ax: Allow PL1/PL2 configuration ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/83269/comment/7dbb2d1a_2ddd6c3c?us… : PS2, Line 9: Tested on ThinkPad T420 with the i7-3940XM. > Set pl1=35000000 and pl2=43750000 microwatts in t420/devicetree.cb […] Correction, `$ sudo iotools mmio_read32 "${MCH_PKG_POWER_LIMIT_LO}"` => 0x0000815e should be `$ sudo iotools mmio_read32 "${MCH_PKG_POWER_LIMIT_HI}"` => 0x0000815e -- To view, visit https://review.coreboot.org/c/coreboot/+/83269?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I064af25ec4805fae755eea52c4c9c6d4386c0aee Gerrit-Change-Number: 83269 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasios Koutian <akoutian2(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 01 Jul 2024 13:16:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasios Koutian <akoutian2(a)gmail.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[S] Change in coreboot[main]: cpu/intel/model_206ax: Allow PL1/PL2 configuration
by Anastasios Koutian (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Angel Pons, Patrick Rudolph, Paul Menzel. Anastasios Koutian has posted comments on this change by Anastasios Koutian. ( https://review.coreboot.org/c/coreboot/+/83269?usp=email ) Change subject: cpu/intel/model_206ax: Allow PL1/PL2 configuration ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/83269/comment/afe7f342_ecb8985f?us… : PS2, Line 9: Tested on ThinkPad T420 with the i7-3940XM. > Can you please elaborate, how you tested this? Set pl1=35000000 and pl2=43750000 microwatts in t420/devicetree.cb Built and flashed Confirmed power limits are 35000000 and 43750000 in sysfs intel-rapl-msr interface: `$ cat /sys/devices/virtual/powercap/intel-rapl/intel-rapl:0/constraint_0_power_limit_uw` and `$ cat /sys/devices/virtual/powercap/intel-rapl/intel-rapl:0/constraint_1_power_limit_uw` Also confirmed the same limits are applied in MCHBAR: `$ MSR_PKG_POWER_LIMIT=0x610` `$ MCH_PKG_POWER_LIMIT_LO=0xfed159a0` `$ MCH_PKG_POWER_LIMIT_HI=0xfed159a4` `$ sudo iotools mmio_read32 "${MCH_PKG_POWER_LIMIT_LO}"` => 0x00dc8118 `$ sudo iotools mmio_read32 "${MCH_PKG_POWER_LIMIT_LO}"` => 0x0000815e `$ sudo rdmsr -c "${MSR_PKG_POWER_LIMIT}"` => 0x815e00dc8118 Finally, run stress test: `$ stress-ng -c 8 --cpu-method matrixprod` while monitoring processor package power using Intel PCM (https://github.com/intel/pcm) -- To view, visit https://review.coreboot.org/c/coreboot/+/83269?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I064af25ec4805fae755eea52c4c9c6d4386c0aee Gerrit-Change-Number: 83269 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasios Koutian <akoutian2(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 01 Jul 2024 13:09:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[S] Change in coreboot[main]: mb/google/geralt: change config to FW_config for support TAS2563 audi...
by Rui Zhou (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu, cong yang. Rui Zhou has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/83287?usp=email ) Change subject: mb/google/geralt: change config to FW_config for support TAS2563 audio amp ...................................................................... Patch Set 9: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/83287/comment/36f78194_524018b4?us… : PS8, Line 7: support TAS2563 audio amp > You also change other logic, don’t you, that fw_config is used for `GERALT_USE_MAX98390`. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/83287?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie9f0cbc30dd950b85581fc1924fa351efe1e0aab Gerrit-Change-Number: 83287 Gerrit-PatchSet: 9 Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Mon, 01 Jul 2024 13:00:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[S] Change in coreboot[main]: mb/google/geralt: change config to FW_config for support TAS2563 audi...
by Rui Zhou (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Hung-Te Lin, Rui Zhou, Yidi Lin, Yu-Ping Wu, cong yang. Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), cong yang, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83287?usp=email to look at the new patch set (#9). The following approvals got outdated and were removed: Code-Review+2 by Yidi Lin, Code-Review+2 by Yu-Ping Wu, Verified+1 by build bot (Jenkins) Change subject: mb/google/geralt: change config to FW_config for support TAS2563 audio amp ...................................................................... mb/google/geralt: change config to FW_config for support TAS2563 audio amp In order to support the judgment of FW_CONFIG, we change the config GERALT_USE_MAX98390 to FW_CONFIG and add the relevant configuration of devicetree. In addition, we delete the unused GERALT_USE_MAX98390. BUG=b:345629159 BRANCH=none TEST=emerge-GERALT coreboot TEST=Verify beep function through deploy in depthcharge successfully. Change-Id: Ie9f0cbc30dd950b85581fc1924fa351efe1e0aab Signed-off-by: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/geralt/Kconfig M src/mainboard/google/geralt/chromeos.c M src/mainboard/google/geralt/devicetree.cb M src/mainboard/google/geralt/mainboard.c 4 files changed, 21 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/83287/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/83287?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie9f0cbc30dd950b85581fc1924fa351efe1e0aab Gerrit-Change-Number: 83287 Gerrit-PatchSet: 9 Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com>

1 0

[M] Change in coreboot[main]: 3rdparty/open-power-signing-utils: add SecureBoot utility for OpenPOWER
by Krystian Hebel (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Arthur Heymans, Sergii Dmytruk. Krystian Hebel has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/coreboot/+/67065?usp=email ) Change subject: 3rdparty/open-power-signing-utils: add SecureBoot utility for OpenPOWER ...................................................................... Patch Set 38: Code-Review-1 (1 comment) Patchset: PS38: Talos II firmware enabled secure boot in 2.10 by default [1], so this will no longer be enough. Created image should be signed with all 3 HW keys as well as the OS key. [1] https://wiki.raptorcs.com/wiki/Talos_II/Firmware/2.10/Release_Notes -- To view, visit https://review.coreboot.org/c/coreboot/+/67065?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id88baef5ecb1f8ffd74a7f464bbbaaaea0ca643d Gerrit-Change-Number: 67065 Gerrit-PatchSet: 38 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Patrick Georgi Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Mon, 01 Jul 2024 12:49:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: treewide: Add generation of CFR Tables
by Angel Pons (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Arthur Heymans, Martin L Roth, Maximilian Brune. Angel Pons has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/82494?usp=email ) Change subject: treewide: Add generation of CFR Tables ...................................................................... Patch Set 7: (2 comments) File src/lib/coreboot_table.c: https://review.coreboot.org/c/coreboot/+/82494/comment/48c459bf_45623fd7?us… : PS7, Line 568: __weak > There is a use case on the prodrive atlas baord, that needs to update the SOT tables in runtime (so […] What does Atlas need to do? If possible, I'd suggest having something like `void __weak mainboard_update_sot_table(void *sot_buf, size_t size) {}` (empty weak definition) and call it from `write_sot_table()`. https://review.coreboot.org/c/coreboot/+/82494/comment/55dd46d1_e5d026e2?us… : PS7, Line 575: size_t size = cbfs_load("fallback/sot", sot_buf, MAX_SOT_SIZE); Is there a way to get the uncompressed size of a CBFS file at runtime? If so, it would be nice to use it to avoid allocating and then deallocating stuff in CBMEM, as well as to log a more detailed error when SOT size exceeds `MAX_SOT_SIZE` (and by how much). -- To view, visit https://review.coreboot.org/c/coreboot/+/82494?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3408e9166139a95b7dcf4b151472a01951597133 Gerrit-Change-Number: 82494 Gerrit-PatchSet: 7 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 01 Jul 2024 12:22:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2024