Attention is currently required from: Anastasios Koutian, Angel Pons, Patrick Rudolph, Paul Menzel.
Nico Huber has posted comments on this change by Anastasios Koutian. ( https://review.coreboot.org/c/coreboot/+/83269?usp=email )
Change subject: cpu/intel/model_206ax: Allow PL1/PL2 configuration
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
File src/cpu/intel/model_206ax/chip.h:
https://review.coreboot.org/c/coreboot/+/83269/comment/55805558_c6bf4b3c?us… :
PS1, Line 46: int pl1; /* Long-term power limit*/
: int pl2; /* Short-term power limit*/
> Done
No too strong feelings about this, but I suggest to change it to milliwatts.
Having all those zeros attached and having to count them every time when
reading a value seems unnecessary. Even if we pretend not to know the
`power_unit` (we do know, though, it's always 8 for these chips. and
given the 15-bit width of the programmed value, we also know it (the
`power_unit`) has to be <1000).
Now I've also noticed that the `unsigned int` could easily overflow if
`power_unit` was much higher. Microwatts just doesn't feel right.
File src/cpu/intel/model_206ax/model_206ax_init.c:
https://review.coreboot.org/c/coreboot/+/83269/comment/2beb1107_4dcff92a?us… :
PS1, Line 99: dev->upstream->dev->upstream->children->chip_info;
> Yeah, you're right. I didn't know we model a single chip as two in the devicetree.
Merged CB:83275. Please rebase.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83269?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I064af25ec4805fae755eea52c4c9c6d4386c0aee
Gerrit-Change-Number: 83269
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasios Koutian <akoutian2(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Anastasios Koutian <akoutian2(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Mon, 01 Jul 2024 15:37:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Anastasios Koutian <akoutian2(a)gmail.com>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Attention is currently required from: Jérémy Compostella, Simon Glass.
Martin Roth has posted comments on this change by Simon Glass. ( https://review.coreboot.org/c/coreboot/+/79594?usp=email )
Change subject: Post-build control of serial
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
I'm not sure if this intends to just silence the serial console or all consoles. It looks like it does different things in different places.
By the name, it seems like it should be silencing *all* consoles, and seems to do that in some places by completely suppressing console_init. In others it just looks to disable serial.
If this is just intended to silence the uart console, the option should probably be renamed and just placed into the uart code path.
--
To view, visit https://review.coreboot.org/c/coreboot/+/79594?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibd867950f117cc6b3dbc582505f3983a0dd714fb
Gerrit-Change-Number: 79594
Gerrit-PatchSet: 4
Gerrit-Owner: Simon Glass <sjg(a)chromium.org>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Simon Glass <sjg(a)chromium.org>
Gerrit-Comment-Date: Mon, 01 Jul 2024 15:37:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Felix Singer, Martin L Roth, Maximilian Brune.
Elyes Haouas has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83296?usp=email )
Change subject: Revert "util/crossgcc: Update ACPICA from 20230628 to 20240321"
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> if we compile from git source, the version is ok, but if we compile from downloaded tarball, w'll ha […]
https://github.com/acpica/acpica/issues/958
--
To view, visit https://review.coreboot.org/c/coreboot/+/83296?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3ce0c5798f14162eaa063a9a64e16e6dbbb9e468
Gerrit-Change-Number: 83296
Gerrit-PatchSet: 3
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Comment-Date: Mon, 01 Jul 2024 15:28:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com>
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Attention is currently required from: Arthur Heymans, Felix Held, Julius Werner, Jérémy Compostella, Karthik Ramasubramanian, Paul Menzel, Simon Glass, Simon Glass.
Martin Roth has posted comments on this change by Simon Glass. ( https://review.coreboot.org/c/coreboot/+/77712?usp=email )
Change subject: Introduce a coreboot Control Block (CCB)
......................................................................
Patch Set 12:
(1 comment)
File src/lib/ccb.c:
https://review.coreboot.org/c/coreboot/+/77712/comment/f4e431fb_5a840602?us… :
PS12, Line 82: BUG()
return NULL after this to avoid returning an uninitialized ccb variable?
--
To view, visit https://review.coreboot.org/c/coreboot/+/77712?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I04e946b33035a493e833500351a0483761252613
Gerrit-Change-Number: 77712
Gerrit-PatchSet: 12
Gerrit-Owner: Simon Glass <sjg(a)chromium.org>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Simon Glass <sjg(a)chromium.org>
Gerrit-Attention: Simon Glass <sjg(a)chromium.org>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Simon Glass <sjg(a)chromium.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 01 Jul 2024 15:24:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Felix Singer, Martin L Roth, Maximilian Brune.
Elyes Haouas has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83296?usp=email )
Change subject: Revert "util/crossgcc: Update ACPICA from 20230628 to 20240321"
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> I looked into the tarball and it seems they actually packaged the sources from 20230628.
if we compile from git source, the version is ok, but if we compile from downloaded tarball, w'll have " ASL+ Optimizing Compiler/Disassembler version 20230628"
--
To view, visit https://review.coreboot.org/c/coreboot/+/83296?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3ce0c5798f14162eaa063a9a64e16e6dbbb9e468
Gerrit-Change-Number: 83296
Gerrit-PatchSet: 3
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Comment-Date: Mon, 01 Jul 2024 15:20:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com>
Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/83297?usp=email )
Change subject: test build IASL
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/83297?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I05a25cefe042411c5ea94b8175c109574ee8ee00
Gerrit-Change-Number: 83297
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Attention is currently required from: Hung-Te Lin, Paul Menzel, Rui Zhou, cong yang.
Yu-Ping Wu has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/83287?usp=email )
Change subject: mb/google/geralt: change config to FW_config for support TAS2563 audio amp
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/geralt/chromeos.c:
https://review.coreboot.org/c/coreboot/+/83287/comment/06a741ad_87cc8168?us… :
PS7, Line 64: fw_config_probe
> sorry,I use vim and vscode to view it locally and it is normal, but after submitting it... […]
Please set tab width to 8 for coreboot (add `set tabstop=8` in .vimrc).
--
To view, visit https://review.coreboot.org/c/coreboot/+/83287?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie9f0cbc30dd950b85581fc1924fa351efe1e0aab
Gerrit-Change-Number: 83287
Gerrit-PatchSet: 9
Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 01 Jul 2024 15:05:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>