coreboot-gerrit July 2024

coreboot-gerrit@coreboot.org

1 participants
3024 discussions

[S] Change in coreboot[main]: Makefile: update clean-symlink target
by Martin Roth (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Felix Singer, Martin L Roth, Maximilian Brune. Martin Roth has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/83124?usp=email ) Change subject: Makefile: update clean-symlink target ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/83124/comment/9a6c3f2c_4301bcc6?us… : PS1, Line 9: ued > used? Done https://review.coreboot.org/c/coreboot/+/83124/comment/0ade2fb2_cfccada6?us… : PS1, Line 14: fies > files Done -- To view, visit https://review.coreboot.org/c/coreboot/+/83124?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ife0e7cf1b856b7394cd5e1de9b35856bd984663c Gerrit-Change-Number: 83124 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Mon, 01 Jul 2024 16:48:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>

1 0

[S] Change in coreboot[main]: Makefile: update clean-symlink target
by Martin Roth (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Martin L Roth, Maximilian Brune. Martin Roth has uploaded a new patch set (#2) to the change originally created by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/83124?usp=email ) Change subject: Makefile: update clean-symlink target ...................................................................... Makefile: update clean-symlink target This almost completely replaces the original clean-symlink target to remove links from site-local into the coreboot tree. Changes include: - Symbolic links removed are based on the EXTERNAL_SYMLINKS value of symlink.txt files under site-local. - Verify that there are site-local symlink.txt files to work on before doing anything. - Verify that the symlink.txt files reference links inside the coreboot directory. - Print out whether or not there are remaining symbolic links in the tree. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Ife0e7cf1b856b7394cd5e1de9b35856bd984663c --- M Makefile 1 file changed, 29 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/83124/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83124?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ife0e7cf1b856b7394cd5e1de9b35856bd984663c Gerrit-Change-Number: 83124 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>

1 0

[XS] Change in coreboot[main]: Revert "util/crossgcc: Update ACPICA from 20230628 to 20240321"
by Elyes Haouas (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Felix Singer, Martin L Roth, Martin Roth, Maximilian Brune. Elyes Haouas has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83296?usp=email ) Change subject: Revert "util/crossgcc: Update ACPICA from 20230628 to 20240321" ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > Should we just update crossgcc to use our own mirror of the tarballs by default? Currently it's an o […] is there a way to compile from git as we do for 3rdparty? -- To view, visit https://review.coreboot.org/c/coreboot/+/83296?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3ce0c5798f14162eaa063a9a64e16e6dbbb9e468 Gerrit-Change-Number: 83296 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Mon, 01 Jul 2024 16:30:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth <martin.roth(a)amd.corp-partner.google.com>

1 0

[M] Change in coreboot[main]: arch/riscv: Factor out common romstage code
by Maximilian Brune (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Arthur Heymans, Felix Held, Philipp Hug, Ron Minnich. Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83098?usp=email ) Change subject: arch/riscv: Factor out common romstage code ...................................................................... Patch Set 5: (1 comment) File src/mainboard/sifive/hifive-unmatched/romstage.c: https://review.coreboot.org/c/coreboot/+/83098/comment/3e7d5253_30313be6?us… : PS5, Line 19: console_init(); > console_init is already called in the common code before calling this function. […] UART subsystem depends on `clock_init()`. I meant to remove it and do it like on the unleashed board. I have a few more patches and tests to do on the unmatched board anyway. If you don't mind I will take care of that in another patch. Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/83098?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ieb11d2644bf42dacf89ef15b2ec51286fe729d64 Gerrit-Change-Number: 83098 Gerrit-PatchSet: 5 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 01 Jul 2024 16:21:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>

1 0

[XS] Change in coreboot[main]: Revert "util/crossgcc: Update ACPICA from 20230628 to 20240321"
by Martin Roth (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Felix Singer, Martin L Roth, Maximilian Brune. Martin Roth has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83296?usp=email ) Change subject: Revert "util/crossgcc: Update ACPICA from 20230628 to 20240321" ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Should we just update crossgcc to use our own mirror of the tarballs by default? Currently it's an option. -- To view, visit https://review.coreboot.org/c/coreboot/+/83296?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3ce0c5798f14162eaa063a9a64e16e6dbbb9e468 Gerrit-Change-Number: 83296 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Mon, 01 Jul 2024 16:02:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: Support CCB at a fixed SPI-flash offset
by Martin Roth (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Simon Glass. Martin Roth has posted comments on this change by Simon Glass. ( https://review.coreboot.org/c/coreboot/+/83293?usp=email ) Change subject: Support CCB at a fixed SPI-flash offset ...................................................................... Patch Set 2: (7 comments) File Documentation/technotes/ccb.md: https://review.coreboot.org/c/coreboot/+/83293/comment/c2aacbf3_e58c6ca1?us… : PS2, Line 88: Care should be taken that : this region is in read-only flash, if preventing users from changing it is : important. : This is true for chromeos, but not every platform. File Makefile.mk: https://review.coreboot.org/c/coreboot/+/83293/comment/620f75e3_acae9ffd?us… : PS2, Line 1124: ifeq ($(CONFIG_CCB_FMAP),y) Maybe print a warning or just error out if the CCB FMAP alignment is different than what's in the fmap file? https://review.coreboot.org/c/coreboot/+/83293/comment/af163b22_f16cbe24?us… : PS2, Line 1259: ifneq ($(CONFIG_ARCH_X86),) Make this the `else` of the above? Reverse the logic? https://review.coreboot.org/c/coreboot/+/83293/comment/0708f996_0cac1ad4?us… : PS2, Line 1274: /usr/bin/printf Maybe use `env printf` instead of the path? File src/lib/bootblock.c: https://review.coreboot.org/c/coreboot/+/83293/comment/cac741f2_b93c8b2c?us… : PS2, Line 63: or FMAP Why does it need to be initialized late if it's at a known location in the SPI rom? Should this be architecture dependent and different for SoCs that have memory mapped SPI ROMs vs any that don't? File src/lib/ccb.c: https://review.coreboot.org/c/coreboot/+/83293/comment/e8acd97d_8375d0d0?us… : PS2, Line 102: if (fmap_locate_area_as_rdev(CCB_REGION, rdev)) { It seems to me that the advantage of using FMAP vs CBFS is that we can parse the fmap at build time and just get a direct address for the table so that we don't have to deal with finding the FMAP and then finding the CCB. This implementation seems no better than CBFS to me. File util/cbfstool/cbfstool.c: https://review.coreboot.org/c/coreboot/+/83293/comment/2755e319_d3807051?us… : PS2, Line 731: /* Now try FMAP */ Based on the Kconfig, we can't have CCB in more than one location. Why check more than the one that's specified in Kconfig? Doesn't that create a security hole? -- To view, visit https://review.coreboot.org/c/coreboot/+/83293?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8abc5ba55d75a3defdea548fffcedba74d4737c2 Gerrit-Change-Number: 83293 Gerrit-PatchSet: 2 Gerrit-Owner: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Simon Glass <sjg(a)chromium.org> Gerrit-Comment-Date: Mon, 01 Jul 2024 15:57:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: 3rdparty/fsp: Update submodule to upstream master
by Felix Singer (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Lean Sheng Tan, Mario Scheithauer, Werner Zeh. Felix Singer has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83294?usp=email ) Change subject: 3rdparty/fsp: Update submodule to upstream master ...................................................................... Patch Set 3: (1 comment) File src/soc/intel/elkhartlake/Kconfig: https://review.coreboot.org/c/coreboot/+/83294/comment/797f5744_38f8b8fc?us… : PS3, Line 195: FSPRel.bin" > We just recently changed it in CB:81344. […] Yeah, this is what they have on their [master branch](https://github.com/intel/FSP/tree/master/ElkhartLakeFspBinPkg/FspBi…. I think there is a bit chaos in the FSP repository.. Look at the [commit history](Here is the commit history for the FspBin directory. https://github.com/intel/FSP/commits/master/ElkhartLakeFspBinPkg/FspBin) for the FspBin directory. When I updated the submodule pointer in CB:81344, which is still in use, commit [4707bc7ab7](https://github.com/intel/FSP/commit/4707bc7ab793a1c5f179743f74d… gets introduced, which adds FSP.fd for a newer FSP version, but FSPRel.bin from an older version still remains. @mario.scheithauer@siemens.com pointed out that FSP.fd is the correct name. In the follow-up commit [aada6a55e1](https://github.com/intel/FSP/commit/aada6a55e1b4c0d9eeb04b7bbe6…, which is pulled in with this change, the commit message suggests that FSPRel.bin is removed, but actually FSP.fd is removed and FSPRel.bin is updated to the version of FSP.fd. Well, and no filename change with the most [recent commit](https://github.com/intel/FSP/commit/8134dbd3dcfadee8a75300c0a6ef2b7…. -- To view, visit https://review.coreboot.org/c/coreboot/+/83294?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I47013bce65054f2c496c9aa7c16e55b51d65e5fe Gerrit-Change-Number: 83294 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Mon, 01 Jul 2024 15:44:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com>

1 0

[S] Change in coreboot[main]: test build IASL
by Elyes Haouas (Code Review) 01 Jul '24

01 Jul '24

Hello Martin L Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83297?usp=email to look at the new patch set (#2). Change subject: test build IASL ...................................................................... test build IASL Change-Id: I05a25cefe042411c5ea94b8175c109574ee8ee00 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix2-20240321_iasl.patch D util/crossgcc/sum/acpica-unix-20240321.tar.gz.cksum A util/crossgcc/sum/acpica-unix2-20240321.tar.gz.cksum 4 files changed, 17 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/83297/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83297?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I05a25cefe042411c5ea94b8175c109574ee8ee00 Gerrit-Change-Number: 83297 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>

1 0

[XS] Change in coreboot[main]: test build IASL
by Elyes Haouas (Code Review) 01 Jul '24

01 Jul '24

Elyes Haouas has restored this change. ( https://review.coreboot.org/c/coreboot/+/83297?usp=email ) Change subject: test build IASL ...................................................................... Restored -- To view, visit https://review.coreboot.org/c/coreboot/+/83297?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: restore Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I05a25cefe042411c5ea94b8175c109574ee8ee00 Gerrit-Change-Number: 83297 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>

1 0

[S] Change in coreboot[main]: cpu/intel/model_206ax: Allow PL1/PL2 configuration
by Nico Huber (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Anastasios Koutian, Angel Pons, Patrick Rudolph, Paul Menzel. Nico Huber has posted comments on this change by Anastasios Koutian. ( https://review.coreboot.org/c/coreboot/+/83269?usp=email ) Change subject: cpu/intel/model_206ax: Allow PL1/PL2 configuration ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File src/cpu/intel/model_206ax/chip.h: https://review.coreboot.org/c/coreboot/+/83269/comment/55805558_c6bf4b3c?us… : PS1, Line 46: int pl1; /* Long-term power limit*/ : int pl2; /* Short-term power limit*/ > Done No too strong feelings about this, but I suggest to change it to milliwatts. Having all those zeros attached and having to count them every time when reading a value seems unnecessary. Even if we pretend not to know the `power_unit` (we do know, though, it's always 8 for these chips. and given the 15-bit width of the programmed value, we also know it (the `power_unit`) has to be <1000). Now I've also noticed that the `unsigned int` could easily overflow if `power_unit` was much higher. Microwatts just doesn't feel right. File src/cpu/intel/model_206ax/model_206ax_init.c: https://review.coreboot.org/c/coreboot/+/83269/comment/2beb1107_4dcff92a?us… : PS1, Line 99: dev->upstream->dev->upstream->children->chip_info; > Yeah, you're right. I didn't know we model a single chip as two in the devicetree. Merged CB:83275. Please rebase. -- To view, visit https://review.coreboot.org/c/coreboot/+/83269?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I064af25ec4805fae755eea52c4c9c6d4386c0aee Gerrit-Change-Number: 83269 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasios Koutian <akoutian2(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anastasios Koutian <akoutian2(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 01 Jul 2024 15:37:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Anastasios Koutian <akoutian2(a)gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2024