coreboot-gerrit July 2024

coreboot-gerrit@coreboot.org

1 participants
3025 discussions

[L] Change in coreboot[main]: mb/asrock: Add Z87M OC Formula (Haswell)
by Nicholas Chin (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Angel Pons, Felix Singer, Jan Philipp Groß, Máté Kukri. Nicholas Chin has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/82906?usp=email ) Change subject: mb/asrock: Add Z87M OC Formula (Haswell) ...................................................................... Patch Set 11: (1 comment) File src/mainboard/asrock/z87m_oc_formula/hda_verb.c: https://review.coreboot.org/c/coreboot/+/82906/comment/3c7b0641_4c2ade36?us… : PS11, Line 14: 0x411111f0 > ```suggestion […] This macro means the same thing as that raw hex value. For reference, see commit ca9f94854176 (mb/**/hda_verb: Use `AZALIA_PIN_CFG_NC(0)`) -- To view, visit https://review.coreboot.org/c/coreboot/+/82906?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iaa156b34ed65e66dd5de5a26010409999a5f8746 Gerrit-Change-Number: 82906 Gerrit-PatchSet: 11 Gerrit-Owner: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Attention: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 02 Jul 2024 00:43:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[L] Change in coreboot[main]: mb/asrock: Add Z87M OC Formula (Haswell)
by Nicholas Chin (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Angel Pons, Felix Singer, Jan Philipp Groß, Máté Kukri. Nicholas Chin has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/82906?usp=email ) Change subject: mb/asrock: Add Z87M OC Formula (Haswell) ...................................................................... Patch Set 11: (1 comment) File src/mainboard/asrock/z87m_oc_formula/hda_verb.c: https://review.coreboot.org/c/coreboot/+/82906/comment/560986d2_38af01a3?us… : PS11, Line 14: 0x411111f0 ```suggestion AZALIA_PIN_CFG(0, 0x17, AZALIA_PIN_CFG_NC(0)), ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/82906?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iaa156b34ed65e66dd5de5a26010409999a5f8746 Gerrit-Change-Number: 82906 Gerrit-PatchSet: 11 Gerrit-Owner: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Attention: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 02 Jul 2024 00:41:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in coreboot[main]: mb/asrock: Add Fatal1ty Z87 Professional (Haswell)
by Nicholas Chin (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Angel Pons, Felix Singer, Jan Philipp Groß, Máté Kukri, Paul Menzel. Nicholas Chin has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/82913?usp=email ) Change subject: mb/asrock: Add Fatal1ty Z87 Professional (Haswell) ...................................................................... Patch Set 8: (2 comments) File src/mainboard/asrock/fatal1ty_z87_professional/acpi/ec.asl: https://review.coreboot.org/c/coreboot/+/82913/comment/1da1f3c6_34c5402a?us… : PS8, Line 1: /* SPDX-License-Identifier: GPL-2.0-or-later */ ```suggestion /* SPDX-License-Identifier: CC-PDDC */ /* Please update the license if adding licensable material. */ ``` as per commit cf4722d317ea (src/mb: Update unlicensable files with the CC-PDDC SPDX ID) File src/mainboard/asrock/fatal1ty_z87_professional/acpi/superio.asl: https://review.coreboot.org/c/coreboot/+/82913/comment/fa1e48bc_03cbd7a1?us… : PS8, Line 1: /* SPDX-License-Identifier: GPL-2.0-or-later */ ```suggestion /* SPDX-License-Identifier: CC-PDDC */ /* Please update the license if adding licensable material. */ ``` as per commit cf4722d317ea (src/mb: Update unlicensable files with the CC-PDDC SPDX ID) -- To view, visit https://review.coreboot.org/c/coreboot/+/82913?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iae0b73d8e81be90ec3a2d5463df3ed170f603266 Gerrit-Change-Number: 82913 Gerrit-PatchSet: 8 Gerrit-Owner: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 02 Jul 2024 00:39:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/domika: Create a domika variant
by Wisley Chen (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Chen Wisley, Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Shou-Chieh Hsu, Subrata Banik. Wisley Chen has posted comments on this change by Chen Wisley. ( https://review.coreboot.org/c/coreboot/+/83291?usp=email ) Change subject: mb/google/nissa/var/domika: Create a domika variant ...................................................................... Patch Set 3: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/83291/comment/0e3b19dc_79ec04a9?us… : PS3, Line 9: Twinlake > Twin Lake Done https://review.coreboot.org/c/coreboot/+/83291/comment/23b6b03d_cbf6f37c?us… : PS3, Line 11: Twinlake > Twin Lake Done https://review.coreboot.org/c/coreboot/+/83291/comment/294de60c_7b9ea8e0?us… : PS3, Line 9: This patch creates a new domika variant which is a Twinlake : platform. This variant uses Yavilla board mounted with the : Twinlake SOC and hence the plan is to reuse the existing : yavilla code. > Please try to use 72 characters per line. Done File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/83291/comment/9a6dc1a3_19ecce86?us… : PS3, Line 235: select EC_GOOGLE_CHROMEEC_INCLUDE_SSFC_IN_FW_CONFIG > order please Done https://review.coreboot.org/c/coreboot/+/83291/comment/1cd1bb81_999f7c29?us… : PS3, Line 236: select CHROMEOS_WIFI_SAR if CHROMEOS > order please? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/83291?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I42c56770f8b8d6018592253d2bb16b8166eb5719 Gerrit-Change-Number: 83291 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley <wisley.chen%quantatw.com(a)gtempaccount.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Chen Wisley <wisley.chen%quantatw.com(a)gtempaccount.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Tue, 02 Jul 2024 00:22:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/domika: Create a domika variant
by Chen Wisley (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Chen Wisley, Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Shou-Chieh Hsu, Wisley Chen. Hello Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Shou-Chieh Hsu, Subrata Banik, Wisley Chen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83291?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+2 by Eric Lai, Verified+1 by build bot (Jenkins) Change subject: mb/google/nissa/var/domika: Create a domika variant ...................................................................... mb/google/nissa/var/domika: Create a domika variant This patch creates a new domika variant which is a Twin Lake platform. This variant uses Yavilla board mounted with the Twin Lake SOC and hence the plan is to reuse the existing yavilla code. BUG=b:350399367 BRANCH=firmware-nissa-15217.B TEST=build, and boot into OS Change-Id: I42c56770f8b8d6018592253d2bb16b8166eb5719 Signed-off-by: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Kconfig.name 2 files changed, 15 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/83291/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/83291?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I42c56770f8b8d6018592253d2bb16b8166eb5719 Gerrit-Change-Number: 83291 Gerrit-PatchSet: 4 Gerrit-Owner: Chen Wisley <wisley.chen%quantatw.com(a)gtempaccount.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Chen Wisley <wisley.chen%quantatw.com(a)gtempaccount.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>

1 0

[S] Change in coreboot[main]: lib: Add Kconfig variable for fw_config default value
by Cliff Huang (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Anil Kumar K, Bora Guvendik, Julius Werner, Paul Menzel, Subrata Banik, Wonkyu Kim. Cliff Huang has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/83153?usp=email ) Change subject: lib: Add Kconfig variable for fw_config default value ...................................................................... Patch Set 6: (2 comments) Patchset: PS6: > Please file a bug to have more specific discussion which I'm unable to follow here. […] Sure. Let me and Hannah create cros bug to continue the discussion. thx. Commit Message: https://review.coreboot.org/c/coreboot/+/83153/comment/f22836dc_e2584085?us… : PS3, Line 9: This CONFIG_FW_CONFIG_DEFAULT_VALUE flag is default to > Thank you. […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/83153?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9694433e01bdcd9ff1e550585c14ea7ccee020a3 Gerrit-Change-Number: 83153 Gerrit-PatchSet: 6 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Mon, 01 Jul 2024 23:47:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Cliff Huang <cliff.huang(a)intel.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[S] Change in coreboot[main]: lib: Add Kconfig variable for fw_config default value
by Cliff Huang (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Anil Kumar K, Bora Guvendik, Cliff Huang, Julius Werner, Wonkyu Kim. Hello Anil Kumar K, Bora Guvendik, Jérémy Compostella, Subrata Banik, Wonkyu Kim, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83153?usp=email to look at the new patch set (#7). Change subject: lib: Add Kconfig variable for fw_config default value ...................................................................... lib: Add Kconfig variable for fw_config default value This CONFIG_FW_CONFIG_DEFAULT_VALUE is used only when CBI fw_config value cannot be read from all sources such as Chrome EC and VPD. When CBI fw_config is not read successfully, fw_config_get returns UNDEFINED_FW_CONFIG (i.e. all '1's) and all fw_config_probe calls will fail. This flag dose not serve as a solution but a way to provide a valid value for validation to move forward at early development period in case Chrome EC communication has issue or the absence of EC in the simulation environment. This flag defaults to the same value as UNDEFINED_FW_CONFIG defined in fw_config.h; and it won't be used unless it is set to different value in config.<board> file. If a valid value is read from the Chrome EC or VPD, the fw_config value will not be overridden by this flag. TEST=boot and check fw_config value from coreboot log Signed-off-by: Cliff Huang <cliff.huang(a)intel.com> Change-Id: I9694433e01bdcd9ff1e550585c14ea7ccee020a3 --- M src/Kconfig M src/lib/fw_config.c 2 files changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/83153/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/83153?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9694433e01bdcd9ff1e550585c14ea7ccee020a3 Gerrit-Change-Number: 83153 Gerrit-PatchSet: 7 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>

1 0

[M] Change in coreboot[main]: drivers/wifi: Support 320Mhz Bandwidth Enablement per MCC
by YH Lin (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Bob Moragues, Bora Guvendik, Cliff Huang, Eric Lai, Hannah Williams, Jérémy Compostella, Poornima Tom, Ravishankar Sarawadi, Subrata Banik, dinesh.sharma(a)intel.com. YH Lin has posted comments on this change by Poornima Tom. ( https://review.coreboot.org/c/coreboot/+/81790?usp=email ) Change subject: drivers/wifi: Support 320Mhz Bandwidth Enablement per MCC ...................................................................... Patch Set 10: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/81790?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie76794825f1a0104d199c078aa4ffc714aa95b17 Gerrit-Change-Number: 81790 Gerrit-PatchSet: 10 Gerrit-Owner: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dinesh.sharma(a)intel.com Gerrit-CC: Bob Moragues <moragues(a)google.com> Gerrit-CC: Dinesh Sharma <dinesh.sharma(a)intel.corp-partner.google.com> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: dinesh.sharma(a)intel.com Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Bob Moragues <moragues(a)google.com> Gerrit-Comment-Date: Mon, 01 Jul 2024 21:30:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: drivers/wifi: Support Bluetooth Regulator Domain Settings
by YH Lin (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Eric Lai, Jérémy Compostella, Subrata Banik, dinesh.sharma(a)intel.com. YH Lin has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/83200?usp=email ) Change subject: drivers/wifi: Support Bluetooth Regulator Domain Settings ...................................................................... Patch Set 9: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/83200?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iebe95815c944d045f4cf686abcd1874a8a45e209 Gerrit-Change-Number: 83200 Gerrit-PatchSet: 9 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dinesh.sharma(a)intel.com Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: dinesh.sharma(a)intel.com Gerrit-Comment-Date: Mon, 01 Jul 2024 21:30:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: drivers/wifi: Support Bluetooth Regulator Domain Settings
by Jérémy Compostella (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Eric Lai, Subrata Banik, YH Lin, dinesh.sharma(a)intel.com. Hello Eric Lai, Subrata Banik, YH Lin, build bot (Jenkins), dinesh.sharma(a)intel.com, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83200?usp=email to look at the new patch set (#9). Change subject: drivers/wifi: Support Bluetooth Regulator Domain Settings ...................................................................... drivers/wifi: Support Bluetooth Regulator Domain Settings The 'Bluetooth Increased Power Mode - SAR Limitation' feature provides ability to utilize increased device Transmit power capability for Bluetooth applications in coordination with Wi-Fi adhering to product SAR limit when Bluetooth and Wi-Fi run together. This commit introduces a `bluetooth_companion' field to the generic Wi-Fi drivers chip data. This field can be set in the board design device tree to supply the bluetooth device for which the BRDS function must be created. This feature is required for Meteor Lake rex karis variant. The implementation follows document 559910 Intel Connectivity Platforms BIOS Guideline revision 8.3 specification. BUG=b:348345301 BRANCH=firmware-rex-15709.B TEST=BRDS method is added to the CNVW device and return the data supplied by the SAR binary blob Change-Id: Iebe95815c944d045f4cf686abcd1874a8a45e209 Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> --- M src/drivers/wifi/generic/acpi.c M src/drivers/wifi/generic/chip.h M src/include/sar.h M src/vendorcode/google/chromeos/sar.c 4 files changed, 105 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/83200/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/83200?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iebe95815c944d045f4cf686abcd1874a8a45e209 Gerrit-Change-Number: 83200 Gerrit-PatchSet: 9 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dinesh.sharma(a)intel.com Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: dinesh.sharma(a)intel.com

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2024