Attention is currently required from: Anastasios Koutian.
Angel Pons has posted comments on this change by Anastasios Koutian. ( https://review.coreboot.org/c/coreboot/+/83298?usp=email )
Change subject: src/{cpu,northbridge}: apply clang-format to files
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Patchset:
PS1:
Sorry for the confusion. We don't auto-format entire files with clang-format, checkpatch is a different thing.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83298?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I776fe392a7542ab239f6968c2417e30e7af0fdfd
Gerrit-Change-Number: 83298
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasios Koutian <akoutian2(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Anastasios Koutian <akoutian2(a)gmail.com>
Gerrit-Comment-Date: Mon, 01 Jul 2024 17:01:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Alexander Couzens, Angel Pons.
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83280?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/lenovo/t420: Use vendor default power limits
......................................................................
mb/lenovo/t420: Use vendor default power limits
Also set the vendor default TCC offset temperature
Change-Id: Ia187b67ae28fbcda7d5d0e35ec64a3b21d97a21b
Signed-off-by: Anastasios Koutian <akoutian2(a)gmail.com>
---
M src/mainboard/lenovo/t420/devicetree.cb
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/83280/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/83280?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia187b67ae28fbcda7d5d0e35ec64a3b21d97a21b
Gerrit-Change-Number: 83280
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasios Koutian <akoutian2(a)gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Attention is currently required from: Angel Pons.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83270?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: cpu/intel/model_206ax: Allow package power limit clamping
......................................................................
cpu/intel/model_206ax: Allow package power limit clamping
Tested on ThinkPad T420 with the i7-3940XM.
Change-Id: Id0c0aedc29aca121d0fd1d8f8826089e13a026be
Signed-off-by: Anastasios Koutian <akoutian2(a)gmail.com>
---
M src/cpu/intel/model_206ax/chip.h
M src/cpu/intel/model_206ax/model_206ax_init.c
2 files changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/83270/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/83270?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id0c0aedc29aca121d0fd1d8f8826089e13a026be
Gerrit-Change-Number: 83270
Gerrit-PatchSet: 5
Gerrit-Owner: Anastasios Koutian <akoutian2(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Attention is currently required from: Anastasios Koutian, Angel Pons, Nico Huber, Patrick Rudolph, Paul Menzel.
Hello Angel Pons, Nico Huber, Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83269?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by Nico Huber, Verified+1 by build bot (Jenkins)
Change subject: cpu/intel/model_206ax: Allow PL1/PL2 configuration
......................................................................
cpu/intel/model_206ax: Allow PL1/PL2 configuration
Tested on ThinkPad T420 with the i7-3940XM.
Change-Id: I064af25ec4805fae755eea52c4c9c6d4386c0aee
Signed-off-by: Anastasios Koutian <akoutian2(a)gmail.com>
---
M src/cpu/intel/model_206ax/chip.h
M src/cpu/intel/model_206ax/model_206ax_init.c
2 files changed, 19 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/83269/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/83269?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I064af25ec4805fae755eea52c4c9c6d4386c0aee
Gerrit-Change-Number: 83269
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasios Koutian <akoutian2(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Anastasios Koutian <akoutian2(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83125?usp=email )
Change subject: Makefile: Add symlink targets to help
......................................................................
Makefile: Add symlink targets to help
Also capitalize the first letter of each help line while I'm here.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: I595265d53a5ecfeb5989075dd4ce23dbdf366c00
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83125
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M Makefile
1 file changed, 9 insertions(+), 4 deletions(-)
Approvals:
Elyes Haouas: Looks good to me, approved
build bot (Jenkins): Verified
diff --git a/Makefile b/Makefile
index 2dddaab..bc6fabc 100644
--- a/Makefile
+++ b/Makefile
@@ -94,10 +94,15 @@
@echo ' sphinx - Build sphinx documentation for coreboot'
@echo ' sphinx-lint - Build sphinx documentation for coreboot with warnings as errors'
@echo ' filelist - Show files used in current build'
- @echo ' printall - print makefile info for debugging'
- @echo ' gitconfig - set up git to submit patches to coreboot'
- @echo ' ctags / ctags-project - make ctags file for all of coreboot or current board'
- @echo ' cscope / cscope-project - make cscope.out file for coreboot or current board'
+ @echo ' printall - Print makefile info for debugging'
+ @echo ' gitconfig - Set up git to submit patches to coreboot'
+ @echo ' ctags / ctags-project - Make ctags file for all of coreboot or current board'
+ @echo ' cscope / cscope-project - Make cscope.out file for coreboot or current board'
+ @echo
+ @echo '*** site-local related targets ***'
+ @echo ' symlink - Create symbolic links from site-local into coreboot tree'
+ @echo ' clean-symlink - Remove symbolic links created by "make symlink"'
+ @echo ' cleanall-symlink - Remove all symbolic links in the coreboot tree'
@echo
# This include must come _before_ the pattern rules below!
--
To view, visit https://review.coreboot.org/c/coreboot/+/83125?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I595265d53a5ecfeb5989075dd4ce23dbdf366c00
Gerrit-Change-Number: 83125
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83124?usp=email )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: Makefile: update clean-symlink target
......................................................................
Makefile: update clean-symlink target
This almost completely replaces the original clean-symlink target to
remove links from site-local into the coreboot tree. Changes include:
- Symbolic links removed are based on the EXTERNAL_SYMLINKS value of
symlink.txt files under site-local.
- Verify that there are site-local symlink.txt files to work on before
doing anything.
- Verify that the symlink.txt files reference links inside the coreboot
directory.
- Print out whether or not there are remaining symbolic links in the
tree.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: Ife0e7cf1b856b7394cd5e1de9b35856bd984663c
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83124
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Eric Lai <ericllai(a)google.com>
Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M Makefile
1 file changed, 29 insertions(+), 5 deletions(-)
Approvals:
Elyes Haouas: Looks good to me, approved
build bot (Jenkins): Verified
Eric Lai: Looks good to me, but someone else must approve
diff --git a/Makefile b/Makefile
index 60570a0..2dddaab 100644
--- a/Makefile
+++ b/Makefile
@@ -519,11 +519,35 @@
done
clean-symlink:
- @echo "Deleting symbolic link";\
- EXISTING_SYMLINKS=`find -L ./src -xtype l | grep -v 3rdparty`; \
- for link in $$EXISTING_SYMLINKS; do \
- echo -e "\tUNLINK $$link"; \
- rm "$$link"; \
+ if [ -z "$(SYMLINK_LIST)" ]; then \
+ echo "No site-local symbolic links to clean."; \
+ exit 0; \
+ fi; \
+ echo "Removing site-local symbolic links from tree.."; \
+ for link in $(SYMLINK_LIST); do \
+ SYMLINK="$(top)/$$(head -n 1 "$${link}")"; \
+ if [ "$${SYMLINK}" = "$$(echo "$${SYMLINK}" | sed "s|^$(top)||")" ]; then \
+ echo " FAILED: $${SYMLINK} is outside of current directory." >&2; \
+ continue; \
+ elif [ ! -L "$${SYMLINK}" ]; then \
+ echo " $${SYMLINK} does not exist - skipping"; \
+ continue; \
+ fi; \
+ if [ -L "$${SYMLINK}" ]; then \
+ REALDIR="$$(realpath "$${link}")"; \
+ echo " UNLINK $${link} (linked from $${REALDIR})"; \
+ rm "$${SYMLINK}"; \
+ fi; \
+ done; \
+ EXISTING_SYMLINKS="$$(find $(top) -type l | grep -v "3rdparty\|crossgcc" )"; \
+ if [ -z "$${EXISTING_SYMLINKS}" ]; then \
+ echo " No remaining symbolic links found in tree."; \
+ else \
+ echo " Remaining symbolic links found:"; \
+ for link in $${EXISTING_SYMLINKS}; do \
+ echo " $${link}"; \
+ done; \
+ fi
cleanall-symlink:
echo "Deleting all symbolic links in the coreboot tree (excluding 3rdparty & crossgcc)"; \
--
To view, visit https://review.coreboot.org/c/coreboot/+/83124?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ife0e7cf1b856b7394cd5e1de9b35856bd984663c
Gerrit-Change-Number: 83124
Gerrit-PatchSet: 3
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com>