coreboot-gerrit July 2024

coreboot-gerrit@coreboot.org

1 participants
3025 discussions

[S] Change in coreboot[main]: mb/google/nissa/var/domika: Create a domika variant
by Subrata Banik (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Chen Wisley, Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Shou-Chieh Hsu, Wisley Chen. Subrata Banik has posted comments on this change by Chen Wisley. ( https://review.coreboot.org/c/coreboot/+/83291?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/nissa/var/domika: Create a domika variant ...................................................................... Patch Set 3: -Code-Review (2 comments) File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/83291/comment/68722add_f33d6b5e?us… : PS3, Line 235: select EC_GOOGLE_CHROMEEC_INCLUDE_SSFC_IN_FW_CONFIG order please https://review.coreboot.org/c/coreboot/+/83291/comment/882b7a95_b52dbccc?us… : PS3, Line 236: select CHROMEOS_WIFI_SAR if CHROMEOS order please? -- To view, visit https://review.coreboot.org/c/coreboot/+/83291?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I42c56770f8b8d6018592253d2bb16b8166eb5719 Gerrit-Change-Number: 83291 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley <wisley.chen%quantatw.com(a)gtempaccount.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Chen Wisley <wisley.chen%quantatw.com(a)gtempaccount.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Mon, 01 Jul 2024 11:14:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/domika: Create a domika variant
by Subrata Banik (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Chen Wisley, Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Shou-Chieh Hsu, Wisley Chen. Subrata Banik has posted comments on this change by Chen Wisley. ( https://review.coreboot.org/c/coreboot/+/83291?usp=email ) Change subject: mb/google/nissa/var/domika: Create a domika variant ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83291?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I42c56770f8b8d6018592253d2bb16b8166eb5719 Gerrit-Change-Number: 83291 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley <wisley.chen%quantatw.com(a)gtempaccount.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Chen Wisley <wisley.chen%quantatw.com(a)gtempaccount.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Mon, 01 Jul 2024 11:13:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/google/geralt: support TAS2563 audio amp
by Yu-Ping Wu (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Hung-Te Lin, Rui Zhou, Yidi Lin, cong yang. Yu-Ping Wu has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/83287?usp=email ) Change subject: mb/google/geralt: support TAS2563 audio amp ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83287?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie9f0cbc30dd950b85581fc1924fa351efe1e0aab Gerrit-Change-Number: 83287 Gerrit-PatchSet: 8 Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Mon, 01 Jul 2024 10:57:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/google/geralt: support TAS2563 audio amp
by Rui Zhou (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu, cong yang. Rui Zhou has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/83287?usp=email ) Change subject: mb/google/geralt: support TAS2563 audio amp ...................................................................... Patch Set 8: (2 comments) File src/mainboard/google/geralt/chromeos.c: https://review.coreboot.org/c/coreboot/+/83287/comment/e366ad65_b3fd35f8?us… : PS7, Line 64: fw_config_probe > Align sorry,I use vim and vscode to view it locally and it is normal, but after submitting it... hum, it seems that I can only use gedit to align it. File src/mainboard/google/geralt/mainboard.c: https://review.coreboot.org/c/coreboot/+/83287/comment/e78e06d9_c198f134?us… : PS7, Line 39: fw_config_probe > Align Done -- To view, visit https://review.coreboot.org/c/coreboot/+/83287?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie9f0cbc30dd950b85581fc1924fa351efe1e0aab Gerrit-Change-Number: 83287 Gerrit-PatchSet: 8 Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Mon, 01 Jul 2024 10:57:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

[S] Change in coreboot[main]: mb/google/geralt: support TAS2563 audio amp
by Rui Zhou (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Hung-Te Lin, Rui Zhou, Yidi Lin, cong yang. Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), cong yang, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83287?usp=email to look at the new patch set (#8). Change subject: mb/google/geralt: support TAS2563 audio amp ...................................................................... mb/google/geralt: support TAS2563 audio amp Add FW_CONFIG to enable TAS2563 support. BUG=b:345629159 BRANCH=none TEST=emerge-GERALT coreboot TEST=Verify beep function through deploy in depthcharge successfully. Change-Id: Ie9f0cbc30dd950b85581fc1924fa351efe1e0aab Signed-off-by: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/geralt/chromeos.c M src/mainboard/google/geralt/devicetree.cb M src/mainboard/google/geralt/mainboard.c 3 files changed, 21 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/83287/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/83287?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie9f0cbc30dd950b85581fc1924fa351efe1e0aab Gerrit-Change-Number: 83287 Gerrit-PatchSet: 8 Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com>

1 0

[S] Change in coreboot[main]: mb/google/geralt: support TAS2563 audio amp
by Yu-Ping Wu (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Hung-Te Lin, Rui Zhou, Yidi Lin, cong yang. Yu-Ping Wu has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/83287?usp=email ) Change subject: mb/google/geralt: support TAS2563 audio amp ...................................................................... Patch Set 7: (2 comments) File src/mainboard/google/geralt/chromeos.c: https://review.coreboot.org/c/coreboot/+/83287/comment/2be984d1_1b74bfff?us… : PS7, Line 64: fw_config_probe Align File src/mainboard/google/geralt/mainboard.c: https://review.coreboot.org/c/coreboot/+/83287/comment/77b89cc2_10d95954?us… : PS7, Line 39: fw_config_probe Align -- To view, visit https://review.coreboot.org/c/coreboot/+/83287?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie9f0cbc30dd950b85581fc1924fa351efe1e0aab Gerrit-Change-Number: 83287 Gerrit-PatchSet: 7 Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Mon, 01 Jul 2024 09:49:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/google/geralt: support TAS2563 audio amp
by Rui Zhou (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu, cong yang. Rui Zhou has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/83287?usp=email ) Change subject: mb/google/geralt: support TAS2563 audio amp ...................................................................... Patch Set 7: (1 comment) File src/mainboard/google/geralt/mainboard.c: https://review.coreboot.org/c/coreboot/+/83287/comment/4717496b_adf7ecd3?us… : PS5, Line 38: if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_MAX98390))) { : printk(BIOS_DEBUG, "Configure MAX98390 audio\n"); : : mtk_i2c_bus_init(I2C0, I2C_SPEED_FAST); : configure_i2s(); : } else if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_TAS2563))) { : printk(BIOS_DEBUG, "Configure TAS2563 audio\n"); : mtk_i2c_bus_init(I2C0, I2C_SPEED_FAST); : configure_i2s(); : } > There is relevant printing information, I has been modified. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/83287?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie9f0cbc30dd950b85581fc1924fa351efe1e0aab Gerrit-Change-Number: 83287 Gerrit-PatchSet: 7 Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Mon, 01 Jul 2024 09:38:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[S] Change in coreboot[main]: mb/google/geralt: support TAS2563 audio amp
by Rui Zhou (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu, cong yang. Rui Zhou has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/83287?usp=email ) Change subject: mb/google/geralt: support TAS2563 audio amp ...................................................................... Patch Set 7: (2 comments) File src/mainboard/google/geralt/chromeos.c: https://review.coreboot.org/c/coreboot/+/83287/comment/5231417a_9aa5f903?us… : PS5, Line 63: fw_config_probe > Jenkins failed because you used >=8 spaces. Please use 2 tabs and <8 spaces. Done File src/mainboard/google/geralt/mainboard.c: https://review.coreboot.org/c/coreboot/+/83287/comment/12e19297_79ee534c?us… : PS5, Line 38: if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_MAX98390))) { : printk(BIOS_DEBUG, "Configure MAX98390 audio\n"); : : mtk_i2c_bus_init(I2C0, I2C_SPEED_FAST); : configure_i2s(); : } else if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_TAS2563))) { : printk(BIOS_DEBUG, "Configure TAS2563 audio\n"); : mtk_i2c_bus_init(I2C0, I2C_SPEED_FAST); : configure_i2s(); : } > Can you check if the FW log shows something like this ? […] There is relevant printing information, I has been modified. -- To view, visit https://review.coreboot.org/c/coreboot/+/83287?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie9f0cbc30dd950b85581fc1924fa351efe1e0aab Gerrit-Change-Number: 83287 Gerrit-PatchSet: 7 Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Mon, 01 Jul 2024 09:37:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[S] Change in coreboot[main]: mb/google/geralt: support TAS2563 audio amp
by Rui Zhou (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Hung-Te Lin, Rui Zhou, cong yang. Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), cong yang, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83287?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/google/geralt: support TAS2563 audio amp ...................................................................... mb/google/geralt: support TAS2563 audio amp Add FW_CONFIG to enable TAS2563 support. BUG=b:345629159 BRANCH=none TEST=emerge-GERALT coreboot TEST=Verify beep function through deploy in depthcharge successfully. Change-Id: Ie9f0cbc30dd950b85581fc1924fa351efe1e0aab Signed-off-by: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/geralt/chromeos.c M src/mainboard/google/geralt/devicetree.cb M src/mainboard/google/geralt/mainboard.c 3 files changed, 21 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/83287/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/83287?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie9f0cbc30dd950b85581fc1924fa351efe1e0aab Gerrit-Change-Number: 83287 Gerrit-PatchSet: 7 Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com>

1 0

[S] Change in coreboot[main]: mb/google/geralt: support TAS2563 audio amp
by Yu-Ping Wu (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Hung-Te Lin, Rui Zhou, cong yang. Yu-Ping Wu has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/83287?usp=email ) Change subject: mb/google/geralt: support TAS2563 audio amp ...................................................................... Patch Set 6: (1 comment) File src/mainboard/google/geralt/chromeos.c: https://review.coreboot.org/c/coreboot/+/83287/comment/f2581e0f_6b2152da?us… : PS5, Line 63: fw_config_probe > Using tabs doesn't allow alignment. If I use spaces, Jenkins will prompt. Jenkins failed because you used >=8 spaces. Please use 2 tabs and <8 spaces. -- To view, visit https://review.coreboot.org/c/coreboot/+/83287?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie9f0cbc30dd950b85581fc1924fa351efe1e0aab Gerrit-Change-Number: 83287 Gerrit-PatchSet: 6 Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Mon, 01 Jul 2024 09:15:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2024