Attention is currently required from: Hung-Te Lin, Yu-Ping Wu, cong yang.
Yidi Lin has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/83287?usp=email )
Change subject: mb/google/geralt: support TAS2563 audio amp
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/geralt/mainboard.c:
https://review.coreboot.org/c/coreboot/+/83287/comment/0814bf37_f6fe2117?us… :
PS5, Line 38: if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_MAX98390))) {
: printk(BIOS_DEBUG, "Configure MAX98390 audio\n");
:
: mtk_i2c_bus_init(I2C0, I2C_SPEED_FAST);
: configure_i2s();
: } else if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_TAS2563))) {
: printk(BIOS_DEBUG, "Configure TAS2563 audio\n");
: mtk_i2c_bus_init(I2C0, I2C_SPEED_FAST);
: configure_i2s();
: }
Can you check if the FW log shows something like this ?
```
fw_config match found: xxxxxxxx
```
If so, then we can just write
```
if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_MAX98390)) ||
fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_TAS2563))) {
...
}
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/83287?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie9f0cbc30dd950b85581fc1924fa351efe1e0aab
Gerrit-Change-Number: 83287
Gerrit-PatchSet: 5
Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 01 Jul 2024 09:00:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu, cong yang.
Rui Zhou has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/83287?usp=email )
Change subject: mb/google/geralt: support TAS2563 audio amp
......................................................................
Patch Set 6:
(4 comments)
File src/mainboard/google/geralt/chromeos.c:
https://review.coreboot.org/c/coreboot/+/83287/comment/37ac32eb_eb42c7f5?us… :
PS5, Line 8: #include <fw_config.h>
> <*.h> should be separated from ".h" by a blank line. […]
thanks for reminding
https://review.coreboot.org/c/coreboot/+/83287/comment/7e5fb418_f1318594?us… :
PS5, Line 63: fw_config_probe
> Align with the fw_config_probe in the previous line.
Using tabs doesn't allow alignment. If I use spaces, Jenkins will prompt.
File src/mainboard/google/geralt/mainboard.c:
https://review.coreboot.org/c/coreboot/+/83287/comment/737e49fe_63ccb19e?us… :
PS5, Line 6: #include <fw_config.h>
> Same here.
Done
https://review.coreboot.org/c/coreboot/+/83287/comment/89953970_a398a678?us… :
PS5, Line 34: {
> Remove `{}`.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/83287?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie9f0cbc30dd950b85581fc1924fa351efe1e0aab
Gerrit-Change-Number: 83287
Gerrit-PatchSet: 6
Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 01 Jul 2024 08:58:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Dolan Liu has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/81738?usp=email )
Change subject: driver/i2c/rt5645: add RT5645 codec driver
......................................................................
Abandoned
resubmit in new cl
--
To view, visit https://review.coreboot.org/c/coreboot/+/81738?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I23407b451c728fb0cfad813552afc6d24e95608a
Gerrit-Change-Number: 81738
Gerrit-PatchSet: 1
Gerrit-Owner: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Dolan Liu has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/81737?usp=email )
Change subject: driver/i2c/rt5645: add RT5645 codec driver
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/81737?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I23407b451c728fb0cfad813552afc6d24e95608a
Gerrit-Change-Number: 81737
Gerrit-PatchSet: 1
Gerrit-Owner: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Attention is currently required from: Hung-Te Lin, Rui Zhou, Yidi Lin, cong yang.
Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), cong yang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83287?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/google/geralt: support TAS2563 audio amp
......................................................................
mb/google/geralt: support TAS2563 audio amp
Add FW_CONFIG to enable TAS2563 support.
BUG=b:345629159
BRANCH=none
TEST=emerge-GERALT coreboot
TEST=Verify beep function through deploy in depthcharge successfully.
Change-Id: Ie9f0cbc30dd950b85581fc1924fa351efe1e0aab
Signed-off-by: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/geralt/chromeos.c
M src/mainboard/google/geralt/devicetree.cb
M src/mainboard/google/geralt/mainboard.c
3 files changed, 24 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/83287/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/83287?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie9f0cbc30dd950b85581fc1924fa351efe1e0aab
Gerrit-Change-Number: 83287
Gerrit-PatchSet: 6
Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Attention is currently required from: Hung-Te Lin, Rui Zhou, Yidi Lin, cong yang.
Yu-Ping Wu has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/83287?usp=email )
Change subject: mb/google/geralt: support TAS2563 audio amp
......................................................................
Patch Set 5:
(4 comments)
File src/mainboard/google/geralt/chromeos.c:
https://review.coreboot.org/c/coreboot/+/83287/comment/83bbcb61_fb716362?us… :
PS5, Line 8: #include <fw_config.h>
<*.h> should be separated from ".h" by a blank line. Within each group, the headers should be sorted.
https://review.coreboot.org/c/coreboot/+/83287/comment/423fc2f9_f3e2b5fe?us… :
PS5, Line 63: fw_config_probe
Align with the fw_config_probe in the previous line.
File src/mainboard/google/geralt/mainboard.c:
https://review.coreboot.org/c/coreboot/+/83287/comment/52beccf0_24cb19a5?us… :
PS5, Line 6: #include <fw_config.h>
Same here.
https://review.coreboot.org/c/coreboot/+/83287/comment/9cd163a0_aeead537?us… :
PS5, Line 34: {
Remove `{}`.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83287?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie9f0cbc30dd950b85581fc1924fa351efe1e0aab
Gerrit-Change-Number: 83287
Gerrit-PatchSet: 5
Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 01 Jul 2024 08:29:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Chen Wisley, Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Shou-Chieh Hsu, Subrata Banik, Wisley Chen.
Wisley Chen has uploaded a new patch set (#3) to the change originally created by Chen Wisley. ( https://review.coreboot.org/c/coreboot/+/83291?usp=email )
Change subject: mb/google/nissa/var/domika: Create a domika variant
......................................................................
mb/google/nissa/var/domika: Create a domika variant
This patch creates a new domika variant which is a Twinlake
platform. This variant uses Yavilla board mounted with the
Twinlake SOC and hence the plan is to reuse the existing
yavilla code.
BUG=b:350399367
BRANCH=firmware-nissa-15217.B
TEST=build, and boot into OS
Change-Id: I42c56770f8b8d6018592253d2bb16b8166eb5719
Signed-off-by: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brya/Kconfig
M src/mainboard/google/brya/Kconfig.name
2 files changed, 15 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/83291/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/83291?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I42c56770f8b8d6018592253d2bb16b8166eb5719
Gerrit-Change-Number: 83291
Gerrit-PatchSet: 3
Gerrit-Owner: Chen Wisley <wisley.chen%quantatw.com(a)gtempaccount.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-CC: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Chen Wisley <wisley.chen%quantatw.com(a)gtempaccount.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>