coreboot-gerrit July 2024

coreboot-gerrit@coreboot.org

1 participants
3025 discussions

[XL] Change in coreboot[main]: skl mainboards/dt: Move usb{2,3}_ports settings into XHCI device scope
by Frans Hendriks (Code Review) 01 Jul '24

01 Jul '24

Frans Hendriks has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83171?usp=email ) Change subject: skl mainboards/dt: Move usb{2,3}_ports settings into XHCI device scope ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83171?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I22ba991a9d559b0ecc7b3ceddcfd099890dd6c3a Gerrit-Change-Number: 83171 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Marvin Evers <marvin.n.evers(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Mon, 01 Jul 2024 06:04:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/google/brox/var/lotso: Fine tune I2C frequency
by Jian Tong (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Jian Tong, Wentao Qin. Hello Kun Liu, Wentao Qin, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83290?usp=email to look at the new patch set (#3). Change subject: mb/google/brox/var/lotso: Fine tune I2C frequency ...................................................................... mb/google/brox/var/lotso: Fine tune I2C frequency I2C0 - 392kHz I2C5 - 400kHz BUG=b:349743464,b:349735055 TEST=emerge-brox sys-boot/coreboot Change-Id: I985837b1b80e973f148529b446905580c0f95e98 Signed-off-by: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/brox/variants/lotso/overridetree.cb 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/83290/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/83290?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I985837b1b80e973f148529b446905580c0f95e98 Gerrit-Change-Number: 83290 Gerrit-PatchSet: 3 Gerrit-Owner: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Wentao Qin <qinwentao(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com> Gerrit-Attention: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Attention: Wentao Qin <qinwentao(a)huaqin.corp-partner.google.com>

1 0

[S] Change in coreboot[main]: Makefile.mk: compile ECC tools and inject ECC to final image
by Elyes Haouas (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Felix Singer, Krystian Hebel, Michał Żygowski, Sergii Dmytruk. Elyes Haouas has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/coreboot/+/67064?usp=email ) Change subject: Makefile.mk: compile ECC tools and inject ECC to final image ...................................................................... Patch Set 37: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/67064?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8541aa6f1429ed6143830ed11c47c150183ddf0d Gerrit-Change-Number: 67064 Gerrit-PatchSet: 37 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Mon, 01 Jul 2024 06:04:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/google/brox/var/lotso: Fine tune I2C frequency
by Kun Liu (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Jian Tong, Wentao Qin. Kun Liu has posted comments on this change by Jian Tong. ( https://review.coreboot.org/c/coreboot/+/83290?usp=email ) Change subject: mb/google/brox/var/lotso: Fine tune I2C frequency ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/83290?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I985837b1b80e973f148529b446905580c0f95e98 Gerrit-Change-Number: 83290 Gerrit-PatchSet: 2 Gerrit-Owner: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Wentao Qin <qinwentao(a)huaqin.corp-partner.google.com> Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com> Gerrit-Attention: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Attention: Wentao Qin <qinwentao(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Mon, 01 Jul 2024 05:59:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/google/geralt: support TAS2563 audio amp
by Yu-Ping Wu (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Hung-Te Lin, Rui Zhou. Yu-Ping Wu has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/83287?usp=email ) Change subject: mb/google/geralt: support TAS2563 audio amp ...................................................................... Patch Set 2: (6 comments) File src/mainboard/google/geralt/chromeos.c: https://review.coreboot.org/c/coreboot/+/83287/comment/ea707b5c_5ac69f56?us… : PS2, Line 56: GERALT_USE_MAX98390 This Kconfig option should be removed from mainboard/google/geralt/Kconfig. https://review.coreboot.org/c/coreboot/+/83287/comment/e635ac84_62df0ae0?us… : PS2, Line 7: #include <fw_config.h> Sort File src/mainboard/google/geralt/devicetree.cb: https://review.coreboot.org/c/coreboot/+/83287/comment/8219001b_f417e056?us… : PS2, Line 6: One space. File src/mainboard/google/geralt/mainboard.c: https://review.coreboot.org/c/coreboot/+/83287/comment/cf3b49e2_ffe45756?us… : PS2, Line 12: #include <fw_config.h> Sort. https://review.coreboot.org/c/coreboot/+/83287/comment/5490b2ca_321fa673?us… : PS2, Line 33: { Skip if `CONFIG(GERALT_USE_NAU8318)`. https://review.coreboot.org/c/coreboot/+/83287/comment/c1fe5476_b78c2cbd?us… : PS2, Line 39: } : else if `} else if` -- To view, visit https://review.coreboot.org/c/coreboot/+/83287?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie9f0cbc30dd950b85581fc1924fa351efe1e0aab Gerrit-Change-Number: 83287 Gerrit-PatchSet: 2 Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Mon, 01 Jul 2024 05:54:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/google/brox/var/lotso: Fine tune I2C frequency
by Jian Tong (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Kun Liu, Wentao Qin. Hello Kun Liu, Wentao Qin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83290?usp=email to look at the new patch set (#2). Change subject: mb/google/brox/var/lotso: Fine tune I2C frequency ...................................................................... mb/google/brox/var/lotso: Fine tune I2C frequency I2C0 - 392kHz I2C5 - 400kHz BUG=b:349743464,b:349735055 TEST=emerge-brox sys-boot/coreboot Change-Id: I985837b1b80e973f148529b446905580c0f95e98 Signed-off-by: Jing Tong <tongjian(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/brox/variants/lotso/overridetree.cb 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/83290/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83290?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I985837b1b80e973f148529b446905580c0f95e98 Gerrit-Change-Number: 83290 Gerrit-PatchSet: 2 Gerrit-Owner: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Wentao Qin <qinwentao(a)huaqin.corp-partner.google.com> Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com> Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Attention: Wentao Qin <qinwentao(a)huaqin.corp-partner.google.com>

1 0

[S] Change in coreboot[main]: mb/google/brox/var/lotso: Fine tune I2C frequency
by Jian Tong (Code Review) 01 Jul '24

01 Jul '24

Jian Tong has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83290?usp=email ) Change subject: mb/google/brox/var/lotso: Fine tune I2C frequency ...................................................................... mb/google/brox/var/lotso: Fine tune I2C frequency I2C0 - 392kHz I2C5 - 400kHz BUG=b:349747500,b:349735055 TEST=emerge-brox sys-boot/coreboot Change-Id: I985837b1b80e973f148529b446905580c0f95e98 Signed-off-by: Jing Tong <tongjian(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/brox/variants/lotso/overridetree.cb 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/83290/1 diff --git a/src/mainboard/google/brox/variants/lotso/overridetree.cb b/src/mainboard/google/brox/variants/lotso/overridetree.cb index 274e22c..187840f 100644 --- a/src/mainboard/google/brox/variants/lotso/overridetree.cb +++ b/src/mainboard/google/brox/variants/lotso/overridetree.cb @@ -48,6 +48,22 @@ register "tcss_ports[0]" = "TCSS_PORT_EMPTY" # Disable TCP0 register "tcss_ports[2]" = "TCSS_PORT_EMPTY" # Disable TCP2 + register "common_soc_config" = "{ + .i2c[0] = { + .speed = I2C_SPEED_FAST, + .rise_time_ns = 650, + .fall_time_ns = 350, + .data_hold_time_ns = 400, + }, + .i2c[4] = { + .early_init = 1, + .speed = I2C_SPEED_FAST, + .rise_time_ns = 600, + .fall_time_ns = 110, + .data_hold_time_ns = 100, + }, + }" + register "serial_io_gspi_mode" = "{ [PchSerialIoIndexGSPI0] = PchSerialIoPci, [PchSerialIoIndexGSPI1] = PchSerialIoPci, -- To view, visit https://review.coreboot.org/c/coreboot/+/83290?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I985837b1b80e973f148529b446905580c0f95e98 Gerrit-Change-Number: 83290 Gerrit-PatchSet: 1 Gerrit-Owner: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>

1 0

[XS] Change in coreboot[main]: Makefile.mk: Temporarily silence clang-format
by Elyes Haouas (Code Review) 01 Jul '24

01 Jul '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83289?usp=email ) Change subject: Makefile.mk: Temporarily silence clang-format ...................................................................... Makefile.mk: Temporarily silence clang-format Change-Id: I8d3e6e213ba08fb0699c309e064f585e66d985c7 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Makefile.mk 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/83289/1 diff --git a/Makefile.mk b/Makefile.mk index 1b658b5..856b7325 100644 --- a/Makefile.mk +++ b/Makefile.mk @@ -806,8 +806,9 @@ gitconfig: util/gitconfig/gitconfig.sh "$(MAKE)" -install-git-commit-clangfmt: - cp util/scripts/prepare-commit-msg.clang-format .git/hooks/prepare-commit-msg +# Uncomment the 2 lines below when clang-format is ready +# install-git-commit-clangfmt: +# cp util/scripts/prepare-commit-msg.clang-format .git/hooks/prepare-commit-msg include util/crossgcc/Makefile.mk -- To view, visit https://review.coreboot.org/c/coreboot/+/83289?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8d3e6e213ba08fb0699c309e064f585e66d985c7 Gerrit-Change-Number: 83289 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[S] Change in coreboot[main]: arch/riscv: Add PMP print function
by Elyes Haouas (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Maximilian Brune, Philipp Hug, Ron Minnich. Elyes Haouas has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83283?usp=email ) Change subject: arch/riscv: Add PMP print function ...................................................................... Patch Set 1: (1 comment) File src/arch/riscv/pmp.c: https://review.coreboot.org/c/coreboot/+/83283/comment/dacde9b3_396e8607?us… : PS1, Line 3: "commonlib/bsd/helpers.h" already included via <commonlib/helpers.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/83283?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6ab1531c65b14690e37aecf57ff441bf22db1ce5 Gerrit-Change-Number: 83283 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Mon, 01 Jul 2024 05:30:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: tree: Use <console/console.h> only when used
by Elyes Haouas (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Jonathan Zhang, Julius Werner, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, Tim Chu. Hello Arthur Heymans, Christian Walter, Johnny Lin, Jonathan Zhang, Julius Werner, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, Tim Chu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83288?usp=email to look at the new patch set (#2). Change subject: tree: Use <console/console.h> only when used ...................................................................... tree: Use <console/console.h> only when used Change-Id: I3cb1f11beba61afdf2be6188bde9ff135f8ace50 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/arch/arm64/dma.c M src/arch/arm64/smbios.c M src/include/device/dram/rcd.h M src/mainboard/ibm/sbp1/romstage.c M src/soc/intel/xeon_sp/chip_gen6.c M src/soc/qualcomm/common/include/soc/qup_se_handlers_common.h M src/soc/qualcomm/common/include/soc/usb/qmp_usb_phy.h M src/soc/qualcomm/common/include/soc/usb/qusb_phy.h M src/soc/qualcomm/common/include/soc/usb/snps_usb_phy.h M src/soc/qualcomm/common/qupv3_spi.c M src/soc/qualcomm/common/usb/qmpv3_usb_phy.c M src/soc/qualcomm/common/usb/qmpv4_usb_phy.c M src/soc/qualcomm/common/usb/qusb_phy.c M src/soc/qualcomm/common/usb/snps_usb_phy.c M src/superio/ite/it8772f/superio.c 15 files changed, 5 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/83288/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83288?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3cb1f11beba61afdf2be6188bde9ff135f8ace50 Gerrit-Change-Number: 83288 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2024