Attention is currently required from: Jian Tong, Wentao Qin.
Hello Kun Liu, Wentao Qin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83290?usp=email
to look at the new patch set (#3).
Change subject: mb/google/brox/var/lotso: Fine tune I2C frequency
......................................................................
mb/google/brox/var/lotso: Fine tune I2C frequency
I2C0 - 392kHz
I2C5 - 400kHz
BUG=b:349743464,b:349735055
TEST=emerge-brox sys-boot/coreboot
Change-Id: I985837b1b80e973f148529b446905580c0f95e98
Signed-off-by: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/brox/variants/lotso/overridetree.cb
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/83290/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/83290?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I985837b1b80e973f148529b446905580c0f95e98
Gerrit-Change-Number: 83290
Gerrit-PatchSet: 3
Gerrit-Owner: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Wentao Qin <qinwentao(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Wentao Qin <qinwentao(a)huaqin.corp-partner.google.com>
Attention is currently required from: Jian Tong, Wentao Qin.
Kun Liu has posted comments on this change by Jian Tong. ( https://review.coreboot.org/c/coreboot/+/83290?usp=email )
Change subject: mb/google/brox/var/lotso: Fine tune I2C frequency
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/83290?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I985837b1b80e973f148529b446905580c0f95e98
Gerrit-Change-Number: 83290
Gerrit-PatchSet: 2
Gerrit-Owner: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Wentao Qin <qinwentao(a)huaqin.corp-partner.google.com>
Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Wentao Qin <qinwentao(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 01 Jul 2024 05:59:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Kun Liu, Wentao Qin.
Hello Kun Liu, Wentao Qin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83290?usp=email
to look at the new patch set (#2).
Change subject: mb/google/brox/var/lotso: Fine tune I2C frequency
......................................................................
mb/google/brox/var/lotso: Fine tune I2C frequency
I2C0 - 392kHz
I2C5 - 400kHz
BUG=b:349743464,b:349735055
TEST=emerge-brox sys-boot/coreboot
Change-Id: I985837b1b80e973f148529b446905580c0f95e98
Signed-off-by: Jing Tong <tongjian(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/brox/variants/lotso/overridetree.cb
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/83290/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83290?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I985837b1b80e973f148529b446905580c0f95e98
Gerrit-Change-Number: 83290
Gerrit-PatchSet: 2
Gerrit-Owner: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Wentao Qin <qinwentao(a)huaqin.corp-partner.google.com>
Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Wentao Qin <qinwentao(a)huaqin.corp-partner.google.com>
Attention is currently required from: Maximilian Brune, Philipp Hug, Ron Minnich.
Elyes Haouas has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83283?usp=email )
Change subject: arch/riscv: Add PMP print function
......................................................................
Patch Set 1:
(1 comment)
File src/arch/riscv/pmp.c:
https://review.coreboot.org/c/coreboot/+/83283/comment/dacde9b3_396e8607?us… :
PS1, Line 3: "commonlib/bsd/helpers.h"
already included via <commonlib/helpers.h>
--
To view, visit https://review.coreboot.org/c/coreboot/+/83283?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6ab1531c65b14690e37aecf57ff441bf22db1ce5
Gerrit-Change-Number: 83283
Gerrit-PatchSet: 1
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Mon, 01 Jul 2024 05:30:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Jonathan Zhang, Julius Werner, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, Tim Chu.
Hello Arthur Heymans, Christian Walter, Johnny Lin, Jonathan Zhang, Julius Werner, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, Tim Chu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83288?usp=email
to look at the new patch set (#2).
Change subject: tree: Use <console/console.h> only when used
......................................................................
tree: Use <console/console.h> only when used
Change-Id: I3cb1f11beba61afdf2be6188bde9ff135f8ace50
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M src/arch/arm64/dma.c
M src/arch/arm64/smbios.c
M src/include/device/dram/rcd.h
M src/mainboard/ibm/sbp1/romstage.c
M src/soc/intel/xeon_sp/chip_gen6.c
M src/soc/qualcomm/common/include/soc/qup_se_handlers_common.h
M src/soc/qualcomm/common/include/soc/usb/qmp_usb_phy.h
M src/soc/qualcomm/common/include/soc/usb/qusb_phy.h
M src/soc/qualcomm/common/include/soc/usb/snps_usb_phy.h
M src/soc/qualcomm/common/qupv3_spi.c
M src/soc/qualcomm/common/usb/qmpv3_usb_phy.c
M src/soc/qualcomm/common/usb/qmpv4_usb_phy.c
M src/soc/qualcomm/common/usb/qusb_phy.c
M src/soc/qualcomm/common/usb/snps_usb_phy.c
M src/superio/ite/it8772f/superio.c
15 files changed, 5 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/83288/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83288?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3cb1f11beba61afdf2be6188bde9ff135f8ace50
Gerrit-Change-Number: 83288
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>