coreboot-gerrit July 2024

coreboot-gerrit@coreboot.org

1 participants
3025 discussions

[S] Change in coreboot[main]: tree: Use <console/console.h> only when needed
by Elyes Haouas (Code Review) 01 Jul '24

01 Jul '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83288?usp=email ) Change subject: tree: Use <console/console.h> only when needed ...................................................................... tree: Use <console/console.h> only when needed Change-Id: I3cb1f11beba61afdf2be6188bde9ff135f8ace50 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/arch/arm64/dma.c M src/arch/arm64/smbios.c M src/include/device/dram/rcd.h M src/mainboard/ibm/sbp1/romstage.c M src/soc/intel/xeon_sp/chip_gen6.c M src/soc/qualcomm/common/include/soc/qup_se_handlers_common.h M src/soc/qualcomm/common/include/soc/usb/qmp_usb_phy.h M src/soc/qualcomm/common/include/soc/usb/qusb_phy.h M src/soc/qualcomm/common/include/soc/usb/snps_usb_phy.h M src/soc/qualcomm/common/qupv3_spi.c M src/soc/qualcomm/common/usb/qmpv3_usb_phy.c M src/soc/qualcomm/common/usb/qmpv4_usb_phy.c M src/soc/qualcomm/common/usb/qusb_phy.c M src/soc/qualcomm/common/usb/snps_usb_phy.c M src/superio/ite/it8772f/superio.c 15 files changed, 5 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/83288/1 diff --git a/src/arch/arm64/dma.c b/src/arch/arm64/dma.c index cdeb50f..ec81ab7 100644 --- a/src/arch/arm64/dma.c +++ b/src/arch/arm64/dma.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <console/console.h> #include <stdlib.h> int dma_coherent(const void *ptr) diff --git a/src/arch/arm64/smbios.c b/src/arch/arm64/smbios.c index f0be956..4bf35c4 100644 --- a/src/arch/arm64/smbios.c +++ b/src/arch/arm64/smbios.c @@ -3,7 +3,6 @@ #include <arch/cache.h> #include <arch/lib_helpers.h> #include <arch/smc.h> -#include <console/console.h> #include <smbios.h> #include <stdio.h> diff --git a/src/include/device/dram/rcd.h b/src/include/device/dram/rcd.h index d0b1f2c..d8429b3 100644 --- a/src/include/device/dram/rcd.h +++ b/src/include/device/dram/rcd.h @@ -5,7 +5,6 @@ #include <types.h> #include <device/i2c_simple.h> -#include <console/console.h> enum rcw_idx { VEN_ID_L, diff --git a/src/mainboard/ibm/sbp1/romstage.c b/src/mainboard/ibm/sbp1/romstage.c index 489f09f..2c4745e 100644 --- a/src/mainboard/ibm/sbp1/romstage.c +++ b/src/mainboard/ibm/sbp1/romstage.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <console/console.h> #include <soc/romstage.h> #include <soc/ddr.h> #include <soc/soc_util.h> diff --git a/src/soc/intel/xeon_sp/chip_gen6.c b/src/soc/intel/xeon_sp/chip_gen6.c index c4462d5..8bbfbe8 100644 --- a/src/soc/intel/xeon_sp/chip_gen6.c +++ b/src/soc/intel/xeon_sp/chip_gen6.c @@ -2,7 +2,6 @@ #include <acpi/acpigen_pci.h> #include <assert.h> -#include <console/console.h> #include <device/pci.h> #include <intelblocks/acpi.h> #include <post.h> diff --git a/src/soc/qualcomm/common/include/soc/qup_se_handlers_common.h b/src/soc/qualcomm/common/include/soc/qup_se_handlers_common.h index a004c79..b9dfb25 100644 --- a/src/soc/qualcomm/common/include/soc/qup_se_handlers_common.h +++ b/src/soc/qualcomm/common/include/soc/qup_se_handlers_common.h @@ -3,7 +3,6 @@ #ifndef __SOC_COMMON_QCOM_QUP_SE_H__ #define __SOC_COMMON_QCOM_QUP_SE_H__ -#include <console/console.h> #include <device/mmio.h> #include <gpio.h> #include <soc/addressmap.h> diff --git a/src/soc/qualcomm/common/include/soc/usb/qmp_usb_phy.h b/src/soc/qualcomm/common/include/soc/usb/qmp_usb_phy.h index fc1721a..ad93865 100644 --- a/src/soc/qualcomm/common/include/soc/usb/qmp_usb_phy.h +++ b/src/soc/qualcomm/common/include/soc/usb/qmp_usb_phy.h @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/mmio.h> -#include <console/console.h> /* USB3PHY_PCIE_USB3_PCS_PCS_STATUS bit */ #define USB3_PCS_PHYSTATUS BIT(6) diff --git a/src/soc/qualcomm/common/include/soc/usb/qusb_phy.h b/src/soc/qualcomm/common/include/soc/usb/qusb_phy.h index dd4a736..90c6ff3 100644 --- a/src/soc/qualcomm/common/include/soc/usb/qusb_phy.h +++ b/src/soc/qualcomm/common/include/soc/usb/qusb_phy.h @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/mmio.h> -#include <console/console.h> #define PORT_TUNE1_MASK 0xf0 diff --git a/src/soc/qualcomm/common/include/soc/usb/snps_usb_phy.h b/src/soc/qualcomm/common/include/soc/usb/snps_usb_phy.h index de0b385..353aba5 100644 --- a/src/soc/qualcomm/common/include/soc/usb/snps_usb_phy.h +++ b/src/soc/qualcomm/common/include/soc/usb/snps_usb_phy.h @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/mmio.h> -#include <console/console.h> struct usb_board_data { /*Register values going to override from the boardfile*/ diff --git a/src/soc/qualcomm/common/qupv3_spi.c b/src/soc/qualcomm/common/qupv3_spi.c index 1bb5c75..5e05d57 100644 --- a/src/soc/qualcomm/common/qupv3_spi.c +++ b/src/soc/qualcomm/common/qupv3_spi.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <assert.h> +#include <console/console.h> #include <lib.h> #include <soc/clock.h> #include <soc/gpio.h> diff --git a/src/soc/qualcomm/common/usb/qmpv3_usb_phy.c b/src/soc/qualcomm/common/usb/qmpv3_usb_phy.c index c1782be..8c4c339 100644 --- a/src/soc/qualcomm/common/usb/qmpv3_usb_phy.c +++ b/src/soc/qualcomm/common/usb/qmpv3_usb_phy.c @@ -1,5 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#include <console/console.h> #include <timer.h> #include <soc/usb/qmp_usb_phy.h> #include <soc/addressmap.h> diff --git a/src/soc/qualcomm/common/usb/qmpv4_usb_phy.c b/src/soc/qualcomm/common/usb/qmpv4_usb_phy.c index 23ab75a..6a5d7ab 100644 --- a/src/soc/qualcomm/common/usb/qmpv4_usb_phy.c +++ b/src/soc/qualcomm/common/usb/qmpv4_usb_phy.c @@ -1,5 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#include <console/console.h> #include <timer.h> #include <soc/usb/qmp_usb_phy.h> #include <soc/addressmap.h> diff --git a/src/soc/qualcomm/common/usb/qusb_phy.c b/src/soc/qualcomm/common/usb/qusb_phy.c index ddb087f..0defd2f 100644 --- a/src/soc/qualcomm/common/usb/qusb_phy.c +++ b/src/soc/qualcomm/common/usb/qusb_phy.c @@ -1,5 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#include <console/console.h> #include <soc/usb/qusb_phy.h> #include <soc/efuse.h> #include <timer.h> diff --git a/src/soc/qualcomm/common/usb/snps_usb_phy.c b/src/soc/qualcomm/common/usb/snps_usb_phy.c index d04694b..a7ad7ba 100644 --- a/src/soc/qualcomm/common/usb/snps_usb_phy.c +++ b/src/soc/qualcomm/common/usb/snps_usb_phy.c @@ -1,5 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#include <console/console.h> #include <soc/usb/snps_usb_phy.h> #include <soc/addressmap.h> #include <commonlib/helpers.h> diff --git a/src/superio/ite/it8772f/superio.c b/src/superio/ite/it8772f/superio.c index 268df0a..662b8a2 100644 --- a/src/superio/ite/it8772f/superio.c +++ b/src/superio/ite/it8772f/superio.c @@ -2,7 +2,6 @@ #include <device/device.h> #include <device/pnp.h> -#include <console/console.h> #include <pc80/keyboard.h> #include <superio/ite/common/env_ctrl.h> #include <arch/io.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/83288?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3cb1f11beba61afdf2be6188bde9ff135f8ace50 Gerrit-Change-Number: 83288 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: security/vboot: Set VBOOT_ALWAYS_ENABLE_DISPLAY if BMP_LOGO
by Subrata Banik (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Julius Werner, Yu-Ping Wu. Subrata Banik has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/83256?usp=email ) Change subject: security/vboot: Set VBOOT_ALWAYS_ENABLE_DISPLAY if BMP_LOGO ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83256?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I20113ec464aa036d0498dedb50f0e82cb677ae93 Gerrit-Change-Number: 83256 Gerrit-PatchSet: 2 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 01 Jul 2024 05:14:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in coreboot[main]: mb/starlabs/byte_adl: Add Alder Lake N Byte Mk II
by Elyes Haouas (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Sean Rhodes. Elyes Haouas has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/80705?usp=email ) Change subject: mb/starlabs/byte_adl: Add Alder Lake N Byte Mk II ...................................................................... Patch Set 7: (1 comment) File src/mainboard/starlabs/byte_adl/bootblock.c: https://review.coreboot.org/c/coreboot/+/80705/comment/42bbfaa0_19f25453?us… : PS7, Line 6: <console/console.h> maybe not used -- To view, visit https://review.coreboot.org/c/coreboot/+/80705?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idff2d883a8c29f0fee9d633708aac92061a45132 Gerrit-Change-Number: 80705 Gerrit-PatchSet: 7 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Mon, 01 Jul 2024 04:26:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: util/ifdtool: fix spacing issues
by Subrata Banik (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Alexander Goncharov, Leah Rowe, Reka Norman. Subrata Banik has posted comments on this change by Alexander Goncharov. ( https://review.coreboot.org/c/coreboot/+/83281?usp=email ) Change subject: util/ifdtool: fix spacing issues ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83281?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I817b1dcf106cc360a7db56e5b4b0716d5419e2cd Gerrit-Change-Number: 83281 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Mon, 01 Jul 2024 04:24:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/google/geralt: support TAS2563 audio amp
by Yidi Lin (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Hung-Te Lin, Rui Zhou, Yu-Ping Wu. Yidi Lin has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/83287?usp=email ) Change subject: mb/google/geralt: support TAS2563 audio amp ...................................................................... Patch Set 2: (2 comments) File src/mainboard/google/geralt/chromeos.c: https://review.coreboot.org/c/coreboot/+/83287/comment/4cece5ee_fff89bc8?us… : PS1, Line 56: if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_MAX98390))) { > In the depthcharge stage, we need to use the value of GPIO_RST_SPKR_L. […] You can still use FW_CONFIG in depthcharge. The if statement here should be ``` if (CONFIG(GERALT_USE_NAU8318)) { ... } else if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_MAX98390)) || fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_TAS2563))) { ... ) ``` File src/mainboard/google/geralt/devicetree.cb: https://review.coreboot.org/c/coreboot/+/83287/comment/0b70b591_c549d6ef?us… : PS1, Line 4: AUDIO_AMP > Because it's not used in the current subproject, no changes have been made. It seems that no project uses NAU8318 and NAU8318 is default disabled on Geralt. Let's keep the setting for now. -- To view, visit https://review.coreboot.org/c/coreboot/+/83287?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie9f0cbc30dd950b85581fc1924fa351efe1e0aab Gerrit-Change-Number: 83287 Gerrit-PatchSet: 2 Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 01 Jul 2024 03:39:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/intel/tglrvp/dt: Remove superfluous USB2_PORT_EMPTY settings
by Felix Singer (Code Review) 01 Jul '24

01 Jul '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83246?usp=email ) Change subject: mb/intel/tglrvp/dt: Remove superfluous USB2_PORT_EMPTY settings ...................................................................... mb/intel/tglrvp/dt: Remove superfluous USB2_PORT_EMPTY settings Configuring USB2_PORT_EMPTY is equal to just not setting it. So remove it to clean up a bit. Change-Id: I6854f4a0d3e7b51b242549556a5838d4183d3473 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/83246 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Eric Lai <ericllai(a)google.com> --- M src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb M src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb 2 files changed, 0 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb index fede521..9c5fa6d 100644 --- a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb +++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb @@ -181,7 +181,6 @@ device ref south_xhci on register "usb2_ports" = "{ [0] = USB2_PORT_MID(OC0), // Type-C Port1 - [1] = USB2_PORT_EMPTY, // M.2 WWAN [2] = USB2_PORT_MID(OC3), // M.2 Bluetooth [3] = USB2_PORT_MID(OC0), // USB3/2 Type A port1 [4] = USB2_PORT_MID(OC0), // Type-C Port2 diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb index 23ccfb9..578eb98 100644 --- a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb +++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb @@ -189,14 +189,10 @@ device ref south_xhci on register "usb2_ports" = "{ [0] = USB2_PORT_MID(OC3), // Type-C Port1 - [1] = USB2_PORT_EMPTY, // M.2 WWAN [2] = USB2_PORT_MID(OC0), // M.2 Bluetooth, USB3/2 Type A Port1 [3] = USB2_PORT_MID(OC3), // USB3/2 Type A Port 1 [4] = USB2_PORT_MID(OC3), // Type-C Port2 [5] = USB2_PORT_MID(OC3), // Type-C Port3 / MECC - [6] = USB2_PORT_EMPTY, // Not used - [7] = USB2_PORT_EMPTY, // Not used - [8] = USB2_PORT_EMPTY, // Not used [9] = USB2_PORT_MID(OC3), // CNVi/BT }" -- To view, visit https://review.coreboot.org/c/coreboot/+/83246?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6854f4a0d3e7b51b242549556a5838d4183d3473 Gerrit-Change-Number: 83246 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in coreboot[main]: util/ifdtool: fix spacing issues
by Eric Lai (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Alexander Goncharov, Leah Rowe, Reka Norman, Subrata Banik. Eric Lai has posted comments on this change by Alexander Goncharov. ( https://review.coreboot.org/c/coreboot/+/83281?usp=email ) Change subject: util/ifdtool: fix spacing issues ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83281?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I817b1dcf106cc360a7db56e5b4b0716d5419e2cd Gerrit-Change-Number: 83281 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Mon, 01 Jul 2024 03:18:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/intel/tglrvp/dt: Remove superfluous USB2_PORT_EMPTY settings
by Eric Lai (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Elyes Haouas, Felix Singer. Eric Lai has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83246?usp=email ) Change subject: mb/intel/tglrvp/dt: Remove superfluous USB2_PORT_EMPTY settings ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83246?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6854f4a0d3e7b51b242549556a5838d4183d3473 Gerrit-Change-Number: 83246 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 01 Jul 2024 03:16:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/google/geralt: support TAS2563 audio amp
by Rui Zhou (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Rui Zhou has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/83287?usp=email ) Change subject: mb/google/geralt: support TAS2563 audio amp ...................................................................... Patch Set 2: (2 comments) File src/mainboard/google/geralt/chromeos.c: https://review.coreboot.org/c/coreboot/+/83287/comment/f9fcab74_5e3300f3?us… : PS1, Line 56: if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_MAX98390))) { > It looks like the configuration for MAX98390 and TAS2563 are the same in coreboot. […] In the depthcharge stage, we need to use the value of GPIO_RST_SPKR_L.id to distinguish, so we judge separately. File src/mainboard/google/geralt/devicetree.cb: https://review.coreboot.org/c/coreboot/+/83287/comment/24545eed_13f8740f?us… : PS1, Line 4: AUDIO_AMP > do we reserve the bits for NAU8318 ? Because it's not used in the current subproject, no changes have been made. -- To view, visit https://review.coreboot.org/c/coreboot/+/83287?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie9f0cbc30dd950b85581fc1924fa351efe1e0aab Gerrit-Change-Number: 83287 Gerrit-PatchSet: 2 Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 01 Jul 2024 02:18:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[S] Change in coreboot[main]: mb/google/geralt: support TAS2563 audio amp
by Yidi Lin (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Hung-Te Lin, Rui Zhou, Yu-Ping Wu. Yidi Lin has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/83287?usp=email ) Change subject: mb/google/geralt: support TAS2563 audio amp ...................................................................... Patch Set 1: (2 comments) File src/mainboard/google/geralt/chromeos.c: https://review.coreboot.org/c/coreboot/+/83287/comment/348e1f1b_32f838d4?us… : PS1, Line 56: if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_MAX98390))) { It looks like the configuration for MAX98390 and TAS2563 are the same in coreboot. If we only differentiate the AMPs in payload, you can just write ``` if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_MAX98390)) || fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_TAS2563))) { ... ) ``` File src/mainboard/google/geralt/devicetree.cb: https://review.coreboot.org/c/coreboot/+/83287/comment/fb4390e5_548a5e19?us… : PS1, Line 4: AUDIO_AMP do we reserve the bits for NAU8318 ? -- To view, visit https://review.coreboot.org/c/coreboot/+/83287?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie9f0cbc30dd950b85581fc1924fa351efe1e0aab Gerrit-Change-Number: 83287 Gerrit-PatchSet: 1 Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 01 Jul 2024 02:00:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2024