Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83312?usp=email )
Change subject: doc/tutorial/part1.md: Remove trailing whitespace
......................................................................
doc/tutorial/part1.md: Remove trailing whitespace
Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com>
Change-Id: Ife87475d367c5491807215342536e3bb0fd15a45
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83312
Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M Documentation/tutorial/part1.md
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
build bot (Jenkins): Verified
Elyes Haouas: Looks good to me, approved
diff --git a/Documentation/tutorial/part1.md b/Documentation/tutorial/part1.md
index 0500742..eea2e17 100644
--- a/Documentation/tutorial/part1.md
+++ b/Documentation/tutorial/part1.md
@@ -149,7 +149,7 @@
Note that this may differ depending on the revision of the coreboot
source you are building from and should not be taken as the required
-contents of defconfig.
+contents of defconfig.
### Step 6 - Build coreboot
--
To view, visit https://review.coreboot.org/c/coreboot/+/83312?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ife87475d367c5491807215342536e3bb0fd15a45
Gerrit-Change-Number: 83312
Gerrit-PatchSet: 2
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Nicholas Chin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83344?usp=email )
Change subject: autoport: Print location of generated sources
......................................................................
autoport: Print location of generated sources
Autoport determines the mainboard vendor and board names based on DMI
entries, which sometimes doesn't result in the most obvious name. In
addition, newcomers may not be familiar with coreboot's directory
structure and have no idea where to look. Print out the absolute patch
of the generated sources once autoport finishes so that it is easier to
locate the files.
Change-Id: I4ba00484ac57355d7539fa6e36e0e6df62719f8a
Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com>
---
M util/autoport/main.go
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/83344/1
diff --git a/util/autoport/main.go b/util/autoport/main.go
index b7130b2..18fb694 100644
--- a/util/autoport/main.go
+++ b/util/autoport/main.go
@@ -8,6 +8,7 @@
"fmt"
"log"
"os"
+ "path/filepath"
"sort"
"strings"
)
@@ -903,4 +904,6 @@
end GMA.Mainboard;
`)
}
+ outputPath, _ := filepath.Abs(ctx.BaseDirectory)
+ fmt.Printf("Done! Generated sources are in %s\n", outputPath)
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/83344?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4ba00484ac57355d7539fa6e36e0e6df62719f8a
Gerrit-Change-Number: 83344
Gerrit-PatchSet: 1
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Paul Menzel has posted comments on this change by Tony Huang. ( https://review.coreboot.org/c/coreboot/+/83300?usp=email )
Change subject: mb/google/ovis/variants/deku: Add K3KL9L90CM-MGCT to RAM ID table
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83300/comment/618d7c67_9f35755a?us… :
PS3, Line 10: K3KL9L90CM-MGCT 0 (0000)
For the record: Samsung is the manufacturer.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83300?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icb84838a6964b9318ded0573ad58a4fd1221867f
Gerrit-Change-Number: 83300
Gerrit-PatchSet: 3
Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kevin Chiu <kevin.chiu(a)quanta.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 03 Jul 2024 21:54:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Derek Huang, Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Shon Wang, Subrata Banik, Sumeet R Pawnikar.
Paul Menzel has posted comments on this change by Shon Wang. ( https://review.coreboot.org/c/coreboot/+/83302?usp=email )
Change subject: mb/google/brask/var/bujia: Hook up two missing sensors
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83302/comment/51bc4e28_efec6384?us… :
PS3, Line 7: mb/google/brask/var/bujia: Hook up two missing sensors
… for X and Y
File src/mainboard/google/brya/variants/bujia/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83302/comment/abccfee7_4ff0c446?us… :
PS3, Line 69: register "options.tsr[3].desc" = ""Memory""
Please mention the renaming in the commit message, or, even better, make it a separate commit before.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83302?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id9a17a22a717faac829e6b5e300351187a62dd43
Gerrit-Change-Number: 83302
Gerrit-PatchSet: 3
Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Derek Huang <derekhuang(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 03 Jul 2024 21:54:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Abhishek Pandit-Subedi, Keith Short, Shelley Chen.
Paul Menzel has posted comments on this change by Abhishek Pandit-Subedi. ( https://review.coreboot.org/c/coreboot/+/83252?usp=email )
Change subject: ec/google/chromeec: Stop checking CBI for UCSI
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> Abhishek is OOO. […]
Feel free to mark it as resolved, but I also put the URL into the commit message, and add a blank line above `BUG=`.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83252?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia9d820c637e56a527fd90f45b1848158a960dee7
Gerrit-Change-Number: 83252
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Pandit-Subedi <abhishekpandit(a)chromium.org>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org>
Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Keith Short <keithshort(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Keith Short <keithshort(a)chromium.org>
Gerrit-Attention: Abhishek Pandit-Subedi <abhishekpandit(a)chromium.org>
Gerrit-Comment-Date: Wed, 03 Jul 2024 21:52:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Keith Short <keithshort(a)chromium.org>