Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83457?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: commonlib/device_tree.c: Add read reg property helper
......................................................................
commonlib/device_tree.c: Add read reg property helper
Add a helper function to read the reg property.
Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com>
Change-Id: I7846eb8af390d709b0757262025cb819e9988699
---
M src/commonlib/device_tree.c
M src/commonlib/include/commonlib/device_tree.h
2 files changed, 59 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/83457/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83457?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7846eb8af390d709b0757262025cb819e9988699
Gerrit-Change-Number: 83457
Gerrit-PatchSet: 2
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: Martin L Roth, Nico Huber.
Hello Martin L Roth, Nico Huber, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83459?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: tree: Add kconfig option for testing C23 dialect
......................................................................
tree: Add kconfig option for testing C23 dialect
This adds C23 dialect for testing and prepare for C23 dialect support.
Change-Id: I07db866bebfd25f1a60d18a3228ada2957500234
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M Makefile.mk
M src/Kconfig
M src/include/stdbool.h
M src/include/stddef.h
4 files changed, 21 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/83459/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/83459?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I07db866bebfd25f1a60d18a3228ada2957500234
Gerrit-Change-Number: 83459
Gerrit-PatchSet: 7
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Attention is currently required from: Martin L Roth, Nico Huber.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83459?usp=email )
Change subject: tree: Add kconfig option for testing C2x dialect
......................................................................
Patch Set 6:
(1 comment)
File Makefile.mk:
https://review.coreboot.org/c/coreboot/+/83459/comment/4bd49071_12419fda?us… :
PS6, Line 511: gnu2x
`gnu23`as `gnu2x` is deprecated.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83459?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I07db866bebfd25f1a60d18a3228ada2957500234
Gerrit-Change-Number: 83459
Gerrit-PatchSet: 6
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Sun, 14 Jul 2024 09:57:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Felix Singer, Martin L Roth.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83452?usp=email )
Change subject: Makefile.mk: Reorganize CFLAGS_common
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Thx
--
To view, visit https://review.coreboot.org/c/coreboot/+/83452?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3216ef2e0b3cd25f343939d5b9ef932f2f91e56c
Gerrit-Change-Number: 83452
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Sun, 14 Jul 2024 09:46:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Martin L Roth, Nico Huber.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83459?usp=email )
Change subject: tree: Add kconfig option for testing C2x dialect
......................................................................
Patch Set 6:
(1 comment)
File src/include/stddef.h:
https://review.coreboot.org/c/coreboot/+/83459/comment/b149ac72_4b9715be?us… :
PS6, Line 22: >
it should be `>=`.
any way, let see if patch is the right way to build test and prepare for C2x dialect support.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83459?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I07db866bebfd25f1a60d18a3228ada2957500234
Gerrit-Change-Number: 83459
Gerrit-PatchSet: 6
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Sun, 14 Jul 2024 09:45:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Martin L Roth, Nico Huber.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83459?usp=email )
Change subject: tree: Add kconfig option for testing C2x dialect
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
Thx
--
To view, visit https://review.coreboot.org/c/coreboot/+/83459?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I07db866bebfd25f1a60d18a3228ada2957500234
Gerrit-Change-Number: 83459
Gerrit-PatchSet: 6
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Sun, 14 Jul 2024 09:38:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Elyes Haouas, Martin L Roth.
Hello Martin L Roth, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81419?usp=email
to look at the new patch set (#15).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: [for test] test upgrade crossgcc and C2X
......................................................................
[for test] test upgrade crossgcc and C2X
Change-Id: I463c303694c304bb3bf664bc1d914462e7af5dbb
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M Makefile.mk
M src/Kconfig
M util/crossgcc/buildgcc
R util/crossgcc/patches/acpica-unix2-20240321_iasl.patch
R util/crossgcc/patches/gcc-15-15-20240707_asan_shadow_offset_callback.patch
R util/crossgcc/patches/gcc-15-20240707_gnat.patch
R util/crossgcc/patches/gcc-15-20240707_libcpp.patch
R util/crossgcc/patches/gcc-15-20240707_libgcc.patch
R util/crossgcc/patches/gcc-15-20240707_musl_poisoned_calloc.patch
R util/crossgcc/patches/gcc-15-20240707_rv32iafc.patch
D util/crossgcc/sum/acpica-unix-20230628.tar.gz.cksum
A util/crossgcc/sum/acpica-unix2-20240321.tar.gz.cksum
D util/crossgcc/sum/clang-18.1.6.src.tar.xz.cksum
A util/crossgcc/sum/clang-18.1.8.src.tar.xz.cksum
D util/crossgcc/sum/clang-tools-extra-18.1.6.src.tar.xz.cksum
A util/crossgcc/sum/clang-tools-extra-18.1.8.src.tar.xz.cksum
D util/crossgcc/sum/cmake-18.1.6.src.tar.xz.cksum
A util/crossgcc/sum/cmake-18.1.8.src.tar.xz.cksum
D util/crossgcc/sum/cmake-3.29.3.tar.gz.cksum
A util/crossgcc/sum/cmake-3.30.0.tar.gz.cksum
D util/crossgcc/sum/compiler-rt-18.1.6.src.tar.xz.cksum
A util/crossgcc/sum/compiler-rt-18.1.8.src.tar.xz.cksum
D util/crossgcc/sum/gcc-14.1.0.tar.xz.cksum
A util/crossgcc/sum/gcc-15-20240707.tar.xz.cksum
D util/crossgcc/sum/libunwind-18.1.6.src.tar.xz.cksum
A util/crossgcc/sum/libunwind-18.1.8.src.tar.xz.cksum
D util/crossgcc/sum/lld-18.1.6.src.tar.xz.cksum
A util/crossgcc/sum/lld-18.1.8.src.tar.xz.cksum
D util/crossgcc/sum/llvm-18.1.6.src.tar.xz.cksum
A util/crossgcc/sum/llvm-18.1.8.src.tar.xz.cksum
M util/xcompile/xcompile
31 files changed, 52 insertions(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/81419/15
--
To view, visit https://review.coreboot.org/c/coreboot/+/81419?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I463c303694c304bb3bf664bc1d914462e7af5dbb
Gerrit-Change-Number: 81419
Gerrit-PatchSet: 15
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83460?usp=email )
Change subject: [only for test] test build using C2x dialect
......................................................................
[only for test] test build using C2x dialect
Change-Id: I4e8d3b07abea2c88455fcd5455ac1eb847b8322d
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M src/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/83460/1
diff --git a/src/Kconfig b/src/Kconfig
index 14cea50..2052803 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -100,7 +100,7 @@
config ALLOW_UNSUPPORTED_C2X
bool
- default n
+ default y
help
C2x is not supported. Don't enable this option.
Use only to build test and prepar for C2x dialect.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83460?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4e8d3b07abea2c88455fcd5455ac1eb847b8322d
Gerrit-Change-Number: 83460
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83459?usp=email )
Change subject: tree: Add kconfig option for testing C2x dialect
......................................................................
tree: Add kconfig option for testing C2x dialect
This adds C2x dialect for testing and prepar for C2x dialect support.
Change-Id: I07db866bebfd25f1a60d18a3228ada2957500234
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M Makefile.mk
M src/Kconfig
M src/include/stdbool.h
M src/include/stddef.h
4 files changed, 19 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/83459/1
diff --git a/Makefile.mk b/Makefile.mk
index bf6363a..1f6415a 100644
--- a/Makefile.mk
+++ b/Makefile.mk
@@ -507,7 +507,11 @@
# Options controlling the kind of output
CFLAGS_common += -pipe
# Options controlling C dialect
+ifeq ($(CONFIG_ALLOW_UNSUPPORTED_C2X),y)
+CFLAGS_common += -std=gnu2x
+else
CFLAGS_common += -std=gnu11
+endif
# C language options
CFLAGS_common += -ffreestanding
CFLAGS_common += -fno-builtin
diff --git a/src/Kconfig b/src/Kconfig
index ef3c72c..14cea50 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -98,6 +98,13 @@
On some architectures CLANG does not work that well.
Use this only to try to get CLANG working.
+config ALLOW_UNSUPPORTED_C2X
+ bool
+ default n
+ help
+ C2x is not supported. Don't enable this option.
+ Use only to build test and prepar for C2x dialect.
+
config ANY_TOOLCHAIN
bool "Allow building with any toolchain"
default n
diff --git a/src/include/stdbool.h b/src/include/stdbool.h
index 3733527..a587673 100644
--- a/src/include/stdbool.h
+++ b/src/include/stdbool.h
@@ -3,7 +3,10 @@
#ifndef __STDBOOL_H__
#define __STDBOOL_H__
+#if __STDC_VERSION__ < 202300L
typedef _Bool bool;
+#endif
+
#define true 1
#define false 0
diff --git a/src/include/stddef.h b/src/include/stddef.h
index 82d38c3..6a68152 100644
--- a/src/include/stddef.h
+++ b/src/include/stddef.h
@@ -19,7 +19,12 @@
typedef __WCHAR_TYPE__ wchar_t;
typedef __WINT_TYPE__ wint_t;
+#if __STDC_VERSION__ > 202300L
+typedef typeof(nullptr) nullptr_t;
+#define NULL nullptr
+#else
#define NULL ((void *)0)
+#endif
/* The devicetree data structures are only mutable in ramstage. All other
stages have a constant devicetree. */
--
To view, visit https://review.coreboot.org/c/coreboot/+/83459?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I07db866bebfd25f1a60d18a3228ada2957500234
Gerrit-Change-Number: 83459
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>