Attention is currently required from: Eric Lai, Karthik Ramasubramanian, Lawrence Chang, Tongtong Pan.
Weimin Wu has posted comments on this change by Tongtong Pan. ( https://review.coreboot.org/c/coreboot/+/83427?usp=email )
Change subject: mb/google/dedede/variants/awasuki: Generate 3 RAM IDs
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/83427?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9a03c86770101ec70c2ee5d6b914313c1bf23b5f
Gerrit-Change-Number: 83427
Gerrit-PatchSet: 5
Gerrit-Owner: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Lawrence Chang <lawrence.chang(a)intel.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Lawrence Chang <lawrence.chang(a)intel.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Sun, 14 Jul 2024 04:28:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Eric Lai, Karthik Ramasubramanian, Lawrence Chang, Tongtong Pan.
Weimin Wu has posted comments on this change by Tongtong Pan. ( https://review.coreboot.org/c/coreboot/+/83376?usp=email )
Change subject: mb/google/dedede: Create awasuki variant
......................................................................
Patch Set 10: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/83376?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If18afc92afdbdff5df3f5b034f4357feda6690b0
Gerrit-Change-Number: 83376
Gerrit-PatchSet: 10
Gerrit-Owner: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Lawrence Chang <lawrence.chang(a)intel.com>
Gerrit-Reviewer: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Lawrence Chang <lawrence.chang(a)intel.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Sun, 14 Jul 2024 04:28:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Eric Lai, Karthik Ramasubramanian, Lawrence Chang, Weimin Wu.
Tongtong Pan has posted comments on this change by Tongtong Pan. ( https://review.coreboot.org/c/coreboot/+/83427?usp=email )
Change subject: mb/google/dedede/variants/awasuki: Generate 3 RAM IDs
......................................................................
Patch Set 5:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83427?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9a03c86770101ec70c2ee5d6b914313c1bf23b5f
Gerrit-Change-Number: 83427
Gerrit-PatchSet: 5
Gerrit-Owner: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Lawrence Chang <lawrence.chang(a)intel.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Lawrence Chang <lawrence.chang(a)intel.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Sun, 14 Jul 2024 04:10:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: Eric Lai, Karthik Ramasubramanian, Lawrence Chang, Weimin Wu.
Tongtong Pan has posted comments on this change by Tongtong Pan. ( https://review.coreboot.org/c/coreboot/+/83376?usp=email )
Change subject: mb/google/dedede: Create awasuki variant
......................................................................
Patch Set 10:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83376?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If18afc92afdbdff5df3f5b034f4357feda6690b0
Gerrit-Change-Number: 83376
Gerrit-PatchSet: 10
Gerrit-Owner: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Lawrence Chang <lawrence.chang(a)intel.com>
Gerrit-Reviewer: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Lawrence Chang <lawrence.chang(a)intel.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Sun, 14 Jul 2024 04:10:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: Nicholas Chin.
Hello Felix Singer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83458?usp=email
to look at the new patch set (#2).
Change subject: util/find_usbdebug: Add 8/9 Series PCH rate matching hub IDs
......................................................................
util/find_usbdebug: Add 8/9 Series PCH rate matching hub IDs
The USB IDs of the EHCI rate matching hubs found in these chipsets were
missing, preventing the utility from detecting connected USB devices.
Change-Id: I52858e2c75e8a3e1424a13bcddc2f5ec1216164b
Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com>
---
M util/find_usbdebug/find_usbdebug.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/83458/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83458?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I52858e2c75e8a3e1424a13bcddc2f5ec1216164b
Gerrit-Change-Number: 83458
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Attention is currently required from: Nicholas Chin.
Felix Singer has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83458?usp=email )
Change subject: util/find_usbdebug: Add 8/9 Series PCH rate matching hub IDs
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83458?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I52858e2c75e8a3e1424a13bcddc2f5ec1216164b
Gerrit-Change-Number: 83458
Gerrit-PatchSet: 1
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Sun, 14 Jul 2024 01:48:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Nicholas Chin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83458?usp=email )
Change subject: util/find_usbdebug: Add 8/9 Series PCH rate matching hub IDs
......................................................................
util/find_usbdebug: Add 8/9 Series PCH rate matching hub IDs
The USB IDs of the EHCI rate matching hubs found in these chipsets was
missing, preventing the utility from detecting connected USB devices.
Change-Id: I52858e2c75e8a3e1424a13bcddc2f5ec1216164b
Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com>
---
M util/find_usbdebug/find_usbdebug.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/83458/1
diff --git a/util/find_usbdebug/find_usbdebug.sh b/util/find_usbdebug/find_usbdebug.sh
index 53b9a7f..6d5837b 100755
--- a/util/find_usbdebug/find_usbdebug.sh
+++ b/util/find_usbdebug/find_usbdebug.sh
@@ -35,7 +35,7 @@
busstr=`printf "Bus %02d" "$bus"`
portstr="Port $port"
- hubs_to_ignore="8087:0020 8087:0024"
+ hubs_to_ignore="8087:0021 8087:0026 8087:8000 8087:8008"
reqlvl=1
found=
--
To view, visit https://review.coreboot.org/c/coreboot/+/83458?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I52858e2c75e8a3e1424a13bcddc2f5ec1216164b
Gerrit-Change-Number: 83458
Gerrit-PatchSet: 1
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Maximilian Brune has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83457?usp=email )
Change subject: commonlib/device_tree.c: Add read reg property helper
......................................................................
commonlib/device_tree.c: Add read reg property helper
Add a helper function to read the reg property.
Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com>
Change-Id: I7846eb8af390d709b0757262025cb819e9988699
---
M src/commonlib/device_tree.c
M src/commonlib/include/commonlib/device_tree.h
2 files changed, 56 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/83457/1
diff --git a/src/commonlib/device_tree.c b/src/commonlib/device_tree.c
index 0ec6ea9..37c0ecc 100644
--- a/src/commonlib/device_tree.c
+++ b/src/commonlib/device_tree.c
@@ -981,6 +981,60 @@
*/
/*
+ * dt_read_reg_prop reads the reg property inside a node
+ *
+ * @params node device tree node to read reg property from
+ * @params addr_cells number of cells used for one address
+ * @params size_cells number of cells used for one size
+ * @params regions all regions that are read inside the reg property are saved inside
+ * this array
+ * @params regions_count maximum number of entries that can be saved inside the regions array.
+ *
+ * Returns: Either 0 on error or returns the number of regions put into the regions array.
+ */
+size_t dt_read_reg_prop(struct device_tree_node *node, u32 addr_cells, u32 size_cells,
+ struct device_tree_region regions[], size_t regions_count)
+{
+ struct device_tree_property *prop;
+ bool found = false;
+ list_for_each(prop, node->properties, list_node)
+ if (!strcmp("reg", prop->prop.name))
+ found = true;
+
+ if (!found) {
+ printk(BIOS_DEBUG, "no reg property found\n");
+ return 0;
+ }
+
+ // we found the reg property, no need to parse all regions in 'reg'
+ size_t count = prop->prop.size / (4 * addr_cells + 4 * size_cells);
+ if (count > regions_count) {
+ printk(BIOS_ERR, "reg property has more entries (%zd) than regions array can hold (%zd)\n", count, regions_count);
+ count = regions_count;
+ }
+ if (addr_cells > 2 || size_cells > 2) {
+ printk(BIOS_ERR, "addr_cells (%d) or size_cells (%d) bigger than 2\n",
+ addr_cells, size_cells);
+ return 0;
+ }
+ uint32_t *ptr = prop->prop.data;
+ for (int i = 0; i < count; i++) {
+ if (addr_cells == 1)
+ regions[i].addr = be32dec(ptr);
+ else if (addr_cells == 2)
+ regions[i].addr = be64dec(ptr);
+ ptr += addr_cells;
+ if (size_cells == 1)
+ regions[i].size = be32dec(ptr);
+ else if (size_cells == 2)
+ regions[i].size = be64dec(ptr);
+ ptr += size_cells;
+ }
+
+ return count; // return the number of regions found in the reg property
+}
+
+/*
* Read #address-cells and #size-cells properties from a node.
*
* @param node The device tree node to read from.
diff --git a/src/commonlib/include/commonlib/device_tree.h b/src/commonlib/include/commonlib/device_tree.h
index 81377fa..225ef3e 100644
--- a/src/commonlib/include/commonlib/device_tree.h
+++ b/src/commonlib/include/commonlib/device_tree.h
@@ -147,6 +147,8 @@
/* Flatten a device tree into the buffer pointed to by dest. */
void dt_flatten(const struct device_tree *tree, void *dest);
void dt_print_node(const struct device_tree_node *node);
+size_t dt_read_reg_prop(struct device_tree_node *node, u32 addr_cells, u32 size_cells,
+ struct device_tree_region regions[], size_t regions_count);
/* Read #address-cells and #size-cells properties from a node. */
void dt_read_cell_props(const struct device_tree_node *node, u32 *addrcp,
u32 *sizecp);
--
To view, visit https://review.coreboot.org/c/coreboot/+/83457?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7846eb8af390d709b0757262025cb819e9988699
Gerrit-Change-Number: 83457
Gerrit-PatchSet: 1
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Attention is currently required from: Sean Rhodes.
Hello Sean Rhodes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83456?usp=email
to look at the new patch set (#2).
Change subject: mb/starlabs/starbook/cml: Drop superfluous devices from devicetree
......................................................................
mb/starlabs/starbook/cml: Drop superfluous devices from devicetree
In order to clean up a bit, drop devices which are equivalent to the
ones from chipset devicetree.
Change-Id: I92765b404508901c7e84fad0bca30489cf69abac
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M src/mainboard/starlabs/starbook/variants/cml/devicetree.cb
1 file changed, 0 insertions(+), 36 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/83456/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83456?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I92765b404508901c7e84fad0bca30489cf69abac
Gerrit-Change-Number: 83456
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83456?usp=email )
Change subject: starlabs/starbook/cml: Drop superfluous devices from devicetree
......................................................................
starlabs/starbook/cml: Drop superfluous devices from devicetree
In order to clean up a bit, drop devices which are equivalent to the
ones from chipset devicetree.
Change-Id: I92765b404508901c7e84fad0bca30489cf69abac
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M src/mainboard/starlabs/starbook/variants/cml/devicetree.cb
1 file changed, 0 insertions(+), 36 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/83456/1
diff --git a/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb b/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb
index 6f800cb..448fc29 100644
--- a/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb
+++ b/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb
@@ -51,14 +51,10 @@
# Actual device tree.
device domain 0 on
- device ref system_agent on end
device ref igpu on end
device ref dptf on
register "Device4Enable" = "1"
end
- device ref thermal off end
- device ref ufs off end
- device ref gspi2 off end
device ref xhci on
# Motherboard USB Type C
register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC_SKIP)"
@@ -81,7 +77,6 @@
# Internal Bluetooth
register "usb2_ports[9]" = "USB2_PORT_MID(OC_SKIP)"
end
- device ref xdci off end
device ref shared_sram on end
device ref cnvi_wifi on
chip drivers/wifi/generic
@@ -89,7 +84,6 @@
device generic 0 on end
end
end
- device ref sdxc off end
device ref i2c0 on
chip drivers/i2c/hid
register "generic.hid" = ""STAR0001""
@@ -100,15 +94,6 @@
device i2c 2c on end
end
end
- device ref i2c1 off end
- device ref i2c2 off end
- device ref i2c3 off end
- device ref heci1 on end
- device ref heci2 off end
- device ref csme_ider off end
- device ref csme_ktr off end
- device ref heci3 off end
- device ref heci4 off end
device ref sata on
register "SataSalpSupport" = "1"
# Port 1
@@ -116,17 +101,7 @@
register "SataPortsDevSlp[1]" = "1"
end
device ref i2c4 on end
- device ref i2c5 off end
device ref uart2 on end
- device ref emmc off end
- device ref pcie_rp1 off end
- device ref pcie_rp2 off end
- device ref pcie_rp3 off end
- device ref pcie_rp4 off end
- device ref pcie_rp5 off end
- device ref pcie_rp6 off end
- device ref pcie_rp7 off end
- device ref pcie_rp8 off end
device ref pcie_rp9 on # SSD x4
register "PcieRpSlotImplemented[8]" = "1"
register "PcieRpEnable[8]" = "1"
@@ -135,13 +110,6 @@
register "PcieClkSrcClkReq[1]" = "1"
smbios_slot_desc "SlotTypeM2Socket3" "SlotLengthOther" "M.2/M 2280" "SlotDataBusWidth4X"
end
- device ref pcie_rp10 off end
- device ref pcie_rp11 off end
- device ref pcie_rp12 off end
- device ref uart0 off end
- device ref uart1 off end
- device ref gspi0 off end
- device ref gspi1 off end
device ref lpc_espi on
register "gen1_dec" = "0x000c0681"
register "gen2_dec" = "0x000c1641"
@@ -172,14 +140,10 @@
device pnp 4e.19 off end # Power Management Channel 5
end
end
- device ref p2sb on end
- device ref pmc hidden end
device ref hda on
register "PchHdaAudioLinkHda" = "1"
end
device ref smbus on end
- device ref fast_spi on end
- device ref gbe off end
end
chip drivers/crb
device mmio 0xfed40000 on end
--
To view, visit https://review.coreboot.org/c/coreboot/+/83456?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I92765b404508901c7e84fad0bca30489cf69abac
Gerrit-Change-Number: 83456
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>