Attention is currently required from: Karthik Ramasubramanian, Lawrence Chang, Tongtong Pan, Weimin Wu.
Dolan Liu has uploaded a new patch set (#6) to the change originally created by Tongtong Pan. ( https://review.coreboot.org/c/coreboot/+/83427?usp=email )
The following approvals got outdated and were removed:
Code-Review+1 by Weimin Wu
Change subject: mb/google/dedede/var/awasuki: Generate 3 RAM IDs
......................................................................
mb/google/dedede/var/awasuki: Generate 3 RAM IDs
Vendor DRAM Part Name Type
SAMSUNG K4U6E3S4AB-MGCL LP4X
SAMSUNG K4UBE3D4AB-MGCL LP4X
MICRON MT53E1G32D2NP-046 WT:B LP4X
BUG=b:351968527
TEST=Run part_id_gen tool without any errors
Change-Id: I9a03c86770101ec70c2ee5d6b914313c1bf23b5f
Signed-off-by: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/dedede/variants/awasuki/memory/Makefile.mk
M src/mainboard/google/dedede/variants/awasuki/memory/dram_id.generated.txt
M src/mainboard/google/dedede/variants/awasuki/memory/mem_parts_used.txt
3 files changed, 17 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/83427/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/83427?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9a03c86770101ec70c2ee5d6b914313c1bf23b5f
Gerrit-Change-Number: 83427
Gerrit-PatchSet: 6
Gerrit-Owner: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Lawrence Chang <lawrence.chang(a)intel.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Lawrence Chang <lawrence.chang(a)intel.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Attention is currently required from: Nicholas Sudsgaard, Ron Minnich.
Michael Niewöhner has posted comments on this change by Nicholas Sudsgaard. ( https://review.coreboot.org/c/coreboot/+/80470?usp=email )
Change subject: util: Add hda-decoder
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80470?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib4fb652e178517b2b7aceaac8be005c5b2d3b03e
Gerrit-Change-Number: 80470
Gerrit-PatchSet: 8
Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Mon, 15 Jul 2024 07:22:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Felix Singer.
Michael Niewöhner has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83441?usp=email )
Change subject: mb/clevo/cml-u/dt: Make use of chipset devicetree
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83441?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifc882c2ac9d4e9ce2ed4305bdd6859a5d1e1b09c
Gerrit-Change-Number: 83441
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Comment-Date: Mon, 15 Jul 2024 07:20:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Eric Herrmann, Shelley Chen.
Sowmya Aralguppe has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/83406?usp=email )
Change subject: mb/google/brox: Reduce PL values for booting without battery
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
I am making sure that these values work on both SKU1 and SKU2 proto-2 boards for 65Watts and 45Watts charger(for SKU1) consistently on few boards in the lab.
I will address review comments shortly after confirming that this a proper fix without regression
--
To view, visit https://review.coreboot.org/c/coreboot/+/83406?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia0074bfc97c54f07d0b7257393de7c355e36b262
Gerrit-Change-Number: 83406
Gerrit-PatchSet: 2
Gerrit-Owner: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com>
Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Reviewer: Deepti Deshatty <deepti.deshatty(a)intel.com>
Gerrit-Reviewer: Eric Herrmann <eherrmann(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Eric Herrmann <eherrmann(a)google.com>
Gerrit-Comment-Date: Mon, 15 Jul 2024 06:38:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Nick Vaccaro, Pranava Y N, Subrata Banik.
Dinesh Gehlot has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/83462?usp=email )
Change subject: util/cbfstool: Add eventLog support for ELOG_TYPE_FW_LATE_SOL
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83462?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I862db946f6ff622ac83072e6bf27832732c0c318
Gerrit-Change-Number: 83462
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Comment-Date: Mon, 15 Jul 2024 05:53:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Nick Vaccaro, Pranava Y N, Subrata Banik.
Dinesh Gehlot has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/83461?usp=email )
Change subject: commonlib: Add ELOG_TYPE_FW_LATE_SOL eventLog type
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83461?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibbe9f37a791e5c2a0c6e982942cf3043a2bd4b45
Gerrit-Change-Number: 83461
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Comment-Date: Mon, 15 Jul 2024 05:53:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes