Attention is currently required from: Lorenzo Aloe, Máté Kukri.
Hello Máté Kukri, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83473?usp=email
to look at the new patch set (#7).
Change subject: src/mainboard/dell/snb_ivb_workstations/: Add variant
......................................................................
src/mainboard/dell/snb_ivb_workstations/: Add variant
The T1650 ROM works with the 9010 MT. Add "optiplex_9010_mt". Add entries in Kconfig and Kconfig.name.
The OptiPlexes and Precision use different PCH SKUs, but they use the same PCB.
Change-Id: I34b7812c3504a80b5730887f1dfa8bef43513abe
Signed-off-by: Lorenzo Aloe <laloe.2fu42(a)8shield.net>
---
M src/mainboard/dell/snb_ivb_workstations/Kconfig
M src/mainboard/dell/snb_ivb_workstations/Kconfig.name
A src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_mt/data.vbt
A src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_mt/hda_verb.c
A src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_mt/include/variant/sch5545_ec_tables.h
A src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_mt/overridetree.cb
6 files changed, 309 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/83473/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/83473?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I34b7812c3504a80b5730887f1dfa8bef43513abe
Gerrit-Change-Number: 83473
Gerrit-PatchSet: 7
Gerrit-Owner: Lorenzo Aloe <laloe.2fu42(a)8shield.net>
Gerrit-Reviewer: Máté Kukri <kukri.mate(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com>
Gerrit-Attention: Lorenzo Aloe <laloe.2fu42(a)8shield.net>
Attention is currently required from: Lorenzo Aloe, Máté Kukri.
Hello Máté Kukri, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83473?usp=email
to look at the new patch set (#6).
Change subject: src/mainboard/dell/snb_ivb_workstations/: Add variant
......................................................................
src/mainboard/dell/snb_ivb_workstations/: Add variant
The T1650 ROM works with the 9010 MT. Add "optiplex_9010_mt". Add entries in Kconfig and Kconfig.name.
The OptiPlexes and Precision use different PCH SKUs, but they use the same PCB.
Change-Id: I34b7812c3504a80b5730887f1dfa8bef43513abe
Signed-off-by: Lorenzo Aloe <laloe.2fu42(a)8shield.net>
---
M src/mainboard/dell/snb_ivb_workstations/Kconfig
M src/mainboard/dell/snb_ivb_workstations/Kconfig.name
A src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_mt/data.vbt
A src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_mt/hda_verb.c
A src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_mt/include/variant/sch5545_ec_tables.h
A src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_mt/overridetree.cb
6 files changed, 309 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/83473/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/83473?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I34b7812c3504a80b5730887f1dfa8bef43513abe
Gerrit-Change-Number: 83473
Gerrit-PatchSet: 6
Gerrit-Owner: Lorenzo Aloe <laloe.2fu42(a)8shield.net>
Gerrit-Reviewer: Máté Kukri <kukri.mate(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com>
Gerrit-Attention: Lorenzo Aloe <laloe.2fu42(a)8shield.net>
Attention is currently required from: Lorenzo Aloe, Máté Kukri.
Hello Máté Kukri, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83473?usp=email
to look at the new patch set (#5).
Change subject: src/mainboard/dell/snb_ivb_workstations/: Add variant
......................................................................
src/mainboard/dell/snb_ivb_workstations/: Add variant
The T1650 ROM works with the 9010 MT. Add "optiplex_9010_mt". Add entries in Kconfig and Kconfig.name. The OptiPlexes and Precision use different PCH SKUs, but they use the same PCB.
Change-Id: I34b7812c3504a80b5730887f1dfa8bef43513abe
Signed-off-by: Lorenzo Aloe <laloe.2fu42(a)8shield.net>
---
M src/mainboard/dell/snb_ivb_workstations/Kconfig
M src/mainboard/dell/snb_ivb_workstations/Kconfig.name
A src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_mt/data.vbt
A src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_mt/hda_verb.c
A src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_mt/include/variant/sch5545_ec_tables.h
A src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_mt/overridetree.cb
6 files changed, 309 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/83473/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/83473?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I34b7812c3504a80b5730887f1dfa8bef43513abe
Gerrit-Change-Number: 83473
Gerrit-PatchSet: 5
Gerrit-Owner: Lorenzo Aloe <laloe.2fu42(a)8shield.net>
Gerrit-Reviewer: Máté Kukri <kukri.mate(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com>
Gerrit-Attention: Lorenzo Aloe <laloe.2fu42(a)8shield.net>
Attention is currently required from: Nicholas Chin.
Felix Held has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83458?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: util/find_usbdebug: Add 8/9 Series PCH rate matching hub IDs
......................................................................
Patch Set 2:
(1 comment)
File util/find_usbdebug/find_usbdebug.sh:
https://review.coreboot.org/c/coreboot/+/83458/comment/b9bcbb4f_8df2e43f?us… :
PS2, Line 38: hubs_to_ignore="8087:0020 8087:0024"
is it intentional that this patch drops the existing IDs and completely replaces them? from the commit message and without having looked too closely at the code i'd assume that only IDs were added but none removed
--
To view, visit https://review.coreboot.org/c/coreboot/+/83458?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I52858e2c75e8a3e1424a13bcddc2f5ec1216164b
Gerrit-Change-Number: 83458
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Mon, 15 Jul 2024 18:13:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Lorenzo Aloe, Máté Kukri.
Hello Máté Kukri, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83473?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: src/mainboard/dell/snb_ivb_workstations/: Add variant
......................................................................
src/mainboard/dell/snb_ivb_workstations/: Add variant
The T1650 ROM works with the 9010 MT. Add "optiplex_9010_mt". Add entires in Kconfig and Kconfig.name. The OptiPlexes and Precision use different PCH SKUs, but they use the same PCB.
Change-Id: I34b7812c3504a80b5730887f1dfa8bef43513abe
Signed-off-by: Lorenzo Aloe <laloe.2fu42(a)8shield.net>
---
M src/mainboard/dell/snb_ivb_workstations/Kconfig
M src/mainboard/dell/snb_ivb_workstations/Kconfig.name
A src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_mt/data.vbt
A src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_mt/hda_verb.c
A src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_mt/include/variant/sch5545_ec_tables.h
A src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_mt/overridetree.cb
6 files changed, 309 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/83473/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/83473?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I34b7812c3504a80b5730887f1dfa8bef43513abe
Gerrit-Change-Number: 83473
Gerrit-PatchSet: 4
Gerrit-Owner: Lorenzo Aloe <laloe.2fu42(a)8shield.net>
Gerrit-Reviewer: Máté Kukri <kukri.mate(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com>
Gerrit-Attention: Lorenzo Aloe <laloe.2fu42(a)8shield.net>