Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83474?usp=email )
Change subject: payloads/edk2/Makefile: Add $(EDK2_PATH) as dependency for 'gop_driver' target
......................................................................
payloads/edk2/Makefile: Add $(EDK2_PATH) as dependency for 'gop_driver' target
Without this, when doing a clean build with 'make j$(nproc)`, the build
can fail copying the GOP driver file since the target directory does
not exist yet.
TEST=build/boot google/hatch (akemi) w/edk2 payload and GOP driver init
on a clean git checkout.
Change-Id: Ic510d70041dc099e6bc469528b80d1e271976655
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M payloads/external/edk2/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/83474/1
diff --git a/payloads/external/edk2/Makefile b/payloads/external/edk2/Makefile
index ef3327e..3966b91 100644
--- a/payloads/external/edk2/Makefile
+++ b/payloads/external/edk2/Makefile
@@ -222,7 +222,7 @@
BMP3:$(EDK2_PATH)/MdeModulePkg/Logo/Logo.bmp;; \
esac \
-gop_driver:
+gop_driver: $(EDK2_PATH)
if [ -n "$(CONFIG_EDK2_GOP_DRIVER)" ]; then \
echo "Using GOP driver $(CONFIG_EDK2_GOP_FILE)"; \
cp $(top)/$(CONFIG_EDK2_GOP_FILE) $(EDK2_PATH)/UefiPayloadPkg/IntelGopDriver.efi; \
--
To view, visit https://review.coreboot.org/c/coreboot/+/83474?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic510d70041dc099e6bc469528b80d1e271976655
Gerrit-Change-Number: 83474
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Anastasios Koutian has posted comments on this change by Anastasios Koutian. ( https://review.coreboot.org/c/coreboot/+/83280?usp=email )
Change subject: mb/lenovo/t420: Use vendor default power limits
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
Something that might be worth looking into is to turn these values into CMOS options. That way users won't have to hack the source code, recompile and flash if they want to change power configuration 😊
--
To view, visit https://review.coreboot.org/c/coreboot/+/83280?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia187b67ae28fbcda7d5d0e35ec64a3b21d97a21b
Gerrit-Change-Number: 83280
Gerrit-PatchSet: 6
Gerrit-Owner: Anastasios Koutian <akoutian2(a)gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 15 Jul 2024 17:54:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Martin L Roth, Nico Huber.
Hello Martin L Roth, Nico Huber, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83459?usp=email
to look at the new patch set (#8).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: tree: Add kconfig option for testing C23 dialect
......................................................................
tree: Add kconfig option for testing C23 dialect
This adds C23 dialect for testing and prepare for C23 dialect support.
Change-Id: I07db866bebfd25f1a60d18a3228ada2957500234
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M Makefile.mk
M src/Kconfig
M src/include/stdbool.h
M src/include/stddef.h
4 files changed, 21 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/83459/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/83459?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I07db866bebfd25f1a60d18a3228ada2957500234
Gerrit-Change-Number: 83459
Gerrit-PatchSet: 8
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Attention is currently required from: Felix Singer, Martin L Roth.
Hello Felix Singer, Martin L Roth, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83452?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: Makefile.mk: Reorganize CFLAGS_common
......................................................................
Makefile.mk: Reorganize CFLAGS_common
Sort CFLAGS_common by kind and alphabetically.
Change-Id: I3216ef2e0b3cd25f343939d5b9ef932f2f91e56c
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M Makefile.mk
1 file changed, 27 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/83452/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/83452?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3216ef2e0b3cd25f343939d5b9ef932f2f91e56c
Gerrit-Change-Number: 83452
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Attention is currently required from: Felix Singer, Martin L Roth.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83452?usp=email )
Change subject: Makefile.mk: Reorganize CFLAGS_common
......................................................................
Patch Set 4:
(1 comment)
File Makefile.mk:
https://review.coreboot.org/c/coreboot/+/83452/comment/9f89ef9c_254437d3?us… :
PS4, Line 543: CFLAGS_common += -g
> Maybe move this before the warning options, so that the list continues with them.
In general, it is best to place the -g option at the end of the compilation flags list.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83452?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3216ef2e0b3cd25f343939d5b9ef932f2f91e56c
Gerrit-Change-Number: 83452
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Mon, 15 Jul 2024 16:04:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>