Attention is currently required from: Martin L Roth, Nico Huber, Paul Menzel.
Hello Martin L Roth, Nico Huber, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83476?usp=email
to look at the new patch set (#2).
Change subject: bootsplash: Increase heap from 1 MB to 4 MB when bootsplash is enabled
......................................................................
bootsplash: Increase heap from 1 MB to 4 MB when bootsplash is enabled
Since commit 1d029b40c9de ("lib/jpeg: Replace decoder with Wuffs'
implementation"), a relatively large heap allocation is needed to
decode many JPEGs for use as work area. The prior decoder did not need
this, but also had many limitations in the JPEGs it could decode.
A 1024x768 non-progressive JPEG used in Heads needs 1179648 bytes of
work area; about 1.2 MB. While the work area will also depend on the
subsampling of each channel, it's generally proportional to the image
size.
Increasing the heap size to 4 MB when bootsplash is enabled should be
enough to decode bootsplashes up to 1920x1080 with some headroom.
Change-Id: Ia4348d39effbc16c1b42ab01bcf1e4ec5d652fa9
Signed-off-by: Jonathon Hall <jonathon.hall(a)puri.sm>
---
M src/device/Kconfig
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/83476/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83476?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia4348d39effbc16c1b42ab01bcf1e4ec5d652fa9
Gerrit-Change-Number: 83476
Gerrit-PatchSet: 2
Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Attention is currently required from: Martin L Roth, Nico Huber, Paul Menzel.
Jonathon Hall has posted comments on this change by Jonathon Hall. ( https://review.coreboot.org/c/coreboot/+/83476?usp=email )
Change subject: bootsplash: Increase heap from 1 MB to 4 MB when bootsplash is enabled
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
The only way to get the Heads bootsplash image to work again after the switch to the Wuffs JPEG decoder is to increase the heap size, AFAIK.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83476?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia4348d39effbc16c1b42ab01bcf1e4ec5d652fa9
Gerrit-Change-Number: 83476
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Mon, 15 Jul 2024 21:06:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Jonathon Hall has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83476?usp=email )
Change subject: bootsplash: Increase heap from 1 MB to 4 MB when bootsplash is enabled
......................................................................
bootsplash: Increase heap from 1 MB to 4 MB when bootsplash is enabled
Since commit 1d029b40 ("lib/jpeg: Replace decoder with Wuffs'
implementation"), a relatively large heap allocation is needed to
decode many JPEGs for use as work area. The prior decoder did not need
this, but also had many limitations in the JPEGs it could decode.
A 1024x768 non-progressive JPEG used in Heads needs 1179648 bytes of
work area; about 1.2 MB. While the work area will also depend on the
subsampling of each channel, it's generally proportional to the image
size.
Increasing the heap size to 4 MB when bootsplash is enabled should be
enough to decode bootsplashes up to 1920x1080 with some headroom.
Change-Id: Ia4348d39effbc16c1b42ab01bcf1e4ec5d652fa9
Signed-off-by: Jonathon Hall <jonathon.hall(a)puri.sm>
---
M src/device/Kconfig
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/83476/1
diff --git a/src/device/Kconfig b/src/device/Kconfig
index 243e23e..4dd03eb 100644
--- a/src/device/Kconfig
+++ b/src/device/Kconfig
@@ -501,6 +501,11 @@
image in the 'General' section or add it manually to CBFS, using,
for example, cbfstool.
+# The bootsplash JPEG decoder requires heap space approximately proportional to
+# the image size. This usually needs a larger heap.
+config HEAP_SIZE
+ default 0x400000 if BOOTSPLASH
+
config LINEAR_FRAMEBUFFER_MAX_WIDTH
int "Maximum width in pixels"
depends on LINEAR_FRAMEBUFFER && MAINBOARD_USE_LIBGFXINIT
--
To view, visit https://review.coreboot.org/c/coreboot/+/83476?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia4348d39effbc16c1b42ab01bcf1e4ec5d652fa9
Gerrit-Change-Number: 83476
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm>
Attention is currently required from: Felix Singer.
Matt DeVillier has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83463?usp=email )
Change subject: util/liveiso/nixos: Install TPM related tools
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83463?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idbf4f40f495fac6c08a9017bfbff25043d7fbb82
Gerrit-Change-Number: 83463
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Comment-Date: Mon, 15 Jul 2024 20:27:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Matt DeVillier, Sean Rhodes.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81409?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: i2c/drivers/generic: Add support for including a CDM
......................................................................
i2c/drivers/generic: Add support for including a CDM
Chip Direct Mapping is exclusive to Windows; it allows specifying the
position where a chip in mounted. There are 8 positions and a _CDM
method should return 0xabcd0X, where X is the position.
Tested by booting Windows 11 on the StarLite Mk V, rotating the device
and checking the orientation is correct.
Change-Id: If70c25288d835df7064b4051c43abeb2d6531f3b
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
---
M src/drivers/i2c/generic/chip.h
M src/drivers/i2c/generic/generic.c
2 files changed, 23 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/81409/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/81409?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If70c25288d835df7064b4051c43abeb2d6531f3b
Gerrit-Change-Number: 81409
Gerrit-PatchSet: 5
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Attention is currently required from: Sean Rhodes.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80706?usp=email
to look at the new patch set (#8).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/starlabs/starlite_adl: Add Alder Lake N StarLite Mk V
......................................................................
mb/starlabs/starlite_adl: Add Alder Lake N StarLite Mk V
Tested using `edk2` from
`github.com/starlabsltd/edk2/tree/uefipayload_vs`:
* Windows 11
* Ubuntu 22.04
* Manjaro 22
No known issues.
https://starlabs.systems/pages/starlite-specification
Change-Id: I8724e578c21353032b844b20b868348580ff561b
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
---
M Documentation/mainboard/index.md
A Documentation/mainboard/starlabs/starlite_adl.md
A src/mainboard/starlabs/starlite_adl/Kconfig
A src/mainboard/starlabs/starlite_adl/Kconfig.name
A src/mainboard/starlabs/starlite_adl/Makefile.mk
A src/mainboard/starlabs/starlite_adl/acpi/ec.asl
A src/mainboard/starlabs/starlite_adl/acpi/mainboard.asl
A src/mainboard/starlabs/starlite_adl/acpi/sleep.asl
A src/mainboard/starlabs/starlite_adl/acpi/superio.asl
A src/mainboard/starlabs/starlite_adl/board_info.txt
A src/mainboard/starlabs/starlite_adl/bootblock.c
A src/mainboard/starlabs/starlite_adl/cmos.default
A src/mainboard/starlabs/starlite_adl/cmos.layout
A src/mainboard/starlabs/starlite_adl/dsdt.asl
A src/mainboard/starlabs/starlite_adl/hda_verb.c
A src/mainboard/starlabs/starlite_adl/include/variants.h
A src/mainboard/starlabs/starlite_adl/mainboard.c
A src/mainboard/starlabs/starlite_adl/smbios.c
A src/mainboard/starlabs/starlite_adl/spd/Makefile.mk
A src/mainboard/starlabs/starlite_adl/spd/mt62f2g64d8.spd.hex
A src/mainboard/starlabs/starlite_adl/variants/mk_v/Makefile.mk
A src/mainboard/starlabs/starlite_adl/variants/mk_v/board.fmd
A src/mainboard/starlabs/starlite_adl/variants/mk_v/data.vbt
A src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb
A src/mainboard/starlabs/starlite_adl/variants/mk_v/devtree.c
A src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c
A src/mainboard/starlabs/starlite_adl/variants/mk_v/hda_verb.c
A src/mainboard/starlabs/starlite_adl/variants/mk_v/romstage.c
A src/mainboard/starlabs/starlite_adl/variants/mk_v/vboot.fmd
A src/mainboard/starlabs/starlite_adl/vboot.c
30 files changed, 1,542 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/80706/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/80706?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8724e578c21353032b844b20b868348580ff561b
Gerrit-Change-Number: 80706
Gerrit-PatchSet: 8
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Attention is currently required from: Elyes Haouas, Felix Singer, Matt DeVillier.
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/80705?usp=email )
Change subject: mb/starlabs/byte_adl: Add Alder Lake N Byte Mk II
......................................................................
Patch Set 9:
(3 comments)
File src/mainboard/starlabs/byte_adl/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/80705/comment/56a4a238_f92fba97?us… :
PS9, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
> ```suggestion […]
Acknowledged
File src/mainboard/starlabs/byte_adl/acpi/superio.asl:
https://review.coreboot.org/c/coreboot/+/80705/comment/238824d8_721cc4af?us… :
PS9, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
> ```suggestion […]
Will do a seperate patch for all of these EC and board files so they're all the same
File src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/80705/comment/e9fe9569_0ad12eda?us… :
PS9, Line 28: # Device Tree
: device cpu_cluster 0 on end
:
: d
> The CPU device already exists in chipset devicetree. […]
Fix applied.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80705?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idff2d883a8c29f0fee9d633708aac92061a45132
Gerrit-Change-Number: 80705
Gerrit-PatchSet: 9
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Mon, 15 Jul 2024 19:58:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Attention is currently required from: Elyes Haouas, Matt DeVillier, Sean Rhodes.
Hello Matt DeVillier, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80705?usp=email
to look at the new patch set (#10).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/starlabs/byte_adl: Add Alder Lake N Byte Mk II
......................................................................
mb/starlabs/byte_adl: Add Alder Lake N Byte Mk II
Tested using `edk2` from
`github.com/starlabsltd/edk2/tree/uefipayload_vs`:
* Windows 11
* Ubuntu 22.04
* Manjaro 22
No known issues.
https://starlabs.systems/pages/byte-specification
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
Change-Id: Idff2d883a8c29f0fee9d633708aac92061a45132
---
M Documentation/mainboard/index.md
A Documentation/mainboard/starlabs/byte_adl.md
M src/ec/starlabs/merlin/acpi/battery.asl
A src/mainboard/starlabs/byte_adl/Kconfig
A src/mainboard/starlabs/byte_adl/Kconfig.name
A src/mainboard/starlabs/byte_adl/Makefile.mk
A src/mainboard/starlabs/byte_adl/acpi/ec.asl
A src/mainboard/starlabs/byte_adl/acpi/mainboard.asl
A src/mainboard/starlabs/byte_adl/acpi/sleep.asl
A src/mainboard/starlabs/byte_adl/acpi/superio.asl
A src/mainboard/starlabs/byte_adl/board_info.txt
A src/mainboard/starlabs/byte_adl/bootblock.c
A src/mainboard/starlabs/byte_adl/cmos.default
A src/mainboard/starlabs/byte_adl/cmos.layout
A src/mainboard/starlabs/byte_adl/dsdt.asl
A src/mainboard/starlabs/byte_adl/hda_verb.c
A src/mainboard/starlabs/byte_adl/include/variants.h
A src/mainboard/starlabs/byte_adl/mainboard.c
A src/mainboard/starlabs/byte_adl/smbios.c
A src/mainboard/starlabs/byte_adl/variants/mk_ii/Makefile.mk
A src/mainboard/starlabs/byte_adl/variants/mk_ii/board.fmd
A src/mainboard/starlabs/byte_adl/variants/mk_ii/data.vbt
A src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb
A src/mainboard/starlabs/byte_adl/variants/mk_ii/devtree.c
A src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c
A src/mainboard/starlabs/byte_adl/variants/mk_ii/hda_verb.c
A src/mainboard/starlabs/byte_adl/variants/mk_ii/romstage.c
A src/mainboard/starlabs/byte_adl/variants/mk_ii/vboot.fmd
A src/mainboard/starlabs/byte_adl/vboot.c
29 files changed, 1,353 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/80705/10
--
To view, visit https://review.coreboot.org/c/coreboot/+/80705?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idff2d883a8c29f0fee9d633708aac92061a45132
Gerrit-Change-Number: 80705
Gerrit-PatchSet: 10
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Attention is currently required from: Dolan Liu, Tongtong Pan.
Karthik Ramasubramanian has posted comments on this change by Tongtong Pan. ( https://review.coreboot.org/c/coreboot/+/83449?usp=email )
Change subject: UPSTREAM: mb/google/dedede/var/awasuki: Add initial GPIOs config
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83449/comment/aabcfc3d_78ef3978?us… :
PS4, Line 7: UPSTREAM:
Not needed.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83449?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic8f346b788b489f50ab96c0ace8541720a832f72
Gerrit-Change-Number: 83449
Gerrit-PatchSet: 4
Gerrit-Owner: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 15 Jul 2024 19:51:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Dolan Liu, Lawrence Chang, Tongtong Pan.
Karthik Ramasubramanian has posted comments on this change by Tongtong Pan. ( https://review.coreboot.org/c/coreboot/+/83376?usp=email )
Change subject: mb/google/dedede: Create awasuki variant
......................................................................
Patch Set 11: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83376?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If18afc92afdbdff5df3f5b034f4357feda6690b0
Gerrit-Change-Number: 83376
Gerrit-PatchSet: 11
Gerrit-Owner: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Lawrence Chang <lawrence.chang(a)intel.com>
Gerrit-Reviewer: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Lawrence Chang <lawrence.chang(a)intel.com>
Gerrit-Comment-Date: Mon, 15 Jul 2024 19:49:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes