Attention is currently required from: Felix Singer, Martin L Roth.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83452?usp=email )
Change subject: Makefile.mk: Reorganize CFLAGS_common
......................................................................
Patch Set 4:
(1 comment)
File Makefile.mk:
https://review.coreboot.org/c/coreboot/+/83452/comment/9f89ef9c_254437d3?us… :
PS4, Line 543: CFLAGS_common += -g
> Maybe move this before the warning options, so that the list continues with them.
In general, it is best to place the -g option at the end of the compilation flags list.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83452?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3216ef2e0b3cd25f343939d5b9ef932f2f91e56c
Gerrit-Change-Number: 83452
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Mon, 15 Jul 2024 16:04:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Attention is currently required from: Lorenzo Aloe, Máté Kukri.
Hello Máté Kukri, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83473?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: src/mainboard/dell/snb_ivb_workstations/: Add variant
......................................................................
src/mainboard/dell/snb_ivb_workstations/: Add variant
The T1650 ROM works with the 9010 MT. Add "optiplex_9010_mt". Add entires in Kconfig and Kconfig.name. The OptiPlexes and Precision use different PCH SKUs, but they use the same PCB.
Change-Id: I34b7812c3504a80b5730887f1dfa8bef43513abe
Signed-off-by: Lorenzo Aloe <laloe.2fu42(a)8shield.net>
---
M src/mainboard/dell/snb_ivb_workstations/Kconfig
M src/mainboard/dell/snb_ivb_workstations/Kconfig.name
A src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_mt/data.vbt
A src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_mt/hda_verb.c
A src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_mt/include/variant/sch5545_ec_tables.h
A src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_mt/overridetree.cb
6 files changed, 308 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/83473/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/83473?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I34b7812c3504a80b5730887f1dfa8bef43513abe
Gerrit-Change-Number: 83473
Gerrit-PatchSet: 3
Gerrit-Owner: Lorenzo Aloe <laloe.2fu42(a)8shield.net>
Gerrit-Reviewer: Máté Kukri <kukri.mate(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com>
Gerrit-Attention: Lorenzo Aloe <laloe.2fu42(a)8shield.net>
Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk.
Matt DeVillier has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/83439?usp=email )
Change subject: soc/amd/phoenix/include/gpio: update GPIO HID to AMDI0030
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83439?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4a6fa1acdca0ee5b6e1358b6279b7c501d3dfd16
Gerrit-Change-Number: 83439
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 15 Jul 2024 15:18:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Dinesh Gehlot, Emilie Roberts, Kapil Porwal, Nick Vaccaro.
Eric Lai has posted comments on this change by Emilie Roberts. ( https://review.coreboot.org/c/coreboot/+/83472?usp=email )
Change subject: mb/google/brya: Fix pmc_mux port mapping for mithrax and felwinter
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
> It should be : https://review.coreboot. […]
commit 4fa8354
--
To view, visit https://review.coreboot.org/c/coreboot/+/83472?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iebd259842d3affa259069cd776b46759c1c60712
Gerrit-Change-Number: 83472
Gerrit-PatchSet: 4
Gerrit-Owner: Emilie Roberts <hadrosaur(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Emilie Roberts <hadrosaur(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Mon, 15 Jul 2024 15:07:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai <ericllai(a)google.com>
Comment-In-Reply-To: Emilie Roberts <hadrosaur(a)google.com>
Attention is currently required from: Máté Kukri.
Hello Máté Kukri, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83473?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: src/mainboard/dell/snb_ivb_workstations/: Add variant
......................................................................
src/mainboard/dell/snb_ivb_workstations/: Add variant
The T1650 ROM works with the 9010 MT. Add "optiplex_9010_mt". Add entires in Kconfig and Kconfig.name. The OptiPlexes and Precision use different PCH SKUs, but they use the same PCB.
Change-Id: I34b7812c3504a80b5730887f1dfa8bef43513abe
Signed-off-by: Lorenzo Aloe <laloe.2fu42(a)8shield.net>
---
M src/mainboard/dell/snb_ivb_workstations/Kconfig
M src/mainboard/dell/snb_ivb_workstations/Kconfig.name
A src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_mt/data.vbt
A src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_mt/hda_verb.c
A src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_mt/include/variant/sch5545_ec_tables.h
A src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_mt/overridetree.cb
6 files changed, 307 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/83473/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83473?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I34b7812c3504a80b5730887f1dfa8bef43513abe
Gerrit-Change-Number: 83473
Gerrit-PatchSet: 2
Gerrit-Owner: Lorenzo Aloe <laloe.2fu42(a)8shield.net>
Gerrit-Reviewer: Máté Kukri <kukri.mate(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com>
Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro.
Emilie Roberts has posted comments on this change by Emilie Roberts. ( https://review.coreboot.org/c/coreboot/+/83472?usp=email )
Change subject: mb/google/brya: Fix pmc_mux port mapping for mithrax and felwinter
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
> Please check if this is correct.
It should be : https://review.coreboot.org/c/coreboot/+/81363, I think that is 4fa8354 ? (I made a mistake on my first commit message, 9207621d is related, but actually we need the changes in that patch. My patch here undoes 4fa8354 and replaces it with the correct values).
--
To view, visit https://review.coreboot.org/c/coreboot/+/83472?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iebd259842d3affa259069cd776b46759c1c60712
Gerrit-Change-Number: 83472
Gerrit-PatchSet: 4
Gerrit-Owner: Emilie Roberts <hadrosaur(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Mon, 15 Jul 2024 14:43:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai <ericllai(a)google.com>
Attention is currently required from: Ashish Kumar Mishra, Felix Held, Paul Menzel, Saurabh Mishra.
Subrata Banik has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/83419?usp=email )
Change subject: mb/google/fatcat: Add Panther Lake SOC support
......................................................................
Patch Set 4:
(5 comments)
File src/mainboard/google/fatcat/Kconfig:
https://review.coreboot.org/c/coreboot/+/83419/comment/5f954dc0_e6db4caa?us… :
PS4, Line 29: SOC_INTEL_IOE_DIE_SUPPORT
we should keep this to ensure P2SB#2 support exists
https://review.coreboot.org/c/coreboot/+/83419/comment/2699b750_0043c412?us… :
PS4, Line 13: if !SIMICS_ENV
please drop the simics support. if you need to keep simics support then better create a separate board.
Assume we are creating google/fatcat and while testing this binary on simics, we can keep one WIP CL to boot into the simics. not necessarily we need to keep simics support inside the code itself.
https://review.coreboot.org/c/coreboot/+/83419/comment/0ba60d1c_8a734652?us… :
PS4, Line 16: DRIVERS_UART_8250IO
this is non-POR for chrome board
https://review.coreboot.org/c/coreboot/+/83419/comment/c0b9e365_5003190b?us… :
PS4, Line 30: SOC_INTEL_PANTHERLAKE_A0
SOC_INTEL_PANTHERLAKE_U_H
https://review.coreboot.org/c/coreboot/+/83419/comment/c1add0cd_ddf0a97b?us… :
PS4, Line 108: config SIMICS_ENV
: default y
:
drop this as we don't need, plus the Kconfig implementation itself is not correct
```
#!!!!! Error: No type defined for symbol SIMICS_ENV defined at src/mainboard/google/fatcat/Kconfig:108.
# 1 errors
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/83419?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5e
Gerrit-Change-Number: 83419
Gerrit-PatchSet: 4
Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-CC: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-CC: Sanju Jose Thottan <sanjujose.thottan(a)intel.com>
Gerrit-CC: Saurabh Mishra <mishra.saurabh(a)intel.corp-partner.google.com>
Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 15 Jul 2024 14:36:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Dinesh Gehlot, Emilie Roberts, Kapil Porwal, Nick Vaccaro.
Eric Lai has posted comments on this change by Emilie Roberts. ( https://review.coreboot.org/c/coreboot/+/83472?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/brya: Fix pmc_mux port mapping for mithrax and felwinter
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
> commit 9207621d
Please check if this is correct.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83472?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iebd259842d3affa259069cd776b46759c1c60712
Gerrit-Change-Number: 83472
Gerrit-PatchSet: 4
Gerrit-Owner: Emilie Roberts <hadrosaur(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Emilie Roberts <hadrosaur(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Mon, 15 Jul 2024 14:32:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai <ericllai(a)google.com>