Attention is currently required from: Felix Singer, Jeremy Soller, Sean Rhodes.
Tim Crawford has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83523?usp=email )
Change subject: tgl,adl,rpl mainboards: Drop superfluous cpu_cluster device
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/system76/tgl-h/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/83523/comment/2a0d813c_b0c43419?us… :
PS1, Line 80: device cpu_cluster 0 on end
`cpu_cluster` is missing from `soc/intel/tigerlake/chipset_pch_h.cb`.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83523?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib84e7804c03f1c0779ab7053a09e397a267a3844
Gerrit-Change-Number: 83523
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Comment-Date: Wed, 17 Jul 2024 23:38:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Forest Mittelberg, Jon Murphy, Karthik Ramasubramanian.
Caveh Jalali has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/83526?usp=email )
Change subject: acpi: add support for reading long battery strings
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
Patchset:
PS2:
what workflow are you using to update this file?
please use `util/chromeos/update_ec_headers.sh`.
see
https://review.coreboot.org/c/coreboot/+/82995
for reference.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83526?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I871433c66cefe5522f9ff942841518e0d6654ca3
Gerrit-Change-Number: 83526
Gerrit-PatchSet: 2
Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Forest Mittelberg <bmbm(a)google.com>
Gerrit-Comment-Date: Wed, 17 Jul 2024 23:30:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Jérémy Compostella, Matt DeVillier, Yu-Ping Wu.
Karthik Ramasubramanian has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/83495?usp=email )
Change subject: soc/amd: Ensure bank 0 is selected before accessing VBNV in CMOS
......................................................................
Patch Set 4:
(1 comment)
File src/soc/amd/common/vboot/vbnv_cmos.c:
https://review.coreboot.org/c/coreboot/+/83495/comment/5e6fb788_dbf6fda5?us… :
PS4, Line 16: cmos_write(RTC_FREQ_SELECT_AMD, RTC_FREQ_SELECT);
> are you proposing to call `cmos_init(0)` here in the platform init, or dropping the platform init an […]
Here in the platform init. That way it applies for AMD platforms where verstage starts before bootblock.
For Intel platforms, cmos_init() is done in bootblock as part of rtc_init and happens before verstage.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83495?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idf167387b403be1977ebc08daa1f40646dd8c83f
Gerrit-Change-Number: 83495
Gerrit-PatchSet: 4
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 17 Jul 2024 23:11:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Attention is currently required from: Caveh Jalali, Forest Mittelberg, Jon Murphy, Karthik Ramasubramanian.
Hello Caveh Jalali, Forest Mittelberg, Karthik Ramasubramanian, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83526?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: acpi: add support for reading long battery strings
......................................................................
acpi: add support for reading long battery strings
This adds EC_ACPI_MEM_STRINGS_FIFO, a method for host firmware to read
arbitrarily long battery information strings (or any other string, but
currently only supporting battery strings).
On ACPI platforms, the host generally reads battery information from a
shared memory region where the strings are limited to 8 bytes in length.
Expanding those would consume a large fraction of the available shared
memory space (limited to 256 bytes), so this implements an ACPI command
(based on the ACPI Embedded Controller Interface Specification) allowing
the host to read strings of any length while consuming only one byte of
ACPI memory space.
Although the EC also supports reading long strings using host commands
(EC_CMD_BATTERY_GET_STATIC), host commands are assumed to be the
exclusive domain of the OS and unavailable to AP firmware because it
would require careful cooperation (locking) to ensure that firmware and
other software cannot interfere with each other's host commands.
BUG=b:339171261
TEST=on yaviks, the EC console logs FIFO readout messages when used in
ACPI and correct strings are shown in the OS.
Original-Cq-Depend: chromium:5599370,chromium:5605867,chromium:5605868
Original-Change-Id: Ibb3d4115f7d5c6b6c2512deb4e53077a48a355e3
Original-Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/5581473
Original-Reviewed-by: Daisuke Nojiri <dnojiri(a)chromium.org>
Original-Commit-Queue: Peter Marheine <pmarheine(a)chromium.org>
Original-Code-Coverage: Zoss <zoss-cl-coverage(a)prod.google.com>
Original-Tested-by: Peter Marheine <pmarheine(a)chromium.org>
GitOrigin-RevId: 22e6b9a3ef43132f10e77bd5845b648fdbd387f1
Change-Id: I871433c66cefe5522f9ff942841518e0d6654ca3
Signed-off-by: Jon Murphy <jpmurphy(a)google.com>
---
M src/ec/google/chromeec/ec_commands.h
1 file changed, 59 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/83526/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83526?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I871433c66cefe5522f9ff942841518e0d6654ca3
Gerrit-Change-Number: 83526
Gerrit-PatchSet: 2
Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Forest Mittelberg <bmbm(a)google.com>
Felix Singer has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83524?usp=email )
Change subject: mb/intel/coffelake_rvp: Make use of chipset devicetree
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/83524?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I79de952d95798aa3c241e7864223c63c0a72ce31
Gerrit-Change-Number: 83524
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 17 Jul 2024 23:00:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: Caveh Jalali, Forest Mittelberg, Jon Murphy, Karthik Ramasubramanian.
Jon Murphy has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/83526?usp=email )
Change subject: acpi: add support for reading long battery strings
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Staging change to allow Chromium Infra to cherry-pick changes to keep this file up to date with the chromium copy found at https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/pla…
--
To view, visit https://review.coreboot.org/c/coreboot/+/83526?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I871433c66cefe5522f9ff942841518e0d6654ca3
Gerrit-Change-Number: 83526
Gerrit-PatchSet: 1
Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Forest Mittelberg <bmbm(a)google.com>
Gerrit-Comment-Date: Wed, 17 Jul 2024 22:58:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Jon Murphy has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83526?usp=email )
Change subject: acpi: add support for reading long battery strings
......................................................................
acpi: add support for reading long battery strings
This adds EC_ACPI_MEM_STRINGS_FIFO, a method for host firmware to read
arbitrarily long battery information strings (or any other string, but
currently only supporting battery strings).
On ACPI platforms, the host generally reads battery information from a
shared memory region where the strings are limited to 8 bytes in length.
Expanding those would consume a large fraction of the available shared
memory space (limited to 256 bytes), so this implements an ACPI command
(based on the ACPI Embedded Controller Interface Specification) allowing
the host to read strings of any length while consuming only one byte of
ACPI memory space.
Although the EC also supports reading long strings using host commands
(EC_CMD_BATTERY_GET_STATIC), host commands are assumed to be the
exclusive domain of the OS and unavailable to AP firmware because it
would require careful cooperation (locking) to ensure that firmware and
other software cannot interfere with each other's host commands.
BUG=b:339171261
TEST=on yaviks, the EC console logs FIFO readout messages when used in
ACPI and correct strings are shown in the OS.
Original-Cq-Depend: chromium:5599370,chromium:5605867,chromium:5605868
Original-Change-Id: Ibb3d4115f7d5c6b6c2512deb4e53077a48a355e3
Original-Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/5581473
Original-Reviewed-by: Daisuke Nojiri <dnojiri(a)chromium.org>
Original-Commit-Queue: Peter Marheine <pmarheine(a)chromium.org>
Original-Code-Coverage: Zoss <zoss-cl-coverage(a)prod.google.com>
Original-Tested-by: Peter Marheine <pmarheine(a)chromium.org>
GitOrigin-RevId: 22e6b9a3ef43132f10e77bd5845b648fdbd387f1
Change-Id: I871433c66cefe5522f9ff942841518e0d6654ca3
Signed-off-by: Jon Murphy <jpmurphy(a)google.com>
---
M src/ec/google/chromeec/ec_commands.h
1 file changed, 59 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/83526/1
diff --git a/src/ec/google/chromeec/ec_commands.h b/src/ec/google/chromeec/ec_commands.h
index 1673c8b..715f94c 100644
--- a/src/ec/google/chromeec/ec_commands.h
+++ b/src/ec/google/chromeec/ec_commands.h
@@ -527,6 +527,65 @@
(((x) & 0xf0) >> USB_RETIMER_FW_UPDATE_OP_SHIFT)
/*
+ * Offset 0x15 is reserved for PBOK, added to Coreboot in
+ * https://crrev.com/c/3840943 and proposed for inclusion here
+ * in https://crrev.com/c/3547317.
+ */
+
+/*
+ * Get extended strings from the EC.
+ * Write:
+ * String index, or 0 to probe for EC support.
+ * Read:
+ * String bytes, following by repeating null bytes.
+ *
+ * Writing a byte (EC_ACPI_MEM_STRINGS_FIFO_ID_*) selects a string, and the
+ * following reads return the non-null bytes of the string in sequence until
+ * the end of the string is reached. After the end of the string, reads 0 until
+ * another byte is written. This interface allows ACPI firmware to read longer
+ * strings from the EC than can reasonably fit into the shared memory region.
+ *
+ * To probe for EC support, write FIFO_ID_VERSION and read will return at least
+ * one nonzero (MEM_STRINGS_FIFO_V1 for example) if MEM_STRINGS_FIFO is
+ * supported. Returned values will indicate which strings are supported. If the
+ * first byte is 0xff, the strings FIFO is unsupported.
+ */
+#define EC_ACPI_MEM_STRINGS_FIFO 0x16
+
+/* String index to probe EC support. */
+#define EC_ACPI_MEM_STRINGS_FIFO_ID_VERSION 0
+#define EC_ACPI_MEM_STRINGS_FIFO_V1 1
+/*
+ * 0xff is the value the EC returns for unimplemented reads, indicating
+ * the current EC firmware does not implement this command.
+ */
+#define EC_ACPI_MEM_STRINGS_FIFO_UNSUPPORTED 0xff
+
+/*
+ * Battery model number for the selected battery. Supported since V1.
+ * Presents the same data as EC_MEMMAP_BATT_MODEL, but can provide more
+ * than 8 bytes.
+ *
+ * This and the other FIFO_ID_BATTERY strings can select one of multiple
+ * batteries by changing the value at EC_MEMMAP_BATT_INDEX. Once that index
+ * is changed, reads of these strings will return information for the
+ * corresponding battery, if present.
+ */
+#define EC_ACPI_MEM_STRINGS_FIFO_ID_BATTERY_MODEL 1
+/*
+ * Battery serial number for the selected battery. Supported since V1.
+ * Presents the same data as EC_MEMMAP_BATT_SERIAL, but can provide more
+ * than 8 bytes.
+ */
+#define EC_ACPI_MEM_STRINGS_FIFO_ID_BATTERY_SERIAL 2
+/*
+ * Battery manufacturer for the selected battery. Supported since V1.
+ * Presents the same data as EC_MEMMAP_BATT_MFGR, but can provide more
+ * than 8 bytes.
+ */
+#define EC_ACPI_MEM_STRINGS_FIFO_ID_BATTERY_MANUFACTURER 3
+
+/*
* ACPI addresses 0x20 - 0xff map to EC_MEMMAP offset 0x00 - 0xdf. This data
* is read-only from the AP. Added in EC_ACPI_MEM_VERSION 2.
*/
--
To view, visit https://review.coreboot.org/c/coreboot/+/83526?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I871433c66cefe5522f9ff942841518e0d6654ca3
Gerrit-Change-Number: 83526
Gerrit-PatchSet: 1
Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>
Felix Singer has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83525?usp=email )
Change subject: mb/google/volteer/{delbin,drobit}: Use alias name for DPTF PCI device
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/83525?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If514ee7c1174d13b8ca8eb7fd20359e0730a8893
Gerrit-Change-Number: 83525
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Comment-Date: Wed, 17 Jul 2024 22:50:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Jérémy Compostella, Karthik Ramasubramanian, Yu-Ping Wu.
Matt DeVillier has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/83495?usp=email )
Change subject: soc/amd: Ensure bank 0 is selected before accessing VBNV in CMOS
......................................................................
Patch Set 4:
(1 comment)
File src/soc/amd/common/vboot/vbnv_cmos.c:
https://review.coreboot.org/c/coreboot/+/83495/comment/19c829f2_54126338?us… :
PS4, Line 16: cmos_write(RTC_FREQ_SELECT_AMD, RTC_FREQ_SELECT);
> Is there any harm in calling cmos_init(0) just like how it is done in ramstage during every boot. […]
are you proposing to call `cmos_init(0)` here in the platform init, or dropping the platform init and calling it universally in `vbnv_init_cmos()` instead?
--
To view, visit https://review.coreboot.org/c/coreboot/+/83495?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idf167387b403be1977ebc08daa1f40646dd8c83f
Gerrit-Change-Number: 83495
Gerrit-PatchSet: 4
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 17 Jul 2024 22:36:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Attention is currently required from: Michał Żygowski, Nico Huber, Paul Menzel.
Matt DeVillier has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/83469?usp=email )
Change subject: superio/ite,mb: Switch to new ITE GPIO driver
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83469/comment/187c1f47_af527c63?us… :
PS2, Line 11:
> I can test on beltino and jecht; I have a stumpy as well but the power LED has been dead for some ti […]
verified working on jecht; couldn't test beltino since the panther variant I have doesn't support LED blinking
--
To view, visit https://review.coreboot.org/c/coreboot/+/83469?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I707ee090ee2551b4935847e12ade678d36ff9302
Gerrit-Change-Number: 83469
Gerrit-PatchSet: 4
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 17 Jul 2024 22:29:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>