coreboot-gerrit July 2024

coreboot-gerrit@coreboot.org

1 participants
3024 discussions

[S] Change in coreboot[main]: device/pci_ids: Add new Intel PTL device IDs for CNVi
by Subrata Banik (Code Review) 17 Jul '24

17 Jul '24

Attention is currently required from: Angel Pons, Eric Lai. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/83520?usp=email ) Change subject: device/pci_ids: Add new Intel PTL device IDs for CNVi ...................................................................... Patch Set 2: (1 comment) File src/include/device/pci_ids.h: https://review.coreboot.org/c/coreboot/+/83520/comment/a3c00077_2fd9d5e5?us… : PS1, Line 4874: #define PCI_DID_INTEL_PTL_U_H_CNVI_WIFI_0 0xe340 : #define PCI_DID_INTEL_PTL_U_H_CNVI_WIFI_1 0xe341 : #define PCI_DID_INTEL_PTL_U_H_CNVI_WIFI_2 0xe342 : #define PCI_DID_INTEL_PTL_U_H_CNVI_WIFI_3 0xe343 > LoL Fix applied. -- To view, visit https://review.coreboot.org/c/coreboot/+/83520?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7d80403b87537aea41ff48ff6d274180577f1ac6 Gerrit-Change-Number: 83520 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 17 Jul 2024 16:23:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[XS] Change in coreboot[main]: device/pci_ids: Remove unused Intel UFS device IDs
by Subrata Banik (Code Review) 17 Jul '24

17 Jul '24

Attention is currently required from: Angel Pons. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/83519?usp=email ) Change subject: device/pci_ids: Remove unused Intel UFS device IDs ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/83519/comment/f2d61c97_372f24f7?us… : PS1, Line 10: devices from `pci_ids.h` as they appear to be unused in the codebase. > I know UFS on ADL is "meh": IIRC, it's only POR on some OSes (Linux, but not Windows). Do you know if things have changed w.r.t. UFS and POR? good question, bt I can only comment for CrOS where UFS is POR but the UFS communication is only limited to payload. Additionally, we don't have any PCI driver need for UFS in coreboot hence those PCI IDs for UFS may not relevant for us. -- To view, visit https://review.coreboot.org/c/coreboot/+/83519?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic795dd2e83c361a2aa04267d4663cf6bb9a755e2 Gerrit-Change-Number: 83519 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 17 Jul 2024 16:15:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[S] Change in coreboot[main]: device/pci_ids: Add new Intel PTL device IDs for UARTx
by Subrata Banik (Code Review) 17 Jul '24

17 Jul '24

Attention is currently required from: Angel Pons, Eric Lai. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/83510?usp=email ) Change subject: device/pci_ids: Add new Intel PTL device IDs for UARTx ...................................................................... Patch Set 2: (1 comment) File src/include/device/pci_ids.h: https://review.coreboot.org/c/coreboot/+/83510/comment/957ef427_26112e80?us… : PS1, Line 3999: #define PCI_DID_INTEL_PTL_H_UART0 0xe425 : #define PCI_DID_INTEL_PTL_H_UART1 0xe426 : #define PCI_DID_INTEL_PTL_H_UART2 0xe452 : #define PCI_DID_INTEL_PTL_U_H_UART0 0xe325 : #define PCI_DID_INTEL_PTL_U_H_UART1 0xe326 : #define PCI_DID_INTEL_PTL_U_H_UART2 0xe352 > nit: the alignment 😭 […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/83510?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I384a753f08ae5a752cef6009d07104e8ff4b4a6e Gerrit-Change-Number: 83510 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 17 Jul 2024 16:11:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[M] Change in coreboot[main]: soc/intel: Add Panther Lake PCIE device IDs
by Subrata Banik (Code Review) 17 Jul '24

17 Jul '24

Subrata Banik has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/81849?usp=email ) Change subject: soc/intel: Add Panther Lake PCIE device IDs ...................................................................... Patch Set 15: (1 comment) Patchset: PS15: > Hi Subrata, it seems you missed to review the CL before it got merged, I was waiting to review the once I have access to the doc and I'm doing the review now because I got access to all PTL doc this week early. IMO, the cl landed in rush w/o following the review in proper. For example: we landed LNL DID2 in form of PTL DID2 (details https://review.coreboot.org/c/coreboot/+/83491/1/src/include/device/pci_ids…). Hence, added this section to share my official feedback. > since during the review, it was asked to remove the SKU Type due to program being in early stage(PSS) and some NDA terms. Following the review comments, SKU Type has been removed, I don't know which SKU type you are referring here. Atleast I'm only interested to land the SKU IDs that CrOS will build for PTL (and rest can be assumed upsteam late by community) > though it is planned to update and add SKU U & H info post apporval. Thanks for taking up and pushing the changes required CLs "fatcat_ptl_pci_ids". I'm not aware of any approval process to be honest here. I got the doc and found that the DIDs are not aligned with our SOC roadmap for PTL hence, I have started by myself knowing you folks have more important work at this stage. -- To view, visit https://review.coreboot.org/c/coreboot/+/81849?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I82f47b6077e28a01f34c59b7e7697323b3d5f990 Gerrit-Change-Number: 81849 Gerrit-PatchSet: 15 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-CC: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Sanju Jose Thottan <sanjujose.thottan(a)intel.com> Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-CC: sridhar siricilla <siricillasridhar(a)gmail.com> Gerrit-Comment-Date: Wed, 17 Jul 2024 16:08:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Saurabh Mishra <mishra.saurabh(a)intel.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[XS] Change in libgfxinit[main]: gma: Work around GNATprove issue with nested loops
by Nico Huber (Code Review) 17 Jul '24

17 Jul '24

Nico Huber has submitted this change. ( https://review.coreboot.org/c/libgfxinit/+/68112?usp=email ) Change subject: gma: Work around GNATprove issue with nested loops ...................................................................... gma: Work around GNATprove issue with nested loops Add some explicit `Loop_Invariant (True)` to work around odd check messages. These show up since about the spark- community-2019 release and still with newer versions, which almost seem to hang (takes some minutes longer than expected). Example messages are provided below. Given that the values are in the ranges as stated by the `for` loops, they can't be out of range. hw-gfx-gma-plls.adb:323:14: medium: range check might fail 323 | for M1 in reverse M1_Range range Limits.M1_Lower .. Limits.M1_Upper | ^~ hw-gfx-gma-plls.adb:325:17: medium: range check might fail 325 | for M2 in reverse M2_Range range Limits.M2_Lower .. Int64'Min (Limits.M2_Upper, M1) | ^~ hw-gfx-gma-plls.adb:327:20: medium: range check might fail 327 | for P1 in reverse P1_Range range Limits.P1_Lower .. Limits.P1_Upper | ^~ hw-gfx-gma-plls.adb:332:41: medium: range check might fail 332 | M2 => M2, | ^~ reason for check: input value must fit in parameter type Change-Id: I5430081767c760b85401300e0db4d26fd78270d7 Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/c/libgfxinit/+/68112 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M common/g45/hw-gfx-gma-plls.adb M common/ironlake/hw-gfx-gma-plls.adb 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Nico Huber: Verified Angel Pons: Looks good to me, approved diff --git a/common/g45/hw-gfx-gma-plls.adb b/common/g45/hw-gfx-gma-plls.adb index 67242f2..5db76d6 100644 --- a/common/g45/hw-gfx-gma-plls.adb +++ b/common/g45/hw-gfx-gma-plls.adb @@ -322,8 +322,10 @@ -- reverse loops as hardware prefers higher values for M1 in reverse M1_Range range Limits.M1_Lower .. Limits.M1_Upper loop + pragma Loop_Invariant (True); for M2 in reverse M2_Range range Limits.M2_Lower .. Int64'Min (Limits.M2_Upper, M1) loop + pragma Loop_Invariant (True); for P1 in reverse P1_Range range Limits.P1_Lower .. Limits.P1_Upper loop Verify_Parameters diff --git a/common/ironlake/hw-gfx-gma-plls.adb b/common/ironlake/hw-gfx-gma-plls.adb index 10e9ff2..8b6ca36 100644 --- a/common/ironlake/hw-gfx-gma-plls.adb +++ b/common/ironlake/hw-gfx-gma-plls.adb @@ -291,8 +291,10 @@ -- reverse loops as hardware prefers higher values for M1 in reverse M1_Range range Limits.M1_Lower .. Limits.M1_Upper loop + pragma Loop_Invariant (True); for M2 in reverse M2_Range range Limits.M2_Lower .. Limits.M2_Upper loop + pragma Loop_Invariant (True); for P1 in reverse P1_Range range Limits.P1_Lower .. Limits.P1_Upper loop Verify_Parameters -- To view, visit https://review.coreboot.org/c/libgfxinit/+/68112?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libgfxinit Gerrit-Branch: main Gerrit-Change-Id: I5430081767c760b85401300e0db4d26fd78270d7 Gerrit-Change-Number: 68112 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>

1 0

[XS] Change in libgfxinit[main]: gma: Work around GNATprove issue with nested loops
by Nico Huber (Code Review) 17 Jul '24

17 Jul '24

Nico Huber has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/libgfxinit/+/68112?usp=email ) Change subject: gma: Work around GNATprove issue with nested loops ...................................................................... Patch Set 3: Verified+1 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/68112?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libgfxinit Gerrit-Branch: main Gerrit-Change-Id: I5430081767c760b85401300e0db4d26fd78270d7 Gerrit-Change-Number: 68112 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 17 Jul 2024 16:01:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: soc/intel: Add Panther Lake PCIE device IDs
by Saurabh Mishra (Code Review) 17 Jul '24

17 Jul '24

Saurabh Mishra has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/81849?usp=email ) Change subject: soc/intel: Add Panther Lake PCIE device IDs ...................................................................... Patch Set 15: (1 comment) Patchset: PS15: > Thanks for letting me know. Hi Subrata, it seems you missed to review the CL before it got merged, since during the review, it was asked to remove the SKU Type due to program being in early stage(PSS) and some NDA terms. Following the review comments, SKU Type has been removed, though it is planned to update and add SKU U & H info post apporval. Thanks for taking up and pushing the changes required CLs "fatcat_ptl_pci_ids". -- To view, visit https://review.coreboot.org/c/coreboot/+/81849?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I82f47b6077e28a01f34c59b7e7697323b3d5f990 Gerrit-Change-Number: 81849 Gerrit-PatchSet: 15 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-CC: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Sanju Jose Thottan <sanjujose.thottan(a)intel.com> Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-CC: sridhar siricilla <siricillasridhar(a)gmail.com> Gerrit-Comment-Date: Wed, 17 Jul 2024 15:59:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[M] Change in coreboot[main]: mb/google/dedede: Create awasuki variant
by Karthik Ramasubramanian (Code Review) 17 Jul '24

17 Jul '24

Attention is currently required from: Eric Lai, Lawrence Chang, Paul Menzel, Tongtong Pan, Weimin Wu. Karthik Ramasubramanian has posted comments on this change by Tongtong Pan. ( https://review.coreboot.org/c/coreboot/+/83376?usp=email ) Change subject: mb/google/dedede: Create awasuki variant ...................................................................... Patch Set 15: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83376?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If18afc92afdbdff5df3f5b034f4357feda6690b0 Gerrit-Change-Number: 83376 Gerrit-PatchSet: 15 Gerrit-Owner: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Lawrence Chang <lawrence.chang(a)intel.com> Gerrit-Reviewer: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Lawrence Chang <lawrence.chang(a)intel.com> Gerrit-Comment-Date: Wed, 17 Jul 2024 15:58:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: mb/google/dedede: Create awasuki variant
by Dolan Liu (Code Review) 17 Jul '24

17 Jul '24

Attention is currently required from: Eric Lai, Karthik Ramasubramanian, Lawrence Chang, Paul Menzel, Tongtong Pan, Weimin Wu. Dolan Liu has posted comments on this change by Tongtong Pan. ( https://review.coreboot.org/c/coreboot/+/83376?usp=email ) Change subject: mb/google/dedede: Create awasuki variant ...................................................................... Patch Set 15: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/83376?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If18afc92afdbdff5df3f5b034f4357feda6690b0 Gerrit-Change-Number: 83376 Gerrit-PatchSet: 15 Gerrit-Owner: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Lawrence Chang <lawrence.chang(a)intel.com> Gerrit-Reviewer: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Lawrence Chang <lawrence.chang(a)intel.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 17 Jul 2024 15:29:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: mb/google/dedede/var/awasuki: Initialise overridetree
by Dolan Liu (Code Review) 17 Jul '24

17 Jul '24

Attention is currently required from: Eric Lai, Karthik Ramasubramanian, Lawrence Chang, Weimin Wu. Dolan Liu has posted comments on this change by Weimin Wu. ( https://review.coreboot.org/c/coreboot/+/83496?usp=email ) Change subject: mb/google/dedede/var/awasuki: Initialise overridetree ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/83496?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie8194b6eca3e88f08f92e0ac8a9063b8de738652 Gerrit-Change-Number: 83496 Gerrit-PatchSet: 5 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Lawrence Chang <lawrence.chang(a)intel.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Lawrence Chang <lawrence.chang(a)intel.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 17 Jul 2024 15:29:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2024