coreboot-gerrit June 2024

coreboot-gerrit@coreboot.org

1 participants
3527 discussions

[XS] Change in coreboot[main]: Doc/tutorial/part1.md: Correct libncurses-dev pkg name for debian
by Elyes Haouas (Code Review) 22 Jun '24

22 Jun '24

Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83032?usp=email ) Change subject: Doc/tutorial/part1.md: Correct libncurses-dev pkg name for debian ...................................................................... Patch Set 4: (2 comments) File Documentation/mainboard/gigabyte/ga-g41m-es2l.md: https://review.coreboot.org/c/coreboot/+/83032/comment/5bd933b5_46b8a183?us… : PS3, Line 41: Install tools and libraries needed for coreboot: : : ```shell : sudo apt-get -V install bison build-essential curl flex git gnat libncurses-dev m4 zlib1g-dev wget python2 python-is-python2 flashrom : ``` > This part is related to "Documentation/tutorial/part1. […] Done https://review.coreboot.org/c/coreboot/+/83032/comment/b9d1c2a1_0f448be5?us… : PS3, Line 47: ### Get sources : : You need about 700 MB disk space for sources only and ~2GB disk space for sources + build results : : ```shell : git clone --recursive https://review.coreboot.org/coreboot.git : ``` : > this related to 'Documentation/tutorial/part1. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/83032?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5a71b914d40a9ea45be87f4581ff0072605e8c00 Gerrit-Change-Number: 83032 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 22 Jun 2024 08:29:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[S] Change in coreboot[main]: Doc/mainboard/gigabyte/ga-g41m-es2l: Use tutorial/part1.md
by Elyes Haouas (Code Review) 22 Jun '24

22 Jun '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83159?usp=email ) Change subject: Doc/mainboard/gigabyte/ga-g41m-es2l: Use tutorial/part1.md ...................................................................... Doc/mainboard/gigabyte/ga-g41m-es2l: Use tutorial/part1.md Use tutorial/part1.md for steps not related to mainboard. Change-Id: If4917d20fe327628dbc156e85a85b1d439915a77 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Documentation/mainboard/gigabyte/ga-g41m-es2l.md 1 file changed, 3 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/83159/1 diff --git a/Documentation/mainboard/gigabyte/ga-g41m-es2l.md b/Documentation/mainboard/gigabyte/ga-g41m-es2l.md index b42cd81..46c28c9 100644 --- a/Documentation/mainboard/gigabyte/ga-g41m-es2l.md +++ b/Documentation/mainboard/gigabyte/ga-g41m-es2l.md @@ -38,19 +38,12 @@ This probably works also for any fresh Debian/Ubuntu-based distros. -Install tools and libraries needed for coreboot: - -```shell -sudo apt-get -V install bison build-essential curl flex git gnat libncurses5-dev m4 zlib1g-dev wget python2 python-is-python2 flashrom -``` +[Install tools and libraries needed for coreboot](../../tutorial/part1.md#step-1-install-tools-and-libraries-needed-for-coreboot) ### Get sources You need about 700 MB disk space for sources only and ~2GB disk space for sources + build results - -```shell -git clone --recursive https://review.coreboot.org/coreboot.git -``` +[get sources](../../tutorial/part1.md#Step-2-Download-coreboot-source-tree) ### Build toolchain @@ -66,6 +59,7 @@ ```shell make crossgcc-i386 CPUS=2 ``` +[Build coreboot toolchain](../../tutorial/part1.md#Step-3-Build-the-coreboot-toolchain) ### Save MAC-address of internal LAN -- To view, visit https://review.coreboot.org/c/coreboot/+/83159?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If4917d20fe327628dbc156e85a85b1d439915a77 Gerrit-Change-Number: 83159 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: Documentation: Correct libncurses-dev pkg name for debian
by Elyes Haouas (Code Review) 22 Jun '24

22 Jun '24

Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83032?usp=email ) Change subject: Documentation: Correct libncurses-dev pkg name for debian ...................................................................... Patch Set 3: (2 comments) File Documentation/mainboard/gigabyte/ga-g41m-es2l.md: https://review.coreboot.org/c/coreboot/+/83032/comment/fb4864bf_4a8f1d87?us… : PS3, Line 41: Install tools and libraries needed for coreboot: : : ```shell : sudo apt-get -V install bison build-essential curl flex git gnat libncurses-dev m4 zlib1g-dev wget python2 python-is-python2 flashrom : ``` This part is related to "Documentation/tutorial/part1.md" section "### Step 1 - Install tools and libraries needed for coreboot" https://review.coreboot.org/c/coreboot/+/83032/comment/b2ae8f69_c6493cff?us… : PS3, Line 47: ### Get sources : : You need about 700 MB disk space for sources only and ~2GB disk space for sources + build results : : ```shell : git clone --recursive https://review.coreboot.org/coreboot.git : ``` : this related to 'Documentation/tutorial/part1.md' -- To view, visit https://review.coreboot.org/c/coreboot/+/83032?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5a71b914d40a9ea45be87f4581ff0072605e8c00 Gerrit-Change-Number: 83032 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 22 Jun 2024 08:12:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: Documentation/mainboard/gigabyte/ga-g41m-es2l: Use python-is-python3
by Elyes Haouas (Code Review) 22 Jun '24

22 Jun '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83158?usp=email ) Change subject: Documentation/mainboard/gigabyte/ga-g41m-es2l: Use python-is-python3 ...................................................................... Documentation/mainboard/gigabyte/ga-g41m-es2l: Use python-is-python3 Change-Id: I627fea0ff7cef4d08b4ec3698a69a0ddbe2e171d Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Documentation/mainboard/gigabyte/ga-g41m-es2l.md 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/83158/1 diff --git a/Documentation/mainboard/gigabyte/ga-g41m-es2l.md b/Documentation/mainboard/gigabyte/ga-g41m-es2l.md index 33a77f2..ab4d726 100644 --- a/Documentation/mainboard/gigabyte/ga-g41m-es2l.md +++ b/Documentation/mainboard/gigabyte/ga-g41m-es2l.md @@ -41,7 +41,7 @@ Install tools and libraries needed for coreboot: ```shell -sudo apt-get -V install bison build-essential curl flex git gnat libncurses-dev zlib1g-dev wget python2 python-is-python2 flashrom +sudo apt-get -V install bison build-essential curl flex git gnat libncurses-dev zlib1g-dev wget python-is-python3 flashrom ``` ### Get sources -- To view, visit https://review.coreboot.org/c/coreboot/+/83158?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I627fea0ff7cef4d08b4ec3698a69a0ddbe2e171d Gerrit-Change-Number: 83158 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[S] Change in coreboot[main]: tree: Use pkgconf over pkg-config
by Elyes Haouas (Code Review) 22 Jun '24

22 Jun '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83157?usp=email ) Change subject: tree: Use pkgconf over pkg-config ...................................................................... tree: Use pkgconf over pkg-config Change-Id: I3e9a92d019854214a5760f705b9cbe3cabe6d2e8 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Documentation/tutorial/part1.md M Makefile M payloads/external/GRUB2/Makefile M tests/data/lib/lzma-test/data.2.bin M util/amdfwtool/Makefile.mk M util/cbfstool/lz4/lib/README.md M util/coreboot-configurator/contrib/debian/control M util/futility/Makefile.mk M util/kconfig/mconf-cfg.sh M util/kconfig/nconf-cfg.sh M util/msrtool/configure M util/nixshell/devshell-i386.nix 12 files changed, 18 insertions(+), 18 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/83157/1 diff --git a/Documentation/tutorial/part1.md b/Documentation/tutorial/part1.md index 015c75c..9691316 100644 --- a/Documentation/tutorial/part1.md +++ b/Documentation/tutorial/part1.md @@ -30,7 +30,7 @@ Debian based distros: `sudo apt-get install -y bison build-essential curl flex git gnat -libncurses-dev libssl-dev zlib1g-dev pkg-config` +libncurses-dev libssl-dev zlib1g-dev pkgconf` Arch based distros: `sudo pacman -S base-devel curl git gcc-ada ncurses zlib` @@ -206,7 +206,7 @@ * `m4, bison, curl, flex, zlib1g-dev, gcc, gnat` and `g++` or `clang` are needed to build the coreboot toolchain. `gcc` and `gnat` have to be of the same version. -* `libssl-dev, pkg-config` are needed to build coreboot image (Step 6). +* `libssl-dev, pkgconf` are needed to build coreboot image (Step 6). In particular, `libcrypto` provided by `libssl-dev` package. If you started with a different distribution or package management diff --git a/Makefile b/Makefile index fddcc5c..e01012b 100644 --- a/Makefile +++ b/Makefile @@ -76,7 +76,7 @@ HOSTCFLAGS := -g HOSTCXXFLAGS := -g -HOSTPKG_CONFIG ?= pkg-config +HOSTPKG_CONFIG ?= pkgconf COREBOOT_EXPORTS += HOSTPKG_CONFIG PREPROCESS_ONLY := -E -P -x assembler-with-cpp -undef -I . diff --git a/payloads/external/GRUB2/Makefile b/payloads/external/GRUB2/Makefile index 4382ae6..0702741 100644 --- a/payloads/external/GRUB2/Makefile +++ b/payloads/external/GRUB2/Makefile @@ -32,7 +32,7 @@ mkdir grub2/build cd grub2 && ./bootstrap ; ./autogen.sh cd grub2/build && ../configure CC="$(HOSTCC)" LD="$(LD)" \ - FREETYPE="pkg-config freetype2" BUILD_FREETYPE="pkg-config freetype2" \ + FREETYPE="pkgconf freetype2" BUILD_FREETYPE="pkgconf freetype2" \ TARGET_CC="$(CC)" TARGET_OBJCOPY="$(OBJCOPY)" TARGET_STRIP="$(STRIP)" \ CFLAGS=-O2 TARGET_CFLAGS="-Os -fno-reorder-functions" \ --with-platform=coreboot --enable-boot-time --disable-werror diff --git a/tests/data/lib/lzma-test/data.2.bin b/tests/data/lib/lzma-test/data.2.bin index 14879c1..7559391 100644 --- a/tests/data/lib/lzma-test/data.2.bin +++ b/tests/data/lib/lzma-test/data.2.bin @@ -49,7 +49,7 @@ `ANY_TOOLCHAIN` Kconfig option if you're feeling lucky (no support in this case). * iasl (for targets with ACPI support) - * pkg-config + * pkgconf * libssl-dev (openssl) Optional: diff --git a/util/amdfwtool/Makefile.mk b/util/amdfwtool/Makefile.mk index 0b9cc1b..9e11b95 100644 --- a/util/amdfwtool/Makefile.mk +++ b/util/amdfwtool/Makefile.mk @@ -14,12 +14,12 @@ ifneq ($(PKG_CONFIG),) HOSTPKGCONFIG ?= $(PKG_CONFIG) else -HOSTPKGCONFIG ?= pkg-config +HOSTPKGCONFIG ?= pkgconf endif AMDFWTOOLCFLAGS += $(shell $(HOSTPKGCONFIG) --cflags libcrypto) ifneq ($(.SHELLSTATUS),0) -$(error "Ensure that pkg-config is installed.") +$(error "Ensure that pkgconf is installed.") endif LDFLAGS += $(shell $(HOSTPKGCONFIG) --libs libcrypto) diff --git a/util/cbfstool/lz4/lib/README.md b/util/cbfstool/lz4/lib/README.md index f6ebf5e..2d82bc1 100644 --- a/util/cbfstool/lz4/lib/README.md +++ b/util/cbfstool/lz4/lib/README.md @@ -16,6 +16,6 @@ - LICENSE : contains the BSD license text - Makefile : script to compile or install lz4 library (static or dynamic) - - liblz4.pc.in : for pkg-config (make install) + - liblz4.pc.in : for pkgconf (make install) [official interoperable frame format]: ../lz4_Frame_format.md diff --git a/util/coreboot-configurator/contrib/debian/control b/util/coreboot-configurator/contrib/debian/control index e73e10b..84c21ce 100644 --- a/util/coreboot-configurator/contrib/debian/control +++ b/util/coreboot-configurator/contrib/debian/control @@ -2,7 +2,7 @@ Section: utils Priority: optional Maintainer: Star Labs <admin(a)starlabs.systems> -Build-Depends: build-essential, cmake, debhelper (>= 7), inkscape, libqt5gui5, libqt5svg5-dev, libyaml-cpp-dev, libqt5gui5, meson, pkg-config, qtbase5-dev, qttools5-dev-tools +Build-Depends: build-essential, cmake, debhelper (>= 7), inkscape, libqt5gui5, libqt5svg5-dev, libyaml-cpp-dev, libqt5gui5, meson, pkgconf, qtbase5-dev, qttools5-dev-tools Standards-Version: 4.1.1 Package: coreboot-configurator diff --git a/util/futility/Makefile.mk b/util/futility/Makefile.mk index a7bcee5..b66572c 100644 --- a/util/futility/Makefile.mk +++ b/util/futility/Makefile.mk @@ -3,7 +3,7 @@ VBOOT_FUTILITY = $(VBOOT_HOST_BUILD)/futility/futility -HOSTPKGCONFIG ?= pkg-config +HOSTPKGCONFIG ?= pkgconf $(VBOOT_FUTILITY): | check-openssl-presence @printf " MAKE $(subst $(objutil)/,,$(@))\n" @@ -19,7 +19,7 @@ .PHONY: check-openssl-presence check-openssl-presence: @$(HOSTPKGCONFIG) --exists libcrypto || \ - (echo "Error: Ensure that pkg-config and openssl's libcrypto, including header files, are installed."; exit 1) + (echo "Error: Ensure that pkgconf and openssl's libcrypto, including header files, are installed."; exit 1) $(objutil)/futility/futility: $(VBOOT_FUTILITY) mkdir -p $(dir $@) diff --git a/util/kconfig/mconf-cfg.sh b/util/kconfig/mconf-cfg.sh index 74c1c27..428dd1e 100755 --- a/util/kconfig/mconf-cfg.sh +++ b/util/kconfig/mconf-cfg.sh @@ -21,9 +21,9 @@ fi fi -# Check the default paths in case pkg-config is not installed. +# Check the default paths in case pkgconf is not installed. # (Even if it is installed, some distributions such as openSUSE cannot -# find ncurses by pkg-config.) +# find ncurses by pkgconf.) if [ -f /usr/include/ncursesw/ncurses.h ]; then echo -D_GNU_SOURCE -I/usr/include/ncursesw > ${cflags} echo -lncursesw > ${libs} diff --git a/util/kconfig/nconf-cfg.sh b/util/kconfig/nconf-cfg.sh index 9d40960..28c3513 100755 --- a/util/kconfig/nconf-cfg.sh +++ b/util/kconfig/nconf-cfg.sh @@ -21,9 +21,9 @@ fi fi -# Check the default paths in case pkg-config is not installed. +# Check the default paths in case pkgconf is not installed. # (Even if it is installed, some distributions such as openSUSE cannot -# find ncurses by pkg-config.) +# find ncurses by pkgconf.) if [ -f /usr/include/ncursesw/ncurses.h ]; then echo -D_GNU_SOURCE -I/usr/include/ncursesw > ${cflags} echo -lncursesw -lmenuw -lpanelw > ${libs} diff --git a/util/msrtool/configure b/util/msrtool/configure index 659cbcd..831372e 100755 --- a/util/msrtool/configure +++ b/util/msrtool/configure @@ -142,8 +142,8 @@ { pacc = pci_alloc(); return 0; } EOF -pc_CFLAGS="`pkg-config libpci --cflags 2>/dev/null`" -pc_LDFLAGS="`pkg-config libpci --libs 2>/dev/null`" +pc_CFLAGS="`pkgconf libpci --cflags 2>/dev/null`" +pc_LDFLAGS="`pkgconf libpci --libs 2>/dev/null`" CFLAGS=`trycompile "libpci (from pciutils)" "${pc_CFLAGS}" "-I/usr/local/include"` || { rm -f .config.c exit 1 diff --git a/util/nixshell/devshell-i386.nix b/util/nixshell/devshell-i386.nix index 88a67dc..14ce025 100644 --- a/util/nixshell/devshell-i386.nix +++ b/util/nixshell/devshell-i386.nix @@ -17,7 +17,7 @@ nativeBuildInputs = [ coreboot-toolchain.i386 - pkg-config + pkgconf openssh ]; -- To view, visit https://review.coreboot.org/c/coreboot/+/83157?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3e9a92d019854214a5760f705b9cbe3cabe6d2e8 Gerrit-Change-Number: 83157 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: Documentation: Remove explicit install of 'm4'
by Elyes Haouas (Code Review) 22 Jun '24

22 Jun '24

Elyes Haouas has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/83156?usp=email ) Change subject: Documentation: Remove explicit install of 'm4' ...................................................................... Documentation: Remove explicit install of 'm4' Remove m4 as it will be installed automatically by flex and bison. Change-Id: Ifb748e5aaabb96825813ddb92cf28d2ea7bdcbf9 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Documentation/mainboard/gigabyte/ga-g41m-es2l.md M Documentation/tutorial/part1.md 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/83156/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83156?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifb748e5aaabb96825813ddb92cf28d2ea7bdcbf9 Gerrit-Change-Number: 83156 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: tutorial/part1.md: Remove explicit install of 'm4'
by Elyes Haouas (Code Review) 22 Jun '24

22 Jun '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83156?usp=email ) Change subject: tutorial/part1.md: Remove explicit install of 'm4' ...................................................................... tutorial/part1.md: Remove explicit install of 'm4' Remove m4 as it will be installed automatically by flex and bison. Change-Id: Ifb748e5aaabb96825813ddb92cf28d2ea7bdcbf9 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Documentation/tutorial/part1.md 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/83156/1 diff --git a/Documentation/tutorial/part1.md b/Documentation/tutorial/part1.md index 35aee43..015c75c 100644 --- a/Documentation/tutorial/part1.md +++ b/Documentation/tutorial/part1.md @@ -30,7 +30,7 @@ Debian based distros: `sudo apt-get install -y bison build-essential curl flex git gnat -libncurses-dev libssl-dev m4 zlib1g-dev pkg-config` +libncurses-dev libssl-dev zlib1g-dev pkg-config` Arch based distros: `sudo pacman -S base-devel curl git gcc-ada ncurses zlib` -- To view, visit https://review.coreboot.org/c/coreboot/+/83156?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifb748e5aaabb96825813ddb92cf28d2ea7bdcbf9 Gerrit-Change-Number: 83156 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[M] Change in coreboot[main]: mb/google/trulo/var/orisa: Fill in ec.h for orisa
by Amanda Hwang (Code Review) 21 Jun '24

21 Jun '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik. Amanda Hwang has posted comments on this change by Amanda Hwang. ( https://review.coreboot.org/c/coreboot/+/83154?usp=email ) Change subject: mb/google/trulo/var/orisa: Fill in ec.h for orisa ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/brya/variants/orisa/include/variant/ec.h: https://review.coreboot.org/c/coreboot/+/83154/comment/5e39b195_6663a850?us… : PS1, Line 22: EC_HOST_EVENT_USB_CHARGER > no more valid https://review.coreboot.org/c/coreboot/+/69374 -- To view, visit https://review.coreboot.org/c/coreboot/+/83154?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie1edf655fd20c0c1baee01fa90ed03501e3fe161 Gerrit-Change-Number: 83154 Gerrit-PatchSet: 2 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Sat, 22 Jun 2024 06:51:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[S] Change in coreboot[main]: mb/google/trulo/var/orisa: Fill in gpio.h for orisa
by Amanda Hwang (Code Review) 21 Jun '24

21 Jun '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik. Amanda Hwang has posted comments on this change by Amanda Hwang. ( https://review.coreboot.org/c/coreboot/+/83155?usp=email ) Change subject: mb/google/trulo/var/orisa: Fill in gpio.h for orisa ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/brya/variants/orisa/include/variant/gpio.h: https://review.coreboot.org/c/coreboot/+/83155/comment/84bf2530_19ed7891?us… : PS1, Line 10: //#define GPIO_PCH_WP GPP_E3 > remove this Done -- To view, visit https://review.coreboot.org/c/coreboot/+/83155?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9de842a8a66632314d5fdf6444005d34338a1100 Gerrit-Change-Number: 83155 Gerrit-PatchSet: 2 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Sat, 22 Jun 2024 06:50:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[S] Change in coreboot[main]: acpi/acpi: Fix Qemu's XSDT patching code
by Patrick Rudolph (Code Review) 21 Jun '24

21 Jun '24

Attention is currently required from: Arthur Heymans, Cliff Huang, Lance Zhao, Paul Menzel, Tim Wawrzynczak. Patrick Rudolph has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/83116?usp=email ) Change subject: acpi/acpi: Fix Qemu's XSDT patching code ...................................................................... Patch Set 4: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/83116/comment/090d0e17_be88be16?us… : PS3, Line 17: > Is there a log message, you could paste here? Nothing that indicates that the XSDT is invalid. https://review.coreboot.org/c/coreboot/+/83116/comment/893cd4a9_1a717379?us… : PS3, Line 26: > Also, does "first and second boot" involve running QEMU twice, or is the second boot the result of a […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/83116?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie4972230c3654714f3dcbaab46a3f70152e75163 Gerrit-Change-Number: 83116 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 22 Jun 2024 05:18:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2024