coreboot-gerrit June 2024

coreboot-gerrit@coreboot.org

1 participants
3527 discussions

[XS] Change in coreboot[main]: mb/emulation/qemu-riscv/cbmem.c: Fix device_tree.h include
by Nico Huber (Code Review) 22 Jun '24

22 Jun '24

Attention is currently required from: Elyes Haouas, Philipp Hug, Ron Minnich. Nico Huber has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83160?usp=email ) Change subject: mb/emulation/qemu-riscv/cbmem.c: Fix device_tree.h include ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83160?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0b49ff8b6275fdde326c79ec21c34faa03094f9e Gerrit-Change-Number: 83160 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sat, 22 Jun 2024 09:16:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/emulation/qemu-riscv/cbmem.c: Fix device_tree.h include
by Lean Sheng Tan (Code Review) 22 Jun '24

22 Jun '24

Attention is currently required from: Elyes Haouas, Philipp Hug, Ron Minnich. Lean Sheng Tan has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83160?usp=email ) Change subject: mb/emulation/qemu-riscv/cbmem.c: Fix device_tree.h include ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83160?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0b49ff8b6275fdde326c79ec21c34faa03094f9e Gerrit-Change-Number: 83160 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sat, 22 Jun 2024 08:50:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/emulation/qemu-riscv/cbmem.c: Fix device_tree.h include
by Lean Sheng Tan (Code Review) 22 Jun '24

22 Jun '24

Attention is currently required from: Elyes Haouas, Philipp Hug, Ron Minnich. Lean Sheng Tan has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83160?usp=email ) Change subject: mb/emulation/qemu-riscv/cbmem.c: Fix device_tree.h include ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: oh dang, thanks Elyes for the quick fix! -- To view, visit https://review.coreboot.org/c/coreboot/+/83160?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0b49ff8b6275fdde326c79ec21c34faa03094f9e Gerrit-Change-Number: 83160 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sat, 22 Jun 2024 08:50:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: mb/google/trulo/var/orisa: Fill in ec.h for orisa
by Paul Menzel (Code Review) 22 Jun '24

22 Jun '24

Attention is currently required from: Amanda Hwang, Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik. Paul Menzel has posted comments on this change by Amanda Hwang. ( https://review.coreboot.org/c/coreboot/+/83154?usp=email ) Change subject: mb/google/trulo/var/orisa: Fill in ec.h for orisa ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/83154/comment/c1c68f4e_301bf13d?us… : PS2, Line 7: for orisa Redundant. https://review.coreboot.org/c/coreboot/+/83154/comment/6a360f88_c6234206?us… : PS2, Line 8: Please document the source for this. -- To view, visit https://review.coreboot.org/c/coreboot/+/83154?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie1edf655fd20c0c1baee01fa90ed03501e3fe161 Gerrit-Change-Number: 83154 Gerrit-PatchSet: 2 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Sat, 22 Jun 2024 08:49:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/google/trulo/var/orisa: Fill in gpio.h for orisa
by Paul Menzel (Code Review) 22 Jun '24

22 Jun '24

Attention is currently required from: Amanda Hwang, Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik. Paul Menzel has posted comments on this change by Amanda Hwang. ( https://review.coreboot.org/c/coreboot/+/83155?usp=email ) Change subject: mb/google/trulo/var/orisa: Fill in gpio.h for orisa ...................................................................... Patch Set 2: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/83155/comment/fc75fbbf_af591322?us… : PS2, Line 7: Fill in gpio.h for orisa Please remove redundant “for orisa”. https://review.coreboot.org/c/coreboot/+/83155/comment/bf4bf9a4_cc61d761?us… : PS2, Line 8: Please document the source for your changes. File src/mainboard/google/brya/variants/orisa/include/variant/gpio.h: https://review.coreboot.org/c/coreboot/+/83155/comment/b358243e_1e44add9?us… : PS2, Line 17: /* GPIO IRQ for tight timestamps */ What are tight timestamps? https://review.coreboot.org/c/coreboot/+/83155/comment/5cd2d9de_8eff0b3b?us… : PS2, Line 19: /* GPP_H18 used as dummy here since nissa not selected HAVE_SLP_S0_GATE */ I do not understand the comment. Can you rephrase the problem with nissa? -- To view, visit https://review.coreboot.org/c/coreboot/+/83155?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9de842a8a66632314d5fdf6444005d34338a1100 Gerrit-Change-Number: 83155 Gerrit-PatchSet: 2 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Sat, 22 Jun 2024 08:48:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: treewide: Move device_tree to commonlib
by Elyes Haouas (Code Review) 22 Jun '24

22 Jun '24

Elyes Haouas has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/77970?usp=email ) Change subject: treewide: Move device_tree to commonlib ...................................................................... Patch Set 12: (1 comment) Patchset: PS12: please see https://review.coreboot.org/c/coreboot/+/83160 -- To view, visit https://review.coreboot.org/c/coreboot/+/77970?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I990d74d9fff06b17ec8a6ee962955e4b0df8b907 Gerrit-Change-Number: 77970 Gerrit-PatchSet: 12 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sat, 22 Jun 2024 08:47:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: tree: Use pkgconf over pkg-config
by Elyes Haouas (Code Review) 22 Jun '24

22 Jun '24

Attention is currently required from: Jakub Czapiga, Julius Werner, Martin L Roth. Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83157?usp=email ) Change subject: tree: Use pkgconf over pkg-config ...................................................................... Patch Set 3: (1 comment) File tests/data/lib/lzma-test/data.2.bin: https://review.coreboot.org/c/coreboot/+/83157/comment/27c0094a_688ed866?us… : PS1, Line 52: * pkgconf > Please drop it or: […] Thx -- To view, visit https://review.coreboot.org/c/coreboot/+/83157?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3e9a92d019854214a5760f705b9cbe3cabe6d2e8 Gerrit-Change-Number: 83157 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Sat, 22 Jun 2024 08:45:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jakub Czapiga <czapiga(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/emulation/qemu-riscv/cbmem.c: Fix device_tree.h include
by Elyes Haouas (Code Review) 22 Jun '24

22 Jun '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83160?usp=email ) Change subject: mb/emulation/qemu-riscv/cbmem.c: Fix device_tree.h include ...................................................................... mb/emulation/qemu-riscv/cbmem.c: Fix device_tree.h include Change-Id: I0b49ff8b6275fdde326c79ec21c34faa03094f9e Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/emulation/qemu-riscv/cbmem.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/83160/1 diff --git a/src/mainboard/emulation/qemu-riscv/cbmem.c b/src/mainboard/emulation/qemu-riscv/cbmem.c index 8c37957..3e11415 100644 --- a/src/mainboard/emulation/qemu-riscv/cbmem.c +++ b/src/mainboard/emulation/qemu-riscv/cbmem.c @@ -3,7 +3,7 @@ #include <cbmem.h> #include <symbols.h> #include <ramdetect.h> -#include <device_tree.h> +#include <commonlib/device_tree.h> #include <mcall.h> uintptr_t cbmem_top_chipset(void) -- To view, visit https://review.coreboot.org/c/coreboot/+/83160?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0b49ff8b6275fdde326c79ec21c34faa03094f9e Gerrit-Change-Number: 83160 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[S] Change in coreboot[main]: tree: Use pkgconf over pkg-config
by Jakub Czapiga (Code Review) 22 Jun '24

22 Jun '24

Attention is currently required from: Elyes Haouas, Julius Werner, Martin L Roth. Jakub Czapiga has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83157?usp=email ) Change subject: tree: Use pkgconf over pkg-config ...................................................................... Patch Set 1: (1 comment) File tests/data/lib/lzma-test/data.2.bin: https://review.coreboot.org/c/coreboot/+/83157/comment/f4bed25a_41d500a9?us… : PS1, Line 52: * pkgconf Please drop it or: ``` How to prepare compressed file: util/cbfs-compression-tool compress file.bin /tmp/file.lzma.bin lzma dd if=/tmp/file.lzma.bin of=file.lzma.bin skip=8 ibs=1 ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/83157?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3e9a92d019854214a5760f705b9cbe3cabe6d2e8 Gerrit-Change-Number: 83157 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sat, 22 Jun 2024 08:38:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: Documentation/mainboard/gigabyte/ga-g41m-es2l: Use python-is-python3
by Elyes Haouas (Code Review) 22 Jun '24

22 Jun '24

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/83158?usp=email ) Change subject: Documentation/mainboard/gigabyte/ga-g41m-es2l: Use python-is-python3 ...................................................................... Abandoned see 83159 -- To view, visit https://review.coreboot.org/c/coreboot/+/83158?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I627fea0ff7cef4d08b4ec3698a69a0ddbe2e171d Gerrit-Change-Number: 83158 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2024