coreboot-gerrit June 2024

coreboot-gerrit@coreboot.org

1 participants
3527 discussions

[XS] Change in coreboot[main]: util/autoport: Remove bd82x6x/pch.h from generated mainboard.c
by Nicholas Chin (Code Review) 23 Jun '24

23 Jun '24

Attention is currently required from: Paul Menzel. Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/82601?usp=email ) Change subject: util/autoport: Remove bd82x6x/pch.h from generated mainboard.c ...................................................................... Patch Set 2: (1 comment) File util/autoport/bd82x6x.go: https://review.coreboot.org/c/coreboot/+/82601/comment/751d6f2b_ecbd24d7?us… : PS1, Line 300: #include <northbridge/intel/sandybridge/raminit_native.h> > CB:82405 also removes this Resolved -- To view, visit https://review.coreboot.org/c/coreboot/+/82601?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I904c95394b4fea73b4990342e647595b5f10335f Gerrit-Change-Number: 82601 Gerrit-PatchSet: 2 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sun, 23 Jun 2024 15:04:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[XS] Change in coreboot[main]: util/autoport: Remove bd82x6x/pch.h from generated mainboard.c
by Nicholas Chin (Code Review) 23 Jun '24

23 Jun '24

Attention is currently required from: Nicholas Chin, Paul Menzel. Hello Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82601?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by Paul Menzel, Verified+1 by build bot (Jenkins) Change subject: util/autoport: Remove bd82x6x/pch.h from generated mainboard.c ...................................................................... util/autoport: Remove bd82x6x/pch.h from generated mainboard.c The southbridge/intel/bd82x6x/pch.h header was previously used to configure a few registers in SPIBAR, but these have since been moved to PCH code and the devicetree, making it unnecessary in mainboard.c Change-Id: I904c95394b4fea73b4990342e647595b5f10335f Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M util/autoport/bd82x6x.go 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/82601/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82601?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I904c95394b4fea73b4990342e647595b5f10335f Gerrit-Change-Number: 82601 Gerrit-PatchSet: 2 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[M] Change in coreboot[main]: device/azalia: Separate codec checking and initialization
by Felix Singer (Code Review) 23 Jun '24

23 Jun '24

Attention is currently required from: Felix Held, Nicholas Sudsgaard, Paul Menzel. Felix Singer has posted comments on this change by Nicholas Sudsgaard. ( https://review.coreboot.org/c/coreboot/+/80332?usp=email ) Change subject: device/azalia: Separate codec checking and initialization ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80332?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I92b6d184abccdbe0e1bfce98a2c959a97a618a29 Gerrit-Change-Number: 80332 Gerrit-PatchSet: 10 Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 23 Jun 2024 13:04:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: inteltool/lpc.c: Add PCI_DEVICE_ID_INTEL_H67
by Elyes Haouas (Code Review) 23 Jun '24

23 Jun '24

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/83110?usp=email ) Change subject: inteltool/lpc.c: Add PCI_DEVICE_ID_INTEL_H67 ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/83110?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I142393bd323418b8723d5bb364e919e1ece1e54d Gerrit-Change-Number: 83110 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Máté Kukri <kukri.mate(a)gmail.com>

1 0

[XS] Change in coreboot[main]: inteltool/lpc.c: Add PCI_DEVICE_ID_INTEL_H67
by Máté Kukri (Code Review) 23 Jun '24

23 Jun '24

Attention is currently required from: Angel Pons, Elyes Haouas, Felix Singer, Pratikkumar V Prajapati. Máté Kukri has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83110?usp=email ) Change subject: inteltool/lpc.c: Add PCI_DEVICE_ID_INTEL_H67 ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/83110/comment/27e2c6ce_6b050f3a?us… : PS2, Line 45: 0x00e0: 0x100c0009 (PCCTL) I think it's entirely believable from the description that this actually works, and these values do not seem useful for someone looking through the commit history in the future. File util/inteltool/lpc.c: https://review.coreboot.org/c/coreboot/+/83110/comment/5da6e34b_d36774b8?us… : PS1, Line 90: case PCI_DEVICE_ID_INTEL_H67: > I am not sure if I understand you correctly. […] I think adding just one device ID is even misleading, the LPC controller is identical on all SKUs of CPT, and this suggests that H67 is somehow special. Maybe just add all CPT SKUs, and change the commit message to "inteltool/lpc: Add CPT device IDs" https://review.coreboot.org/c/coreboot/+/83110/comment/e35646f5_fc3eea0a?us… : PS1, Line 120: bc = pci_read_long(dev, SUNRISE_LPC_BC); > It definitely is in scope of this patch. […] I don't see how it is out of scope either: - Before the code was correct because it was only reading registers on hardware where it exists. - Adding this device ID makes the code incorrect by reading non-existent registers. - I would think a commit exposing a code path to different hardware should also fix such problems. -- To view, visit https://review.coreboot.org/c/coreboot/+/83110?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I142393bd323418b8723d5bb364e919e1ece1e54d Gerrit-Change-Number: 83110 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 23 Jun 2024 08:58:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: inteltool/lpc.c: Add PCI_DEVICE_ID_INTEL_H67
by Angel Pons (Code Review) 23 Jun '24

23 Jun '24

Attention is currently required from: Elyes Haouas, Felix Singer, Pratikkumar V Prajapati. Angel Pons has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83110?usp=email ) Change subject: inteltool/lpc.c: Add PCI_DEVICE_ID_INTEL_H67 ...................................................................... Patch Set 2: Code-Review-1 (2 comments) File util/inteltool/lpc.c: https://review.coreboot.org/c/coreboot/+/83110/comment/9c24ab8b_4fbef1dc?us… : PS1, Line 90: case PCI_DEVICE_ID_INTEL_H67: > looks better to me I am not sure if I understand you correctly. Are you saying that **NOT** adding some more `case PCI_DEVICE_ID_INTEL_*:` lines for CPT (Cougar Point, aka 6 series PCH) "looks better to you"? https://review.coreboot.org/c/coreboot/+/83110/comment/04d758a8_6ad755be?us… : PS1, Line 120: bc = pci_read_long(dev, SUNRISE_LPC_BC); > Out of scope of current patch It definitely is in scope of this patch. The bit you are checking has a different meaning in CPT (Cougar Point, aka 6 series PCH): https://i.imgur.com/joVk40u.png This is not the only difference. Here is the full datasheet for your hardware: https://www.intel.com/content/dam/www/public/us/en/documents/datasheets/6-c… -- To view, visit https://review.coreboot.org/c/coreboot/+/83110?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I142393bd323418b8723d5bb364e919e1ece1e54d Gerrit-Change-Number: 83110 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 23 Jun 2024 08:40:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: inteltool/lpc.c: Add PCI_DEVICE_ID_INTEL_H67
by Elyes Haouas (Code Review) 23 Jun '24

23 Jun '24

Attention is currently required from: Angel Pons, Felix Singer, Pratikkumar V Prajapati. Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83110?usp=email ) Change subject: inteltool/lpc.c: Add PCI_DEVICE_ID_INTEL_H67 ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/83110/comment/c8e1a291_6a609b94?us… : PS1, Line 9: bh67bl > Did you mean `DH67BL`? Yep :) Thx -- To view, visit https://review.coreboot.org/c/coreboot/+/83110?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I142393bd323418b8723d5bb364e919e1ece1e54d Gerrit-Change-Number: 83110 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Comment-Date: Sun, 23 Jun 2024 08:25:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[XS] Change in coreboot[main]: inteltool/lpc.c: Add PCI_DEVICE_ID_INTEL_H67
by Elyes Haouas (Code Review) 23 Jun '24

23 Jun '24

Attention is currently required from: Angel Pons, Felix Singer, Pratikkumar V Prajapati. Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83110?usp=email ) Change subject: inteltool/lpc.c: Add PCI_DEVICE_ID_INTEL_H67 ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/83110/comment/c1228db9_bfd1e0e5?us… : PS1, Line 11: ./inteltool -l > Do we need the inteltool output in the commit message? it doesn't hurt :) File util/inteltool/lpc.c: https://review.coreboot.org/c/coreboot/+/83110/comment/bae1e31b_514e0d01?us… : PS1, Line 90: case PCI_DEVICE_ID_INTEL_H67: > Why not add at least the rest of CPT IDs? looks better to me https://review.coreboot.org/c/coreboot/+/83110/comment/728d76c9_548ddf2c?us… : PS1, Line 120: bc = pci_read_long(dev, SUNRISE_LPC_BC); > Does this actually exist on CPT? I would prefer to have a special case for older platforms that only […] Out of scope of current patch -- To view, visit https://review.coreboot.org/c/coreboot/+/83110?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I142393bd323418b8723d5bb364e919e1ece1e54d Gerrit-Change-Number: 83110 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Comment-Date: Sun, 23 Jun 2024 08:24:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[XS] Change in coreboot[main]: inteltool/lpc.c: Add PCI_DEVICE_ID_INTEL_H67
by Elyes Haouas (Code Review) 23 Jun '24

23 Jun '24

Attention is currently required from: Elyes Haouas, Felix Singer, Pratikkumar V Prajapati. Hello Felix Singer, Paul Menzel, Pratikkumar V Prajapati, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83110?usp=email to look at the new patch set (#2). Change subject: inteltool/lpc.c: Add PCI_DEVICE_ID_INTEL_H67 ...................................................................... inteltool/lpc.c: Add PCI_DEVICE_ID_INTEL_H67 tested on unsupported board (intel - dh67bl): ./inteltool -l CPU: ID 0x206a7, Processor Type 0x0, Family 0x6, Model 0x2a, Stepping 0x7 Northbridge: 8086:0100 (2nd generation (Sandy Bridge family) Core Processor (Desktop)) Southbridge: 8086:1c4a (H67) IGD: 8086:0102 (Intel(R) HD 2000 Graphics) ========== LPC/eSPI ========= Device 0:1f.0 is LPC (BC.LPC_ESPI=0) 0x0000: 0x1c4a8086 (ID) 0x0004: 0x0007 (CMD) 0x0006: 0x0210 (STS) 0x0008: 0x05 (RID) 0x0009: 0x00 (CC[3]) 0x000a: 0x01 (CC[2]) 0x000b: 0x06 (CC[1]) 0x000c: 0x00 (CC[0]) 0x000e: 0x80 (HTYPE) 0x002c: 0x20028086 (SS) 0x0034: 0xe0 (CAPP) 0x0064: 0xd0 (SCNT) 0x0080: 0x0010 (IOD) 0x0082: 0x3f0f (IOE) 0x0084: 0x00fc0241 (LGIR1) 0x0088: 0x00fc0291 (LGIR2) 0x008c: 0x00fc0251 (LGIR3) 0x0090: 0x00fc02a1 (LGIR4) 0x0094: 0x00000f00 (ULKMC) 0x0098: 0x00000000 (LGMR) 0x00d0: 0x2233 (FS1) 0x00d4: 0x4567 (FS2) 0x00d8: 0xffc0 (BDE) 0x00dc: 0x22 (BC) 0x00e0: 0x100c0009 (PCCTL) Change-Id: I142393bd323418b8723d5bb364e919e1ece1e54d Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/inteltool/lpc.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/83110/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83110?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I142393bd323418b8723d5bb364e919e1ece1e54d Gerrit-Change-Number: 83110 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[L] Change in coreboot[main]: [test] Add DH67BL mainboard
by Elyes Haouas (Code Review) 23 Jun '24

23 Jun '24

Attention is currently required from: Elyes Haouas, Pratikkumar V Prajapati. Hello Pratikkumar V Prajapati, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83027?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: [test] Add DH67BL mainboard ...................................................................... [test] Add DH67BL mainboard based on this log https://fileport.io/TdudfPex37MY Change-Id: If466e834aae0a980941fadb18635e90280119088 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- A src/mainboard/intel/dh67bl/Kconfig A src/mainboard/intel/dh67bl/Kconfig.name A src/mainboard/intel/dh67bl/Makefile.mk A src/mainboard/intel/dh67bl/acpi/ec.asl A src/mainboard/intel/dh67bl/acpi/platform.asl A src/mainboard/intel/dh67bl/acpi/superio.asl A src/mainboard/intel/dh67bl/acpi_tables.c A src/mainboard/intel/dh67bl/board_info.txt A src/mainboard/intel/dh67bl/devicetree.cb A src/mainboard/intel/dh67bl/dsdt.asl A src/mainboard/intel/dh67bl/early_init.c A src/mainboard/intel/dh67bl/gma-mainboard.ads A src/mainboard/intel/dh67bl/gpio.c A src/mainboard/intel/dh67bl/hda_verb.c A src/mainboard/intel/dh67bl/mainboard.c M util/inteltool/lpc.c 16 files changed, 489 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/83027/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/83027?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If466e834aae0a980941fadb18635e90280119088 Gerrit-Change-Number: 83027 Gerrit-PatchSet: 7 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2024