coreboot-gerrit June 2024

coreboot-gerrit@coreboot.org

1 participants
3527 discussions

[XS] Change in coreboot[main]: util/autoport: Remove extra blank lines
by Nicholas Chin (Code Review) 23 Jun '24

23 Jun '24

Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83186?usp=email ) Change subject: util/autoport: Remove extra blank lines ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/83186/comment/fb8aee16_004aa445?us… : PS1, Line 7: til/autoport: Remove extra blank lines ... from generated files -- To view, visit https://review.coreboot.org/c/coreboot/+/83186?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iad74098518320c5389cb86badb8737e81dd656ae Gerrit-Change-Number: 83186 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Comment-Date: Sun, 23 Jun 2024 17:43:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: util/autoport: Remove bd82x6x/pch.h from generated mainboard.c
by Felix Singer (Code Review) 23 Jun '24

23 Jun '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/82601?usp=email ) Change subject: util/autoport: Remove bd82x6x/pch.h from generated mainboard.c ...................................................................... util/autoport: Remove bd82x6x/pch.h from generated mainboard.c The southbridge/intel/bd82x6x/pch.h header was previously used to configure a few registers in SPIBAR, but these have since been moved to PCH code and the devicetree, making it unnecessary in mainboard.c Change-Id: I904c95394b4fea73b4990342e647595b5f10335f Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/82601 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M util/autoport/bd82x6x.go 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Felix Singer: Looks good to me, approved build bot (Jenkins): Verified diff --git a/util/autoport/bd82x6x.go b/util/autoport/bd82x6x.go index 00b136b..8ad0c17 100644 --- a/util/autoport/bd82x6x.go +++ b/util/autoport/bd82x6x.go @@ -194,9 +194,6 @@ Value: "\\_SB.PCI0.GFX0.DECB", }) - /* SPI init */ - MainboardIncludes = append(MainboardIncludes, "southbridge/intel/bd82x6x/pch.h") - FADT := ctx.InfoSource.GetACPI()["FACP"] pcieHotplugMap := "{ " -- To view, visit https://review.coreboot.org/c/coreboot/+/82601?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I904c95394b4fea73b4990342e647595b5f10335f Gerrit-Change-Number: 82601 Gerrit-PatchSet: 3 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: util/autoport: Remove extra blank lines
by Felix Singer (Code Review) 23 Jun '24

23 Jun '24

Attention is currently required from: Nicholas Chin. Felix Singer has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83186?usp=email ) Change subject: util/autoport: Remove extra blank lines ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83186?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iad74098518320c5389cb86badb8737e81dd656ae Gerrit-Change-Number: 83186 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Sun, 23 Jun 2024 17:42:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: util/autoport: Remove extra blank lines
by Nicholas Chin (Code Review) 23 Jun '24

23 Jun '24

Nicholas Chin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83186?usp=email ) Change subject: util/autoport: Remove extra blank lines ...................................................................... util/autoport: Remove extra blank lines The generated dsdt.asl and early_init.c files contained 2 consecutive blank lines, so remove one of them. Change-Id: Iad74098518320c5389cb86badb8737e81dd656ae Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M util/autoport/bd82x6x.go M util/autoport/main.go 2 files changed, 1 insertion(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/83186/1 diff --git a/util/autoport/bd82x6x.go b/util/autoport/bd82x6x.go index 00b136b..bacc49e 100644 --- a/util/autoport/bd82x6x.go +++ b/util/autoport/bd82x6x.go @@ -297,7 +297,6 @@ sb.WriteString(`#include <bootblock_common.h> #include <device/pci_ops.h> #include <southbridge/intel/bd82x6x/pch.h> - `) usbPortConfig := "{\n" diff --git a/util/autoport/main.go b/util/autoport/main.go index 6426dd3..99099d5 100644 --- a/util/autoport/main.go +++ b/util/autoport/main.go @@ -837,8 +837,7 @@ Add_gpl(dsdt) dsdt.WriteString( - ` -#include <acpi/acpi.h> +`#include <acpi/acpi.h> DefinitionBlock( "dsdt.aml", -- To view, visit https://review.coreboot.org/c/coreboot/+/83186?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iad74098518320c5389cb86badb8737e81dd656ae Gerrit-Change-Number: 83186 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[M] Change in coreboot[main]: util/autoport: Extend Add_gpl to more files
by Nicholas Chin (Code Review) 23 Jun '24

23 Jun '24

Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83184?usp=email ) Change subject: util/autoport: Extend Add_gpl to more files ...................................................................... Patch Set 2: (1 comment) File util/autoport/main.go: https://review.coreboot.org/c/coreboot/+/83184/comment/166aca2d_86888747?us… : PS1, Line 778: Add_gpl(devtree, Devicetree) > Apparently devicetree does not require license headers, as it was added to the lint filter in commit […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/83184?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I24a1ccd0afb7045e878bf6eaae7a23f828a9240d Gerrit-Change-Number: 83184 Gerrit-PatchSet: 2 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 23 Jun 2024 17:28:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[M] Change in coreboot[main]: util/autoport: Extend Add_gpl to more files
by Nicholas Chin (Code Review) 23 Jun '24

23 Jun '24

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83184?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: util/autoport: Extend Add_gpl to more files ...................................................................... util/autoport: Extend Add_gpl to more files Previously, Add_gpl() was only used with C and ASL source code files, and was hard coded to use the C /* */ style comment. Add a new argument to specify a filetype, which is used to look up a format string with the appropriate comment style. This allows the hard coded gma-mainboard.c SPDX header to be replaced with a call to Add_gpl(), as the original function would not be able to generate -- style Ada comments. An SPDX header is also added to Kconfig and Makefile sources; as previous commits added them to all such files in the tree. Change-Id: I24a1ccd0afb7045e878bf6eaae7a23f828a9240d Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M util/autoport/azalia.go M util/autoport/bd82x6x.go M util/autoport/ec_fixme.go M util/autoport/ec_lenovo.go M util/autoport/ec_none.go M util/autoport/main.go 6 files changed, 42 insertions(+), 19 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/83184/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83184?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I24a1ccd0afb7045e878bf6eaae7a23f828a9240d Gerrit-Change-Number: 83184 Gerrit-PatchSet: 2 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: util/autoport: Add CC-PDDC SPDX header to empty files
by Nicholas Chin (Code Review) 23 Jun '24

23 Jun '24

Nicholas Chin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83185?usp=email ) Change subject: util/autoport: Add CC-PDDC SPDX header to empty files ...................................................................... util/autoport: Add CC-PDDC SPDX header to empty files As per commit cf4722d317ea (src/mb: Update unlicensable files with the CC-PDDC SPDX ID) effectively empty files should use the the Creative Commons Public Domain Dedication and Certification (CC-PDDC) license header. The only empty files that autoport currently generates are ec.asl and superio.asl on non-laptop systems, where NoEC() is used. Change-Id: I5fdf0c80443a79c082b3d0418d16cd858782b2c9 Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M util/autoport/ec_none.go M util/autoport/main.go 2 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/83185/1 diff --git a/util/autoport/ec_none.go b/util/autoport/ec_none.go index 60ffd50..1e63e29 100644 --- a/util/autoport/ec_none.go +++ b/util/autoport/ec_none.go @@ -18,7 +18,9 @@ si := Create(ctx, "acpi/superio.asl") defer si.Close() + Add_CC_PDDC(si, ASL) ec := Create(ctx, "acpi/ec.asl") defer ec.Close() + Add_CC_PDDC(ec, ASL) } diff --git a/util/autoport/main.go b/util/autoport/main.go index ff530f5..114c064 100644 --- a/util/autoport/main.go +++ b/util/autoport/main.go @@ -237,6 +237,14 @@ fmt.Fprintln(f) } +func Add_CC_PDDC(f *os.File, filetype Filetype) { + fmt.Fprintf(f, CommentFormatStrings[filetype], + "SPDX-License-Identifier: CC-PDDC") + fmt.Fprintln(f) + fmt.Fprintf(f, CommentFormatStrings[filetype], + "Please update the license if adding licensable material.") +} + func RestorePCI16Simple(f *os.File, pcidev PCIDevData, addr uint16) { fmt.Fprintf(f, " pci_write_config16(PCI_DEV(%d, 0x%02x, %d), 0x%02x, 0x%02x%02x);\n", pcidev.Bus, pcidev.Dev, pcidev.Func, addr, -- To view, visit https://review.coreboot.org/c/coreboot/+/83185?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5fdf0c80443a79c082b3d0418d16cd858782b2c9 Gerrit-Change-Number: 83185 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[M] Change in coreboot[main]: util/autoport: Extend Add_gpl to more files
by Nicholas Chin (Code Review) 23 Jun '24

23 Jun '24

Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83184?usp=email ) Change subject: util/autoport: Extend Add_gpl to more files ...................................................................... Patch Set 1: (1 comment) File util/autoport/main.go: https://review.coreboot.org/c/coreboot/+/83184/comment/b0f59a37_37f95f4c?us… : PS1, Line 778: Add_gpl(devtree, Devicetree) Apparently devicetree does not require license headers, as it was added to the lint filter in commit 84129b8c6 (util/lint: update lint-000-license-headers) -- To view, visit https://review.coreboot.org/c/coreboot/+/83184?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I24a1ccd0afb7045e878bf6eaae7a23f828a9240d Gerrit-Change-Number: 83184 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 23 Jun 2024 17:07:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: util/autoport: Extend Add_gpl to more files
by Nicholas Chin (Code Review) 23 Jun '24

23 Jun '24

Nicholas Chin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83184?usp=email ) Change subject: util/autoport: Extend Add_gpl to more files ...................................................................... util/autoport: Extend Add_gpl to more files Previously, Add_gpl() was only used with C and ASL source code files, and was hard coded to use the C /* */ style comment. Add a new argument to specify a filetype, which is used to look up a format string with the appropriate comment style. This allows the hard coded gma-mainboard.c SPDX header to be replaced with a call to Add_gpl(), as the original function would not be able to generate -- style Ada comments. An SPDX header is also added to Kconfig, Makefile, and devicetree sources; as previous commits added them to all such files in the tree. Change-Id: I24a1ccd0afb7045e878bf6eaae7a23f828a9240d Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M util/autoport/azalia.go M util/autoport/bd82x6x.go M util/autoport/ec_fixme.go M util/autoport/ec_lenovo.go M util/autoport/ec_none.go M util/autoport/main.go 6 files changed, 45 insertions(+), 19 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/83184/1 diff --git a/util/autoport/azalia.go b/util/autoport/azalia.go index c98b03c..90c1cd6 100644 --- a/util/autoport/azalia.go +++ b/util/autoport/azalia.go @@ -12,7 +12,7 @@ az := Create(ctx, "hda_verb.c") defer az.Close() - Add_gpl(az) + Add_gpl(az, C) az.WriteString( `#include <device/azalia_device.h> diff --git a/util/autoport/bd82x6x.go b/util/autoport/bd82x6x.go index 00b136b..d9bc3f0 100644 --- a/util/autoport/bd82x6x.go +++ b/util/autoport/bd82x6x.go @@ -44,7 +44,7 @@ AddBootBlockFile("gpio.c", "") AddROMStageFile("gpio.c", "") - Add_gpl(gpio) + Add_gpl(gpio, C) gpio.WriteString("#include <southbridge/intel/common/gpio.h>\n\n") addresses := [3][6]int{ @@ -292,7 +292,7 @@ sb := Create(ctx, "early_init.c") defer sb.Close() - Add_gpl(sb) + Add_gpl(sb, C) sb.WriteString(`#include <bootblock_common.h> #include <device/pci_ops.h> @@ -358,7 +358,7 @@ gnvs := Create(ctx, "acpi_tables.c") defer gnvs.Close() - Add_gpl(gnvs) + Add_gpl(gnvs, C) gnvs.WriteString(`#include <acpi/acpi_gnvs.h> #include <soc/nvs.h> diff --git a/util/autoport/ec_fixme.go b/util/autoport/ec_fixme.go index 54f78ab..2902332 100644 --- a/util/autoport/ec_fixme.go +++ b/util/autoport/ec_fixme.go @@ -19,7 +19,7 @@ SouthBridge.EnableGPE(SouthBridge.DecodeGPE(sbGPE)) } - Add_gpl(ap) + Add_gpl(ap, ASL) ap.WriteString( `Method(_WAK, 1) { @@ -65,7 +65,7 @@ defer si.Close() if hasKeyboard { - Add_gpl(si) + Add_gpl(si, ASL) si.WriteString("#include <drivers/pc80/pc/ps2_controller.asl>\n") MainboardInit += fmt.Sprintf("\tpc_keyboard_init(NO_AUX_DEVICE);\n") MainboardIncludes = append(MainboardIncludes, "pc80/keyboard.h") @@ -74,7 +74,7 @@ ec := Create(ctx, "acpi/ec.asl") defer ec.Close() - Add_gpl(ec) + Add_gpl(ec, ASL) ec.WriteString(`Device(EC) { Name (_HID, EISAID("PNP0C09")) diff --git a/util/autoport/ec_lenovo.go b/util/autoport/ec_lenovo.go index a34960f..e8dd847 100644 --- a/util/autoport/ec_lenovo.go +++ b/util/autoport/ec_lenovo.go @@ -39,7 +39,7 @@ Value: "1", }, GPEDefine) - Add_gpl(ap) + Add_gpl(ap, ASL) ap.WriteString( `Method(_WAK, 1) { @@ -58,7 +58,7 @@ si := Create(ctx, "acpi/superio.asl") defer si.Close() - Add_gpl(si) + Add_gpl(si, ASL) si.WriteString("#include <drivers/pc80/pc/ps2_controller.asl>\n") /* FIXME:XX Move this to ec/lenovo. */ @@ -67,7 +67,7 @@ AddSMMFile("smihandler.c", "") - Add_gpl(smi) + Add_gpl(smi, C) smi.WriteString( `#include <arch/io.h> #include <console/console.h> @@ -146,7 +146,7 @@ ec := Create(ctx, "acpi/ec.asl") defer ec.Close() - Add_gpl(ec) + Add_gpl(ec, ASL) ec.WriteString("#include <ec/lenovo/h8/acpi/ec.asl>\n") KconfigBool["EC_LENOVO_PMH7"] = true diff --git a/util/autoport/ec_none.go b/util/autoport/ec_none.go index bcb61bf..60ffd50 100644 --- a/util/autoport/ec_none.go +++ b/util/autoport/ec_none.go @@ -4,7 +4,7 @@ ap := Create(ctx, "acpi/platform.asl") defer ap.Close() - Add_gpl(ap) + Add_gpl(ap, ASL) ap.WriteString( `Method(_WAK, 1) { diff --git a/util/autoport/main.go b/util/autoport/main.go index 6426dd3..ff530f5 100644 --- a/util/autoport/main.go +++ b/util/autoport/main.go @@ -100,6 +100,26 @@ IRQNO [4]int } +type Filetype int + +const ( + Ada Filetype = iota + ASL + C + Devicetree + Kconfig + Makefile +) + +var CommentFormatStrings map[Filetype]string = map[Filetype]string { + Ada: "-- %s\n", + ASL: "/* %s */\n", + C: "/* %s */\n", + Devicetree: "# %s\n", + Kconfig: "# %s\n", + Makefile: "# %s\n", +} + var IOAPICIRQs map[PCIAddr]IOAPICIRQ = map[PCIAddr]IOAPICIRQ{} var KconfigBool map[string]bool = map[string]bool{} var KconfigComment map[string]string = map[string]string{} @@ -211,8 +231,9 @@ return mf } -func Add_gpl(f *os.File) { - fmt.Fprintln(f, "/* SPDX-License-Identifier: GPL-2.0-only */") +func Add_gpl(f *os.File, filetype Filetype) { + fmt.Fprintf(f, CommentFormatStrings[filetype], + "SPDX-License-Identifier: GPL-2.0-only") fmt.Fprintln(f) } @@ -529,6 +550,7 @@ func makeKconfigName(ctx Context) { kn := Create(ctx, "Kconfig.name") defer kn.Close() + Add_gpl(kn, Kconfig) fmt.Fprintf(kn, "config %s\n\tbool \"%s\"\n", ctx.KconfigName, ctx.Model) } @@ -544,6 +566,7 @@ func makeKconfig(ctx Context) { kc := Create(ctx, "Kconfig") defer kc.Close() + Add_gpl(kc, Kconfig) fmt.Fprintf(kc, "if %s\n\n", ctx.KconfigName) @@ -640,6 +663,7 @@ log.Fatal(err) } defer f.Close() + Add_gpl(f, Kconfig) f.WriteString(`if VENDOR_` + vendorUpper + ` choice @@ -664,6 +688,7 @@ log.Fatal(err) } defer f.Close() + Add_gpl(f, Kconfig) f.WriteString(`config VENDOR_` + vendorUpper + ` bool "` + vendor + `" `) @@ -741,6 +766,7 @@ if len(BootBlockFiles) > 0 || len(ROMStageFiles) > 0 || len(RAMStageFiles) > 0 || len(SMMFiles) > 0 { mf := Create(ctx, "Makefile.mk") defer mf.Close() + Add_gpl(mf, Makefile) writeMF(mf, BootBlockFiles, "bootblock") writeMF(mf, ROMStageFiles, "romstage") writeMF(mf, RAMStageFiles, "ramstage") @@ -749,6 +775,7 @@ devtree := Create(ctx, "devicetree.cb") defer devtree.Close() + Add_gpl(devtree, Devicetree) MatchDev(&DevTree) WriteDev(devtree, 0, "", DevTree) @@ -756,7 +783,7 @@ if MainboardInit != "" || MainboardEnable != "" || MainboardIncludes != nil { mainboard := Create(ctx, "mainboard.c") defer mainboard.Close() - Add_gpl(mainboard) + Add_gpl(mainboard, C) mainboard.WriteString("#include <device/device.h>\n") for _, include := range MainboardIncludes { mainboard.WriteString("#include <" + include + ">\n") @@ -835,7 +862,7 @@ dsdt.WriteString("#define " + define.Key + " " + define.Value + "\n") } - Add_gpl(dsdt) + Add_gpl(dsdt, ASL) dsdt.WriteString( ` #include <acpi/acpi.h> @@ -878,10 +905,9 @@ if IGDEnabled { gma := Create(ctx, "gma-mainboard.ads") defer gma.Close() + Add_gpl(gma, Ada) - gma.WriteString(`-- SPDX-License-Identifier: GPL-2.0-or-later - -with HW.GFX.GMA; + gma.WriteString(`with HW.GFX.GMA; with HW.GFX.GMA.Display_Probing; use HW.GFX.GMA; -- To view, visit https://review.coreboot.org/c/coreboot/+/83184?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I24a1ccd0afb7045e878bf6eaae7a23f828a9240d Gerrit-Change-Number: 83184 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[XS] Change in coreboot[main]: util/autoport: Remove bd82x6x/pch.h from generated mainboard.c
by Felix Singer (Code Review) 23 Jun '24

23 Jun '24

Attention is currently required from: Nicholas Chin, Paul Menzel. Felix Singer has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/82601?usp=email ) Change subject: util/autoport: Remove bd82x6x/pch.h from generated mainboard.c ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82601?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I904c95394b4fea73b4990342e647595b5f10335f Gerrit-Change-Number: 82601 Gerrit-PatchSet: 2 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Sun, 23 Jun 2024 15:15:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2024